From c54b3da86d95d82f78a1c15920563c6569dfe1d3 Mon Sep 17 00:00:00 2001 From: Shreya Malviya Date: Fri, 27 May 2022 23:09:03 +0530 Subject: [PATCH] Island: Minor changes to API spec comments as per CR --- monkey/monkey_island/cc/app.py | 4 ++-- .../cc/resources/agent_controls/stop_agent_check.py | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/monkey/monkey_island/cc/app.py b/monkey/monkey_island/cc/app.py index 2df4b7b1c..a9305cfc9 100644 --- a/monkey/monkey_island/cc/app.py +++ b/monkey/monkey_island/cc/app.py @@ -155,7 +155,7 @@ def init_api_resources(api: FlaskDIWrapper): api.add_resource(IslandConfiguration) api.add_resource(ConfigurationExport) api.add_resource(ConfigurationImport) - # API Spec: Rename to /api/agent-binary, because information about agent runs + # API Spec: Rename to /api/agent-binaries, because information about agent runs # and binary files are different resources api.add_resource(MonkeyDownload) api.add_resource(NetMap) @@ -175,7 +175,7 @@ def init_api_resources(api: FlaskDIWrapper): api.add_resource(Log) api.add_resource(IslandLog) - # API Spec: These two should have the same url syntax + # API Spec: These two should be the same resource, GET for download and POST for upload api.add_resource(PBAFileDownload) api.add_resource(FileUpload) diff --git a/monkey/monkey_island/cc/resources/agent_controls/stop_agent_check.py b/monkey/monkey_island/cc/resources/agent_controls/stop_agent_check.py index fd1fc213a..18195e1ce 100644 --- a/monkey/monkey_island/cc/resources/agent_controls/stop_agent_check.py +++ b/monkey/monkey_island/cc/resources/agent_controls/stop_agent_check.py @@ -1,8 +1,10 @@ from monkey_island.cc.resources.AbstractResource import AbstractResource from monkey_island.cc.services.infection_lifecycle import should_agent_die + class StopAgentCheck(AbstractResource): - # API Spec: Rename to AgentStopStatus or something + # API Spec: Rename to AgentStopStatus or something, endpoint for this could be + # "/api/agents//stop-status" urls = ["/api/monkey-control/needs-to-stop/"] def get(self, monkey_guid: int):