diff --git a/.travis.yml b/.travis.yml
index 963c37fc6..b14482939 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,12 +3,6 @@ language: python
cache: pip
python:
- 2.7
- - 3.6
-matrix:
- include:
- - python: 3.7
- dist: xenial # required for Python 3.7 (travis-ci/travis-ci#9069)
- sudo: required # required for Python 3.7 (travis-ci/travis-ci#9069)
install:
#- pip install -r requirements.txt
- pip install flake8 # pytest # add another testing frameworks later
diff --git a/deployment_scripts/README.md b/deployment_scripts/README.md
index 92a2fd76e..10027edce 100644
--- a/deployment_scripts/README.md
+++ b/deployment_scripts/README.md
@@ -13,9 +13,10 @@ Don't forget to add python to PATH or do so while installing it via this script.
## Linux
-You must have root permissions, but there is no need to run the script as root.
+You must have root permissions, but don't run the script as root.
Launch deploy_linux.sh from scripts directory.
-First argument is an empty directory (script can create one) and second is branch you want to clone.
+First argument should be an empty directory (script can create one, default is ./infection_monkey) and second is the branch you want to clone (develop by default).
+Choose a directory where you have all the relevant permissions, for e.g. /home/your_username
Example usages:
./deploy_linux.sh (deploys under ./infection_monkey)
./deploy_linux.sh "/home/test/monkey" (deploys under /home/test/monkey)
diff --git a/monkey/infection_monkey/config.py b/monkey/infection_monkey/config.py
index f7e4cfae4..cb5bf881b 100644
--- a/monkey/infection_monkey/config.py
+++ b/monkey/infection_monkey/config.py
@@ -1,3 +1,4 @@
+import hashlib
import os
import json
import sys
@@ -13,9 +14,11 @@ GUID = str(uuid.getnode())
EXTERNAL_CONFIG_FILE = os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])), 'monkey.bin')
+SENSITIVE_FIELDS = ["exploit_password_list", "exploit_user_list"]
+HIDDEN_FIELD_REPLACEMENT_CONTENT = "hidden"
+
class Configuration(object):
-
def from_kv(self, formatted_data):
# now we won't work at <2.7 for sure
network_import = importlib.import_module('infection_monkey.network')
@@ -53,6 +56,12 @@ class Configuration(object):
result = self.from_kv(formatted_data)
return result
+ @staticmethod
+ def hide_sensitive_info(config_dict):
+ for field in SENSITIVE_FIELDS:
+ config_dict[field] = HIDDEN_FIELD_REPLACEMENT_CONTENT
+ return config_dict
+
def as_dict(self):
result = {}
for key in dir(Configuration):
@@ -174,7 +183,7 @@ class Configuration(object):
# TCP Scanner
HTTP_PORTS = [80, 8080, 443,
- 8008, # HTTP alternate
+ 8008, # HTTP alternate
7001 # Oracle Weblogic default server port
]
tcp_target_ports = [22,
@@ -272,5 +281,17 @@ class Configuration(object):
PBA_linux_filename = None
PBA_windows_filename = None
+ @staticmethod
+ def hash_sensitive_data(sensitive_data):
+ """
+ Hash sensitive data (e.g. passwords). Used so the log won't contain sensitive data plain-text, as the log is
+ saved on client machines plain-text.
+
+ :param sensitive_data: the data to hash.
+ :return: the hashed data.
+ """
+ password_hashed = hashlib.sha512(sensitive_data).hexdigest()
+ return password_hashed
+
WormConfiguration = Configuration()
diff --git a/monkey/infection_monkey/control.py b/monkey/infection_monkey/control.py
index ba30bf515..4e917e5a6 100644
--- a/monkey/infection_monkey/control.py
+++ b/monkey/infection_monkey/control.py
@@ -169,7 +169,8 @@ class ControlClient(object):
try:
unknown_variables = WormConfiguration.from_kv(reply.json().get('config'))
- LOG.info("New configuration was loaded from server: %r" % (WormConfiguration.as_dict(),))
+ LOG.info("New configuration was loaded from server: %r" %
+ (WormConfiguration.hide_sensitive_info(WormConfiguration.as_dict()),))
except Exception as exc:
# we don't continue with default conf here because it might be dangerous
LOG.error("Error parsing JSON reply from control server %s (%s): %s",
diff --git a/monkey/infection_monkey/exploit/mssqlexec.py b/monkey/infection_monkey/exploit/mssqlexec.py
index 9d1dcb2d6..f1e561644 100644
--- a/monkey/infection_monkey/exploit/mssqlexec.py
+++ b/monkey/infection_monkey/exploit/mssqlexec.py
@@ -123,8 +123,9 @@ class MSSQLExploiter(HostExploiter):
# Core steps
# Trying to connect
conn = pymssql.connect(host, user, password, port=port, login_timeout=self.LOGIN_TIMEOUT)
- LOG.info('Successfully connected to host: {0}, '
- 'using user: {1}, password: {2}'.format(host, user, password))
+ LOG.info(
+ 'Successfully connected to host: {0}, using user: {1}, password (SHA-512): {2}'.format(
+ host, user, self._config.hash_sensitive_data(password)))
self.add_vuln_port(MSSQLExploiter.SQL_DEFAULT_TCP_PORT)
self.report_login_attempt(True, user, password)
cursor = conn.cursor()
diff --git a/monkey/infection_monkey/exploit/rdpgrinder.py b/monkey/infection_monkey/exploit/rdpgrinder.py
index 0db63e86d..c63affcdc 100644
--- a/monkey/infection_monkey/exploit/rdpgrinder.py
+++ b/monkey/infection_monkey/exploit/rdpgrinder.py
@@ -9,16 +9,16 @@ from rdpy.core.error import RDPSecurityNegoFail
from rdpy.protocol.rdp import rdp
from twisted.internet import reactor
+from common.utils.attack_utils import ScanStatus, BITS_UPLOAD_STRING
+from common.utils.exploit_enum import ExploitType
from infection_monkey.exploit import HostExploiter
from infection_monkey.exploit.tools import HTTPTools, get_monkey_depth
+from infection_monkey.exploit.tools import build_monkey_commandline
from infection_monkey.exploit.tools import get_target_monkey
from infection_monkey.model import RDP_CMDLINE_HTTP_BITS, RDP_CMDLINE_HTTP_VBS
from infection_monkey.network.tools import check_tcp_port
-from infection_monkey.exploit.tools import build_monkey_commandline
from infection_monkey.telemetry.attack.t1197_telem import T1197Telem
from infection_monkey.utils import utf_to_ascii
-from common.utils.exploit_enum import ExploitType
-from common.utils.attack_utils import ScanStatus, BITS_UPLOAD_STRING
__author__ = 'hoffer'
@@ -299,8 +299,8 @@ class RdpExploiter(HostExploiter):
for user, password in user_password_pairs:
try:
# run command using rdp.
- LOG.info("Trying RDP logging into victim %r with user %s and password '%s'",
- self.host, user, password)
+ LOG.info("Trying RDP logging into victim %r with user %s and password (SHA-512) '%s'",
+ self.host, user, self._config.hash_sensitive_data(password))
LOG.info("RDP connected to %r", self.host)
@@ -327,8 +327,8 @@ class RdpExploiter(HostExploiter):
except Exception as exc:
LOG.debug("Error logging into victim %r with user"
- " %s and password '%s': (%s)", self.host,
- user, password, exc)
+ " %s and password (SHA-512) '%s': (%s)", self.host,
+ user, self._config.hash_sensitive_data(password), exc)
continue
http_thread.join(DOWNLOAD_TIMEOUT)
diff --git a/monkey/infection_monkey/exploit/smbexec.py b/monkey/infection_monkey/exploit/smbexec.py
index 74354108e..a8ec2a78c 100644
--- a/monkey/infection_monkey/exploit/smbexec.py
+++ b/monkey/infection_monkey/exploit/smbexec.py
@@ -68,8 +68,8 @@ class SmbExploiter(HostExploiter):
self._config.smb_download_timeout)
if remote_full_path is not None:
- LOG.debug("Successfully logged in %r using SMB (%s : %s : %s : %s)",
- self.host, user, password, lm_hash, ntlm_hash)
+ LOG.debug("Successfully logged in %r using SMB (%s : (SHA-512) %s : %s : %s)",
+ self.host, user, self._config.hash_sensitive_data(password), lm_hash, ntlm_hash)
self.report_login_attempt(True, user, password, lm_hash, ntlm_hash)
self.add_vuln_port("%s or %s" % (SmbExploiter.KNOWN_PROTOCOLS['139/SMB'][1],
SmbExploiter.KNOWN_PROTOCOLS['445/SMB'][1]))
@@ -81,8 +81,8 @@ class SmbExploiter(HostExploiter):
except Exception as exc:
LOG.debug("Exception when trying to copy file using SMB to %r with user:"
- " %s, password: '%s', LM hash: %s, NTLM hash: %s: (%s)", self.host,
- user, password, lm_hash, ntlm_hash, exc)
+ " %s, password (SHA-512): '%s', LM hash: %s, NTLM hash: %s: (%s)", self.host,
+ user, self._config.hash_sensitive_data(password), lm_hash, ntlm_hash, exc)
continue
if not exploited:
@@ -137,7 +137,7 @@ class SmbExploiter(HostExploiter):
except:
status = ScanStatus.SCANNED
pass
- T1035Telem(status, UsageEnum.SMB.name).send()
+ T1035Telem(status, UsageEnum.SMB).send()
scmr.hRDeleteService(scmr_rpc, service)
scmr.hRCloseServiceHandle(scmr_rpc, service)
diff --git a/monkey/infection_monkey/exploit/sshexec.py b/monkey/infection_monkey/exploit/sshexec.py
index c7cf030c1..1e002cd26 100644
--- a/monkey/infection_monkey/exploit/sshexec.py
+++ b/monkey/infection_monkey/exploit/sshexec.py
@@ -1,16 +1,16 @@
+import StringIO
import logging
import time
import paramiko
-import StringIO
import infection_monkey.monkeyfs as monkeyfs
+from common.utils.exploit_enum import ExploitType
from infection_monkey.exploit import HostExploiter
+from infection_monkey.exploit.tools import build_monkey_commandline
from infection_monkey.exploit.tools import get_target_monkey, get_monkey_depth
from infection_monkey.model import MONKEY_ARG
from infection_monkey.network.tools import check_tcp_port
-from infection_monkey.exploit.tools import build_monkey_commandline
-from common.utils.exploit_enum import ExploitType
__author__ = 'hoffer'
@@ -71,26 +71,26 @@ class SSHExploiter(HostExploiter):
exploited = False
- for user, curpass in user_password_pairs:
+ for user, current_password in user_password_pairs:
try:
ssh.connect(self.host.ip_addr,
username=user,
- password=curpass,
+ password=current_password,
port=port,
timeout=None)
- LOG.debug("Successfully logged in %r using SSH (%s : %s)",
- self.host, user, curpass)
+ LOG.debug("Successfully logged in %r using SSH. User: %s, pass (SHA-512): %s)",
+ self.host, user, self._config.hash_sensitive_data(current_password))
exploited = True
self.add_vuln_port(port)
- self.report_login_attempt(True, user, curpass)
+ self.report_login_attempt(True, user, current_password)
break
except Exception as exc:
LOG.debug("Error logging into victim %r with user"
- " %s and password '%s': (%s)", self.host,
- user, curpass, exc)
- self.report_login_attempt(False, user, curpass)
+ " %s and password (SHA-512) '%s': (%s)", self.host,
+ user, self._config.hash_sensitive_data(current_password), exc)
+ self.report_login_attempt(False, user, current_password)
continue
return exploited
@@ -109,7 +109,7 @@ class SSHExploiter(HostExploiter):
LOG.info("SSH port is closed on %r, skipping", self.host)
return False
- #Check for possible ssh exploits
+ # Check for possible ssh exploits
exploited = self.exploit_with_ssh_keys(port, ssh)
if not exploited:
exploited = self.exploit_with_login_creds(port, ssh)
diff --git a/monkey/infection_monkey/exploit/wmiexec.py b/monkey/infection_monkey/exploit/wmiexec.py
index 9439d7414..b27dccbb8 100644
--- a/monkey/infection_monkey/exploit/wmiexec.py
+++ b/monkey/infection_monkey/exploit/wmiexec.py
@@ -33,8 +33,10 @@ class WmiExploiter(HostExploiter):
creds = self._config.get_exploit_user_password_or_hash_product()
for user, password, lm_hash, ntlm_hash in creds:
- LOG.debug("Attempting to connect %r using WMI with user,password,lm hash,ntlm hash: ('%s','%s','%s','%s')",
- self.host, user, password, lm_hash, ntlm_hash)
+ password_hashed = self._config.hash_sensitive_data(password)
+ LOG.debug("Attempting to connect %r using WMI with "
+ "user,password (SHA-512),lm hash,ntlm hash: ('%s','%s','%s','%s')",
+ self.host, user, password_hashed, lm_hash, ntlm_hash)
wmi_connection = WmiTools.WmiConnection()
@@ -44,23 +46,23 @@ class WmiExploiter(HostExploiter):
self.report_login_attempt(False, user, password, lm_hash, ntlm_hash)
LOG.debug("Failed connecting to %r using WMI with "
"user,password,lm hash,ntlm hash: ('%s','%s','%s','%s')",
- self.host, user, password, lm_hash, ntlm_hash)
+ self.host, user, password_hashed, lm_hash, ntlm_hash)
continue
except DCERPCException:
self.report_login_attempt(False, user, password, lm_hash, ntlm_hash)
LOG.debug("Failed connecting to %r using WMI with "
"user,password,lm hash,ntlm hash: ('%s','%s','%s','%s')",
- self.host, user, password, lm_hash, ntlm_hash)
+ self.host, user, password_hashed, lm_hash, ntlm_hash)
continue
except socket.error:
LOG.debug("Network error in WMI connection to %r with "
"user,password,lm hash,ntlm hash: ('%s','%s','%s','%s')",
- self.host, user, password, lm_hash, ntlm_hash)
+ self.host, user, password_hashed, lm_hash, ntlm_hash)
return False
except Exception as exc:
LOG.debug("Unknown WMI connection error to %r with "
"user,password,lm hash,ntlm hash: ('%s','%s','%s','%s') (%s):\n%s",
- self.host, user, password, lm_hash, ntlm_hash, exc, traceback.format_exc())
+ self.host, user, password_hashed, lm_hash, ntlm_hash, exc, traceback.format_exc())
return False
self.report_login_attempt(True, user, password, lm_hash, ntlm_hash)
@@ -91,7 +93,8 @@ class WmiExploiter(HostExploiter):
# execute the remote dropper in case the path isn't final
elif remote_full_path.lower() != self._config.dropper_target_path_win_32.lower():
cmdline = DROPPER_CMDLINE_WINDOWS % {'dropper_path': remote_full_path} + \
- build_monkey_commandline(self.host, get_monkey_depth() - 1, self._config.dropper_target_path_win_32)
+ build_monkey_commandline(
+ self.host, get_monkey_depth() - 1, self._config.dropper_target_path_win_32)
else:
cmdline = MONKEY_CMDLINE_WINDOWS % {'monkey_path': remote_full_path} + \
build_monkey_commandline(self.host, get_monkey_depth() - 1)
@@ -118,3 +121,4 @@ class WmiExploiter(HostExploiter):
return success
return False
+
diff --git a/monkey/infection_monkey/main.py b/monkey/infection_monkey/main.py
index b8e292243..2ddf9127e 100644
--- a/monkey/infection_monkey/main.py
+++ b/monkey/infection_monkey/main.py
@@ -68,7 +68,7 @@ def main():
else:
print("Config file wasn't supplied and default path: %s wasn't found, using internal default" % (config_file,))
- print("Loaded Configuration: %r" % WormConfiguration.as_dict())
+ print("Loaded Configuration: %r" % WormConfiguration.hide_sensitive_info(WormConfiguration.as_dict()))
# Make sure we're not in a machine that has the kill file
kill_path = os.path.expandvars(
diff --git a/monkey/infection_monkey/monkey.py b/monkey/infection_monkey/monkey.py
index b3410704c..d6a28c924 100644
--- a/monkey/infection_monkey/monkey.py
+++ b/monkey/infection_monkey/monkey.py
@@ -255,6 +255,7 @@ class InfectionMonkey(object):
if WormConfiguration.self_delete_in_cleanup \
and -1 == sys.executable.find('python'):
try:
+ status = None
if "win32" == sys.platform:
from _subprocess import SW_HIDE, STARTF_USESHOWWINDOW, CREATE_NEW_CONSOLE
startupinfo = subprocess.STARTUPINFO()
@@ -265,10 +266,12 @@ class InfectionMonkey(object):
close_fds=True, startupinfo=startupinfo)
else:
os.remove(sys.executable)
- T1107Telem(ScanStatus.USED, sys.executable).send()
+ status = ScanStatus.USED
except Exception as exc:
LOG.error("Exception in self delete: %s", exc)
- T1107Telem(ScanStatus.SCANNED, sys.executable).send()
+ status = ScanStatus.SCANNED
+ if status:
+ T1107Telem(status, sys.executable).send()
def send_log(self):
monkey_log_path = utils.get_monkey_log_path()
diff --git a/monkey/infection_monkey/system_info/mimikatz_collector.py b/monkey/infection_monkey/system_info/mimikatz_collector.py
index 0e6a913c9..7843d1108 100644
--- a/monkey/infection_monkey/system_info/mimikatz_collector.py
+++ b/monkey/infection_monkey/system_info/mimikatz_collector.py
@@ -56,7 +56,7 @@ class MimikatzCollector(object):
LOG.exception("Error initializing mimikatz collector")
status = ScanStatus.SCANNED
T1106Telem(status, UsageEnum.MIMIKATZ_WINAPI.name).send()
- T1129Telem(status, UsageEnum.MIMIKATZ.name).send()
+ T1129Telem(status, UsageEnum.MIMIKATZ).send()
def get_logon_info(self):
diff --git a/monkey/infection_monkey/telemetry/attack/t1035_telem.py b/monkey/infection_monkey/telemetry/attack/t1035_telem.py
index 13d0bcc59..4ca9dc93c 100644
--- a/monkey/infection_monkey/telemetry/attack/t1035_telem.py
+++ b/monkey/infection_monkey/telemetry/attack/t1035_telem.py
@@ -6,6 +6,6 @@ class T1035Telem(UsageTelem):
"""
T1035 telemetry.
:param status: ScanStatus of technique
- :param usage: Enum name of UsageEnum
+ :param usage: Enum of UsageEnum type
"""
super(T1035Telem, self).__init__('T1035', status, usage)
diff --git a/monkey/infection_monkey/telemetry/attack/t1129_telem.py b/monkey/infection_monkey/telemetry/attack/t1129_telem.py
index a04834959..4e7a12ce8 100644
--- a/monkey/infection_monkey/telemetry/attack/t1129_telem.py
+++ b/monkey/infection_monkey/telemetry/attack/t1129_telem.py
@@ -6,6 +6,6 @@ class T1129Telem(UsageTelem):
"""
T1129 telemetry.
:param status: ScanStatus of technique
- :param usage: Enum name of UsageEnum
+ :param usage: Enum of UsageEnum type
"""
super(T1129Telem, self).__init__("T1129", status, usage)
diff --git a/monkey/infection_monkey/telemetry/attack/usage_telem.py b/monkey/infection_monkey/telemetry/attack/usage_telem.py
index d493c64d8..4b47d8be3 100644
--- a/monkey/infection_monkey/telemetry/attack/usage_telem.py
+++ b/monkey/infection_monkey/telemetry/attack/usage_telem.py
@@ -7,10 +7,10 @@ class UsageTelem(AttackTelem):
"""
:param technique: Id of technique
:param status: ScanStatus of technique
- :param usage: Enum name of UsageEnum
+ :param usage: Enum of UsageEnum type
"""
super(UsageTelem, self).__init__(technique, status)
- self.usage = usage
+ self.usage = usage.name
def get_data(self):
data = super(UsageTelem, self).get_data()
diff --git a/monkey/monkey_island/cc/consts.py b/monkey/monkey_island/cc/consts.py
index deb1db449..c302f6fb7 100644
--- a/monkey/monkey_island/cc/consts.py
+++ b/monkey/monkey_island/cc/consts.py
@@ -3,3 +3,4 @@ import os
__author__ = 'itay.mizeretz'
MONKEY_ISLAND_ABS_PATH = os.path.join(os.getcwd(), 'monkey_island')
+DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS = 60 * 5
diff --git a/monkey/monkey_island/cc/models/monkey.py b/monkey/monkey_island/cc/models/monkey.py
index 520b967a0..f1bd12905 100644
--- a/monkey/monkey_island/cc/models/monkey.py
+++ b/monkey/monkey_island/cc/models/monkey.py
@@ -1,11 +1,11 @@
"""
Define a Document Schema for the Monkey document.
"""
-import mongoengine
from mongoengine import Document, StringField, ListField, BooleanField, EmbeddedDocumentField, ReferenceField, \
- DateTimeField
+ DateTimeField, DynamicField, DoesNotExist
-from monkey_island.cc.models.monkey_ttl import MonkeyTtl
+from monkey_island.cc.models.monkey_ttl import MonkeyTtl, create_monkey_ttl_document
+from monkey_island.cc.consts import DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS
class Monkey(Document):
@@ -26,24 +26,37 @@ class Monkey(Document):
ip_addresses = ListField(StringField())
keepalive = DateTimeField()
modifytime = DateTimeField()
- # TODO change this to an embedded document as well - RN it's an unnamed tuple which is confusing.
- parent = ListField(ListField(StringField()))
+ # TODO make "parent" an embedded document, so this can be removed and the schema explained (and validated) verbosly.
+ # This is a temporary fix, since mongoengine doesn't allow for lists of strings to be null
+ # (even with required=False of null=True).
+ # See relevant issue: https://github.com/MongoEngine/mongoengine/issues/1904
+ parent = ListField(ListField(DynamicField()))
config_error = BooleanField()
critical_services = ListField(StringField())
pba_results = ListField()
ttl_ref = ReferenceField(MonkeyTtl)
+ tunnel = ReferenceField("self")
# LOGIC
@staticmethod
def get_single_monkey_by_id(db_id):
try:
- return Monkey.objects(id=db_id)[0]
- except IndexError:
- raise MonkeyNotFoundError("id: {0}".format(str(db_id)))
+ return Monkey.objects.get(id=db_id)
+ except DoesNotExist as ex:
+ raise MonkeyNotFoundError("info: {0} | id: {1}".format(ex.message, str(db_id)))
+
+ @staticmethod
+ def get_single_monkey_by_guid(monkey_guid):
+ try:
+ return Monkey.objects.get(guid=monkey_guid)
+ except DoesNotExist as ex:
+ raise MonkeyNotFoundError("info: {0} | guid: {1}".format(ex.message, str(monkey_guid)))
@staticmethod
def get_latest_modifytime():
- return Monkey.objects.order_by('-modifytime').first().modifytime
+ if Monkey.objects.count() > 0:
+ return Monkey.objects.order_by('-modifytime').first().modifytime
+ return None
def is_dead(self):
monkey_is_dead = False
@@ -54,7 +67,7 @@ class Monkey(Document):
if MonkeyTtl.objects(id=self.ttl_ref.id).count() == 0:
# No TTLs - monkey has timed out. The monkey is MIA.
monkey_is_dead = True
- except (mongoengine.DoesNotExist, AttributeError):
+ except (DoesNotExist, AttributeError):
# Trying to dereference unknown document - the monkey is MIA.
monkey_is_dead = True
return monkey_is_dead
@@ -67,6 +80,10 @@ class Monkey(Document):
os = "windows"
return os
+ def renew_ttl(self, duration=DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS):
+ self.ttl_ref = create_monkey_ttl_document(duration)
+ self.save()
+
class MonkeyNotFoundError(Exception):
pass
diff --git a/monkey/monkey_island/cc/models/monkey_ttl.py b/monkey/monkey_island/cc/models/monkey_ttl.py
index 9ccf77974..b3e59d5ed 100644
--- a/monkey/monkey_island/cc/models/monkey_ttl.py
+++ b/monkey/monkey_island/cc/models/monkey_ttl.py
@@ -38,3 +38,16 @@ class MonkeyTtl(Document):
}
expire_at = DateTimeField()
+
+
+def create_monkey_ttl_document(expiry_duration_in_seconds):
+ """
+ Create a new Monkey TTL document and save it as a document.
+ :param expiry_duration_in_seconds: How long should the TTL last for. THIS IS A LOWER BOUND - depends on mongodb
+ performance.
+ :return: The TTL document. To get its ID use `.id`.
+ """
+ # The TTL data uses the new `models` module which depends on mongoengine.
+ current_ttl = MonkeyTtl.create_ttl_expire_in(expiry_duration_in_seconds)
+ current_ttl.save()
+ return current_ttl
diff --git a/monkey/monkey_island/cc/models/test_monkey.py b/monkey/monkey_island/cc/models/test_monkey.py
index a744db6b6..717fb309a 100644
--- a/monkey/monkey_island/cc/models/test_monkey.py
+++ b/monkey/monkey_island/cc/models/test_monkey.py
@@ -46,6 +46,19 @@ class TestMonkey(IslandTestCase):
self.assertTrue(mia_monkey.is_dead())
self.assertFalse(alive_monkey.is_dead())
+ def test_ttl_renewal(self):
+ self.fail_if_not_testing_env()
+ self.clean_monkey_db()
+
+ # Arrange
+ monkey = Monkey(guid=str(uuid.uuid4()))
+ monkey.save()
+ self.assertIsNone(monkey.ttl_ref)
+
+ # act + assert
+ monkey.renew_ttl()
+ self.assertIsNotNone(monkey.ttl_ref)
+
def test_get_single_monkey_by_id(self):
self.fail_if_not_testing_env()
self.clean_monkey_db()
diff --git a/monkey/monkey_island/cc/resources/monkey.py b/monkey/monkey_island/cc/resources/monkey.py
index 36720e465..8e523a8a7 100644
--- a/monkey/monkey_island/cc/resources/monkey.py
+++ b/monkey/monkey_island/cc/resources/monkey.py
@@ -5,26 +5,17 @@ import dateutil.parser
import flask_restful
from flask import request
+from monkey_island.cc.consts import DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS
from monkey_island.cc.database import mongo
-from monkey_island.cc.models.monkey_ttl import MonkeyTtl
+from monkey_island.cc.models.monkey_ttl import create_monkey_ttl_document
from monkey_island.cc.services.config import ConfigService
from monkey_island.cc.services.node import NodeService
-MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS = 60 * 5
-
__author__ = 'Barak'
# TODO: separate logic from interface
-def create_monkey_ttl():
- # The TTL data uses the new `models` module which depends on mongoengine.
- current_ttl = MonkeyTtl.create_ttl_expire_in(MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS)
- current_ttl.save()
- ttlid = current_ttl.id
- return ttlid
-
-
class Monkey(flask_restful.Resource):
# Used by monkey. can't secure.
@@ -58,8 +49,8 @@ class Monkey(flask_restful.Resource):
tunnel_host_ip = monkey_json['tunnel'].split(":")[-2].replace("//", "")
NodeService.set_monkey_tunnel(monkey["_id"], tunnel_host_ip)
- ttlid = create_monkey_ttl()
- update['$set']['ttl_ref'] = ttlid
+ ttl = create_monkey_ttl_document(DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS)
+ update['$set']['ttl_ref'] = ttl.id
return mongo.db.monkey.update({"_id": monkey["_id"]}, update, upsert=False)
@@ -120,7 +111,8 @@ class Monkey(flask_restful.Resource):
tunnel_host_ip = monkey_json['tunnel'].split(":")[-2].replace("//", "")
monkey_json.pop('tunnel')
- monkey_json['ttl_ref'] = create_monkey_ttl()
+ ttl = create_monkey_ttl_document(DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS)
+ monkey_json['ttl_ref'] = ttl.id
mongo.db.monkey.update({"guid": monkey_json["guid"]},
{"$set": monkey_json},
diff --git a/monkey/monkey_island/cc/resources/telemetry.py b/monkey/monkey_island/cc/resources/telemetry.py
index d4aaa72df..279547dc1 100644
--- a/monkey/monkey_island/cc/resources/telemetry.py
+++ b/monkey/monkey_island/cc/resources/telemetry.py
@@ -15,10 +15,10 @@ from monkey_island.cc.services.edge import EdgeService
from monkey_island.cc.services.node import NodeService
from monkey_island.cc.encryptor import encryptor
from monkey_island.cc.services.wmi_handler import WMIHandler
+from monkey_island.cc.models.monkey import Monkey
__author__ = 'Barak'
-
logger = logging.getLogger(__name__)
@@ -49,6 +49,9 @@ class Telemetry(flask_restful.Resource):
telemetry_json = json.loads(request.data)
telemetry_json['timestamp'] = datetime.now()
+ # Monkey communicated, so it's alive. Update the TTL.
+ Monkey.get_single_monkey_by_guid(telemetry_json['monkey_guid']).renew_ttl()
+
monkey = NodeService.get_monkey_by_guid(telemetry_json['monkey_guid'])
try:
@@ -59,7 +62,7 @@ class Telemetry(flask_restful.Resource):
else:
logger.info('Got unknown type of telemetry: %s' % telem_category)
except Exception as ex:
- logger.error("Exception caught while processing telemetry", exc_info=True)
+ logger.error("Exception caught while processing telemetry. Info: {}".format(ex.message), exc_info=True)
telem_id = mongo.db.telemetry.insert(telemetry_json)
return mongo.db.telemetry.find_one_or_404({"_id": telem_id})
@@ -188,7 +191,7 @@ class Telemetry(flask_restful.Resource):
Telemetry.add_system_info_creds_to_config(creds)
Telemetry.replace_user_dot_with_comma(creds)
if 'mimikatz' in telemetry_json['data']:
- users_secrets = mimikatz_utils.MimikatzSecrets.\
+ users_secrets = mimikatz_utils.MimikatzSecrets. \
extract_secrets_from_mimikatz(telemetry_json['data'].get('mimikatz', ''))
if 'wmi' in telemetry_json['data']:
wmi_handler = WMIHandler(monkey_id, telemetry_json['data']['wmi'], users_secrets)
diff --git a/monkey/monkey_island/cc/resources/telemetry_feed.py b/monkey/monkey_island/cc/resources/telemetry_feed.py
index a4f090758..e271c45c5 100644
--- a/monkey/monkey_island/cc/resources/telemetry_feed.py
+++ b/monkey/monkey_island/cc/resources/telemetry_feed.py
@@ -1,3 +1,4 @@
+import logging
from datetime import datetime
import dateutil
@@ -9,6 +10,8 @@ from monkey_island.cc.auth import jwt_required
from monkey_island.cc.database import mongo
from monkey_island.cc.services.node import NodeService
+logger = logging.getLogger(__name__)
+
__author__ = 'itay.mizeretz'
@@ -23,11 +26,15 @@ class TelemetryFeed(flask_restful.Resource):
telemetries = telemetries.sort([('timestamp', flask_pymongo.ASCENDING)])
- return \
- {
- 'telemetries': [TelemetryFeed.get_displayed_telemetry(telem) for telem in telemetries],
- 'timestamp': datetime.now().isoformat()
- }
+ try:
+ return \
+ {
+ 'telemetries': [TelemetryFeed.get_displayed_telemetry(telem) for telem in telemetries],
+ 'timestamp': datetime.now().isoformat()
+ }
+ except KeyError as err:
+ logger.error("Failed parsing telemetries. Error: {0}.".format(err.message))
+ return {'telemetries': [], 'timestamp': datetime.now().isoformat()}
@staticmethod
def get_displayed_telemetry(telem):
diff --git a/monkey/monkey_island/cc/services/attack/technique_reports/__init__.py b/monkey/monkey_island/cc/services/attack/technique_reports/__init__.py
index cc702de62..ec5ee7781 100644
--- a/monkey/monkey_island/cc/services/attack/technique_reports/__init__.py
+++ b/monkey/monkey_island/cc/services/attack/technique_reports/__init__.py
@@ -124,8 +124,8 @@ class UsageTechnique(AttackTechnique):
def parse_usages(usage):
"""
Parses data from database and translates usage enums into strings
- :param usage:
- :return:
+ :param usage: Usage telemetry that contains fields: {'usage': 'SMB', 'status': 1}
+ :return: usage string
"""
try:
usage['usage'] = UsageEnum[usage['usage']].value[usage['status']]
diff --git a/monkey/monkey_island/cc/services/config_schema.py b/monkey/monkey_island/cc/services/config_schema.py
index 07596cf51..2fa1a3aff 100644
--- a/monkey/monkey_island/cc/services/config_schema.py
+++ b/monkey/monkey_island/cc/services/config_schema.py
@@ -389,7 +389,7 @@ SCHEMA = {
"self_delete_in_cleanup": {
"title": "Self delete on cleanup",
"type": "boolean",
- "default": False,
+ "default": True,
"description": "Should the monkey delete its executable when going down"
},
"use_file_logging": {
diff --git a/monkey/monkey_island/cc/services/report.py b/monkey/monkey_island/cc/services/report.py
index 9ceb9662a..593bbfdaf 100644
--- a/monkey/monkey_island/cc/services/report.py
+++ b/monkey/monkey_island/cc/services/report.py
@@ -373,8 +373,13 @@ class ReportService:
@staticmethod
def get_exploits():
+ query = [{'$match': {'telem_category': 'exploit', 'data.result': True}},
+ {'$group': {'_id': {'ip_address': '$data.machine.ip_addr'},
+ 'data': {'$first': '$$ROOT'},
+ }},
+ {"$replaceRoot": {"newRoot": "$data"}}]
exploits = []
- for exploit in mongo.db.telemetry.find({'telem_category': 'exploit', 'data.result': True}):
+ for exploit in mongo.db.telemetry.aggregate(query):
new_exploit = ReportService.process_exploit(exploit)
if new_exploit not in exploits:
exploits.append(new_exploit)
diff --git a/monkey/monkey_island/cc/ui/src/components/attack/techniques/Helpers.js b/monkey/monkey_island/cc/ui/src/components/attack/techniques/Helpers.js
index 9cb0de635..89721429d 100644
--- a/monkey/monkey_island/cc/ui/src/components/attack/techniques/Helpers.js
+++ b/monkey/monkey_island/cc/ui/src/components/attack/techniques/Helpers.js
@@ -36,7 +36,7 @@ export function getUsageColumns() {
style: { 'whiteSpace': 'unset' }}]
}])}
-export const scanStatus = {
+export const ScanStatus = {
UNSCANNED: 0,
SCANNED: 1,
USED: 2
diff --git a/monkey/monkey_island/cc/ui/src/components/attack/techniques/T1003.js b/monkey/monkey_island/cc/ui/src/components/attack/techniques/T1003.js
index 208840cf3..07fd4a400 100644
--- a/monkey/monkey_island/cc/ui/src/components/attack/techniques/T1003.js
+++ b/monkey/monkey_island/cc/ui/src/components/attack/techniques/T1003.js
@@ -2,7 +2,7 @@ import React from 'react';
import '../../../styles/Collapse.scss'
import '../../report-components/StolenPasswords'
import StolenPasswordsComponent from "../../report-components/StolenPasswords";
-import {scanStatus} from "./Helpers"
+import {ScanStatus} from "./Helpers"
class T1003 extends React.Component {
@@ -16,7 +16,7 @@ class T1003 extends React.Component {
- Not sure what this is? Not seeing your AWS EC2 instances? Read the documentation! + Not sure what this is? Not seeing your AWS EC2 instances? Read the documentation!