p20319658
/
monkey
forked from p34709852/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Island: Use list comprehension instead of map()

This commit is contained in:
Mike Salvatore 2022-09-30 14:22:02 -04:00
parent a2a6934a49
commit df1baeebe0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monkey/monkey_island/cc/repository/mongo_machine_repository.py
View File

@ -75,7 +75,7 @@ class MongoMachineRepository(IMachineRepository):
except Exception as err: except Exception as err:
raise RetrievalError(f"Error retrieving machines: {err}") raise RetrievalError(f"Error retrieving machines: {err}")
return list(map(lambda m: Machine(**m), cursor)) return [Machine(**m) for m in cursor]
def get_machines_by_ip(self, ip: IPv4Address) -> Sequence[Machine]: def get_machines_by_ip(self, ip: IPv4Address) -> Sequence[Machine]:
ip_regex = "^" + str(ip).replace(".", "\\.") + "\\/.*$" ip_regex = "^" + str(ip).replace(".", "\\.") + "\\/.*$"
@ -86,7 +86,7 @@ class MongoMachineRepository(IMachineRepository):
except Exception as err: except Exception as err:
raise RetrievalError(f'Error retrieving machines with ip "{ip}": {err}') raise RetrievalError(f'Error retrieving machines with ip "{ip}": {err}')
machines = list(map(lambda m: Machine(**m), cursor)) machines = [Machine(**m) for m in cursor]
if len(machines) == 0: if len(machines) == 0:
raise UnknownRecordError(f'No machines found with IP "{ip}"') raise UnknownRecordError(f'No machines found with IP "{ip}"')