p20319658
/
monkey
forked from p34709852/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

UT: Remove mocking of private method in test_pba_file_upload.py

This commit is contained in:
Mike Salvatore 2022-04-26 13:49:17 -04:00
parent 55c4f68902
commit fefdd9f024
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
monkey/tests/unit_tests/monkey_island/cc/resources/test_pba_file_upload.py
View File

@ -60,9 +60,14 @@ class MockFileStorageService(IFileStorageService):
@pytest.fixture @pytest.fixture
def flask_client(build_flask_client, tmp_path): def file_storage_service():
return MockFileStorageService()
@pytest.fixture
def flask_client(build_flask_client, file_storage_service):
container = DIContainer() container = DIContainer()
container.register(IFileStorageService, MockFileStorageService) container.register_instance(IFileStorageService, file_storage_service)
with build_flask_client(container) as flask_client: with build_flask_client(container) as flask_client:
yield flask_client yield flask_client
@ -91,12 +96,9 @@ def test_pba_file_upload_post__invalid(flask_client, monkeypatch, mock_set_confi
@pytest.mark.parametrize("pba_os", [LINUX_PBA_TYPE, WINDOWS_PBA_TYPE]) @pytest.mark.parametrize("pba_os", [LINUX_PBA_TYPE, WINDOWS_PBA_TYPE])
def test_pba_file_upload_post__internal_server_error( def test_pba_file_upload_post__internal_server_error(
flask_client, pba_os, monkeypatch, mock_set_config_value flask_client, pba_os, mock_set_config_value, file_storage_service
): ):
monkeypatch.setattr( file_storage_service.save_file = lambda x, y: raise_(Exception())
"monkey_island.cc.resources.pba_file_upload.FileUpload._upload_pba_file",
lambda x, y: raise_(Exception()),
)
resp = flask_client.post( resp = flask_client.post(
f"/api/file-upload/{pba_os}", f"/api/file-upload/{pba_os}",