Mike Salvatore
3dafdc810b
add unit tests for AutoNewLinuxUser
2021-01-18 13:58:36 -05:00
Mike Salvatore
5481baf387
add unit tests for auto_new_user_factory
2021-01-18 13:56:25 -05:00
Mike Salvatore
32a8c1b362
Merge branch 'fix-code-coverage-accuracy' into develop
2021-01-18 13:40:27 -05:00
VakarisZ
e69c94ae50
Split and moved zero trust service into pillar_service.py and principle_service.py
2021-01-18 12:01:33 +02:00
Mike Salvatore
d008e3d52a
ci: add .coveragerc to omit unit test code from coverage report
...
The code coverage report was including the unit tests themselves in the
coverage report. This resulted in an artifically inflated code coverage
metric, as code coverage tools will naturally report test code to be
very highly "covered".
2021-01-17 20:20:06 -05:00
VakarisZ
01feea905b
Refactored "scoutsuite_findings" directory back to "scoutsuite" directory, because it doesn't only parse findings
2021-01-15 15:34:59 +02:00
Mike Salvatore
bf6db078a6
ui: add missing semicolons
2021-01-15 08:16:08 -05:00
VakarisZ
3a9aa3191f
Separated zero trust and security report resources
2021-01-15 15:10:07 +02:00
VakarisZ
02a45c7449
Moved and renamed some services to improve directory structure of zero trust services
2021-01-15 15:08:49 +02:00
VakarisZ
85f4c4f250
Small ScoutSuite feature code style refactorings
2021-01-15 11:22:40 +02:00
VakarisZ
e79290e761
Refactored scoutsuite rule button from "ScoutSuite rules" to just "Rules" to look more consistent with "Events" button
2021-01-15 11:20:57 +02:00
Mike Salvatore
74933daf8d
ci: Use pytest-cov instead of coverage
...
For some unknown reason, running `coverage` omits some python files from
the coverage report. It also runs the test suite a second time, which is
inefficient. By using pytest-cov, tests are only run once and coverage
data is more complete.
2021-01-14 14:10:43 -05:00
Mike Salvatore
d9b25978a0
Fix codecov.io integration
...
See https://docs.codecov.io/docs/fixing-paths for more details
2021-01-14 09:24:37 -05:00
VakarisZ
de69d167ba
Minor scoutsuite code refactorings
2021-01-14 16:05:52 +02:00
VakarisZ
22194c566a
Refactored aws access keys in config, added them to encrypted parameter list and added ScoutSuite specific exception
2021-01-14 16:05:06 +02:00
Mike Salvatore
11ea5e1a7e
ui: separate json schema-related functions into JsonSchemaHelpers.js
2021-01-14 08:44:43 -05:00
Mike Salvatore
8d024b9002
ui: separate MasterCheckbox and ChildCheckbox into their own files
2021-01-14 08:37:52 -05:00
VakarisZ
761ed2ec43
Refactored code of rule ordering
2021-01-14 12:17:34 +02:00
VakarisZ
a818025f63
Typo fix in service_consts.py
2021-01-14 12:05:13 +02:00
VakarisZ
cd9d2904c5
Added comment explaining why finding details are in a separate documents to discourage uninformed refactoring in the future
2021-01-14 12:02:38 +02:00
VakarisZ
2dfcbb49d4
Minor refactoring and typo fix
2021-01-14 11:59:57 +02:00
VakarisZ
87dafeb440
Refactored scoutsuite rule count badge readability.
2021-01-13 17:57:54 +02:00
VakarisZ
b90f6587c1
Reverted resource value display to show "False", because for IAM rules it makes sense and expresses if it the rule is enabled or not.
2021-01-13 16:57:36 +02:00
VakarisZ
7b60d4d2e6
Refactored ScoutSuiteDataParser.js to improve the readability of scoutsuite data extraction process
...
temp
2021-01-13 16:57:36 +02:00
Mike Salvatore
73dd8ddcc9
ui: Minor readability and style changes for AdvancedMultiSelect
2021-01-13 07:35:03 -05:00
Mike Salvatore
94b87f8d9a
ui: Remove unnecessary call to getDefaultPaneParams()
2021-01-12 15:59:16 -05:00
Mike Salvatore
e2e87dc733
docs: Rename mispelled directory "configruation" -> "configuration"
2021-01-12 15:45:32 -05:00
Mike Salvatore
819e1778c8
docs: Update network-breach.PNG with mixed-state Exploiters checkbox
2021-01-12 15:25:23 -05:00
Mike Salvatore
701d938330
ui: refactor AdvancedMultiSelect.js for readability and flow
2021-01-12 15:15:23 -05:00
Mike Salvatore
19bc09196f
ui: Enable mixed-state behavior for master checkbox in AdavncedMultiSelect
...
The AdvancedMultiSelect should adhere to some set of human interface
guidelines. In the absence of a formal, agreed upon set of guidelines
for Infection Monkey, this commit uses KDE's guidelines for checkboxes:
https://hig.kde.org/components/editing/checkbox.html
When child checkboxes are not all checked, the master checkbox displays
a mixed-state icon, instead of a checked icon. Clicking the mixed-state
icon checks all child checkboxes. Clicking an unchecked master checkbox
also enables all child checkboxes.
In the past, clicking an unchecked master checkbox checked only the
*default* child checkboxes. While this may seem desirable so that unsafe
exploits do not accidentally get selected by the user, it will confuse
and frustrate users, as master/child checkboxes do not normally function
this way. If there is concern that users may unknowingly select unsafe
exploits/options, we should pop up a warning to inform the user when the
config is saved/submitted.
Issue #891
2021-01-12 15:15:18 -05:00
VakarisZ
7e07489807
Moved rule parsing methods into a separate component, added more details about rules in rule overview: added how many failed/passed/uncheck rules there are for a finding.
2021-01-12 12:41:58 +02:00
VakarisZ
5027dd4d2c
Improved unsecure resource display: removed a separate line for unsecure resource count and instead added the count to the annotation of unsecure resource list. E.g: "Flagged resources (3)"
2021-01-12 12:41:58 +02:00
VakarisZ
1472382387
Fixed react warnings related to keys and <div/> in <p/>
2021-01-12 12:41:58 +02:00
VakarisZ
d9a5289c8d
Minor FindingsTable.js readability refactoring
2021-01-12 12:41:58 +02:00
VakarisZ
789c58f0ac
Refactored ScoutSuite finding classes to have ABC
2021-01-12 12:41:58 +02:00
VakarisZ
737e6bce3d
Renamed rule_parsing.py to rule_parser.py, to match the classname
2021-01-12 12:41:58 +02:00
VakarisZ
d1d5c45c26
Added scoutsuite package requirements to agent requirements.txt
2021-01-12 12:41:58 +02:00
VakarisZ
ba947a6b30
"type" param renamed to "finding_type" in finding DAO
...
Fixed bug, which happened due to type -> finding_type refactoring
2021-01-12 12:41:58 +02:00
Mike Salvatore
878f959a8f
ui: Factor ChildCheckbox out of AdvancedMultiSelect
2021-01-11 19:54:51 -05:00
Mike Salvatore
af329d56d8
ui: Factor MasterCheckbox() out of AdvancedMultiSelect
2021-01-11 19:16:18 -05:00
Mike Salvatore
84b422a120
ui: Refactor AdvancedMultiSelect as a class
...
AdvancedMultiSelect can be broken up and composed of smaller, more
focused components. This commit refactors AdvancedMultiSelect from a
functional component to a class component.
2021-01-11 19:15:45 -05:00
VakarisZ
f2b9f850d7
Merge pull request #838 from shreyamalviya/add-run-as-user-option
...
Add option to run as a certain user on the Run Monkey page
2021-01-11 10:19:34 +02:00
VakarisZ
4f43edbefb
Removed unnecessary logging in pba_file_download.py
2021-01-11 08:54:01 +02:00
VakarisZ
78aaa4091d
Fixed custom PBA upload path to use abstract path in island dir rather than flask cwd.
2021-01-08 17:07:36 +02:00
VakarisZ
46abff412d
Grouped files used for serving flask into a "server_utils" package
2021-01-08 12:05:18 +02:00
Shreya
55dae3f29d
Minor code changes
2021-01-08 15:16:29 +05:30
Shreya
22d9f70374
Add option to run as a certain user via manual command on the Run Monkey page
2021-01-08 15:16:29 +05:30
VakarisZ
28601d97ed
Refactored utility method and added unit test
2021-01-08 10:57:44 +02:00
Mike Salvatore
62541d2027
Merge pull request #913 from guardicore/improve-report-documentation
...
Fixes #887
2021-01-06 16:16:56 -05:00
Mike Salvatore
708bb88c35
docs: Format report list with '"style="p"'
2021-01-06 11:25:48 -05:00