Commit Graph

4315 Commits

Author SHA1 Message Date
Mike Salvatore 11ea5e1a7e ui: separate json schema-related functions into JsonSchemaHelpers.js 2021-01-14 08:44:43 -05:00
Mike Salvatore 8d024b9002 ui: separate MasterCheckbox and ChildCheckbox into their own files 2021-01-14 08:37:52 -05:00
VakarisZ 761ed2ec43 Refactored code of rule ordering 2021-01-14 12:17:34 +02:00
VakarisZ a818025f63 Typo fix in service_consts.py 2021-01-14 12:05:13 +02:00
VakarisZ cd9d2904c5 Added comment explaining why finding details are in a separate documents to discourage uninformed refactoring in the future 2021-01-14 12:02:38 +02:00
VakarisZ 2dfcbb49d4 Minor refactoring and typo fix 2021-01-14 11:59:57 +02:00
VakarisZ 87dafeb440 Refactored scoutsuite rule count badge readability. 2021-01-13 17:57:54 +02:00
VakarisZ b90f6587c1 Reverted resource value display to show "False", because for IAM rules it makes sense and expresses if it the rule is enabled or not. 2021-01-13 16:57:36 +02:00
VakarisZ 7b60d4d2e6 Refactored ScoutSuiteDataParser.js to improve the readability of scoutsuite data extraction process
temp
2021-01-13 16:57:36 +02:00
Mike Salvatore 73dd8ddcc9 ui: Minor readability and style changes for AdvancedMultiSelect 2021-01-13 07:35:03 -05:00
Mike Salvatore 94b87f8d9a ui: Remove unnecessary call to getDefaultPaneParams() 2021-01-12 15:59:16 -05:00
Mike Salvatore e2e87dc733 docs: Rename mispelled directory "configruation" -> "configuration" 2021-01-12 15:45:32 -05:00
Mike Salvatore 819e1778c8 docs: Update network-breach.PNG with mixed-state Exploiters checkbox 2021-01-12 15:25:23 -05:00
Mike Salvatore 701d938330 ui: refactor AdvancedMultiSelect.js for readability and flow 2021-01-12 15:15:23 -05:00
Mike Salvatore 19bc09196f ui: Enable mixed-state behavior for master checkbox in AdavncedMultiSelect
The AdvancedMultiSelect should adhere to some set of human interface
guidelines. In the absence of a formal, agreed upon set of guidelines
for Infection Monkey, this commit uses KDE's guidelines for checkboxes:
https://hig.kde.org/components/editing/checkbox.html

When child checkboxes are not all checked, the master checkbox displays
a mixed-state icon, instead of a checked icon. Clicking the mixed-state
icon checks all child checkboxes. Clicking an unchecked master checkbox
also enables all child checkboxes.

In the past, clicking an unchecked master checkbox checked only the
*default* child checkboxes. While this may seem desirable so that unsafe
exploits do not accidentally get selected by the user, it will confuse
and frustrate users, as master/child checkboxes do not normally function
this way. If there is concern that users may unknowingly select unsafe
exploits/options, we should pop up a warning to inform the user when the
config is saved/submitted.

Issue #891
2021-01-12 15:15:18 -05:00
VakarisZ 7e07489807 Moved rule parsing methods into a separate component, added more details about rules in rule overview: added how many failed/passed/uncheck rules there are for a finding. 2021-01-12 12:41:58 +02:00
VakarisZ 5027dd4d2c Improved unsecure resource display: removed a separate line for unsecure resource count and instead added the count to the annotation of unsecure resource list. E.g: "Flagged resources (3)" 2021-01-12 12:41:58 +02:00
VakarisZ 1472382387 Fixed react warnings related to keys and <div/> in <p/> 2021-01-12 12:41:58 +02:00
VakarisZ d9a5289c8d Minor FindingsTable.js readability refactoring 2021-01-12 12:41:58 +02:00
VakarisZ 789c58f0ac Refactored ScoutSuite finding classes to have ABC 2021-01-12 12:41:58 +02:00
VakarisZ 737e6bce3d Renamed rule_parsing.py to rule_parser.py, to match the classname 2021-01-12 12:41:58 +02:00
VakarisZ d1d5c45c26 Added scoutsuite package requirements to agent requirements.txt 2021-01-12 12:41:58 +02:00
VakarisZ ba947a6b30 "type" param renamed to "finding_type" in finding DAO
Fixed bug, which happened due to type -> finding_type refactoring
2021-01-12 12:41:58 +02:00
Mike Salvatore 878f959a8f ui: Factor ChildCheckbox out of AdvancedMultiSelect 2021-01-11 19:54:51 -05:00
Mike Salvatore af329d56d8 ui: Factor MasterCheckbox() out of AdvancedMultiSelect 2021-01-11 19:16:18 -05:00
Mike Salvatore 84b422a120 ui: Refactor AdvancedMultiSelect as a class
AdvancedMultiSelect can be broken up and composed of smaller, more
focused components. This commit refactors AdvancedMultiSelect from a
functional component to a class component.
2021-01-11 19:15:45 -05:00
VakarisZ f2b9f850d7
Merge pull request #838 from shreyamalviya/add-run-as-user-option
Add option to run as a certain user on the Run Monkey page
2021-01-11 10:19:34 +02:00
VakarisZ 4f43edbefb Removed unnecessary logging in pba_file_download.py 2021-01-11 08:54:01 +02:00
VakarisZ 78aaa4091d Fixed custom PBA upload path to use abstract path in island dir rather than flask cwd. 2021-01-08 17:07:36 +02:00
VakarisZ 46abff412d Grouped files used for serving flask into a "server_utils" package 2021-01-08 12:05:18 +02:00
Shreya 55dae3f29d Minor code changes 2021-01-08 15:16:29 +05:30
Shreya 22d9f70374 Add option to run as a certain user via manual command on the Run Monkey page 2021-01-08 15:16:29 +05:30
VakarisZ 28601d97ed Refactored utility method and added unit test 2021-01-08 10:57:44 +02:00
Mike Salvatore 62541d2027
Merge pull request #913 from guardicore/improve-report-documentation
Fixes #887
2021-01-06 16:16:56 -05:00
Mike Salvatore 708bb88c35 docs: Format report list with '"style="p"' 2021-01-06 11:25:48 -05:00
Mike Salvatore ae614c83ed docs: Add descriptions for reports and display them on the reports index page 2021-01-04 15:38:48 -05:00
Mike Salvatore 539a87a5cc docs: Move "Reports" to the top level of the documentation menu 2021-01-04 15:11:49 -05:00
VakarisZ eaf9b6a8d1 Renamed cloud providers enum to camel case 2021-01-04 15:46:53 +02:00
VakarisZ 8cd3834fe4 Fixed wrong argument in scoutsuite_collector.py 2021-01-04 14:06:34 +02:00
VakarisZ 1f129757a4
Merge pull request #909 from shreyamalviya/doc-fix
Documentation fix
2020-12-22 18:00:14 +02:00
VakarisZ 1bff64f09b
Merge pull request #875 from VakarisZ/validation_script
Validation script
2020-12-22 15:48:39 +02:00
Shreya 208f83f4ff Change label from "other" to "unused" in ZT report documentation 2020-12-22 18:49:01 +05:30
VakarisZ da1ef9088d
Merge pull request #855 from VakarisZ/readme_update_password_change
Added password reset tutorial to FAQ
2020-12-18 12:30:24 +02:00
VakarisZ 7fb1e3f15b
Merge pull request #862 from VakarisZ/gevent_refactoring
Gevent refactoring
2020-12-17 17:29:58 +02:00
VakarisZ 99d73be0d8
Merge pull request #890 from guardicore/custom_pba_bugfix
Fixed custom post breach action path bug.
2020-12-17 14:14:23 +02:00
VakarisZ 8aae611396 Merge remote-tracking branch 'upstream/develop' into custom_pba_bugfix 2020-12-17 13:26:55 +02:00
VakarisZ e6bb978dc4
Merge pull request #894 from withshubh/develop
Fix code quality issues
2020-12-16 12:19:37 +02:00
Shubhendra Singh Chauhan 866d62239f
Delete .deepsource.toml 2020-12-15 17:53:17 +05:30
VakarisZ d8440303ce
Merge pull request #867 from VakarisZ/aws_run_option_fix
Run on AWS instance option fix
2020-12-15 12:15:41 +02:00
VakarisZ cd27a889b1
Merge pull request #895 from guardicore/smb_exec_bugfix
SMB bugfix
2020-12-15 12:11:53 +02:00