p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Removed unnecessary DBCacheTests.test_clear_commits_transaction test. 

Was added in 44164c5c30 but the
transaction.commit_unless_managed() line was removed in
ba5138b1c0253fcf390b7509ad7b954117b3be88; thus the test does nothing
but check that clear() runs.
This commit is contained in:
Adam Chainz 2015-08-30 20:28:37 +01:00 committed by Tim Graham
parent 73df1040a2
commit 05239180c0
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/cache/tests.py vendored
View File

@ -20,7 +20,7 @@ from django.core.cache import (
DEFAULT_CACHE_ALIAS, CacheKeyWarning, cache, caches, DEFAULT_CACHE_ALIAS, CacheKeyWarning, cache, caches,
) )
from django.core.cache.utils import make_template_fragment_key from django.core.cache.utils import make_template_fragment_key
from django.db import connection, connections, transaction from django.db import connection, connections
from django.http import HttpRequest, HttpResponse, StreamingHttpResponse from django.http import HttpRequest, HttpResponse, StreamingHttpResponse
from django.middleware.cache import ( from django.middleware.cache import (
CacheMiddleware, FetchFromCacheMiddleware, UpdateCacheMiddleware, CacheMiddleware, FetchFromCacheMiddleware, UpdateCacheMiddleware,
@ -971,13 +971,6 @@ class DBCacheTests(BaseCacheTests, TransactionTestCase):
self.assertEqual(out.getvalue(), self.assertEqual(out.getvalue(),
"Cache table 'test cache table' created.\n") "Cache table 'test cache table' created.\n")
def test_clear_commits_transaction(self):
# Ensure the database transaction is committed (#19896)
cache.set("key1", "spam")
cache.clear()
transaction.rollback()
self.assertIsNone(cache.get("key1"))
@override_settings(USE_TZ=True) @override_settings(USE_TZ=True)
class DBCacheWithTimeZoneTests(DBCacheTests): class DBCacheWithTimeZoneTests(DBCacheTests):