p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed #5749 -- Added field_name as a key in the _html_output dict 

Thanks SmileyChris for the suggestion.
This commit is contained in:
e0ne 2013-09-10 16:09:55 +03:00 committed by Tim Graham
parent 4840fd9cbc
commit 053de6131a
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/forms/forms.py
View File

@ -185,7 +185,8 @@ class BaseForm(object):
'label': force_text(label), 'label': force_text(label),
'field': six.text_type(bf), 'field': six.text_type(bf),
'help_text': help_text, 'help_text': help_text,
'html_class_attr': html_class_attr 'html_class_attr': html_class_attr,
'field_name': bf.html_name,
}) })
if top_errors: if top_errors:

11
tests/forms_tests/tests/test_forms.py
View File

@ -1950,3 +1950,14 @@ class FormsTestCase(TestCase):
boundfield = SomeForm(label_suffix='!')['field'] boundfield = SomeForm(label_suffix='!')['field']
self.assertHTMLEqual(boundfield.label_tag(label_suffix='$'), '<label for="id_field">Field$</label>') self.assertHTMLEqual(boundfield.label_tag(label_suffix='$'), '<label for="id_field">Field$</label>')
def test_field_name(self):
"""#5749 - `field_name` may be used as a key in _html_output()."""
class SomeForm(Form):
some_field = CharField()
def as_p(self):
return self._html_output(u'<p id="p_%(field_name)s"></p>', u'%s', '</p>', u' %s', True)
form = SomeForm()
self.assertHTMLEqual(form.as_p(), '<p id="p_some_field"></p>')