Fixed #33626 -- Cleared cache when unregistering a lookup.

This commit is contained in:
Himanshu-Balasamanta 2022-04-08 15:21:51 +05:30 committed by Mariusz Felisiak
parent 884b4c27f5
commit 06ebaa9e28
4 changed files with 13 additions and 11 deletions

View File

@ -217,6 +217,7 @@ class RegisterLookupMixin:
if lookup_name is None: if lookup_name is None:
lookup_name = lookup.lookup_name lookup_name = lookup.lookup_name
del cls.class_lookups[lookup_name] del cls.class_lookups[lookup_name]
cls._clear_cached_lookups()
def select_related_descend(field, restricted, requested, load_fields, reverse=False): def select_related_descend(field, restricted, requested, load_fields, reverse=False):

View File

@ -323,6 +323,8 @@ class LookupTests(TestCase):
with register_lookup(models.ForeignObject, Exactly): with register_lookup(models.ForeignObject, Exactly):
# getting the lookups again should re-cache # getting the lookups again should re-cache
self.assertIn("exactly", field.get_lookups()) self.assertIn("exactly", field.get_lookups())
# Unregistration should bust the cache.
self.assertNotIn("exactly", field.get_lookups())
class BilateralTransformTests(TestCase): class BilateralTransformTests(TestCase):

View File

@ -88,7 +88,6 @@ class TestMethods(SimpleTestCase):
transform = field.get_transform("my_transform") transform = field.get_transform("my_transform")
self.assertIs(transform, MyTransform) self.assertIs(transform, MyTransform)
models.JSONField._unregister_lookup(MyTransform) models.JSONField._unregister_lookup(MyTransform)
models.JSONField._clear_cached_lookups()
transform = field.get_transform("my_transform") transform = field.get_transform("my_transform")
self.assertIsInstance(transform, KeyTransformFactory) self.assertIsInstance(transform, KeyTransformFactory)