p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed #32087 -- Made technical 500 debug page use HTTPS for sharing traceback.

This commit is contained in:
nik258heda 2020-10-09 17:45:09 +05:30 committed by Mariusz Felisiak
parent f1f24539d8
commit 079deba530
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/views/templates/technical_500.html
View File

@ -278,7 +278,7 @@
{% endfor %} {% endfor %}
</ul> </ul>
</div> </div>
<form action="http://dpaste.com/" name="pasteform" id="pasteform" method="post"> <form action="https://dpaste.com/" name="pasteform" id="pasteform" method="post">
{% if not is_email %} {% if not is_email %}
<div id="pastebinTraceback" class="pastebin"> <div id="pastebinTraceback" class="pastebin">
<input type="hidden" name="language" value="PythonConsole"> <input type="hidden" name="language" value="PythonConsole">

13
tests/view_tests/tests/test_debug.py
View File

@ -401,6 +401,19 @@ class ExceptionReporterTests(SimpleTestCase):
self.assertIn('<h2>Request information</h2>', html) self.assertIn('<h2>Request information</h2>', html)
self.assertIn('<p>Request data not supplied</p>', html) self.assertIn('<p>Request data not supplied</p>', html)
def test_sharing_traceback(self):
try:
raise ValueError('Oops')
except ValueError:
exc_type, exc_value, tb = sys.exc_info()
reporter = ExceptionReporter(None, exc_type, exc_value, tb)
html = reporter.get_traceback_html()
self.assertIn(
'<form action="https://dpaste.com/" name="pasteform" '
'id="pasteform" method="post">',
html,
)
def test_eol_support(self): def test_eol_support(self):
"""The ExceptionReporter supports Unix, Windows and Macintosh EOL markers""" """The ExceptionReporter supports Unix, Windows and Macintosh EOL markers"""
LINES = ['print %d' % i for i in range(1, 6)] LINES = ['print %d' % i for i in range(1, 6)]