p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed #34662 -- Corrected number in error messages for Array(Min/Max)LengthValidator.

This commit is contained in:
şuayip üzülmez 2023-06-17 00:34:47 +03:00 committed by Mariusz Felisiak
parent 17cdc7395e
commit 0c5146523b
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
django/contrib/postgres/validators.py
View File

@ -16,7 +16,7 @@ class ArrayMaxLengthValidator(MaxLengthValidator):
"%(limit_value)d.",
"List contains %(show_value)d items, it should contain no more than "
"%(limit_value)d.",
"limit_value",
"show_value",
)
@ -26,7 +26,7 @@ class ArrayMinLengthValidator(MinLengthValidator):
"%(limit_value)d.",
"List contains %(show_value)d items, it should contain no fewer than "
"%(limit_value)d.",
"limit_value",
"show_value",
)

14
tests/postgres_tests/test_array.py
View File

@ -990,6 +990,13 @@ class TestValidation(PostgreSQLSimpleTestCase):
"List contains 4 items, it should contain no more than 3.",
)
def test_with_size_singular(self):
field = ArrayField(models.IntegerField(), size=1)
field.clean([1], None)
msg = "List contains 2 items, it should contain no more than 1."
with self.assertRaisesMessage(exceptions.ValidationError, msg):
field.clean([1, 2], None)
def test_nested_array_mismatch(self):
field = ArrayField(ArrayField(models.IntegerField()))
field.clean([[1, 2], [3, 4]], None)
@ -1132,6 +1139,13 @@ class TestSimpleFormField(PostgreSQLSimpleTestCase):
"List contains 3 items, it should contain no fewer than 4.",
)
def test_min_length_singular(self):
field = SimpleArrayField(forms.IntegerField(), min_length=2)
field.clean([1, 2])
msg = "List contains 1 item, it should contain no fewer than 2."
with self.assertRaisesMessage(exceptions.ValidationError, msg):
field.clean([1])
def test_required(self):
field = SimpleArrayField(forms.CharField(), required=True)
with self.assertRaises(exceptions.ValidationError) as cm: