p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Refs #33201 -- Avoided unnecessary queries when renaming models with db_table on SpatiaLite.

This commit is contained in:
Mariusz Felisiak 2023-07-18 14:08:47 +02:00 committed by GitHub
parent 6ad2738a8f
commit 3109038992
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
django/contrib/gis/db/backends/spatialite/schema.py
View File

@ -139,6 +139,11 @@ class SpatialiteSchemaEditor(DatabaseSchemaEditor):
):
from django.contrib.gis.db.models import GeometryField
if old_db_table == new_db_table or (
self.connection.features.ignores_table_name_case
and old_db_table.lower() == new_db_table.lower()
):
return
# Remove geometry-ness from temp table
for field in model._meta.local_fields:
if isinstance(field, GeometryField):

9
tests/migrations/test_operations.py
View File

@ -988,6 +988,15 @@ class OperationTests(OperationTestBase):
"test_rmwsc_rider", ["pony_id"], ("test_rmwsc_littlehorse", "id")
)
def test_rename_model_no_relations_with_db_table_noop(self):
app_label = "test_rmwdbtnoop"
project_state = self.set_up_test_model(app_label, db_table="my_pony")
operation = migrations.RenameModel("Pony", "LittleHorse")
new_state = project_state.clone()
operation.state_forwards(app_label, new_state)
with connection.schema_editor() as editor, self.assertNumQueries(0):
operation.database_forwards(app_label, editor, project_state, new_state)
def test_rename_model_with_self_referential_m2m(self):
app_label = "test_rename_model_with_self_referential_m2m"