p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed #21403: Corrected test code 

A test for annotations incorrectly assumed that the first instance
(in the test) of a model using AutoField for PK will always get pk=1.
The test was changed to compare against actual instance id instead.
This commit is contained in:
Shai Berger 2013-11-25 16:12:43 +02:00
parent 70e61310d6
commit 3411af3cd1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/generic_relations_regress/tests.py
View File

@ -222,10 +222,10 @@ class GenericRelationTests(TestCase):
Link.objects.create(content_object=b) Link.objects.create(content_object=b)
qs = HasLinkThing.objects.annotate(Sum('links')) qs = HasLinkThing.objects.annotate(Sum('links'))
# If content_type restriction isn't in the query's join condition, # If content_type restriction isn't in the query's join condition,
# then wrong results are produced here as b will also match (it has # then wrong results are produced here as the link to b will also match
# same pk). # (b and hs1 have equal pks).
self.assertEqual(qs.count(), 1) self.assertEqual(qs.count(), 1)
self.assertEqual(qs[0].links__sum, 1) self.assertEqual(qs[0].links__sum, l.id)
l.delete() l.delete()
# Now if we don't have proper left join, we will not produce any # Now if we don't have proper left join, we will not produce any
# results at all here. # results at all here.