p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Refs #31055 -- Made DiscoverRunner skip running system checks on unused test databases.

This commit is contained in:
Simon Charette 2020-02-07 10:37:25 +01:00 committed by Mariusz Felisiak
parent 0b83c8cc4d
commit 430e796980
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
django/test/runner.py
View File

@ -630,10 +630,10 @@ class DiscoverRunner:
'buffer': self.buffer, 'buffer': self.buffer,
} }
def run_checks(self): def run_checks(self, databases):
# Checks are run after database creation since some checks require # Checks are run after database creation since some checks require
# database access. # database access.
call_command('check', verbosity=self.verbosity) call_command('check', verbosity=self.verbosity, databases=databases)
def run_suite(self, suite, **kwargs): def run_suite(self, suite, **kwargs):
kwargs = self.get_test_runner_kwargs() kwargs = self.get_test_runner_kwargs()
@ -695,7 +695,7 @@ class DiscoverRunner:
old_config = self.setup_databases(aliases=databases) old_config = self.setup_databases(aliases=databases)
run_failed = False run_failed = False
try: try:
self.run_checks() self.run_checks(databases)
result = self.run_suite(suite) result = self.run_suite(suite)
except Exception: except Exception:
run_failed = True run_failed = True

3
docs/releases/3.1.txt
View File

@ -332,6 +332,9 @@ Tests
* Django test runner now supports a :option:`test --buffer` option to discard * Django test runner now supports a :option:`test --buffer` option to discard
output for passing tests. output for passing tests.
* :class:`~django.test.runner.DiscoverRunner` now skips running the system
checks on databases not :ref:`referenced by tests<testing-multi-db>`.
URLs URLs
~~~~ ~~~~

8
docs/topics/testing/advanced.txt
View File

@ -637,9 +637,13 @@ Methods
Creates the test databases by calling Creates the test databases by calling
:func:`~django.test.utils.setup_databases`. :func:`~django.test.utils.setup_databases`.
.. method:: DiscoverRunner.run_checks() .. method:: DiscoverRunner.run_checks(databases)
Runs the :doc:`system checks </topics/checks>`. Runs the :doc:`system checks </topics/checks>` on the test ``databases``.
.. versionadded:: 3.1
The ``databases`` parameter was added.
.. method:: DiscoverRunner.run_suite(suite, **kwargs) .. method:: DiscoverRunner.run_suite(suite, **kwargs)