diff --git a/django/db/models/related.py b/django/db/models/related.py index a63f09b7455..8c64b464ec2 100644 --- a/django/db/models/related.py +++ b/django/db/models/related.py @@ -1,7 +1,7 @@ class BoundRelatedObject(object): def __init__(self, related_object, field_mapping, original): self.relation = related_object - self.field_mappings = field_mapping[related_object.opts.module_name] + self.field_mappings = field_mapping[related_object.name] def template_name(self): raise NotImplementedError @@ -16,7 +16,7 @@ class RelatedObject(object): self.opts = model._meta self.field = field self.edit_inline = field.rel.edit_inline - self.name = self.opts.module_name + self.name = '%s_%s' % (self.opts.app_label, self.opts.module_name) self.var_name = self.opts.object_name.lower() def flatten_data(self, follow, obj=None): diff --git a/tests/regressiontests/many_to_one_regress/models.py b/tests/regressiontests/many_to_one_regress/models.py index 6c067446b10..8ddec98da44 100644 --- a/tests/regressiontests/many_to_one_regress/models.py +++ b/tests/regressiontests/many_to_one_regress/models.py @@ -1,13 +1,34 @@ from django.db import models +# If ticket #1578 ever slips back in, these models will not be able to be +# created (the field names being lower-cased versions of their opposite +# classes is important here). + class First(models.Model): second = models.IntegerField() class Second(models.Model): first = models.ForeignKey(First, related_name = 'the_first') -# If ticket #1578 ever slips back in, these models will not be able to be -# created (the field names being lower-cased versions of their opposite -# classes is important here). +# Protect against repetition of #1839, #2415 and #2536. +class Third(models.Model): + name = models.CharField(maxlength=20) + third = models.ForeignKey('self', null=True, related_name='child_set') -__test__ = {'API_TESTS':""} +class Parent(models.Model): + name = models.CharField(maxlength=20) + bestchild = models.ForeignKey('Child', null=True, related_name='favored_by') + +class Child(models.Model): + name = models.CharField(maxlength=20) + parent = models.ForeignKey(Parent) + + +__test__ = {'API_TESTS':""" +>>> Third.AddManipulator().save(dict(id='3', name='An example', another=None)) + +>>> parent = Parent(name = 'fred') +>>> parent.save() +>>> Child.AddManipulator().save(dict(name='bam-bam', parent=parent.id)) + +"""}