mirror of https://github.com/django/django.git
Fixed #16856 - Added a way to clear select_related.
Thanks Carl for the suggestion and David Cramer for the patch.
This commit is contained in:
parent
616f3c4a79
commit
5074c75a37
|
@ -645,6 +645,8 @@ class QuerySet(object):
|
||||||
|
|
||||||
If fields are specified, they must be ForeignKey fields and only those
|
If fields are specified, they must be ForeignKey fields and only those
|
||||||
related objects are included in the selection.
|
related objects are included in the selection.
|
||||||
|
|
||||||
|
If select_related(None) is called, the list is cleared.
|
||||||
"""
|
"""
|
||||||
if 'depth' in kwargs:
|
if 'depth' in kwargs:
|
||||||
warnings.warn('The "depth" keyword argument has been deprecated.\n'
|
warnings.warn('The "depth" keyword argument has been deprecated.\n'
|
||||||
|
@ -654,7 +656,9 @@ class QuerySet(object):
|
||||||
raise TypeError('Unexpected keyword arguments to select_related: %s'
|
raise TypeError('Unexpected keyword arguments to select_related: %s'
|
||||||
% (list(kwargs),))
|
% (list(kwargs),))
|
||||||
obj = self._clone()
|
obj = self._clone()
|
||||||
if fields:
|
if fields == (None,):
|
||||||
|
obj.query.select_related = False
|
||||||
|
elif fields:
|
||||||
if depth:
|
if depth:
|
||||||
raise TypeError('Cannot pass both "depth" and fields to select_related()')
|
raise TypeError('Cannot pass both "depth" and fields to select_related()')
|
||||||
obj.query.add_select_related(fields)
|
obj.query.add_select_related(fields)
|
||||||
|
|
|
@ -774,6 +774,13 @@ You can also refer to the reverse direction of a
|
||||||
is defined. Instead of specifying the field name, use the :attr:`related_name
|
is defined. Instead of specifying the field name, use the :attr:`related_name
|
||||||
<django.db.models.ForeignKey.related_name>` for the field on the related object.
|
<django.db.models.ForeignKey.related_name>` for the field on the related object.
|
||||||
|
|
||||||
|
.. versionadded:: 1.6
|
||||||
|
|
||||||
|
If you need to clear the list of related fields added by past calls of
|
||||||
|
``select_related`` on a ``QuerySet``, you can pass ``None`` as a parameter::
|
||||||
|
|
||||||
|
>>> without_relations = queryset.select_related(None)
|
||||||
|
|
||||||
.. deprecated:: 1.5
|
.. deprecated:: 1.5
|
||||||
The ``depth`` parameter to ``select_related()`` has been deprecated. You
|
The ``depth`` parameter to ``select_related()`` has been deprecated. You
|
||||||
should replace it with the use of the ``(*fields)`` listing specific
|
should replace it with the use of the ``(*fields)`` listing specific
|
||||||
|
|
|
@ -287,6 +287,11 @@ Minor features
|
||||||
helper for testing formset errors:
|
helper for testing formset errors:
|
||||||
:meth:`~django.test.SimpleTestCase.assertFormsetError`.
|
:meth:`~django.test.SimpleTestCase.assertFormsetError`.
|
||||||
|
|
||||||
|
* The list of related fields added to a
|
||||||
|
:class:`~django.db.models.query.QuerySet` by
|
||||||
|
:meth:`~django.db.models.query.QuerySet.select_related` can be cleared using
|
||||||
|
``select_related(None)``.
|
||||||
|
|
||||||
Backwards incompatible changes in 1.6
|
Backwards incompatible changes in 1.6
|
||||||
=====================================
|
=====================================
|
||||||
|
|
||||||
|
|
|
@ -172,3 +172,7 @@ class SelectRelatedTests(TestCase):
|
||||||
Species.objects.select_related,
|
Species.objects.select_related,
|
||||||
'genus__family__order', depth=4
|
'genus__family__order', depth=4
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def test_none_clears_list(self):
|
||||||
|
queryset = Species.objects.select_related('genus').select_related(None)
|
||||||
|
self.assertEqual(queryset.query.select_related, False)
|
||||||
|
|
Loading…
Reference in New Issue