From 50dbda9a3eb83c9e2e79b7d56305a1f0700f8478 Mon Sep 17 00:00:00 2001 From: Malcolm Tredinnick Date: Sun, 12 Apr 2009 00:13:03 +0000 Subject: [PATCH] Added a test from Jamie Gennis to ensure #9848 doesn't reappear. The bug itself was fixed at some point in the past months (there have been a few improvements to update() recently). Fixed #9848. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10528 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- tests/regressiontests/queries/models.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/regressiontests/queries/models.py b/tests/regressiontests/queries/models.py index 88d08b0bd1b..b5fa377496c 100644 --- a/tests/regressiontests/queries/models.py +++ b/tests/regressiontests/queries/models.py @@ -1126,6 +1126,23 @@ Bug #10432 (see also the Python 2.4+ tests for this, below). Testing an empty >>> list(Note.objects.filter(pk__in=g())) == [n_obj] True +Make sure that updates which only filter on sub-tables don't inadvertently +update the wrong records (bug #9848). + +# Make sure that the IDs from different tables don't happen to match. +>>> Ranking.objects.filter(author__name='a1') +[] +>>> Ranking.objects.filter(author__name='a1').update(rank='4') +1 +>>> r = Ranking.objects.filter(author__name='a1')[0] +>>> r.id != r.author.id +True +>>> r.rank +4 +>>> r.rank = 3 +>>> r.save() +>>> Ranking.objects.all() +[, , ] """} # In Python 2.3 and the Python 2.6 beta releases, exceptions raised in __len__