p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Documentation fixes for the select_for_update change. 

Refs #22343; thanks Tim Graham for the fixes.
This commit is contained in:
Shai Berger 2014-04-10 03:40:33 +03:00
parent f095356ba2
commit 59b1d3098f
3 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/ref/models/querysets.txt
View File

@ -1365,7 +1365,7 @@ do not support ``nowait``, such as MySQL, will cause a
:exc:`~django.db.DatabaseError` to be raised. This is in order to prevent code :exc:`~django.db.DatabaseError` to be raised. This is in order to prevent code
unexpectedly blocking. unexpectedly blocking.
Executing a queryset with ``select_for_update`` in autocommit mode is Evaluating a queryset with ``select_for_update`` in autocommit mode is
an error because the rows are then not locked. If allowed, this would an error because the rows are then not locked. If allowed, this would
facilitate data corruption, and could easily be caused by calling, facilitate data corruption, and could easily be caused by calling,
outside of any transaction, code that expects to be run in one. outside of any transaction, code that expects to be run in one.

14
docs/releases/1.6.3.txt
View File

@ -17,19 +17,19 @@ executed in autocommit mode, outside of a transaction. Before Django
lock records until the next write operation. Django 1.6 introduced lock records until the next write operation. Django 1.6 introduced
database-level autocommit; since then, execution in such a context database-level autocommit; since then, execution in such a context
voids the effect of ``select_for_update()``. It is, therefore, assumed voids the effect of ``select_for_update()``. It is, therefore, assumed
now to be an error, and raises an exception. now to be an error and raises an exception.
This change was made because such errors can be caused by including an
app which expects global transactions (e.g. :setting:`ATOMIC_REQUESTS
<DATABASE-ATOMIC_REQUESTS>` set to ``True``), or Django's old autocommit
behavior, in a project which runs without them; and further, such
errors may manifest as data-corruption bugs.
This change may cause test failures if you use ``select_for_update()`` This change may cause test failures if you use ``select_for_update()``
in a test class which is a subclass of in a test class which is a subclass of
:class:`~django.test.TransactionTestCase` rather than :class:`~django.test.TransactionTestCase` rather than
:class:`~django.test.TestCase`. :class:`~django.test.TestCase`.
This change was made because such errors can be caused by including an
app which expects global transactions (e.g. :setting:`ATOMIC_REQUESTS
<DATABASE-ATOMIC_REQUESTS>` set to True), or Django's old autocommit
behavior, in a project which runs without them; and further, such
errors may manifest as data-corruption bugs.
Other bugfixes and changes Other bugfixes and changes
========================== ==========================

17
docs/releases/1.7.txt
View File

@ -1096,21 +1096,20 @@ executed in autocommit mode, outside of a transaction. Before Django
lock records until the next write operation. Django 1.6 introduced lock records until the next write operation. Django 1.6 introduced
database-level autocommit; since then, execution in such a context database-level autocommit; since then, execution in such a context
voids the effect of ``select_for_update()``. It is, therefore, assumed voids the effect of ``select_for_update()``. It is, therefore, assumed
now to be an error, and raises an exception. now to be an error and raises an exception.
This change was made because such errors can be caused by including an
app which expects global transactions (e.g. :setting:`ATOMIC_REQUESTS
<DATABASE-ATOMIC_REQUESTS>` set to ``True``), or Django's old autocommit
behavior, in a project which runs without them; and further, such
errors may manifest as data-corruption bugs. It was also made in
Django 1.6.3.
This change may cause test failures if you use ``select_for_update()`` This change may cause test failures if you use ``select_for_update()``
in a test class which is a subclass of in a test class which is a subclass of
:class:`~django.test.TransactionTestCase` rather than :class:`~django.test.TransactionTestCase` rather than
:class:`~django.test.TestCase`. :class:`~django.test.TestCase`.
This change was made because such errors can be caused by including an
app which expects global transactions (e.g. :setting:`ATOMIC_REQUESTS
<DATABASE-ATOMIC_REQUESTS>` set to True), or Django's old autocommit
behavior, in a project which runs without them; and further, such
errors may manifest as data-corruption bugs.
This was also fixed in Django 1.6.3.
Miscellaneous Miscellaneous
~~~~~~~~~~~~~ ~~~~~~~~~~~~~