From 62347208bb0cef6990699d7373fa06e2e12ead07 Mon Sep 17 00:00:00 2001
From: Tim Graham <timograham@gmail.com>
Date: Thu, 20 Aug 2015 12:46:14 -0400
Subject: [PATCH] [1.8.x] Fixed #24525 -- Fixed AssertionError in some complex
 queries.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Thanks Anssi Kääriäinen for providing the solution.

Backport of 2dc9ec5616a942de3a0886a707f93988f56dd594 from master
---
 django/db/models/sql/query.py |  3 ++-
 docs/releases/1.8.5.txt       |  2 ++
 tests/queries/models.py       |  1 +
 tests/queries/tests.py        | 24 ++++++++++++++++++++++--
 4 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py
index 7a0fe8f892b..40b6cc57a15 100644
--- a/django/db/models/sql/query.py
+++ b/django/db/models/sql/query.py
@@ -539,7 +539,8 @@ class Query(object):
             # distinct joins for the same connection in rhs query, then the
             # combined query must have two joins, too.
             reuse.discard(new_alias)
-            change_map[alias] = new_alias
+            if alias != new_alias:
+                change_map[alias] = new_alias
             if not rhs.alias_refcount[alias]:
                 # The alias was unused in the rhs query. Unref it so that it
                 # will be unused in the new query, too. We have to add and
diff --git a/docs/releases/1.8.5.txt b/docs/releases/1.8.5.txt
index ac1735bb16a..66cee6e25c4 100644
--- a/docs/releases/1.8.5.txt
+++ b/docs/releases/1.8.5.txt
@@ -14,6 +14,8 @@ Bugfixes
 * Fixed ``AssertionError`` in some delete queries with a model containing a
   field that is both a foreign and primary key (:ticket:`24951`).
 
+* Fixed ``AssertionError`` in some complex queries (:ticket:`24525`).
+
 * Fixed a migrations crash with ``GenericForeignKey`` (:ticket:`25040`).
 
 * Made ``translation.override()`` clear the overridden language when a
diff --git a/tests/queries/models.py b/tests/queries/models.py
index 5d63ae9ea8d..81f3b3f390b 100644
--- a/tests/queries/models.py
+++ b/tests/queries/models.py
@@ -45,6 +45,7 @@ class Tag(models.Model):
 class Note(models.Model):
     note = models.CharField(max_length=100)
     misc = models.CharField(max_length=10)
+    tag = models.ForeignKey(Tag, blank=True, null=True)
 
     class Meta:
         ordering = ['note']
diff --git a/tests/queries/tests.py b/tests/queries/tests.py
index 6ba799d2442..84871e8dfeb 100644
--- a/tests/queries/tests.py
+++ b/tests/queries/tests.py
@@ -1177,6 +1177,15 @@ class Queries1Tests(BaseQuerysetTest):
             self.assertEqual(len(w), 1)
             self.assertTrue(issubclass(w[0].category, RemovedInDjango19Warning))
 
+    def test_lookup_constraint_fielderror(self):
+        msg = (
+            "Cannot resolve keyword 'unknown_field' into field. Choices are: "
+            "annotation, category, category_id, children, id, item, "
+            "managedmodel, name, note, parent, parent_id"
+        )
+        with self.assertRaisesMessage(FieldError, msg):
+            Tag.objects.filter(unknown_field__name='generic')
+
 
 class Queries2Tests(TestCase):
     @classmethod
@@ -1319,8 +1328,8 @@ class Queries4Tests(BaseQuerysetTest):
         generic = NamedCategory.objects.create(name="Generic")
         cls.t1 = Tag.objects.create(name='t1', category=generic)
 
-        n1 = Note.objects.create(note='n1', misc='foo', id=1)
-        n2 = Note.objects.create(note='n2', misc='bar', id=2)
+        n1 = Note.objects.create(note='n1', misc='foo')
+        n2 = Note.objects.create(note='n2', misc='bar')
 
         e1 = ExtraInfo.objects.create(info='e1', note=n1)
         e2 = ExtraInfo.objects.create(info='e2', note=n2)
@@ -1335,6 +1344,17 @@ class Queries4Tests(BaseQuerysetTest):
         Item.objects.create(name='i1', created=datetime.datetime.now(), note=n1, creator=cls.a1)
         Item.objects.create(name='i2', created=datetime.datetime.now(), note=n1, creator=cls.a3)
 
+    def test_ticket24525(self):
+        tag = Tag.objects.create()
+        anth100 = tag.note_set.create(note='ANTH', misc='100')
+        math101 = tag.note_set.create(note='MATH', misc='101')
+        s1 = tag.annotation_set.create(name='1')
+        s2 = tag.annotation_set.create(name='2')
+        s1.notes = [math101, anth100]
+        s2.notes = [math101]
+        result = math101.annotation_set.all() & tag.annotation_set.exclude(notes__in=[anth100])
+        self.assertEqual(list(result), [s2])
+
     def test_ticket11811(self):
         unsaved_category = NamedCategory(name="Other")
         with six.assertRaisesRegex(self, ValueError,