From 6a708cd654fe63278ea8a14b3e44da847c62ebf4 Mon Sep 17 00:00:00 2001 From: Florian Apolloner Date: Tue, 17 Sep 2013 22:33:11 +0200 Subject: [PATCH] [1.5.x] Silenced last sporadic failure on 1.5. This commit is a last resort; technically the test is correct but our testsuite has some threading issues when LiveServer is used. Since this will never get fixed in 1.5 and apperently doesn't get triggered on 1.6 we just make sure the test doesn't error out. I am not 100% sure why this actually fixes the issue, but this is still better than having failing builds wheneever we do a security release for 1.5. (Tested on jenkins itself, should work (tm)). --- tests/regressiontests/forms/tests/widgets.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/regressiontests/forms/tests/widgets.py b/tests/regressiontests/forms/tests/widgets.py index 599ba534cf5..640e9221b22 100644 --- a/tests/regressiontests/forms/tests/widgets.py +++ b/tests/regressiontests/forms/tests/widgets.py @@ -1116,6 +1116,12 @@ class LiveWidgetTests(AdminSeleniumWebDriverTestCase): article = Article.objects.get(pk=article.pk) # Should be "\nTst\n" after #19251 is fixed self.assertEqual(article.content, "\r\nTst\r\n") + # So now it's becoming obscure; we do have threading issues here, so this + # test fails sometimes for sqlite, I could only ever witness it on jenkins. + # As long as 1.5 is supported we manually "fix" this test by quitting + # selenium. No idea why closing the browser window isn't enough, but hey… + self.selenium.quit() + delattr(self.__class__, 'selenium') @python_2_unicode_compatible