p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Refs #31051 -- Optimized serialize_db_to_string() by avoiding creation of models list.

This commit is contained in:
Matthijs Kooijman 2020-04-02 11:38:23 +02:00 committed by Mariusz Felisiak
parent 289d0ec6fd
commit 75520e1767
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
django/db/backends/base/creation.py
View File

@ -97,25 +97,25 @@ class BaseDatabaseCreation:
Designed only for test runner usage; will not handle large Designed only for test runner usage; will not handle large
amounts of data. amounts of data.
""" """
# Build list of all models to serialize. # Iteratively return every object for all models to serialize.
from django.db.migrations.loader import MigrationLoader
loader = MigrationLoader(self.connection)
model_list = []
for app_config in apps.get_app_configs():
if (
app_config.models_module is not None and
app_config.label in loader.migrated_apps and
app_config.name not in settings.TEST_NON_SERIALIZED_APPS
):
model_list.extend(app_config.get_models())
# Make a function to iteratively return every object
def get_objects(): def get_objects():
for model in model_list: from django.db.migrations.loader import MigrationLoader
if (model._meta.can_migrate(self.connection) and loader = MigrationLoader(self.connection)
router.allow_migrate_model(self.connection.alias, model)): for app_config in apps.get_app_configs():
queryset = model._default_manager.using(self.connection.alias).order_by(model._meta.pk.name) if (
yield from queryset.iterator() app_config.models_module is not None and
app_config.label in loader.migrated_apps and
app_config.name not in settings.TEST_NON_SERIALIZED_APPS
):
for model in app_config.get_models():
if (
model._meta.can_migrate(self.connection) and
router.allow_migrate_model(self.connection.alias, model)
):
queryset = model._default_manager.using(
self.connection.alias,
).order_by(model._meta.pk.name)
yield from queryset.iterator()
# Serialize to a string # Serialize to a string
out = StringIO() out = StringIO()
serializers.serialize("json", get_objects(), indent=None, stream=out) serializers.serialize("json", get_objects(), indent=None, stream=out)