p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Refs #26447 -- Removed outdated ETag comment in CommonMiddleware. 

Follow up to 48d57788ee.
This commit is contained in:
Tim Graham 2017-11-11 20:45:17 -05:00
parent 1907fc9b12
commit 8f8a4d10d3
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/middleware/common.py
View File

@ -94,8 +94,6 @@ class CommonMiddleware(MiddlewareMixin):
def process_response(self, request, response): def process_response(self, request, response):
""" """
Calculate the ETag, if needed.
When the status code of the response is 404, it may redirect to a path When the status code of the response is 404, it may redirect to a path
with an appended slash if should_redirect_with_slash() returns True. with an appended slash if should_redirect_with_slash() returns True.
""" """

13
docs/ref/middleware.txt
View File

@ -456,6 +456,14 @@ Here are some hints about the ordering of various Django middleware classes:
After ``UpdateCacheMiddleware``: Modifies ``Vary`` header. After ``UpdateCacheMiddleware``: Modifies ``Vary`` header.
#. :class:`~django.middleware.http.ConditionalGetMiddleware`
Before any middleware that may change the response (it sets the ``ETag``
header).
After ``GZipMiddleware`` so it won't calculate an ``ETag`` header on gzipped
contents.
#. :class:`~django.middleware.locale.LocaleMiddleware` #. :class:`~django.middleware.locale.LocaleMiddleware`
One of the topmost, after ``SessionMiddleware`` (uses session data) and One of the topmost, after ``SessionMiddleware`` (uses session data) and
@ -463,11 +471,6 @@ Here are some hints about the ordering of various Django middleware classes:
#. :class:`~django.middleware.common.CommonMiddleware` #. :class:`~django.middleware.common.CommonMiddleware`
Before any middleware that may change the response (it calculates ``ETags``).
After ``GZipMiddleware`` so it won't calculate an ``ETag`` header on gzipped
contents.
Close to the top: it redirects when :setting:`APPEND_SLASH` or Close to the top: it redirects when :setting:`APPEND_SLASH` or
:setting:`PREPEND_WWW` are set to ``True``. :setting:`PREPEND_WWW` are set to ``True``.