diff --git a/AUTHORS b/AUTHORS index 0ddbc36804c..0be13d0c9fa 100644 --- a/AUTHORS +++ b/AUTHORS @@ -561,6 +561,7 @@ answer newbie questions, and generally made Django that much better: Peter Sheats Pete Shinners Leo Shklovskii + Zbigniew Siciarz jason.sidabras@gmail.com MikoĊ‚aj Siedlarek Karol Sikora diff --git a/docs/ref/applications.txt b/docs/ref/applications.txt index be86f42305a..2a5128ebb8b 100644 --- a/docs/ref/applications.txt +++ b/docs/ref/applications.txt @@ -221,6 +221,19 @@ Methods def ready(self): MyModel = self.get_model('MyModel') + .. warning:: + + Although you can access model classes as described above, avoid + interacting with the database in your :meth:`ready()` implementation. + This includes model methods that execute queries + (:meth:`~django.db.models.Model.save()`, + :meth:`~django.db.models.Model.delete()`, manager methods etc.), and + also raw SQL queries via ``django.db.connection``. Your + :meth:`ready()` method will run during startup of every management + command. For example, even though the test database configuration is + separate from the production settings, ``manage.py test`` would still + execute some queries against your **production** database! + .. _namespace package: Namespace packages as apps (Python 3.3+) diff --git a/docs/topics/testing/overview.txt b/docs/topics/testing/overview.txt index 078c2a1da93..7a2d15edcee 100644 --- a/docs/topics/testing/overview.txt +++ b/docs/topics/testing/overview.txt @@ -196,6 +196,11 @@ advanced settings. your tests. *It is a bad idea to have such import-time database queries in your code* anyway - rewrite your code so that it doesn't do this. + .. versionadded:: 1.7 + + This also applies to customized implementations of + :meth:`~django.apps.AppConfig.ready()`. + .. seealso:: The :ref:`advanced multi-db testing topics `.