mirror of https://github.com/django/django.git
[1.8.x] Fixed urlize regression with entities in query strings
Refs #22267.
Thanks Shai Berger for spotting the issue and Tim Graham for the
initial patch.
Backport of ec808e807
from master.
This commit is contained in:
parent
823f8cdbc9
commit
ac07890f95
|
@ -290,17 +290,17 @@ def urlize(text, trim_url_limit=None, nofollow=False, autoescape=False):
|
|||
smart_urlquote. For example:
|
||||
http://example.com?x=1&y=<2> => http://example.com?x=1&y=<2>
|
||||
"""
|
||||
if not safe_input:
|
||||
return text, text, trail
|
||||
unescaped = (text + trail).replace(
|
||||
'&', '&').replace('<', '<').replace(
|
||||
'>', '>').replace('"', '"').replace(''', "'")
|
||||
# ';' in trail can be either trailing punctuation or end-of-entity marker
|
||||
if unescaped.endswith(';'):
|
||||
return text, unescaped[:-1], trail
|
||||
else:
|
||||
if trail and unescaped.endswith(trail):
|
||||
# Remove trail for unescaped if it was not consumed by unescape
|
||||
unescaped = unescaped[:-len(trail)]
|
||||
elif trail == ';':
|
||||
# Trail was consumed by unescape (as end-of-entity marker), move it to text
|
||||
text += trail
|
||||
return text, unescaped, ''
|
||||
trail = ''
|
||||
return text, unescaped, trail
|
||||
|
||||
words = word_split_re.split(force_text(text))
|
||||
for i, word in enumerate(words):
|
||||
|
|
|
@ -73,6 +73,14 @@ class UrlizeTests(SimpleTestCase):
|
|||
'Email me at <<a href="mailto:me@example.com">me@example.com</a>>',
|
||||
)
|
||||
|
||||
@setup({'urlize09': '{% autoescape off %}{{ a|urlize }}{% endautoescape %}'})
|
||||
def test_urlize09(self):
|
||||
output = self.engine.render_to_string('urlize09', {'a': "http://example.com/?x=&y=<2>"})
|
||||
self.assertEqual(
|
||||
output,
|
||||
'<a href="http://example.com/?x=&y=%3C2%3E" rel="nofollow">http://example.com/?x=&y=<2></a>',
|
||||
)
|
||||
|
||||
|
||||
class FunctionTests(SimpleTestCase):
|
||||
|
||||
|
|
Loading…
Reference in New Issue