p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed #27172 -- Closed database cursor explicitly in two doc examples

This commit is contained in:
Chris Jerdonek 2016-09-07 03:14:29 -07:00 committed by Claude Paroz
parent 6a2af01452
commit ccf7adb064
2 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/topics/db/managers.txt
View File

@ -67,7 +67,7 @@ returns a list of all ``OpinionPoll`` objects, each with an extra
class PollManager(models.Manager): class PollManager(models.Manager):
def with_counts(self): def with_counts(self):
from django.db import connection from django.db import connection
cursor = connection.cursor() with connection.cursor() as cursor:
cursor.execute(""" cursor.execute("""
SELECT p.id, p.question, p.poll_date, COUNT(*) SELECT p.id, p.question, p.poll_date, COUNT(*)
FROM polls_opinionpoll p, polls_response r FROM polls_opinionpoll p, polls_response r

4
docs/topics/db/sql.txt
View File

@ -250,10 +250,8 @@ For example::
from django.db import connection from django.db import connection
def my_custom_sql(self): def my_custom_sql(self):
cursor = connection.cursor() with connection.cursor() as cursor:
cursor.execute("UPDATE bar SET foo = 1 WHERE baz = %s", [self.baz]) cursor.execute("UPDATE bar SET foo = 1 WHERE baz = %s", [self.baz])
cursor.execute("SELECT foo FROM bar WHERE baz = %s", [self.baz]) cursor.execute("SELECT foo FROM bar WHERE baz = %s", [self.baz])
row = cursor.fetchone() row = cursor.fetchone()