From cf7a2a000e16b86dd721a021f1a2001529d8d707 Mon Sep 17 00:00:00 2001 From: Stratos Moros Date: Tue, 18 Nov 2014 14:25:03 +0200 Subject: [PATCH] Fixed #22248 -- Made RenameModel reversible --- django/db/migrations/operations/models.py | 2 -- docs/releases/1.7.2.txt | 3 +++ tests/migrations/test_operations.py | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/django/db/migrations/operations/models.py b/django/db/migrations/operations/models.py index 5b052b4734b..e195d9d841f 100644 --- a/django/db/migrations/operations/models.py +++ b/django/db/migrations/operations/models.py @@ -106,8 +106,6 @@ class RenameModel(Operation): Renames a model. """ - reversible = False - def __init__(self, old_name, new_name): self.old_name = old_name self.new_name = new_name diff --git a/docs/releases/1.7.2.txt b/docs/releases/1.7.2.txt index 0fe97a32256..4955f30946a 100644 --- a/docs/releases/1.7.2.txt +++ b/docs/releases/1.7.2.txt @@ -65,3 +65,6 @@ Bugfixes * Fixed :djadmin:`squashmigrations` to respect the ``--no-optimize`` parameter (:ticket:`23799`). + +* Made :class:`~django.db.migrations.operations.RenameModel` reversible + (:ticket:`22248`) diff --git a/tests/migrations/test_operations.py b/tests/migrations/test_operations.py index 09dc25fd26c..952ab245239 100644 --- a/tests/migrations/test_operations.py +++ b/tests/migrations/test_operations.py @@ -434,8 +434,7 @@ class OperationTests(OperationTestBase): self.assertFKNotExists("test_rnmo_rider", ["pony_id"], ("test_rnmo_pony", "id")) self.assertFKExists("test_rnmo_rider", ["pony_id"], ("test_rnmo_horse", "id")) # And test reversal - with connection.schema_editor() as editor: - operation.database_backwards("test_rnmo", editor, new_state, project_state) + self.unapply_operations("test_rnmo", project_state, [operation]) self.assertTableExists("test_rnmo_pony") self.assertTableNotExists("test_rnmo_horse") if connection.features.supports_foreign_keys: