p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[2.2.x] Fixed #30648 -- Removed unnecessary overriding get_context_data() from mixins with CBVs docs. 

Backport of 7f612eda80 from master
This commit is contained in:
Davit Gachechiladze 2019-07-18 17:57:25 +04:00 committed by Mariusz Felisiak
parent 0088e59292
commit de2635fb4e
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
docs/topics/class-based-views/mixins.txt
View File

@ -461,11 +461,6 @@ Our new ``AuthorDetail`` looks like this::
def get_success_url(self): def get_success_url(self):
return reverse('author-detail', kwargs={'pk': self.object.pk}) return reverse('author-detail', kwargs={'pk': self.object.pk})
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
context['form'] = self.get_form()
return context
def post(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
if not request.user.is_authenticated: if not request.user.is_authenticated:
return HttpResponseForbidden() return HttpResponseForbidden()
@ -483,9 +478,7 @@ Our new ``AuthorDetail`` looks like this::
``get_success_url()`` is just providing somewhere to redirect to, ``get_success_url()`` is just providing somewhere to redirect to,
which gets used in the default implementation of which gets used in the default implementation of
``form_valid()``. We have to provide our own ``post()`` as ``form_valid()``. We have to provide our own ``post()`` as noted earlier.
noted earlier, and override ``get_context_data()`` to make the
:class:`~django.forms.Form` available in the context data.
A better solution A better solution
----------------- -----------------