p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Don't escape object ids when passing to the contenttypes.shortcut view. 

This commit also changes the string pk to string_pk instead of id, to test
if the admin uses .pk throughout the codebase.
This commit is contained in:
Florian Apolloner 2012-06-07 17:34:25 +02:00
parent 840ffd80ba
commit e1643e3535
4 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/contrib/admin/templates/admin/change_form.html
View File

@ -31,7 +31,7 @@
<ul class="object-tools"> <ul class="object-tools">
{% block object-tools-items %} {% block object-tools-items %}
<li><a href="history/" class="historylink">{% trans "History" %}</a></li> <li><a href="history/" class="historylink">{% trans "History" %}</a></li>
{% if has_absolute_url %}<li><a href="../../../r/{{ content_type_id }}/{{ object_id }}/" class="viewsitelink">{% trans "View on site" %}</a></li>{% endif%} {% if has_absolute_url %}<li><a href="../../../r/{{ content_type_id }}/{{ original.pk }}/" class="viewsitelink">{% trans "View on site" %}</a></li>{% endif%}
{% endblock %} {% endblock %}
</ul> </ul>
{% endif %}{% endif %} {% endif %}{% endif %}

2
tests/regressiontests/admin_views/fixtures/string-primary-key.xml
View File

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<django-objects version="1.0"> <django-objects version="1.0">
<object pk="1" model="admin_views.modelwithstringprimarykey"> <object pk="1" model="admin_views.modelwithstringprimarykey">
<field type="CharField" name="id"><![CDATA[abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ 1234567890 -_.!~*'() ;/?:@&=+$, <>#%" {}|\^[]`]]></field> <field type="CharField" name="string_pk"><![CDATA[abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ 1234567890 -_.!~*'() ;/?:@&=+$, <>#%" {}|\^[]`]]></field>
</object> </object>
</django-objects> </django-objects>

7
tests/regressiontests/admin_views/models.py
View File

@ -93,10 +93,13 @@ class CustomArticle(models.Model):
class ModelWithStringPrimaryKey(models.Model): class ModelWithStringPrimaryKey(models.Model):
id = models.CharField(max_length=255, primary_key=True) string_pk = models.CharField(max_length=255, primary_key=True)
def __unicode__(self): def __unicode__(self):
return self.id return self.string_pk
def get_absolute_url(self):
return u'/dummy/%s/' % self.string_pk
class Color(models.Model): class Color(models.Model):

14
tests/regressiontests/admin_views/tests.py
View File

@ -1403,7 +1403,7 @@ class AdminViewStringPrimaryKeyTest(TestCase):
def test_url_conflicts_with_add(self): def test_url_conflicts_with_add(self):
"A model with a primary key that ends with add should be visible" "A model with a primary key that ends with add should be visible"
add_model = ModelWithStringPrimaryKey(id="i have something to add") add_model = ModelWithStringPrimaryKey(pk="i have something to add")
add_model.save() add_model.save()
response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(add_model.pk)) response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(add_model.pk))
should_contain = """<h1>Change model with string primary key</h1>""" should_contain = """<h1>Change model with string primary key</h1>"""
@ -1411,7 +1411,7 @@ class AdminViewStringPrimaryKeyTest(TestCase):
def test_url_conflicts_with_delete(self): def test_url_conflicts_with_delete(self):
"A model with a primary key that ends with delete should be visible" "A model with a primary key that ends with delete should be visible"
delete_model = ModelWithStringPrimaryKey(id="delete") delete_model = ModelWithStringPrimaryKey(pk="delete")
delete_model.save() delete_model.save()
response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(delete_model.pk)) response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(delete_model.pk))
should_contain = """<h1>Change model with string primary key</h1>""" should_contain = """<h1>Change model with string primary key</h1>"""
@ -1419,12 +1419,20 @@ class AdminViewStringPrimaryKeyTest(TestCase):
def test_url_conflicts_with_history(self): def test_url_conflicts_with_history(self):
"A model with a primary key that ends with history should be visible" "A model with a primary key that ends with history should be visible"
history_model = ModelWithStringPrimaryKey(id="history") history_model = ModelWithStringPrimaryKey(pk="history")
history_model.save() history_model.save()
response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(history_model.pk)) response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(history_model.pk))
should_contain = """<h1>Change model with string primary key</h1>""" should_contain = """<h1>Change model with string primary key</h1>"""
self.assertContains(response, should_contain) self.assertContains(response, should_contain)
def test_shortcut_view_with_escaping(self):
"'View on site should' work properly with char fields"
model = ModelWithStringPrimaryKey(pk='abc_123')
model.save()
response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(model.pk))
should_contain = '/%s/" class="viewsitelink">' % model.pk
self.assertContains(response, should_contain)
@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',)) @override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',))
class SecureViewTests(TestCase): class SecureViewTests(TestCase):