From f5ea9aa2f32c7ca9a1fdf793580fddba3daae1b9 Mon Sep 17 00:00:00 2001 From: Dan Strokirk Date: Thu, 24 Jun 2021 17:15:25 +0200 Subject: [PATCH] Fixed #32807 -- Fixed JSONField crash when redisplaying None values. Thanks to Alex Hill for the initial patch. --- django/forms/fields.py | 2 ++ tests/forms_tests/field_tests/test_jsonfield.py | 15 +++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/django/forms/fields.py b/django/forms/fields.py index 57886656de4..f1275aa3874 100644 --- a/django/forms/fields.py +++ b/django/forms/fields.py @@ -1251,6 +1251,8 @@ class JSONField(CharField): def bound_data(self, data, initial): if self.disabled: return initial + if data is None: + return None try: return json.loads(data, cls=self.decoder) except json.JSONDecodeError: diff --git a/tests/forms_tests/field_tests/test_jsonfield.py b/tests/forms_tests/field_tests/test_jsonfield.py index 46ef0005f63..b4f3e74f6a4 100644 --- a/tests/forms_tests/field_tests/test_jsonfield.py +++ b/tests/forms_tests/field_tests/test_jsonfield.py @@ -97,6 +97,21 @@ class JSONFieldTest(SimpleTestCase): form = JSONForm({'json_field': '["bar"]'}, initial={'json_field': ['foo']}) self.assertIn('["foo"]', form.as_p()) + def test_redisplay_none_input(self): + class JSONForm(Form): + json_field = JSONField(required=True) + + tests = [ + {}, + {'json_field': None}, + ] + for data in tests: + with self.subTest(data=data): + form = JSONForm(data) + self.assertEqual(form['json_field'].value(), 'null') + self.assertIn('null', form.as_p()) + self.assertEqual(form.errors['json_field'], ['This field is required.']) + def test_redisplay_wrong_input(self): """ Displaying a bound form (typically due to invalid input). The form