p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Removed unused BaseReloader.watch_file(). 

Unused since its introduction in c8720e7696.
This commit is contained in:
Mariusz Felisiak 2019-07-24 13:32:02 +02:00 committed by GitHub
parent d89053585e
commit fed5e19369
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
django/utils/autoreload.py
View File

@ -245,13 +245,6 @@ class BaseReloader:
logger.debug('Watching dir %s with glob %s.', path, glob) logger.debug('Watching dir %s with glob %s.', path, glob)
self.directory_globs[path].add(glob) self.directory_globs[path].add(glob)
def watch_file(self, path):
path = Path(path)
if not path.is_absolute():
raise ValueError('%s must be absolute.' % path)
logger.debug('Watching file %s.', path)
self.extra_files.add(path)
def watched_files(self, include_globs=True): def watched_files(self, include_globs=True):
""" """
Yield all files that need to be watched, including module files and Yield all files that need to be watched, including module files and

18
tests/utils_tests/test_autoreload.py
View File

@ -416,15 +416,6 @@ class ReloaderTests(SimpleTestCase):
class IntegrationTests: class IntegrationTests:
@mock.patch('django.utils.autoreload.BaseReloader.notify_file_changed')
@mock.patch('django.utils.autoreload.iter_all_python_module_files', return_value=frozenset())
def test_file(self, mocked_modules, notify_mock):
self.reloader.watch_file(self.existing_file)
with self.tick_twice():
self.increment_mtime(self.existing_file)
self.assertEqual(notify_mock.call_count, 1)
self.assertCountEqual(notify_mock.call_args[0], [self.existing_file])
@mock.patch('django.utils.autoreload.BaseReloader.notify_file_changed') @mock.patch('django.utils.autoreload.BaseReloader.notify_file_changed')
@mock.patch('django.utils.autoreload.iter_all_python_module_files', return_value=frozenset()) @mock.patch('django.utils.autoreload.iter_all_python_module_files', return_value=frozenset())
def test_glob(self, mocked_modules, notify_mock): def test_glob(self, mocked_modules, notify_mock):
@ -508,15 +499,6 @@ class IntegrationTests:
class BaseReloaderTests(ReloaderTests): class BaseReloaderTests(ReloaderTests):
RELOADER_CLS = autoreload.BaseReloader RELOADER_CLS = autoreload.BaseReloader
def test_watch_without_absolute(self):
with self.assertRaisesMessage(ValueError, 'test.py must be absolute.'):
self.reloader.watch_file('test.py')
def test_watch_with_single_file(self):
self.reloader.watch_file(self.existing_file)
watched_files = list(self.reloader.watched_files())
self.assertIn(self.existing_file, watched_files)
def test_watch_with_glob(self): def test_watch_with_glob(self):
self.reloader.watch_dir(self.tempdir, '*.py') self.reloader.watch_dir(self.tempdir, '*.py')
watched_files = list(self.reloader.watched_files()) watched_files = list(self.reloader.watched_files())