9fb0f5dddc
Fixed #22510 -- Harden field removal to only None.
...
Refs #8620 .
If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.
Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.
Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
2014-05-24 13:10:50 +01:00
4ef10f245a
Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin.
...
Thanks Stephen Burrows for work on the patch as well.
Forwardport of 2914f66983
2014-05-15 07:25:35 -04:00
5eb81ce445
Fixed #22533 -- Added label_suffix parameter to form fields.
...
Fields can now receive the `label_suffix` attribute, which will override
a form's `label_suffix`.
This enhances the possibility to customize form's `label_suffix`, allowing
to use such customizations while using shortcuts such as
`{{ form.as_p }}`.
Note that the field's own customization can be overridden at runtime by
using the `label_prefix` parameter to `BoundField.label_tag()`.
Refs #18134 .
2014-05-13 09:09:33 -04:00
66ec9ee441
Fixed #22378 -- Updated \d to [0-9]+ in urlpatterns of docs and tests.
...
Thanks tomwys for the suggestion.
2014-04-16 20:36:29 -04:00
d2f4553d70
Fixed #22216 -- Added Form.non_field_errors to form API doc.
2014-04-05 18:16:01 -04:00
9494f29d4f
Fixed case in form widgets docs
2014-04-05 16:26:11 +02:00
51c8045145
Removed versionadded/changed annotations for 1.6.
2014-03-24 11:42:56 -04:00
416a858023
Fixed #17922 -- Added required_css_class to form label.
...
Thanks hanson2010 for the suggestion.
2014-03-24 08:11:54 -04:00
7ac8380799
Fixed #22318 -- Added Form.has_error() to easily check if a given error has happened.
2014-03-24 07:21:32 -04:00
3a97f992fb
Fixed #22313 -- Removed 'u' prefixes from documentation
2014-03-22 21:32:20 +01:00
e61d99d96d
Fixed #20684 -- Added support for HTML5 boolean attributes to form widgets.
2014-03-22 14:28:12 -04:00
ee4edb1eda
Made ModelForms raise ImproperlyConfigured if the list of fields is not specified.
...
Also applies to modelform(set)_factory and generic model views.
refs #19733 .
2014-03-22 07:56:48 -04:00
4965a77407
Removed PIL compatability layer per deprecation timeline.
...
refs #19934 .
2014-03-21 10:54:53 -04:00
ad43fdaa00
Fixed #21860 -- Added to_field_name to ModelChoiceField docs.
...
Thanks Keryn Knight for the suggestion.
2014-03-16 15:40:52 -04:00
7f2505ad9e
Fixed doc typos.
2014-02-28 11:44:03 -05:00
c23b3717be
Fixed #21962 -- Added escape_html flag to ErrorDict.as_json()
2014-02-28 07:05:55 -05:00
2e4200b5c7
Fixed #21654 -- Documented a use-case for Form.errors.as_data().
...
Thanks selwin for the suggestion.
2014-02-14 06:52:50 -05:00
8aa1efff6d
Fixed #21951 -- Updated docs to use __str__ for Python 3
...
Thanks Tim Graham for the report and recommendations
2014-02-13 07:12:40 -05:00
867f8fd6c7
Made some PEP8 fixes in docs/ref/forms/widgets.txt
...
Thanks Siecje.
2014-02-04 06:24:13 -05:00
05d36dc06e
Always use parentheses when documenting a method with no arguments.
2014-01-22 22:26:10 +01:00
79e1d6ebd7
Don't show `self` in the list of arguments of a method.
...
This is consistent with Python's official documentation
and it's a sphinx recommendation too[1].
[1] http://sphinx-doc.org/markup/desc.html#dir-method
Refs #21855 .
2014-01-22 22:17:32 +01:00
0179852d7f
Fixed #8898 -- Obsoleted SplitDateTimeWidget usage with DateTimeField
...
Thanks Tim Graham for the review.
2014-01-11 15:50:34 +01:00
ea83102d0f
Fixed #21319 -- Added documentation for the Form.fields attribute.
...
Thanks pydanny for the report. Also, added documentation about
base_fields attribute and its difference with fields attribute.
2014-01-02 19:43:26 -05:00
5d82658657
Fixed #21669 -- Typo in docs/ref/forms/fields.txt.
...
Thanks alex_koval for the report.
2013-12-25 06:02:43 -05:00
3ce9829b61
Fixed #17413 -- Serialization of form errors along with all metadata.
2013-12-16 16:33:28 -05:00
b72b85af15
Removed Form._errors from the docs in favor of the add_error API.
2013-11-30 01:00:53 +07:00
f563c339ca
Fixed #20867 -- Added the Form.add_error() method.
...
Refs #20199 #16986 .
Thanks @akaariai, @bmispelon, @mjtamlyn, @timgraham for the reviews.
2013-11-30 01:00:53 +07:00
a0f3eeccf3
Fixed #21397 -- Re-added flexibility to TypedChoiceField coercion
...
Thanks Elec for the report and Simon Charette for the review.
2013-11-18 18:24:56 +01:00
0048ed77c7
Fixed typos in previous commit ( 9aa6d4bdb6).
2013-11-12 20:42:44 +01:00
9aa6d4bdb6
Removed a mention of `Form._errors` from the documentation.
...
Also removed a sentence that was incorrect: raising a
`ValidationError` inside `Form.clean` doesn't clear the
`cleaned_data` attribute.
Thanks to loic84 and timograham for the review.
2013-11-12 20:27:21 +01:00
b16dd1fe01
Fixed #8620 -- Updated the Form metaclass to support excluding fields by shadowing them.
2013-10-14 22:42:33 +07:00
18ea1c473b
Forms docs: More emphasis in 'id' value customizability.
2013-10-12 13:29:11 -03:00
1a63092981
Fixed #20439 -- Started deprecation of IPAddressField
2013-09-28 10:55:32 +02:00
98e0453f00
Fixed #21120 -- Added more explicit text on using validators and link to writing validators.
...
Thanks nicolas at niconomicon.net for the suggestion.
2013-09-23 10:37:41 -04:00
df27803a55
Fixed #9532 -- Added min_num and validate_min on formsets.
...
Thanks gsf for the suggestion.
2013-09-19 13:11:49 -04:00
18ffdb1772
Fixed #17627 -- Renamed util.py files to utils.py
...
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
2013-09-16 12:52:05 -04:00
ebfe42d018
Fixed #21009 -- Added a versionchanged note regarding changes to clean().
...
refs [fb1dd6b13a1c4a9bd9ad
2013-09-05 05:47:45 -04:00
da800be6dd
Fixed #20986 -- Enabled SelectDateWidget to use custom months
...
Reviewed by Trac alias MarkusH.
2013-08-28 16:39:26 +03:00
7b69c3e775
Removed versionadded/changed annotations for 1.5
2013-08-19 09:09:41 -04:00
907ef9d0d1
Fixed #20555 -- Make subwidget id attribute available
...
In `BoundField.__iter__`, the widget's id attribute is now passed to
each subwidget. A new id_for_label property was added to ChoiceInput.
2013-08-13 13:23:05 -04:00
8442268869
Added an anchor for django.forms.Form.clean in docs
2013-08-08 14:13:52 -04:00
fb1dd6b13a
Form.clean() does not need to return cleaned_data.
...
If it does, that will be used as the cleaned_data. The default
implementation has been changed to match this change.
2013-08-08 14:05:55 +01:00
1280675834
Fixed #15511 -- Allow optional fields on ``MultiValueField` subclasses.
...
The `MultiValueField` class gets a new ``require_all_fields`` argument that
defaults to ``True``. If set to ``False``, individual fields can be made
optional, and a new ``incomplete`` validation error will be raised if any
required fields have empty values.
The ``incomplete`` error message can be defined on a `MultiValueField`
subclass or on each individual field. Skip duplicate errors.
2013-08-06 08:50:47 -04:00
05ea5a2139
Fixed #20823 -- Typo in docs/ref/forms/validation.txt
2013-07-29 18:41:08 -04:00
70c080fcdb
Misc doc cleanups.
2013-07-29 06:57:33 -04:00
8676318d2d
Fixed #20805 -- Removed an extra colon beside checkboxes in the admin.
...
Thanks CollinAnderson for the report.
2013-07-26 14:45:38 -04:00
7557207983
Fixed #20582 -- Allowed default Form.label_suffix to be translated
...
Thanks Tim Graham for the review.
2013-07-13 16:19:16 +02:00
c0f03175ce
Fixed #19695 -- Retitle "Form Media" to "Form Assets".
2013-07-08 13:59:54 -04:00
181f63c22d
Fixed #12346 -- Added a note on how to validate InlineFormSets.
...
Thanks johnsmith for the suggestion.
2013-07-08 08:29:28 -04:00
7442eb1a24
Fixed #20224 -- Update docs examples which mention __unicode__
...
Thanks Marc Tamlyn and Tim Graham for the review.
2013-07-05 19:27:07 +02:00
3632d289de
A couple more semicolon -> colon fixes; refs #18134 .
2013-07-02 14:14:56 -04:00
ee77d4b253
Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields
2013-06-18 08:01:17 -04:00
9e50833e22
Fixed #20000 -- Allowed ModelForm meta overrides for label, help_text and error_messages
2013-06-13 15:06:25 -04:00
584bd14dcf
Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix
...
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.
This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
2013-06-10 14:23:15 -04:00
175a102ddc
Fixed #20567 - Documented BoundField.id_for_label.
...
Thanks littlepig for the suggestion.
2013-06-09 12:13:43 -04:00
bb863faecd
Proofed the 1.6 release notes
2013-06-05 12:55:58 -04:00
08b501e7d3
add missing imports to the examples in the 'Forms'
2013-05-19 13:31:45 +02:00
756b81dbd1
Fixed #13546 -- Easier handling of localize field options in ModelForm
2013-05-18 14:13:00 +02:00
b16b72d415
Fixed #5472 --Added OpenLayers-based widgets in contrib.gis
...
Largely inspired from django-floppyforms. Designed to not depend
on OpenLayers at code level.
2013-05-17 13:33:40 +02:00
33793f7c3e
Fixed #19934 - Use of Pillow is now preferred over PIL.
...
This starts the deprecation period for PIL (support to end in 1.8).
2013-05-14 19:32:04 -07:00
f026a519ae
Fixed #19733 - deprecated ModelForms without 'fields' or 'exclude', and added '__all__' shortcut
...
This also updates all dependent functionality, including modelform_factory
and modelformset_factory, and the generic views `ModelFormMixin`,
`CreateView` and `UpdateView` which gain a new `fields` attribute.
2013-05-09 16:44:36 +01:00
78c842a323
Adapted uses of versionchanged/versionadded to the new form.
...
Refs #20104 .
2013-04-20 17:18:35 +02:00
5306285ce2
Complemented documentation following commit be9ae693c
...
Refs #17840 . Thanks Carl Meyer for noticing the omission.
2013-04-18 20:38:07 +02:00
9ac4dbd7b5
Fixed #4592 : Made CheckboxSelectMultiple more like RadioSelect
...
I refactored RadioSelect and CheckboxSelectMultiple to
make them inherit from a base class, allowing them to share
the behavior of being able to iterate over their subwidgets.
Thanks to Matt McClanahan for the initial patch and to
Claude Paroz for the review.
2013-04-13 16:37:27 +02:00
c4186c2fec
Fixed #4117 : Apply id attribute to the outer <ul> of RadioSelect
2013-04-13 12:23:25 +02:00
844fbc85c1
Fixed #19874 : Apply id attribute to the outer <ul> of CheckboxSelectMultiple
2013-04-13 11:09:47 +02:00
0f99246b6f
Documented BoundField.label_tag
2013-04-12 10:17:17 +02:00
f9ab543720
Fixed #20084 -- Provided option to validate formset max_num on server.
...
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
2013-03-21 01:27:24 -07:00
2f121dfe63
Fixed #17051 -- Removed some 'invalid' field error messages
...
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
2013-03-14 17:03:43 +01:00
8e5fbebe02
Fixed #19801 - Added brackets to input_formats.
...
Thanks leandron85@ for the suggestion.
2013-02-25 12:22:02 -05:00
7ec2a21be1
Fixed #19686 -- Added HTML5 number input type
...
Thanks Simon Charette for his help on the patch. Refs #16630 .
2013-02-23 10:18:08 +01:00
7a80904b00
Fixed #19812 - Removed a duplicate phrase in the widget docs.
...
Thanks diegueus9 for the report and itsallvoodoo for the draft patch.
2013-02-16 18:23:39 -05:00
f7394d2c32
Added HTML5 url input type
...
Refs #16630 .
2013-01-28 22:11:00 +01:00
4f16376274
Added HTML5 email input type
...
Refs #16630 .
2013-01-28 22:10:50 +01:00
93e79b45bc
Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory
2013-01-24 08:58:17 +01:00
0de2645c00
Fixed #19610 - Added enctype note to forms topics doc.
...
Thanks will@ for the suggestion.
2013-01-23 04:49:48 -05:00
5b2d9bacd2
Fixed #19640 - Added inlineformset_factory to reference docs.
...
Thanks wim@ for the suggestion.
2013-01-22 07:55:34 -05:00
71d76ec011
Fixed #10239 - Added docs for modelform_factory
...
Thanks ingenieroariel for the suggestion and slurms for the review.
2013-01-11 06:00:19 -05:00
9b5f64cc6e
Fixed #19516 - Fixed remaining broken links.
...
Added -n to sphinx builds to catch issues going forward.
2013-01-02 18:32:57 -05:00
7ee7599ab3
Removed versionadded/changed annotations dating back to 1.4.
2012-12-29 21:59:08 +01:00
2d0b35d2bb
Added links to default widget in forms.fields documentation
2012-12-29 11:30:12 +01:00
b3a8c9dab8
Fixed broken links, round 3. refs #19516
2012-12-26 19:07:22 -05:00
04775b4598
Fixed #13997 - Added an example of constructing a MultiWidget and documented the value_from_datadict method.
2012-11-17 17:54:09 -05:00
b0c72d0a30
Fixed invalid ipv4 mapped ipv6 addresses in docs
2012-11-07 17:13:06 +01:00
22742e4ac4
Added ref to format localization in Date[Time]Field docs
...
Thanks henrik@aisti.fi for the suggestion in #19119 .
2012-10-13 11:17:25 +02:00
10dc4797ea
Fixed #19119 -- Corrected default date input formats in docs
...
Thanks henrik@aisti.fi for the report.
2012-10-13 11:02:18 +02:00
218abcc9e5
Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as empty value
2012-10-03 20:47:35 +03:00
2c8267bf3d
Fixed #17899 -- Rewrote [Ee]-mail to [Ee]mail
2012-09-26 14:14:51 +02:00
837425b425
Fixed #18934 - Removed versionadded/changed annotations for Django 1.3
2012-09-20 19:06:55 -04:00
a73838fde3
Fixed #11185 - Expanded docs on customizing widgets; thanks fadeev for the draft patch.
2012-09-15 06:22:00 -04:00
f1bdfbd24b
Document and test 'type' usage in Widget attrs
...
Refs #16630 .
2012-09-10 19:31:11 +02:00
fa8fb2b383
Fixed #18490 - Updated DateField input formats; thanks dloewenherz for the draft patch.
2012-09-07 19:49:38 -04:00
46249061d6
Merge pull request #333 from brad/ticket_18917
...
clarify clean_<field> docs, ticket #18917
2012-09-07 12:00:01 -07:00
6a5a12ea3e
Fixed #17888 -- no longer silence exceptions inside of check_test. Thanks to brutasse for the patch.
2012-09-07 14:37:21 -04:00
c634375e9c
clarify clean_<field> docs, ticket #18917
2012-09-07 10:43:55 -04:00
121fd109de
Fixed #5524 -- Do not remove cleaned_data when a form fails validation
...
cleaned_data is no longer deleted when form validation fails but only
contains the data that did validate.
Thanks to the various contributors to this patch (see ticket).
2012-08-04 14:22:23 +02:00
5e94ef293c
Fixed #18374 -- Explained "corrupt image" error
...
Thanks fabian and charettes.
2012-07-08 11:53:45 +02:00
f8ef93a657
Fixed a documentation typo on the widget page.
2012-06-19 10:37:53 +02:00
33999d9871
Fixed #18445 -- Added a links in the docs.
...
Thanks Audrey Roy for the patch.
2012-06-07 22:11:24 +02:00
4a103086d5
Fixed #18269 -- Applied unicode_literals for Python 3 compatibility.
...
Thanks Vinay Sajip for the support of his django3 branch and
Jannis Leidel for the review.
2012-06-07 18:08:47 +02:00
Marc Tamlyn
Anders Steinlein
Julen Ruiz Aizpuru
chriscauley
Tim Graham
Claude Paroz
Anubhav Joshi
Loic Bistuer
vvojvoda
Loic Bistuer
Alasdair Nicol
Baptiste Mispelon
Vajrasky Kok
Ramiro Morales
Erik Romijn
Ben Huckvale
yokomizor
Matt Johnson
Tai Lee
minusf
James Bennett
Gabe Jackson
leandrafinger
Erik Romijn
Daniel Lindsley
Luke Plant
Juan Catalano
Andrew Gorcester
Nick Sandford
Aymeric Augustin
Danilo Bargen
Stephen Burrows
Adrien Lemaire
Alex Gaynor
Brad Pitcher
Tim Saylor