David Wobrock
67da22f08e
Fixed #34074 -- Added headers argument to RequestFactory and Client classes.
2022-11-14 10:21:51 +01:00
Simon Charette
10037130c1
Refs #28477 -- Fixed handling aliased annotations on aggregation.
...
Just like when using .annotate(), the .alias() method will generate the
necessary JOINs to resolve the alias even if not selected.
Since these JOINs could be multi-valued non-selected aggregates must be
considered to require subquery wrapping as a GROUP BY is required to
combine duplicated tuples from the base table.
Regression in 59bea9efd2
.
2022-11-14 05:45:33 +01:00
Simon Charette
a9d2d8d1c3
Refs #28477 -- Reduced complexity of aggregation over qualify queries.
2022-11-11 08:46:08 +01:00
Francesco Panico
032c09c414
Refs #34110 -- Reorganized django.core.files.storage into a separate module.
2022-11-11 06:59:33 +01:00
Nick Pope
9bd174b9a7
Updated documentation and comments for RFC updates.
...
- Updated references to RFC 1123 to RFC 5322
- Only partial as RFC 5322 sort of sub-references RFC 1123.
- Updated references to RFC 2388 to RFC 7578
- Except RFC 2388 Section 5.3 which has no equivalent.
- Updated references to RFC 2396 to RFC 3986
- Updated references to RFC 2616 to RFC 9110
- Updated references to RFC 3066 to RFC 5646
- Updated references to RFC 7230 to RFC 9112
- Updated references to RFC 7231 to RFC 9110
- Updated references to RFC 7232 to RFC 9110
- Updated references to RFC 7234 to RFC 9111
- Tidied up style of text when referring to RFC documents
2022-11-10 13:52:17 +01:00
Márton Salomváry
d6cbf39a1b
Fixed #34149 -- Allowed adding deferrable conditional exclusion constraints on PostgreSQL.
2022-11-10 11:07:24 +01:00
Simon Charette
59bea9efd2
Fixed #28477 -- Stripped unused annotations on aggregation.
...
Also avoid an unnecessary pushdown when aggregating over a query that doesn't
have aggregate annotations.
2022-11-09 13:22:14 +01:00
Jon Janzen
321ecb40f4
Fixed #34135 -- Added async-compatible interface to related managers.
2022-11-09 10:32:40 +01:00
Scott Halgrim
c4eaa67e2b
Fixed #34063 -- Fixed reading request body with async request factory and client.
...
Co-authored-by: Kevan Swanberg <kevswanberg@gmail.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2022-11-08 13:53:34 +01:00
Jon Janzen
7b94847e38
Fixed #34139 -- Fixed acreate(), aget_or_create(), and aupdate_or_create() methods for related managers.
...
Bug in 58b27e0dbb
.
2022-11-08 06:20:10 +01:00
Simon Charette
76e37513e2
Refs #33374 -- Adjusted full match condition handling.
...
Adjusting WhereNode.as_sql() to raise an exception when encoutering a
full match just like with empty matches ensures that all case are
explicitly handled.
2022-11-07 20:23:53 +01:00
Simon Charette
4b702c832c
Refs #33374 -- Added tests for multi-table fast-deletion with filters that match everything.
2022-11-07 20:23:53 +01:00
Simon Charette
5f09ab8c30
Refs #17144 -- Removed support for grouping by primary key.
...
No core backend require the feature anymore as it was only added to
support a MySQL'ism that has been deprecated since then.
2022-11-07 12:21:29 +01:00
Simon Charette
967f8750ab
Refs #27849 -- Fixed filtered aggregates crash on filters that match everything.
2022-11-07 09:05:24 +01:00
Simon Charette
77cf70ea96
Refs #27849 -- Added test for filtered aggregates with empty conditions.
2022-11-07 08:57:40 +01:00
Bhuvnesh
123b1d3fcf
Fixed #34137 -- Made Model.refresh_from_db() clear cached generic relations.
...
Thanks Simon Charette for the implementation idea.
2022-11-07 08:06:30 +01:00
Daniel Ivanov
5eab4d1924
Fixed #34088 -- Fixed Sitemap.get_latest_lastmod() crash with empty items.
...
Bug in 480191244d
.
Thanks Michal Čihař for the report.
2022-11-07 06:15:54 +01:00
LightDiscord
e20c9eb60a
Fixed #27654 -- Propagated alters_data attribute to callables overridden in subclasses.
...
Thanks Shai Berger and Adam Johnson for reviews and the implementation
idea.
2022-11-04 11:08:58 +01:00
Mariusz Felisiak
7b0e9ea53c
Fixed #34138 -- Avoided table rebuild when adding inline m2m fields on SQLite.
...
Regression in 2f73e5406d
.
Thanks David Wobrock for the report.
2022-11-04 09:30:23 +01:00
Bhuvnesh
e580b891cb
Refs #33646 -- Moved tests of QuerySet async interface into async tests.
2022-11-03 20:11:19 +01:00
Ion Alberdi
3dc9f3ac69
Fixed #34080 -- Fixed __exact lookup when nested arrays contain only NULL values.
...
Thanks jerch and David Sanders for reviews.
2022-11-03 06:59:49 +01:00
Ion Alberdi
34d63d5a41
Refs #34080 -- Added tests for __exact lookup when non-nested arrays contain only NULL values.
2022-11-03 06:39:34 +01:00
Mariusz Felisiak
57c2e5da71
Refs #33984 -- Added test for creating copies of model instances with inherited m2m fields.
2022-11-02 12:30:16 +01:00
DevilsAutumn
d5bcdf858d
Fixed #34112 -- Added async-compatible interface to Model methods.
...
Thanks Adam Johnson for the review.
2022-11-02 09:14:17 +01:00
Nick Pope
2bc47d7fe9
Avoided assignment followed by immediate return.
...
Identified using the following command:
$ pcre2grep --line-number --multiline --recursive \
"(?s)(\n +)(\w+) = [^\n]+\1return \2;?$" \
django docs extras js_tests scripts tests
2022-10-31 12:31:13 +01:00
Nick Pope
d3cb91db87
Used more augmented assignment statements.
...
Identified using the following command:
$ git grep -I '\(\<[_a-zA-Z0-9]\+\>\) *= *\1 *[-+/*^%&|<>@]'
2022-10-31 12:30:13 +01:00
David Wobrock
a320aab512
Fixed #16211 -- Added logical NOT support to F expressions.
2022-10-31 09:55:51 +01:00
Msvstl
67bc2f1b99
Corrected test_update_or_create_with_model_property_defaults test.
2022-10-29 13:27:10 +02:00
Simon Charette
c2cc80756b
Fixed #34125 -- Fixed sliced QuerySet.union() crash on a single non-empty queryset.
...
The bug existed since sliced query union was added but was elevated to
query union slices by moving the .exists() optimization to the compiler
in 3d734c09ff
.
Thanks Stefan Hammer for the report.
2022-10-29 09:21:25 +02:00
Simon Kern
de2c2127b6
Fixed #34066 -- Fixed link to password reset view in UserChangeForm.password's help text when using to_field.
...
Co-Authored-By: David Sanders <shang.xiao.sanders@gmail.com>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2022-10-27 09:23:34 +02:00
Mariusz Felisiak
d559cb02da
Refs #19215 -- Fixed admin_widgets tests if Pillow isn't installed.
...
Follow up to c0fc1b5302
.
2022-10-27 08:41:03 +02:00
Tobias Bengfort
350455b666
Fixed #33606 -- Cleansed sessionid cookie in error reports.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2022-10-26 14:39:58 +02:00
Marcelo Galigniana
b440493eaa
Completed test coverage for contrib.auth.forms.
2022-10-26 12:52:18 +02:00
Marcelo Galigniana
c0fc1b5302
Fixed #19215 -- Fixed rendering ClearableFileInput when editing with invalid files.
...
Thanks Michael Cardillo for the initial patch.
2022-10-25 16:53:52 +02:00
Yuri Konotopov
64e5ef1f17
Fixed #29027 -- Fixed file_move_safe() crash when moving files with SELinux.
...
Thanks Florian Apolloner for the review.
2022-10-24 13:54:51 +02:00
Vlastimil Zíma
08c5a78726
Fixed #34098 -- Fixed loss of precision for Decimal values in floatformat filter.
...
Regression in 12f7928f5a
.
2022-10-24 12:59:34 +02:00
Marcelo Galigniana
1d6948096f
Fixed flaky test_ForeignKey_using_to_field test.
2022-10-24 11:54:00 +02:00
Giebisch
3283120cca
Fixed #34111 -- Made test runner with --debug-sql format SQL queries.
2022-10-24 08:11:30 +02:00
HieuPham9720
3e928de8ad
Skipped scrypt tests when OpenSSL 1.1+ is not installed.
2022-10-20 18:50:48 -07:00
Carlton Gibson
5c2c7277d4
Fixed #34085 -- Made management commands don't use black for non-Python files.
...
Bug in d113b5a837
.
Co-authored-by: programmylife <acmshar@gmail.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2022-10-20 13:38:31 -07:00
Simon Charette
d62563cbb1
Fixed #34105 -- Fixed crash of ordering by nested selected expression.
...
This stops ordering by nested selected references. It's not supported on
PostgreSQL and not required to support psycopg3.
Regression in 04518e310d
.
Thanks Matt Westcott for the report.
2022-10-18 17:31:45 -07:00
Marcelo Galigniana
2a2503c2c1
Completed test coverage for django.core.paginator.
2022-10-13 12:27:41 +02:00
Sergio
94e7f471c4
Fixed #34069 -- Made LocaleMiddleware respect language from requests when i18n patterns are used.
2022-10-13 10:38:26 +02:00
Rasmus Magnell
c4aac2ac1e
Fixed #34042 -- Improved accessibility of admin's navigation sidebar.
2022-10-12 10:21:17 +02:00
Marcelo Galigniana
f30c7e381c
Completed test coverage for contenttypes models.
2022-10-11 05:38:39 +02:00
Adam Johnson
6402b064a9
Used test client headers in i18n tests.
2022-10-10 11:46:31 +02:00
Sarah Boyce
84206607d6
Fixed #32833 -- Fixed ContentTypeManager.get_for_models() crash when using in migrations.
...
Co-authored-by: Heraldo Lucena <23155511+HMaker@users.noreply.github.com>
2022-10-10 08:57:52 +02:00
Gregor Gärtner
f0c06f8ab7
Refs #33990 -- Renamed TransactionTestCase.assertQuerysetEqual() to assertQuerySetEqual().
...
Co-Authored-By: Michael Howitz <mh@gocept.com>
2022-10-08 08:07:38 +02:00
Mariusz Felisiak
d795259ea9
Replaced assertQuerysetEqual() to assertSequenceEqual()/assertCountEqual() where appropriate.
...
Follow up to 3f7b327562
.
2022-10-07 13:05:35 +02:00
Gregor Gärtner
564b317fb5
Refs #33990 -- Renamed SimpleTestCase.assertFormsetError() to assertFormSetError().
...
Co-Authored-By: Michael Howitz <mh@gocept.com>
2022-10-07 11:22:16 +02:00
Mariusz Felisiak
749cd83e13
Removed hardcoded pks in TestQuerying.test_group_by_order_by_aliases test.
2022-10-07 08:26:41 +02:00
Shubh1815
7a39a691e1
Fixed #32603 -- Made ModelAdmin.list_editable use transactions.
2022-10-06 20:44:07 +02:00
Simon Charette
c6350d594c
Refs #30158 -- Removed alias argument for Expression.get_group_by_cols().
...
Recent refactors allowed GROUP BY aliasing allowed for aliasing to be
entirely handled by the sql.Query.set_group_by and compiler layers.
2022-10-06 12:04:00 +02:00
Simon Charette
b7b28c7c18
Refs #31150 -- Enabled implicit GROUP BY aliases.
...
This ensures implicit grouping from aggregate function annotations
groups by uncollapsed selected aliases if supported.
The feature is disabled on Oracle because it doesn't support it.
2022-10-06 11:51:32 +02:00
Simon Charette
3d734c09ff
Refs #33992 -- Refactored subquery grouping logic.
...
This required moving the combined queries slicing logic to the compiler
in order to allow Query.exists() to be called at expression resolving
time.
It allowed for Query.exists() to be called at Exists() initialization
time and thus ensured that get_group_by_cols() was operating on the
terminal representation of the query that only has a single column
selected.
2022-10-06 11:38:03 +02:00
Simon Charette
04518e310d
Refs #33308 -- Enabled explicit GROUP BY and ORDER BY aliases.
...
This ensures explicit grouping from using values() before annotating an
aggregate function groups by selected aliases if supported.
The GROUP BY feature is disabled on Oracle because it doesn't support it.
2022-10-06 09:34:31 +02:00
Simon Charette
c58a8acd41
Fixed #33768 -- Fixed ordering compound queries by nulls_first/nulls_last on MySQL.
...
Columns of the left outer most select statement in a combined query
can be referenced by alias just like by index.
This removes combined query ordering by column index and avoids an
unnecessary usage of RawSQL which causes issues for backends that
specialize the treatment of null ordering.
2022-10-05 14:04:49 +02:00
Jack Linke
344d31c7e9
Fixed #34071 -- Improved error message for Range(Min/Max)ValueValidator.
2022-10-05 09:41:01 +02:00
Dhanush
9fbb5b5e16
Fixed #34068 -- Corrected output of runserver command for "0" IP address.
...
Thanks David Sanders for the review.
2022-10-04 10:13:32 +02:00
Adam Johnson
e5ea284294
Fixed CVE-2022-41323 -- Prevented locales being interpreted as regular expressions.
...
Thanks to Benjamin Balder Bach for the report.
2022-10-04 09:10:04 +02:00
David Sanders
4771a1694b
Fixed #34012 -- Made QuerySet.order_by() apply transforms on related fields for models with Meta.ordering.
...
This makes QuerySet.order_by() no longer ignore trailing transforms for
models with Meta.ordering. As a consequence, FieldError is raised in
such cases for non-existent fields.
Thanks to Klaas van Schelven for the report and Mariusz Felisiak for the
review and advice.
2022-10-04 08:19:34 +02:00
Lily Foote
649b28eab6
Fixed #34070 -- Added subsecond support to Now() on SQLite and MySQL.
2022-10-03 12:13:27 +02:00
Mariusz Felisiak
f71b0cf769
Refs #32987 -- Relaxed system check for template tag modules with the same name by turning into a warning.
...
Thanks Claude Paroz for the report.
Regression in 004b4620f6
.
2022-10-03 10:52:21 +02:00
David Wobrock
3b4a5b9f97
Fixed #23353 -- Used "raise from" when raising TransactionManagementError.
...
This change sets the __cause__ attribute to raised exceptions.
2022-10-03 06:08:54 +02:00
Mariusz Felisiak
bc3b8f1524
Refs #34058 -- Fixed changing/deleting sequences when altering pre-Django 4.1 auto fields on PostgreSQL.
...
Thanks Anders Kaseorg for the report.
Follow up to 19e6efa50b
.
Regression in 2eea361eff
.
2022-10-01 07:53:32 +02:00
Mariusz Felisiak
5e0aa362d9
Fixed #33984 -- Reverted "Fixed #32980 -- Made models cache related managers."
...
This reverts 4f8c7fd9d9
and adds
two regression tests:
- test_related_manager_refresh(), and
- test_create_copy_with_m2m().
Thanks joeli for the report.
2022-09-30 18:18:33 +02:00
sarahboyce
6cc0f22a73
Fixed #32095 -- Made QuerySet.update_or_create() save only fields passed in defaults or with custom pre_save().
...
Thanks Florian Apolloner for the initial patch.
2022-09-30 06:26:19 +02:00
Antoine Lorence
9b0c9821ed
Fixed #34062 -- Updated View.http_method_not_allowed() to support async.
...
As with the options() methods, wrap the response in a coroutine if
the view is async.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2022-09-29 16:28:44 +02:00
Mariusz Felisiak
19e6efa50b
Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL.
...
Thanks Anders Kaseorg for the report.
Thanks Florian Apolloner for pair programming.
Regression in 2eea361eff
.
2022-09-29 13:20:14 +02:00
Adam Johnson
0f5b11eca0
Refs #34010 -- Made --debug-mode work for parallel tests using spawn.
...
Bug in 3b3f38b3b0
.
Thanks Kevin Renskers for the report.
2022-09-28 19:39:25 +02:00
David Sanders
9976f3d4b8
Fixed #34025 -- Fixed selecting ModelAdmin.autocomplete_fields after adding/changing related instances via popups.
...
Regression in c72f6f36c1
.
Thanks Alexandre da Silva for the report.
2022-09-28 11:28:01 +02:00
Mariusz Felisiak
6e891a1722
Removed obsolete test_skip_link_is_skipped_when_there_is_searchbar test.
...
searchbar doesn't have autofocus since
d938b3b257
.
2022-09-28 11:27:11 +02:00
Jacob Walls
80d38de52b
Fixed #34051 -- Made makemigrations --check exit before making migrations.
2022-09-28 09:48:07 +02:00
JunKi Yoon
1a7b6909ac
Fixed #34052 -- Made migrate --check don't emit signals and output when up to date.
2022-09-27 21:10:30 +02:00
David Wobrock
cff1f888e9
Fixed #33464 -- Resolved output_field for combined numeric expressions with MOD operator.
2022-09-27 20:41:10 +02:00
sarahboyce
ae3d575ec3
Added tests for QuerySet.update_or_create() with multi-table inheritance.
2022-09-27 12:55:33 +02:00
Marcelo Galigniana
67c34c1a37
Completed test coverage for createsuperuser command.
2022-09-27 09:57:16 +02:00
Adam Johnson
cd03e8e2d6
Fixed #34050 -- Replaced invalid chars in migration names with '_'.
...
Thanks to Bishal Gautam for the report and initial implementation.
Regression in fa58450a9a
.
Co-Authored-By: Bishal Gautam <bisalgt@gmail.com>
2022-09-27 08:02:51 +02:00
Moshe Nahmias
d938b3b257
Fixed #34040 -- Removed autofocus from admin search box.
2022-09-26 21:06:48 +02:00
Mariusz Felisiak
f4e592e383
Removed unnecessary MySQL workaround in timezones tests.
...
Unnecessary since 22da5f8817
.
2022-09-26 13:36:47 +02:00
Florian Perucki
872b61193b
Refs #34041 -- Added navigation landmark to breadcrumbs in admin.
...
Thanks Thibaud Colas for pair programming.
2022-09-26 08:51:15 +02:00
David Sanders
9f8c994851
Fixed #34027 -- Fixed migrations crash when altering type of char/text fields referenced by foreign key on PostgreSQL.
2022-09-25 20:23:01 +02:00
select-case
f3822d4ab0
Fixed #34026 -- Fixed WKBReader.read() crash on string input.
2022-09-24 17:16:08 +01:00
David Sanders
1674c70525
Fixed #34024 -- Fixed crash when aggregating querysets with Q objects annotations.
...
This reverts b64db05b9c
.
It was reasonable to assume it was unnecessary code as there were
no failing tests upon its removal. This commit adds the necessary
regression tests for the failing condition identified in #34024
alongside the original tests added in the PR for which
WhereNode.is_summary was introduced.
2022-09-23 15:15:03 +01:00
Mariusz Felisiak
37a13cc92d
Refs #34012 -- Added test for ordering by transform of related fields.
2022-09-22 12:55:47 +02:00
Mariusz Felisiak
ce6230aa97
Fixed #34015 -- Allowed filtering by transforms on relation fields.
2022-09-22 00:17:04 +02:00
Alexander Kerkum
f88fc72da4
Fixed #34016 -- Fixed QuerySet.values()/values_list() crash on ArrayAgg() and JSONBAgg().
...
Regression in e06dc4571e
.
2022-09-17 19:38:20 +02:00
Kamil Turek
ae509f8f08
Fixed #34014 -- Fixed DecimalValidator validating 0 in positive exponent scientific notation.
...
Thanks Shiplu Mokaddim for the report.
2022-09-17 10:02:55 +02:00
Mariusz Felisiak
229360d7ad
Fixed test_relational_post_delete_signals_happen_before_parent_object when run in isolation.
2022-09-16 11:14:27 +02:00
Allen Jonathan David
10178197d5
Fixed #33966 -- Added support for using KeyTextTransform from lookup.
2022-09-16 05:36:57 +02:00
Anvesh Mishra
6220c445c4
Fixed #29186 -- Fixed pickling HttpRequest and subclasses.
2022-09-14 13:04:34 +02:00
David Sanders
e14d08cd89
Fixed #33996 -- Fixed CheckConstraint validation on NULL values.
...
Bug in 667105877e
.
Thanks James Beith for the report.
2022-09-13 12:48:31 +02:00
Sergey Fursov
b731e88415
Fixed #31335 -- Fixed removing composed composed Meta constraints/indexes on foreign keys on MySQL.
2022-09-13 10:38:57 +02:00
Sergey Fursov
1b08e9bf7d
Refs #31335 -- Added more tests for removing composed Meta constraints/indexes on foreign keys.
2022-09-12 13:52:06 +02:00
Jimmy Angelakos
07ebef566f
Refs #34000 -- Optimized handling None values in numberformat.format().
2022-09-12 13:02:50 +02:00
Jimmy Angelakos
e911e0996f
Fixed #34000 -- Fixed numberformat.format() crash on empty strings.
2022-09-12 12:54:12 +02:00
DevilsAutumn
f3cd252cfc
Fixed #33995 -- Fixed FormSet.empty_form crash when empty_permitted is passed to form_kwargs.
2022-09-09 13:51:47 +02:00
DevilsAutumn
32797e7fbf
Fixed #33975 -- Fixed __in lookup when rhs is a queryset with annotate() and alias().
...
This fixes clearing selected fields.
2022-09-09 08:37:46 +02:00
Simon Charette
32536b1324
Fixed #33992 -- Fixed queryset crash when aggregating over a group containing Exists.
...
A more in-depth solution is likely to make sure that we always GROUP BY
selected annotations or revisit how we use Query.exists() in the Exists
expression but that requires extra work that isn't suitable for a
backport.
Regression in e5a92d400a
.
Thanks Fernando Flores Villaça for the report.
2022-09-08 05:50:02 +02:00
Mariusz Felisiak
a2e580acf6
Refs #24179 -- Fixed selenium tests for offset of admin selector boxes in fieldset.
...
Regression in be63c78760
.
2022-09-07 12:02:08 +02:00
James Beith
19e838daa8
Fixed #33982 -- Fixed migrations crash when adding model with ExclusionConstraint.
...
Regression in 0e656c02fe
.
2022-09-07 08:40:56 +02:00
SirAbhi13
4a1150b41d
Fixed #33616 -- Allowed registering callbacks that can fail in transaction.on_commit().
...
Thanks David Wobrock and Mariusz Felisiak for reviews.
2022-09-06 12:21:36 +02:00
Mariusz Felisiak
69fa2e8eb2
Refs #26780 -- Made prefetch_related() don't use window expressions fo sliced queries if not supported.
2022-09-06 05:54:35 +02:00
Mark Evans
19e0587ee5
Fixed #33937 -- Optimized serialization of related m2m fields without natural keys.
2022-09-05 20:23:32 +02:00
Allen Jonathan David
cd1afd553f
Fixed #29799 -- Allowed registering lookups per field instances.
...
Thanks Simon Charette and Mariusz Felisiak for reviews and mentoring
this Google Summer of Code 2022 project.
2022-09-02 10:02:24 +02:00
Shai Berger
fdf0f62521
Fixed ReadOnlyPasswordHashWidget's template for RTL languages.
2022-09-01 21:20:15 +02:00
Mariusz Felisiak
974942a750
Fixed #33955 , Fixed #33971 -- Reverted "Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs."
...
This reverts commit 7f3cfaa12b
.
Thanks Tom Carrick and Greg Kaleka for reports.
2022-09-01 21:09:16 +02:00
Allen Jonathan David
e64919ae54
Refs #29799 -- Added more tests for registering lookups.
2022-09-01 09:59:31 +02:00
Simon Charette
b3db6c8dcb
Fixed #21204 -- Tracked field deferrals by field instead of models.
...
This ensures field deferral works properly when a model is involved
more than once in the same query with a distinct deferral mask.
2022-08-30 08:43:53 +02:00
Simon Charette
5d12650ed9
Refs #21204 -- Added more QuerySet.defer()/only() tests for invalid fields.
2022-08-30 07:09:15 +02:00
Mariusz Felisiak
a9e7beb959
Refs #33953 -- Fixed test_rename_model_with_db_table_rename_m2m() crash on SQLite < 3.20.
2022-08-29 10:07:53 +02:00
Mariusz Felisiak
f210de760b
Refs #28333 -- Fixed NonQueryWindowTests.test_invalid_filter() on databases that don't support window expressions.
2022-08-29 09:14:56 +02:00
Mohamed Karam
b92ffebb0c
Fixed #33954 -- Prevented models.DecimalField from accepting NaN, Inf, and -Inf values.
2022-08-27 15:51:08 +02:00
David Wobrock
806e9e2d0d
Fixed #33952 -- Reallowed creating reverse foreign key managers on unsaved instances.
...
Thanks Claude Paroz for the report.
Regression in 7ba6ebe914
.
2022-08-27 15:03:48 +02:00
Simon Charette
0701bb8e1f
Fixed #33928 -- Avoided unnecessary queries when cascade updating.
...
Models that use SET, SET_NULL, and SET_DEFAULT as on_delete handler
don't have to fetch objects for the sole purpose of passing them back to
a follow up UPDATE query filtered by the retrieved objects primary key.
This was achieved by flagging SET handlers as _lazy_ and having the
collector logic defer object collections until the last minute. This
should ensure that the rare cases where custom on_delete handlers are
defined remain uncalled when when dealing with an empty collection of
instances.
This reduces the number queries required to apply SET handlers from
2 to 1 where the remaining UPDATE use the same predicate as the non
removed SELECT query.
In a lot of ways this is similar to the fast-delete optimization that
was added in #18676 but for updates this time. The conditions only
happen to be simpler in this case because SET handlers are always
terminal. They never cascade to more deletes that can be combined.
Thanks Renan GEHAN for the report.
2022-08-27 14:25:55 +02:00
Iuri de Silvio
166a3b3263
Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel operation a noop for models with db_table."
...
Regression in afeafd6036
.
This reverts afeafd6036
.
Thanks Timothy Thomas for the report.
2022-08-26 06:14:44 +02:00
Simon Charette
71902e0d9f
Fixed #33938 -- Fixed migration crash for m2m with a through model in another app.
...
Regression in aa4acc164d
.
Thanks bryangeplant for the report.
2022-08-25 10:03:57 +02:00
Neeraj Kumar
9942f3fb49
Fixed #33830 -- Fixed VariableDoesNotExist when rendering ClearableFileInput.
2022-08-25 07:52:36 +02:00
Willem Van Onsem
16fffc829c
Fixed #33916 -- Added support for serialization of enum.Flag in migrations.
2022-08-25 06:43:48 +02:00
Simon Charette
b30c0081d4
Refs #27412 -- Confirmed support for executing Coalesce(subquery).
...
This has been supported for subqueries wrapped in Subquery since the expression
was introduced and for Queryset directly since Subquery resolves to sql.Query.
Piggy-backed on the existing tests covering Coalesce handling of EmptyResultSet
as it seemed like a proper location to combine testing.
2022-08-24 12:30:47 +02:00
David Wobrock
897f38fabe
Fixed #33927 -- Fixed crash when displaying ArrayField with choices in admin.
2022-08-23 15:51:42 +02:00
Claude Paroz
4488a25cc9
Removed unused path variable in model_fields tests.
2022-08-23 15:34:07 +02:00
Claude Paroz
903ac2f364
Fixed #33949 -- Fixed fixture dirs duplicates with Path instances.
2022-08-23 13:24:18 +02:00
Mariusz Felisiak
e9fd2b5724
Refs #26511 -- Fixed json.KeyTextTransform() on MySQL/MariaDB.
2022-08-18 21:02:29 +02:00
Tom Carrick
bd36023100
Used CSS flex for admin's submit row.
2022-08-18 12:29:40 +02:00
Benoît Vinot
e3cb8bcb7d
Fixed #33932 -- Fixed altering AutoFields to OneToOneField on PostgreSQL.
...
Regression in 2eea361eff
.
2022-08-17 17:06:00 +02:00
Tom Carrick
d46cc15c51
Fixed #33878 -- Switched to system fonts in CSS.
2022-08-17 10:19:00 +02:00
Willem Van Onsem
08688bd7dd
Refs #33916 -- Added tests for serialization of enum.Flag in migrations.
2022-08-16 07:52:27 +02:00
Simon Charette
242499f2dc
Fixed #26780 -- Added prefetch_related() support for sliced queries.
...
This was made possible by window function filtering support added in
f387d024fc
.
2022-08-15 10:25:20 +02:00
Simon Charette
f387d024fc
Refs #28333 -- Added partial support for filtering against window functions.
...
Adds support for joint predicates against window annotations through
subquery wrapping while maintaining errors for disjointed filter
attempts.
The "qualify" wording was used to refer to predicates against window
annotations as it's the name of a specialized Snowflake extension to
SQL that is to window functions what HAVING is to aggregates.
While not complete the implementation should cover most of the common
use cases for filtering against window functions without requiring
the complex subquery pushdown and predicate re-aliasing machinery to
deal with disjointed predicates against columns, aggregates, and window
functions.
A complete disjointed filtering implementation should likely be
deferred until proper QUALIFY support lands or the ORM gains a proper
subquery pushdown interface.
2022-08-15 08:26:26 +02:00
Haolun Chai
f3f9d03edf
Fixed #33901 -- Skipped varchar_pattern_ops/text_pattern_ops index creation when db_collation is set.
2022-08-15 06:28:35 +02:00
Mariusz Felisiak
5c803bc070
Fixed #33919 -- Fixed adding AutoFields on PostgreSQL.
...
Thanks Jack Calvin Brown for the report.
Regression in 2eea361eff
.
2022-08-12 17:30:23 +02:00
Claude Paroz
4fcba800b8
Fixed #33924 -- Deprecated BaseGeometryWidget.map_height/map_width attributes.
2022-08-12 13:26:35 +02:00
Carlton Gibson
e34dfad0a3
Refs #30213 -- Removed post-startup check for Watchman availability.
...
This is checked at startup in get_reloader(). The runtime check ties
the implementation to Watchman excessively.
2022-08-11 11:02:03 +02:00
David Sanders
e0ae1363ec
Fixed #33905 -- Fixed CheckConstraint() validation on range fields.
...
Bug in 667105877e
.
2022-08-09 20:13:21 +02:00
David Sanders
e0ac72fe80
Refs #33905 -- Added test for CheckConstraint() validation with ArrayField and __contains.
2022-08-09 20:06:59 +02:00
David Wobrock
036bb2b74a
Fixed #33895 -- Fixed Case() crash with filters that match everything in When().
...
Thanks shukryzablah for the report.
2022-08-09 07:55:31 +02:00
Mariusz Felisiak
63884829ac
Fixed #33902 -- Fixed Meta.constraints validation crash with F() expressions.
...
Thanks Adam Zahradník for the report.
Bug in 667105877e
.
2022-08-09 06:08:48 +02:00
Kamil Turek
e03cdf76e7
Fixed #31721 -- Allowed ModelForm meta to specify form fields.
2022-08-08 09:46:05 +02:00
Carlton Gibson
88e67a54b7
Added test for non-HTTP request on ASGIStaticFilesHandler.
2022-08-08 07:27:32 +02:00
Fiza Ashraf
c0beff2123
Fixed #33899 -- Fixed migration crash when removing indexed field on SQLite 3.35.5+.
...
Regression in 702819227fd0cdd9b581cd99e11d1561d51cbeb.
Thanks cessor for the report.
2022-08-08 06:28:53 +02:00
Mariusz Felisiak
fd93db97c7
Fixed #33898 -- Fixed Window() expression crash with ArrayAgg().
...
Thanks Kia for the report.
Regression in e06dc4571e
.
2022-08-06 17:59:31 +02:00
Fab
0756c61f2a
Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double submission of admin forms."
...
Regression in fe7dbef586
.
2022-08-05 16:38:52 +02:00
Carlton Gibson
f476c8847a
Refs #33173 , Refs #33755 -- Fixed ResourceWarning from unclosed files in ASGI tests.
2022-08-04 10:00:36 +02:00
Claude Paroz
0638b4e23d
Fixed #33888 -- Fixed get_select2_language() crash with no language activated.
...
Regression in 3079133c73
.
2022-08-03 19:51:25 +02:00
Alberto Planas
4e13b40a76
Fixed #33887 -- Fixed test_fails_squash_migration_manual_porting() on final tags.
...
Regression in 7c318a8bdd
.
2022-08-03 16:36:04 +02:00
Mariusz Felisiak
cb791a2540
Fixed #33872 -- Deprecated django.contrib.postgres.fields.CIText/CICharField/CIEmailField/CITextField.
2022-08-03 11:42:51 +02:00
Carlton Gibson
bd062445cf
Fixed CVE-2022-36359 -- Escaped filename in Content-Disposition header.
...
Thanks to Motoyasu Saburi for the report.
2022-08-03 08:46:31 +02:00
Mariusz Felisiak
919e65b21e
Updated translations from Transifex.
...
This also fixes related i18n tests.
Forwardport of a3bab93324
from stable/4.1.x.
Co-authored-by: Claude Paroz <claude@2xlibre.net>
2022-08-03 08:04:34 +02:00
Mariusz Felisiak
ab1955a05e
Fixed #33881 -- Added support for database collations to ArrayField(Char/TextFields).
2022-08-02 11:44:26 +02:00