4082a8886e
Fixed #35724 -- Tested migration commands handling of distributed namespace packages.
...
Also increased coverage of module_loading.py.
2024-09-03 08:07:53 +02:00
c6a4f853c7
Fixed #35712 -- Prevented Q.check() from leaving the connection in an unusable state.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2024-09-02 17:00:55 +02:00
387475c5b2
Refs #35706 -- Prefixed 'Error:' to titles of admin pages with form errors.
...
This improves the screen reader experience.
2024-09-02 15:19:33 +02:00
e4a2e22ddb
Fixed #35690 -- Errored nicely when using in_bulk() with a values() or values_list() queryset.
2024-09-02 15:04:52 +02:00
fd1dd76778
Fixed #35716 -- Fixed VariableDoesNotExist when rendering admin fieldsets.
...
Regression in 01ed59f753
2024-08-30 20:49:27 +02:00
20d44abb41
Fixed #35700 -- Added AlterModelTable and AlterModelTableComment reductions.
2024-08-30 18:50:12 +02:00
884ce37479
Fixed #35083 -- Updated method_decorator to handle async methods.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2024-08-30 08:54:49 -03:00
2c1f27d0d0
Dropped safeguards against very old versions of gettext.
...
gettext 0.19 was released in 2014.
2024-08-30 13:39:04 +02:00
2ff00251f9
Fixed #35669 -- Improved max post-process passes exceeded error message in HashedFilesMixin.
...
Signed-off-by: SaJH <wogur981208@gmail.com>
2024-08-30 10:00:51 +02:00
7380ac5734
Fixed #35688 -- Restored timezone and role setters to be PostgreSQL DatabaseWrapper methods.
...
Following the addition of PostgreSQL connection pool support in
Refs #33497 , the methods for configuring the database role and timezone
were moved to module-level functions. This change prevented subclasses
of DatabaseWrapper from overriding these methods as needed, for example,
when creating wrappers for other PostgreSQL-based backends.
Thank you Christian Hardenberg for the report and to
Florian Apolloner and Natalia Bidart for the review.
Regression in fad334e1a9
2024-08-28 19:25:07 -03:00
57307bbc7d
Fixed #35666 -- Documented stacklevel usage and testing, and adjusted test suite accordingly.
...
Over the years we've had multiple instances of hit and misses when
emitting warnings: either setting the wrong stacklevel or not setting
it at all.
This work adds assertions for the existing warnings that were declaring
the correct stacklevel, but were lacking tests for it.
2024-08-28 11:44:05 -03:00
39abd56a7f
Refs #35405 -- Adjusted deprecation warning stacklevel in FieldCacheMixin.get_cache_name().
2024-08-28 11:44:05 -03:00
47f18a7226
Refs #35326 -- Adjusted deprecation warning stacklevel in FileSystemStorage.OS_OPEN_FLAGS.
2024-08-28 11:44:05 -03:00
52ed2b645e
Refs #35060 -- Adjusted deprecation warning stacklevel in Model.save()/asave().
2024-08-28 11:44:05 -03:00
a69f895d7d
Refs #34547 -- Adjusted deprecation warning stacklevel in DatabaseOperations.field_cast_sql().
2024-08-28 11:44:05 -03:00
c042fe3a74
Refs #33735 -- Adjusted warning stacklevel in StreamingHttpResponse.__iter__()/__aiter__().
2024-08-28 11:44:05 -03:00
7e6e1c8383
Refs #32339 -- Adjusted deprecation warning stacklevel in transitional form renderers.
2024-08-28 11:44:05 -03:00
6bd5d4f705
Refs #22712 -- Adjusted deprecation warning stacklevel in staticfiles finders.
2024-08-28 11:44:05 -03:00
8ee17037ae
Refs #16055 -- Adjusted deprecation warning stacklevel in get_joining_columns()/get_reverse_joining_columns().
2024-08-28 11:44:05 -03:00
5e81a4e790
Refs #12581 -- Adjusted warning stacklevel in queries ring buffer.
2024-08-28 11:44:05 -03:00
07a4d23283
Refs #34900 -- Updated requirements for Python 3.13.
2024-08-28 09:02:47 -03:00
2b71b2c8dc
Refs #34609 -- Fixed deprecation warning stack level in format_html().
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2024-08-27 15:14:50 -03:00
bc9b6251e0
Added supports_sequence_reset skip in backends tests.
2024-08-26 12:53:08 -03:00
6a85c888bf
Added supports_select_union skips in queries and aggregation tests.
2024-08-26 12:53:08 -03:00
cdcd604ef8
Fixed #35703 -- Made technical_404_response() respect SCRIPT_NAME to return default_urlconf().
2024-08-23 18:07:47 +02:00
f72bbd4480
Fixed #35689 -- Handled custom labels in LabelCommand.missing_args_message.
2024-08-23 17:26:28 +02:00
046a354217
Added helper and refactored PasswordResetFormTest to unify email sending tests.
2024-08-23 11:13:31 -03:00
519087819e
Fixed #35695 -- Ensured FileFields use a storage pointing to a temp directory in model_fields tests.
2024-08-21 08:51:25 -03:00
d9ae7f5b58
Fixed #35686 -- Added table headers to app list tables for screen readers.
2024-08-20 09:05:16 +02:00
231c0d8593
Fixed #35668 -- Added mapping support to format_html_join.
2024-08-20 08:20:34 +02:00
0ebed5fa95
Fixed #35678 -- Removed "usable_password" field from BaseUserCreationForm.
...
Refs #34429 : Following the implementation allowing the setting of
unusable passwords via the admin site, the `BaseUserCreationForm` and
`UserCreationForm` were extended to include a new field for choosing
whether password-based authentication for the new user should be enabled
or disabled at creation time.
Given that these forms are designed to be extended when implementing
custom user models, this branch ensures that this new field is moved to
a new, admin-dedicated, user creation form `AdminUserCreationForm`.
Regression in e626716c28
2024-08-19 12:39:57 -03:00
b60fd8722f
Refs #35678 -- Split tests for BaseUserCreationForm when using a custom User model.
...
This work also allows to subclass BaseUserCreationFormTest to reuse the
tests and assertions for testing forms that extend BaseUserCreationForm,
which is now used for UserCreationFormTest, increasing its coverage.
2024-08-19 12:39:57 -03:00
a57596e443
Refs #35658 -- Fixed test_create_file_field_from_another_file_field_in_memory_storage when run in reverse.
2024-08-15 08:52:19 +02:00
b99c608ea1
Refs #35402 -- Added tests for invalid usage of submodules in some settings.
2024-08-13 16:09:52 +02:00
602fe961e6
Fixed #35665 -- Fixed a crash when passing an empty order_by to Window.
...
This also caused un-ordered sliced prefetches to crash as they rely on Window.
Regression in e16d0c176e#35064 .
Thanks Andrew Backer for the report and Mariusz for the review.
2024-08-13 11:26:17 +02:00
d84200e4eb
Fixed #35648 -- Raised NotImplementedError in SafeString.__add__ for non-string RHS.
...
This change ensures SafeString addition operations handle non-string RHS
properly, allowing them to implement __radd__ for better compatibility.
2024-08-12 14:25:05 -03:00
b5c048f5ec
Refs #35648 -- Added test for addition between SafeString and str in utils_tests.
2024-08-12 14:25:05 -03:00
e03083917d
Fixed #35586 -- Added support for set-returning database functions.
...
Aggregation optimization didn't account for not referenced set-returning annotations on Postgres.
Co-authored-by: Simon Charette <charette.s@gmail.com>
2024-08-12 15:35:19 +02:00
228128618b
Fixed #35575 -- Added support for constraint validation on GeneratedFields.
2024-08-12 13:45:57 +02:00
f883bef054
Refs #35591 -- Removed hardcoded "stable" version in runserver warning.
2024-08-12 10:57:02 +02:00
f16a9a556f
Fixed #35658 -- Initialized InMemoryFileNode instances with a name.
2024-08-09 12:27:15 +02:00
69aa13ffb9
Fixed #35591 -- Added unsuitable for production console warning to runserver.
2024-08-09 10:34:10 +02:00
9582745257
Fixed #35622 -- Made unittest ignore Django assertions in traceback frames.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-08-08 21:34:01 -03:00
e1606d27b4
Added test for acheck_password() to ensure make_password is called for unusable passwords.
...
This is a follow up for the fix of CVE-2024-39329
(5d86458579
2024-08-08 12:53:36 -03:00
7fb15ad5bc
Fixed #35661 -- Fixed test_too_many_digits_to_rander() test crash on PyPy.
...
Thanks Michał Górny for the report.
2024-08-08 09:53:04 +02:00
54888408a1
Fixed #35639 -- Improved admin's delete confirmation page title.
2024-08-07 18:10:49 -03:00
a05187fce6
Fixed i18n.tests.TranslationTests.test_plural to use correct French translation.
...
Forwardport of d5ad743e79
2024-08-07 10:10:28 -03:00
6993c9d8c9
Fixed #35553 -- Handled import*as in HashedFilesMixin.
2024-08-07 11:01:56 +02:00
c87bfaacf8
Fixed CVE-2024-42005 -- Mitigated QuerySet.values() SQL injection attacks against JSON fields.
...
Thanks Eyal (eyalgabay) for the report.
2024-08-06 08:50:08 +02:00
5f1757142f
Fixed CVE-2024-41991 -- Prevented potential ReDoS in django.utils.html.urlize() and AdminURLFieldWidget.
...
Thanks Seokchan Yoon for the report.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-08-06 08:50:08 +02:00
ecf1f8fb90
Fixed CVE-2024-41990 -- Mitigated potential DoS in urlize and urlizetrunc template filters.
...
Thanks to MProgrammer for the report.
2024-08-06 08:50:08 +02:00
c19465ad87
Fixed CVE-2024-41989 -- Prevented excessive memory consumption in floatformat.
...
Thanks Elias Myllymäki for the report.
Co-authored-by: Shai Berger <shai@platonix.com>
2024-08-06 08:50:08 +02:00
8deb6bb1fc
Fixed #35657 -- Made FileField handle db_default values.
2024-08-05 16:36:49 -03:00
509763c799
Fixed #35638 -- Updated validate_constraints to consider db_default.
2024-08-05 17:33:12 +02:00
7f8d839722
Fixed #35628 -- Allowed compatible GeneratedFields for ModelAdmin.date_hierarchy.
2024-08-05 15:27:20 +02:00
d5bebc1c26
Refs #35537 -- Improved documentation and test coverage for email attachments and alternatives.
2024-08-05 09:21:44 +02:00
a16f13a866
Fixed #35643 -- Fixed a crash when ordering a QuerySet by a reference containing "__".
...
Regression in b0ad41198b#34013 . The initial logic did not consider that annotation aliases
can include lookup or transform separators.
Thanks Gert Van Gool for the report and Mariusz Felisiak for the review.
2024-08-02 16:21:12 -03:00
b478cae006
Fixed #35601 -- Added TelInput widget.
2024-08-02 11:31:54 +02:00
946c3cf734
Fixed #35599 -- Added ColorInput widget.
2024-08-02 09:51:49 +02:00
54e8b4e582
Fixed #35489 -- Fixed vertical alignment of raw_id_fields widget.
...
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-08-02 08:56:54 +02:00
aa90795050
Fixed #35646 -- Extended SafeExceptionReporterFilter.hidden_settings to treat `AUTH` as a sensitive match.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-08-01 15:02:00 -03:00
615c80aba6
Improved view_tests.tests.test_debug.ExceptionReporterFilterTests.
2024-08-01 15:02:00 -03:00
1eac690d25
Refs #373 -- Added tuple lookups.
2024-08-01 17:26:09 +02:00
3dac3271d2
Reverted "Fixed #28646 -- Prevented duplicate index when unique is set to True on PostgreSQL."
...
This reverts commit 9cf9c796be
2024-08-01 09:25:33 +02:00
30a60e8492
Fixed #35598 -- Added SearchInput widget.
2024-07-31 13:11:45 +02:00
9cf9c796be
Fixed #28646 -- Prevented duplicate index when unique is set to True on PostgreSQL.
2024-07-30 17:27:10 +02:00
b6ad8b687a
Added missing skips in constraint tests.
2024-07-26 18:59:12 +02:00
1b277b45cc
Added dedicated test for invalid inputs in floatformat template filter tests.
...
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-07-25 16:15:53 -03:00
0e94f292cd
Fixed #35627 -- Raised a LookupError rather than an unhandled ValueError in get_supported_language_variant().
...
LocaleMiddleware didn't handle the ValueError raised by
get_supported_language_variant() when language codes were
over 500 characters.
Regression in 9e9792228a
2024-07-25 09:38:46 +02:00
cd0479ff76
Fixed #35331 -- Updated dropdown lists with entries added via the '+' sign from M2M field.
2024-07-25 08:52:24 +02:00
f359990e49
Fixed #35625 -- Fixed a crash when adding a field with db_default and check constraint.
...
This is the exact same issue as refs #30408 but for creating a model with a
constraint containing % escapes instead of column addition. All of these issues
stem from a lack of SQL and parameters separation from the BaseConstraint DDL
generating methods preventing them from being mixed with other parts of the
schema alteration logic that do make use of parametrization on some backends
(e.g. Postgres, MySQL for DEFAULT).
Prior to the addition of Field.db_default and GeneratedField in 5.0
parametrization of DDL was never exercised on model creation so this is
effectively a bug with db_default as the GeneratedField case was addressed by
refs #35336 .
Thanks Julien Chaumont for the report and Mariusz Felisiak for the review.
2024-07-25 07:48:53 +02:00
8d6a20b656
Fixed #35604 , Refs #35326 -- Made FileSystemStorage.exists() behaviour independent from allow_overwrite.
...
Partially reverts 0b33a3abc2
2024-07-24 14:55:10 +02:00
df35cf578f
Updated asgiref dependency for 5.1 release series.
2024-07-24 08:21:07 +02:00
9f5e2306e2
Refs #29049 -- Fixed isolation of BasicExpressionsTests._test_slicing_of_f_expressions() subtests.
...
Thanks Tim Graham for the report.
2024-07-23 14:29:14 -03:00
b06cf62c88
Cleaned up temporary test directories in tests.
2024-07-22 08:51:01 +02:00
bdd538488c
Fixed #35614 -- Prevented SQLCompiler.as_subquery_condition() from mutating a query.
2024-07-22 08:34:29 +02:00
9cb8baa0c4
Fixed #35559 -- Avoided unnecessary query on sliced union of empty queries.
...
While refs #34125 focused on the SQL correctness of slicing of union of
potentially empty queries it missed an optimization opportunity to avoid
performing a query at all when all queries are empty.
Thanks Lucidiot for the report.
2024-07-19 08:54:47 +02:00
6b3f55446f
Fixed #35603 -- Prevented F.__contains__() from hanging.
...
Regression in 94b6f101f7
2024-07-18 08:39:10 +02:00
182f262b15
Fixed #35606 , Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox for models with a __html__ method.
...
Thank you Claude Paroz for the report.
Regression in 85366fbca7
2024-07-18 08:09:37 +02:00
0e49a8c3bd
Refs #34701 -- Moved UniqueConstraint(nulls_distinct) validation tests.
...
The original tests required the creation of a model that is no longer necessary
and were exercising Model.full_clean(validate_constraints) which has nothing
to do with the nulls_distinct feature.
2024-07-17 12:52:17 +02:00
adc0b6aac3
Fixed #35594 -- Added unique nulls distinct validation for expressions.
...
Thanks Mark Gensler for the report.
2024-07-17 12:52:17 +02:00
13922580cc
Refs #30581 -- Made unattached UniqueConstraint(fields) validation testable.
...
The logic allowing UniqueConstraint(fields).validate to preserve backward
compatiblity with Model.unique_error_message failed to account for cases where
the constraint might not be attached to a model which is a common pattern
during testing.
This changes allows for arbitrary UniqueConstraint(fields) to be tested in
isolation without requiring actual models backing them up.
Co-authored-by: Mark G <mark.gensler@protonmail.com>
2024-07-17 12:52:17 +02:00
5dc17177c3
Refs #10941 -- Renamed test file test_query_string.py to test_querystring.py.
...
This follows previous renames made in 27043bde5b
2024-07-16 22:14:52 -03:00
27043bde5b
Refs #10941 -- Renamed query_string template tag to querystring.
2024-07-15 13:28:55 -03:00
65344f0e1e
Refs #35464 -- Added test to cover layout of TabularInline fieldsets.
2024-07-15 12:43:42 +02:00
86b548a59b
Removed duplicate inline from tests.admin_inlines.admin.PhotographerAdmin.
2024-07-15 11:12:14 +02:00
2d3bb414cf
Refs #35560 -- Corrected required feature flags in GeneratedModelUniqueConstraint.
2024-07-15 10:20:09 +02:00
86e13843c2
Refs #25466 -- Removed unused DeprecationInstanceCheck.
...
Unused since ff419de263
2024-07-11 09:40:07 +02:00
7264d7f750
Fixed syntax of CSS file used in tests.
2024-07-11 08:03:21 +02:00
b9098538a9
Fixed #35033 , Refs #28912 -- Fixed repeated headers in EmailMessage.
...
Fixed a regression which would cause multiple To, Cc, and
Reply-To headers in the result of EmailMessage.message() if
values were supplied for both to/cc/reply_to and the
corresponding extra_headers fields.
Updated related tests to check the generated message() has
exactly one of each expected header using get_all().
Regression in b03d500295
2024-07-11 08:00:46 +02:00
c6d1f98d26
Improved test coverage of urlize.
2024-07-10 09:32:02 +02:00
d12184fedc
Fixed #35424 -- Checked order_with_respect_to is available when migrating _order fields.
...
Migrations would crash following the removal of an order_with_respect_to
field from a model and the addition of an _order field.
2024-07-10 08:40:50 +02:00
9e9792228a
Fixed CVE-2024-39614 -- Mitigated potential DoS in get_supported_language_variant().
...
Language codes are now parsed with a maximum length limit of 500 chars.
Thanks to MProgrammer for the report.
2024-07-09 09:21:19 -03:00
fe4a0bbe20
Fixed CVE-2024-39330 -- Added extra file name validation in Storage's save method.
...
Thanks to Josh Schneier for the report, and to Carlton Gibson and Sarah
Boyce for the reviews.
2024-07-09 09:21:19 -03:00
5d86458579
Fixed CVE-2024-39329 -- Standarized timing of verify_password() when checking unusuable passwords.
...
Refs #20760 .
Thanks Michael Manfre for the fix and to Adam Johnson for the review.
2024-07-09 09:21:19 -03:00
d666457453
Fixed CVE-2024-38875 -- Mitigated potential DoS in urlize and urlizetrunc template filters.
...
Thank you to Elias Myllymäki for the report.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-07-09 09:21:19 -03:00
af84bcc8d1
Fixed #35580 -- Allowed related fields referencing auto-created through models.
2024-07-09 13:50:12 +02:00
759abc4daf
Fixed #35413 -- Made unsupported lookup error message more specific.
2024-07-09 09:15:38 +02:00
1005c2abd1
Fixed #35560 -- Made Model.full_clean() ignore GeneratedFields for constraints.
...
Accessing generated field values on unsaved models caused a crash when
validating CheckConstraints and UniqueConstraints with expressions.
2024-07-04 11:45:15 +02:00
53e674d574
Fixed #35520 -- Avoided opening transaction for read-only ModelAdmin requests.
2024-07-04 11:38:58 +02:00
Jacob Walls
Alex Fischer
sanjeevholla26
John Parton
Sarah Boyce
Adam Johnson
Vaarun Sinha
Claude Paroz
SaJH
Simon Charette
Mariusz Felisiak
Tim Graham
Maarten Breddels
Giovanni Fabbretti
nessita
Hisham Mahmood
nabil-rady
Matthias Kestenholz
Devin Cox
Mark Gensler
lucasesposito
Andrew Miller
Farhan
David Sanders
Jake Howard
arjunomray
Markus Holtermann
Bendeguz Csirmaz
Jeremy Thompson
Ben Cail
Lorenzo Peña
Maryam Yusuf
Tom Carrick
Mike Edmunds
Daniel Patrick
Michael Manfre
jason_bruce
wookkl