2bc47d7fe9
Avoided assignment followed by immediate return.
...
Identified using the following command:
$ pcre2grep --line-number --multiline --recursive \
"(?s)(\n +)(\w+) = [^\n]+\1return \2;?$" \
django docs extras js_tests scripts tests
2022-10-31 12:31:13 +01:00
d3cb91db87
Used more augmented assignment statements.
...
Identified using the following command:
$ git grep -I '\(\<[_a-zA-Z0-9]\+\>\) *= *\1 *[-+/*^%&|<>@]'
2022-10-31 12:30:13 +01:00
a320aab512
Fixed #16211 -- Added logical NOT support to F expressions.
2022-10-31 09:55:51 +01:00
67bc2f1b99
Corrected test_update_or_create_with_model_property_defaults test.
2022-10-29 13:27:10 +02:00
c2cc80756b
Fixed #34125 -- Fixed sliced QuerySet.union() crash on a single non-empty queryset.
...
The bug existed since sliced query union was added but was elevated to
query union slices by moving the .exists() optimization to the compiler
in 3d734c09ff
2022-10-29 09:21:25 +02:00
de2c2127b6
Fixed #34066 -- Fixed link to password reset view in UserChangeForm.password's help text when using to_field.
...
Co-Authored-By: David Sanders <shang.xiao.sanders@gmail.com>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2022-10-27 09:23:34 +02:00
d559cb02da
Refs #19215 -- Fixed admin_widgets tests if Pillow isn't installed.
...
Follow up to c0fc1b5302
2022-10-27 08:41:03 +02:00
350455b666
Fixed #33606 -- Cleansed sessionid cookie in error reports.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2022-10-26 14:39:58 +02:00
b440493eaa
Completed test coverage for contrib.auth.forms.
2022-10-26 12:52:18 +02:00
c0fc1b5302
Fixed #19215 -- Fixed rendering ClearableFileInput when editing with invalid files.
...
Thanks Michael Cardillo for the initial patch.
2022-10-25 16:53:52 +02:00
64e5ef1f17
Fixed #29027 -- Fixed file_move_safe() crash when moving files with SELinux.
...
Thanks Florian Apolloner for the review.
2022-10-24 13:54:51 +02:00
08c5a78726
Fixed #34098 -- Fixed loss of precision for Decimal values in floatformat filter.
...
Regression in 12f7928f5a
2022-10-24 12:59:34 +02:00
1d6948096f
Fixed flaky test_ForeignKey_using_to_field test.
2022-10-24 11:54:00 +02:00
3283120cca
Fixed #34111 -- Made test runner with --debug-sql format SQL queries.
2022-10-24 08:11:30 +02:00
3e928de8ad
Skipped scrypt tests when OpenSSL 1.1+ is not installed.
2022-10-20 18:50:48 -07:00
5c2c7277d4
Fixed #34085 -- Made management commands don't use black for non-Python files.
...
Bug in d113b5a837
2022-10-20 13:38:31 -07:00
d62563cbb1
Fixed #34105 -- Fixed crash of ordering by nested selected expression.
...
This stops ordering by nested selected references. It's not supported on
PostgreSQL and not required to support psycopg3.
Regression in 04518e310d
2022-10-18 17:31:45 -07:00
2a2503c2c1
Completed test coverage for django.core.paginator.
2022-10-13 12:27:41 +02:00
94e7f471c4
Fixed #34069 -- Made LocaleMiddleware respect language from requests when i18n patterns are used.
2022-10-13 10:38:26 +02:00
c4aac2ac1e
Fixed #34042 -- Improved accessibility of admin's navigation sidebar.
2022-10-12 10:21:17 +02:00
f30c7e381c
Completed test coverage for contenttypes models.
2022-10-11 05:38:39 +02:00
6402b064a9
Used test client headers in i18n tests.
2022-10-10 11:46:31 +02:00
84206607d6
Fixed #32833 -- Fixed ContentTypeManager.get_for_models() crash when using in migrations.
...
Co-authored-by: Heraldo Lucena <23155511+HMaker@users.noreply.github.com>
2022-10-10 08:57:52 +02:00
f0c06f8ab7
Refs #33990 -- Renamed TransactionTestCase.assertQuerysetEqual() to assertQuerySetEqual().
...
Co-Authored-By: Michael Howitz <mh@gocept.com>
2022-10-08 08:07:38 +02:00
d795259ea9
Replaced assertQuerysetEqual() to assertSequenceEqual()/assertCountEqual() where appropriate.
...
Follow up to 3f7b327562
2022-10-07 13:05:35 +02:00
564b317fb5
Refs #33990 -- Renamed SimpleTestCase.assertFormsetError() to assertFormSetError().
...
Co-Authored-By: Michael Howitz <mh@gocept.com>
2022-10-07 11:22:16 +02:00
749cd83e13
Removed hardcoded pks in TestQuerying.test_group_by_order_by_aliases test.
2022-10-07 08:26:41 +02:00
7a39a691e1
Fixed #32603 -- Made ModelAdmin.list_editable use transactions.
2022-10-06 20:44:07 +02:00
c6350d594c
Refs #30158 -- Removed alias argument for Expression.get_group_by_cols().
...
Recent refactors allowed GROUP BY aliasing allowed for aliasing to be
entirely handled by the sql.Query.set_group_by and compiler layers.
2022-10-06 12:04:00 +02:00
b7b28c7c18
Refs #31150 -- Enabled implicit GROUP BY aliases.
...
This ensures implicit grouping from aggregate function annotations
groups by uncollapsed selected aliases if supported.
The feature is disabled on Oracle because it doesn't support it.
2022-10-06 11:51:32 +02:00
3d734c09ff
Refs #33992 -- Refactored subquery grouping logic.
...
This required moving the combined queries slicing logic to the compiler
in order to allow Query.exists() to be called at expression resolving
time.
It allowed for Query.exists() to be called at Exists() initialization
time and thus ensured that get_group_by_cols() was operating on the
terminal representation of the query that only has a single column
selected.
2022-10-06 11:38:03 +02:00
04518e310d
Refs #33308 -- Enabled explicit GROUP BY and ORDER BY aliases.
...
This ensures explicit grouping from using values() before annotating an
aggregate function groups by selected aliases if supported.
The GROUP BY feature is disabled on Oracle because it doesn't support it.
2022-10-06 09:34:31 +02:00
c58a8acd41
Fixed #33768 -- Fixed ordering compound queries by nulls_first/nulls_last on MySQL.
...
Columns of the left outer most select statement in a combined query
can be referenced by alias just like by index.
This removes combined query ordering by column index and avoids an
unnecessary usage of RawSQL which causes issues for backends that
specialize the treatment of null ordering.
2022-10-05 14:04:49 +02:00
344d31c7e9
Fixed #34071 -- Improved error message for Range(Min/Max)ValueValidator.
2022-10-05 09:41:01 +02:00
9fbb5b5e16
Fixed #34068 -- Corrected output of runserver command for "0" IP address.
...
Thanks David Sanders for the review.
2022-10-04 10:13:32 +02:00
e5ea284294
Fixed CVE-2022-41323 -- Prevented locales being interpreted as regular expressions.
...
Thanks to Benjamin Balder Bach for the report.
2022-10-04 09:10:04 +02:00
4771a1694b
Fixed #34012 -- Made QuerySet.order_by() apply transforms on related fields for models with Meta.ordering.
...
This makes QuerySet.order_by() no longer ignore trailing transforms for
models with Meta.ordering. As a consequence, FieldError is raised in
such cases for non-existent fields.
Thanks to Klaas van Schelven for the report and Mariusz Felisiak for the
review and advice.
2022-10-04 08:19:34 +02:00
649b28eab6
Fixed #34070 -- Added subsecond support to Now() on SQLite and MySQL.
2022-10-03 12:13:27 +02:00
f71b0cf769
Refs #32987 -- Relaxed system check for template tag modules with the same name by turning into a warning.
...
Thanks Claude Paroz for the report.
Regression in 004b4620f6
2022-10-03 10:52:21 +02:00
3b4a5b9f97
Fixed #23353 -- Used "raise from" when raising TransactionManagementError.
...
This change sets the __cause__ attribute to raised exceptions.
2022-10-03 06:08:54 +02:00
bc3b8f1524
Refs #34058 -- Fixed changing/deleting sequences when altering pre-Django 4.1 auto fields on PostgreSQL.
...
Thanks Anders Kaseorg for the report.
Follow up to 19e6efa50b2eea361eff
2022-10-01 07:53:32 +02:00
5e0aa362d9
Fixed #33984 -- Reverted "Fixed #32980 -- Made models cache related managers."
...
This reverts 4f8c7fd9d9
2022-09-30 18:18:33 +02:00
6cc0f22a73
Fixed #32095 -- Made QuerySet.update_or_create() save only fields passed in defaults or with custom pre_save().
...
Thanks Florian Apolloner for the initial patch.
2022-09-30 06:26:19 +02:00
9b0c9821ed
Fixed #34062 -- Updated View.http_method_not_allowed() to support async.
...
As with the options() methods, wrap the response in a coroutine if
the view is async.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2022-09-29 16:28:44 +02:00
19e6efa50b
Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL.
...
Thanks Anders Kaseorg for the report.
Thanks Florian Apolloner for pair programming.
Regression in 2eea361eff
2022-09-29 13:20:14 +02:00
0f5b11eca0
Refs #34010 -- Made --debug-mode work for parallel tests using spawn.
...
Bug in 3b3f38b3b0
2022-09-28 19:39:25 +02:00
9976f3d4b8
Fixed #34025 -- Fixed selecting ModelAdmin.autocomplete_fields after adding/changing related instances via popups.
...
Regression in c72f6f36c1
2022-09-28 11:28:01 +02:00
6e891a1722
Removed obsolete test_skip_link_is_skipped_when_there_is_searchbar test.
...
searchbar doesn't have autofocus since
d938b3b257
2022-09-28 11:27:11 +02:00
80d38de52b
Fixed #34051 -- Made makemigrations --check exit before making migrations.
2022-09-28 09:48:07 +02:00
1a7b6909ac
Fixed #34052 -- Made migrate --check don't emit signals and output when up to date.
2022-09-27 21:10:30 +02:00
cff1f888e9
Fixed #33464 -- Resolved output_field for combined numeric expressions with MOD operator.
2022-09-27 20:41:10 +02:00
ae3d575ec3
Added tests for QuerySet.update_or_create() with multi-table inheritance.
2022-09-27 12:55:33 +02:00
67c34c1a37
Completed test coverage for createsuperuser command.
2022-09-27 09:57:16 +02:00
cd03e8e2d6
Fixed #34050 -- Replaced invalid chars in migration names with '_'.
...
Thanks to Bishal Gautam for the report and initial implementation.
Regression in fa58450a9a
2022-09-27 08:02:51 +02:00
d938b3b257
Fixed #34040 -- Removed autofocus from admin search box.
2022-09-26 21:06:48 +02:00
f4e592e383
Removed unnecessary MySQL workaround in timezones tests.
...
Unnecessary since 22da5f8817
2022-09-26 13:36:47 +02:00
872b61193b
Refs #34041 -- Added navigation landmark to breadcrumbs in admin.
...
Thanks Thibaud Colas for pair programming.
2022-09-26 08:51:15 +02:00
9f8c994851
Fixed #34027 -- Fixed migrations crash when altering type of char/text fields referenced by foreign key on PostgreSQL.
2022-09-25 20:23:01 +02:00
f3822d4ab0
Fixed #34026 -- Fixed WKBReader.read() crash on string input.
2022-09-24 17:16:08 +01:00
1674c70525
Fixed #34024 -- Fixed crash when aggregating querysets with Q objects annotations.
...
This reverts b64db05b9c#34024
alongside the original tests added in the PR for which
WhereNode.is_summary was introduced.
2022-09-23 15:15:03 +01:00
37a13cc92d
Refs #34012 -- Added test for ordering by transform of related fields.
2022-09-22 12:55:47 +02:00
ce6230aa97
Fixed #34015 -- Allowed filtering by transforms on relation fields.
2022-09-22 00:17:04 +02:00
f88fc72da4
Fixed #34016 -- Fixed QuerySet.values()/values_list() crash on ArrayAgg() and JSONBAgg().
...
Regression in e06dc4571e
2022-09-17 19:38:20 +02:00
ae509f8f08
Fixed #34014 -- Fixed DecimalValidator validating 0 in positive exponent scientific notation.
...
Thanks Shiplu Mokaddim for the report.
2022-09-17 10:02:55 +02:00
229360d7ad
Fixed test_relational_post_delete_signals_happen_before_parent_object when run in isolation.
2022-09-16 11:14:27 +02:00
10178197d5
Fixed #33966 -- Added support for using KeyTextTransform from lookup.
2022-09-16 05:36:57 +02:00
6220c445c4
Fixed #29186 -- Fixed pickling HttpRequest and subclasses.
2022-09-14 13:04:34 +02:00
e14d08cd89
Fixed #33996 -- Fixed CheckConstraint validation on NULL values.
...
Bug in 667105877e
2022-09-13 12:48:31 +02:00
b731e88415
Fixed #31335 -- Fixed removing composed composed Meta constraints/indexes on foreign keys on MySQL.
2022-09-13 10:38:57 +02:00
1b08e9bf7d
Refs #31335 -- Added more tests for removing composed Meta constraints/indexes on foreign keys.
2022-09-12 13:52:06 +02:00
07ebef566f
Refs #34000 -- Optimized handling None values in numberformat.format().
2022-09-12 13:02:50 +02:00
e911e0996f
Fixed #34000 -- Fixed numberformat.format() crash on empty strings.
2022-09-12 12:54:12 +02:00
f3cd252cfc
Fixed #33995 -- Fixed FormSet.empty_form crash when empty_permitted is passed to form_kwargs.
2022-09-09 13:51:47 +02:00
32797e7fbf
Fixed #33975 -- Fixed __in lookup when rhs is a queryset with annotate() and alias().
...
This fixes clearing selected fields.
2022-09-09 08:37:46 +02:00
32536b1324
Fixed #33992 -- Fixed queryset crash when aggregating over a group containing Exists.
...
A more in-depth solution is likely to make sure that we always GROUP BY
selected annotations or revisit how we use Query.exists() in the Exists
expression but that requires extra work that isn't suitable for a
backport.
Regression in e5a92d400a
2022-09-08 05:50:02 +02:00
a2e580acf6
Refs #24179 -- Fixed selenium tests for offset of admin selector boxes in fieldset.
...
Regression in be63c78760
2022-09-07 12:02:08 +02:00
19e838daa8
Fixed #33982 -- Fixed migrations crash when adding model with ExclusionConstraint.
...
Regression in 0e656c02fe
2022-09-07 08:40:56 +02:00
4a1150b41d
Fixed #33616 -- Allowed registering callbacks that can fail in transaction.on_commit().
...
Thanks David Wobrock and Mariusz Felisiak for reviews.
2022-09-06 12:21:36 +02:00
69fa2e8eb2
Refs #26780 -- Made prefetch_related() don't use window expressions fo sliced queries if not supported.
2022-09-06 05:54:35 +02:00
19e0587ee5
Fixed #33937 -- Optimized serialization of related m2m fields without natural keys.
2022-09-05 20:23:32 +02:00
cd1afd553f
Fixed #29799 -- Allowed registering lookups per field instances.
...
Thanks Simon Charette and Mariusz Felisiak for reviews and mentoring
this Google Summer of Code 2022 project.
2022-09-02 10:02:24 +02:00
fdf0f62521
Fixed ReadOnlyPasswordHashWidget's template for RTL languages.
2022-09-01 21:20:15 +02:00
974942a750
Fixed #33955 , Fixed #33971 -- Reverted "Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs."
...
This reverts commit 7f3cfaa12b
2022-09-01 21:09:16 +02:00
e64919ae54
Refs #29799 -- Added more tests for registering lookups.
2022-09-01 09:59:31 +02:00
b3db6c8dcb
Fixed #21204 -- Tracked field deferrals by field instead of models.
...
This ensures field deferral works properly when a model is involved
more than once in the same query with a distinct deferral mask.
2022-08-30 08:43:53 +02:00
5d12650ed9
Refs #21204 -- Added more QuerySet.defer()/only() tests for invalid fields.
2022-08-30 07:09:15 +02:00
a9e7beb959
Refs #33953 -- Fixed test_rename_model_with_db_table_rename_m2m() crash on SQLite < 3.20.
2022-08-29 10:07:53 +02:00
f210de760b
Refs #28333 -- Fixed NonQueryWindowTests.test_invalid_filter() on databases that don't support window expressions.
2022-08-29 09:14:56 +02:00
b92ffebb0c
Fixed #33954 -- Prevented models.DecimalField from accepting NaN, Inf, and -Inf values.
2022-08-27 15:51:08 +02:00
806e9e2d0d
Fixed #33952 -- Reallowed creating reverse foreign key managers on unsaved instances.
...
Thanks Claude Paroz for the report.
Regression in 7ba6ebe914
2022-08-27 15:03:48 +02:00
0701bb8e1f
Fixed #33928 -- Avoided unnecessary queries when cascade updating.
...
Models that use SET, SET_NULL, and SET_DEFAULT as on_delete handler
don't have to fetch objects for the sole purpose of passing them back to
a follow up UPDATE query filtered by the retrieved objects primary key.
This was achieved by flagging SET handlers as _lazy_ and having the
collector logic defer object collections until the last minute. This
should ensure that the rare cases where custom on_delete handlers are
defined remain uncalled when when dealing with an empty collection of
instances.
This reduces the number queries required to apply SET handlers from
2 to 1 where the remaining UPDATE use the same predicate as the non
removed SELECT query.
In a lot of ways this is similar to the fast-delete optimization that
was added in #18676 but for updates this time. The conditions only
happen to be simpler in this case because SET handlers are always
terminal. They never cascade to more deletes that can be combined.
Thanks Renan GEHAN for the report.
2022-08-27 14:25:55 +02:00
166a3b3263
Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel operation a noop for models with db_table."
...
Regression in afeafd6036afeafd6036
2022-08-26 06:14:44 +02:00
71902e0d9f
Fixed #33938 -- Fixed migration crash for m2m with a through model in another app.
...
Regression in aa4acc164d
2022-08-25 10:03:57 +02:00
9942f3fb49
Fixed #33830 -- Fixed VariableDoesNotExist when rendering ClearableFileInput.
2022-08-25 07:52:36 +02:00
16fffc829c
Fixed #33916 -- Added support for serialization of enum.Flag in migrations.
2022-08-25 06:43:48 +02:00
b30c0081d4
Refs #27412 -- Confirmed support for executing Coalesce(subquery).
...
This has been supported for subqueries wrapped in Subquery since the expression
was introduced and for Queryset directly since Subquery resolves to sql.Query.
Piggy-backed on the existing tests covering Coalesce handling of EmptyResultSet
as it seemed like a proper location to combine testing.
2022-08-24 12:30:47 +02:00
897f38fabe
Fixed #33927 -- Fixed crash when displaying ArrayField with choices in admin.
2022-08-23 15:51:42 +02:00
4488a25cc9
Removed unused path variable in model_fields tests.
2022-08-23 15:34:07 +02:00
903ac2f364
Fixed #33949 -- Fixed fixture dirs duplicates with Path instances.
2022-08-23 13:24:18 +02:00
e9fd2b5724
Refs #26511 -- Fixed json.KeyTextTransform() on MySQL/MariaDB.
2022-08-18 21:02:29 +02:00
bd36023100
Used CSS flex for admin's submit row.
2022-08-18 12:29:40 +02:00
e3cb8bcb7d
Fixed #33932 -- Fixed altering AutoFields to OneToOneField on PostgreSQL.
...
Regression in 2eea361eff
2022-08-17 17:06:00 +02:00
d46cc15c51
Fixed #33878 -- Switched to system fonts in CSS.
2022-08-17 10:19:00 +02:00
08688bd7dd
Refs #33916 -- Added tests for serialization of enum.Flag in migrations.
2022-08-16 07:52:27 +02:00
242499f2dc
Fixed #26780 -- Added prefetch_related() support for sliced queries.
...
This was made possible by window function filtering support added in
f387d024fc
2022-08-15 10:25:20 +02:00
f387d024fc
Refs #28333 -- Added partial support for filtering against window functions.
...
Adds support for joint predicates against window annotations through
subquery wrapping while maintaining errors for disjointed filter
attempts.
The "qualify" wording was used to refer to predicates against window
annotations as it's the name of a specialized Snowflake extension to
SQL that is to window functions what HAVING is to aggregates.
While not complete the implementation should cover most of the common
use cases for filtering against window functions without requiring
the complex subquery pushdown and predicate re-aliasing machinery to
deal with disjointed predicates against columns, aggregates, and window
functions.
A complete disjointed filtering implementation should likely be
deferred until proper QUALIFY support lands or the ORM gains a proper
subquery pushdown interface.
2022-08-15 08:26:26 +02:00
f3f9d03edf
Fixed #33901 -- Skipped varchar_pattern_ops/text_pattern_ops index creation when db_collation is set.
2022-08-15 06:28:35 +02:00
5c803bc070
Fixed #33919 -- Fixed adding AutoFields on PostgreSQL.
...
Thanks Jack Calvin Brown for the report.
Regression in 2eea361eff
2022-08-12 17:30:23 +02:00
4fcba800b8
Fixed #33924 -- Deprecated BaseGeometryWidget.map_height/map_width attributes.
2022-08-12 13:26:35 +02:00
e34dfad0a3
Refs #30213 -- Removed post-startup check for Watchman availability.
...
This is checked at startup in get_reloader(). The runtime check ties
the implementation to Watchman excessively.
2022-08-11 11:02:03 +02:00
e0ae1363ec
Fixed #33905 -- Fixed CheckConstraint() validation on range fields.
...
Bug in 667105877e
2022-08-09 20:13:21 +02:00
e0ac72fe80
Refs #33905 -- Added test for CheckConstraint() validation with ArrayField and __contains.
2022-08-09 20:06:59 +02:00
036bb2b74a
Fixed #33895 -- Fixed Case() crash with filters that match everything in When().
...
Thanks shukryzablah for the report.
2022-08-09 07:55:31 +02:00
63884829ac
Fixed #33902 -- Fixed Meta.constraints validation crash with F() expressions.
...
Thanks Adam Zahradník for the report.
Bug in 667105877e
2022-08-09 06:08:48 +02:00
e03cdf76e7
Fixed #31721 -- Allowed ModelForm meta to specify form fields.
2022-08-08 09:46:05 +02:00
88e67a54b7
Added test for non-HTTP request on ASGIStaticFilesHandler.
2022-08-08 07:27:32 +02:00
c0beff2123
Fixed #33899 -- Fixed migration crash when removing indexed field on SQLite 3.35.5+.
...
Regression in 702819227fd0cdd9b581cd99e11d1561d51cbeb.
Thanks cessor for the report.
2022-08-08 06:28:53 +02:00
fd93db97c7
Fixed #33898 -- Fixed Window() expression crash with ArrayAgg().
...
Thanks Kia for the report.
Regression in e06dc4571e
2022-08-06 17:59:31 +02:00
0756c61f2a
Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double submission of admin forms."
...
Regression in fe7dbef586
2022-08-05 16:38:52 +02:00
f476c8847a
Refs #33173 , Refs #33755 -- Fixed ResourceWarning from unclosed files in ASGI tests.
2022-08-04 10:00:36 +02:00
0638b4e23d
Fixed #33888 -- Fixed get_select2_language() crash with no language activated.
...
Regression in 3079133c73
2022-08-03 19:51:25 +02:00
4e13b40a76
Fixed #33887 -- Fixed test_fails_squash_migration_manual_porting() on final tags.
...
Regression in 7c318a8bdd
2022-08-03 16:36:04 +02:00
cb791a2540
Fixed #33872 -- Deprecated django.contrib.postgres.fields.CIText/CICharField/CIEmailField/CITextField.
2022-08-03 11:42:51 +02:00
bd062445cf
Fixed CVE-2022-36359 -- Escaped filename in Content-Disposition header.
...
Thanks to Motoyasu Saburi for the report.
2022-08-03 08:46:31 +02:00
919e65b21e
Updated translations from Transifex.
...
This also fixes related i18n tests.
Forwardport of a3bab93324
2022-08-03 08:04:34 +02:00
ab1955a05e
Fixed #33881 -- Added support for database collations to ArrayField(Char/TextFields).
2022-08-02 11:44:26 +02:00
89e695a69b
Fixed #33876 , Refs #32229 -- Made management forms render with div.html template.
...
Thanks to Claude Paroz for the report.
2022-08-02 10:30:09 +02:00
44c24bf028
Refs #25706 -- Removed inline CSS in the openlayers widget template.
2022-08-01 20:29:49 +02:00
c18861804f
Fixed warnings per flake8 5.0.0.
2022-07-31 08:16:19 +02:00
564437f767
Fixed #33726 -- Added skip-link to admin for keyboard navigation.
2022-07-28 11:52:48 +02:00
9dff316be4
Refs #32948 , Refs #32946 -- Used Q.create() internally for dynamic Q() objects.
...
Node.create() which has a compatible signature with Node.__init__()
takes in a single `children` argument rather than relying in unpacking
*args in Q.__init__() which calls Node.__init__().
In addition, we were often needing to unpack iterables into *args and
can instead pass a list direct to Node.create().
2022-07-27 10:06:24 +02:00
ddf0002bb7
Refs #32948 -- Renamed Node._new_instance() to Node.create().
...
Node._new_instance() was added in
6dd2b5468f
2022-07-27 10:06:24 +02:00
cc52e02c96
Refs #32948 -- Added more tests for django.utils.tree.Node.
...
The tests for creating new instances or copying instances of Node and
its subclasses didn't fully capture the behaviour of the implementation,
particularly around whether the `children` list or is contents were the
same as the source.
2022-07-27 07:58:29 +02:00
769d7cce4a
Used AND, OR, XOR constants instead of hard-coded values.
2022-07-27 07:55:09 +02:00
a1e9e9abc5
Refs #27236 -- Reverted "Refs #27236 -- Added generic mechanism to handle the deprecation of migration operations."
...
This reverts commit 41019e48bb
2022-07-26 11:41:19 +02:00
c773d5794e
Refs #27236 -- Reverted AlterIndexTogether deprecation.
...
This partly reverts a6385b382e
2022-07-26 11:41:19 +02:00
7bdb682215
Fixed BasicExtractorTests.test_makemessages_find_files() test.
2022-07-26 07:23:45 +02:00
2d23a07817
Fixed #33866 -- Added pathlib.Path support to GDALRaster constructor.
2022-07-25 20:48:33 +02:00
f2dd652245
Fixed #33863 -- Fixed JavaScriptCatalog with more than 1 level of fallback translations.
...
Co-authored-by: Carlos Mermingas <cmermingas@gmail.com>
2022-07-25 08:45:46 +02:00
3b79dab19a
Refs #33691 -- Deprecated insecure password hashers.
...
SHA1PasswordHasher, UnsaltedSHA1PasswordHasher, and UnsaltedMD5PasswordHasher
are now deprecated.
2022-07-23 21:29:31 +02:00
0afb65e635
Removed unneeded test suite creation for GIS measure tests.
2022-07-23 15:57:05 +02:00
4d4bf55e0e
Fixed #33864 -- Deprecated length_is template filter.
2022-07-23 12:36:21 +02:00
f810325721
Refs #27236 -- Made cosmetic edits to Meta.index_together deprecation.
...
This should make it more straightforward to move forward when
deprecation ends.
2022-07-21 07:05:50 +02:00
24effbceb8
Fixed #33855 -- Removed unnecessary system check calls from test worker initialization.
...
Regression in 3b3f38b3b0
2022-07-19 09:45:11 +02:00
3e3e814166
Fixed #33854 -- Corrected the order of parameters in dbshell on PostgreSQL.
2022-07-18 06:30:20 +02:00
d4c5d2b52c
Fixed #33631 -- Marked {% blocktranslate asvar %} result as HTML safe.
2022-07-14 11:09:19 +02:00
a6385b382e
Fixed #27236 -- Deprecated Meta.index_together in favor of Meta.indexes.
...
This also deprecates AlterIndexTogether migration operation.
2022-07-12 09:04:31 +02:00
4f284115a9
Refs #27236 -- Split RenameField() tests with unique/index_together.
2022-07-12 06:38:03 +02:00
f8f16b3cd8
Refs #27236 -- Removed usage of Meta.index_together from indexes/introspection test models.
2022-07-11 08:30:19 +02:00
77330a089c
Fixed typo in tests/sitemaps_tests/test_http.py.
2022-07-11 08:25:04 +02:00
eb3699ea77
Fixed #33718 -- Dropped support for MySQL 5.7.
2022-07-08 13:30:12 +02:00
ccbf714ebe
Fixed #33829 -- Made BaseConstraint.deconstruct() and equality handle violation_error_message.
...
Regression in 667105877e
2022-07-08 08:17:42 +02:00
41019e48bb
Refs #27236 -- Added generic mechanism to handle the deprecation of migration operations.
2022-07-08 07:05:55 +02:00
608ab043f7
Fixed #33826 -- Fixed RedisCache.set_many()/delete_many() crash with an empty list.
2022-07-06 10:45:52 +02:00
3926e35aa8
Fixed #33823 -- Made inspectdb generate unique related_name when reverse accessor clashes.
2022-07-06 09:35:50 +02:00
877c800f25
Refs CVE-2022-34265 -- Properly escaped Extract() and Trunc() parameters.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2022-07-06 07:40:07 +02:00
73766c1187
Fixed RelatedGeoModelTest.test08_defer_only() on MySQL 8+ with MyISAM storage engine.
2022-07-05 19:05:03 +02:00
18c5ba07cc
Fixed #33822 -- Fixed save() crash on model formsets when not created by modelformset_factory().
...
Thanks Claude Paroz for the report.
Regression in e87f57fdb8
2022-07-05 07:19:18 +02:00
249ecc437f
Fixed #33815 -- Fixed last_executed_query() on Oracle when parameter names overlap.
2022-07-05 05:53:49 +02:00
54eb8a374d
Fixed CVE-2022-34265 -- Protected Trunc(kind)/Extract(lookup_name) against SQL injection.
...
Thanks Takuto Yoshikai (Aeye Security Lab) for the report.
2022-07-04 08:13:41 +02:00
425718726b
Fixed #33816 -- Fixed QuerySet.only() after select_related() crash on proxy models.
2022-07-04 06:37:36 +02:00
863aa7541d
Fixed GEOSTest.test_emptyCollections() on GEOS 3.8.0.
...
It's a regression in GEOS 3.8.0 fixed in GEOS 3.8.1.
2022-07-01 19:05:27 +02:00
03eec9ff6c
Updated vendored _urlsplit() to strip newline and tabs.
...
Refs Python CVE-2022-0391. Django is not affected, but others who
incorrectly use internal function url_has_allowed_host_and_scheme()
with unsanitized input could be at risk.
2022-07-01 08:48:38 +02:00
72e41a0df6
Fixed #33779 -- Allowed customizing encoder class in django.utils.html.json_script().
2022-06-28 10:54:38 +02:00
d4d5427571
Refs #33697 -- Used django.utils.http.parse_header_parameters() for parsing boundary streams.
...
This also removes unused parse_header() and _parse_header_params()
helpers in django.http.multipartparser.
2022-06-28 09:42:47 +02:00
eb7b8f3699
Fixed #33805 -- Made admin's many-to-many widgets do not display help text for selecting values when allow_multiple_selected is False.
2022-06-28 06:04:42 +02:00
44ffd8d06f
Fixed #33796 -- Fixed ordered combined queryset crash when used in subquery on PostgreSQL and MySQL.
...
Thanks Shai Berger for the report.
Regression in 30a0144134
2022-06-27 06:21:31 +02:00
083bfca6b6
Fixed #33800 -- Fixed system check for the same template tag module in installed apps and template tag libraries.
...
Thanks Claude Paroz for the report.
Regression in 004b4620f6
2022-06-23 20:22:59 +02:00
c627226d05
Fixed #33799 , Refs #31685 -- Added parameters for updating conflicts to QuerySeta.abulk_create().
2022-06-23 11:12:35 +02:00
e6f36ea0a9
Made HashedFilesMixin ignore URLs without a path.
2022-06-23 08:59:49 +02:00
d80a258553
Fixed #33028 -- Used ModelAdmin's opts attribute instead of model._meta.
2022-06-22 07:50:24 +02:00
de74a74b4b
Fixed #33794 -- Fixed string-casting of GIS queries on PostgreSQL.
...
Regression in 64c3f049ea
2022-06-21 10:10:37 +02:00
2887b9f67c
Fixed #33657 -- Allowed customizing formatter class of argument parsers.
2022-06-20 17:34:52 +02:00
d7f5bfd241
Fixed #32969 -- Fixed pickling HttpResponse and subclasses.
2022-06-20 08:51:26 +02:00
901a169198
Fixed #23689 -- Made parsing HTTP Accept-Language header case-insensitive.
...
Thank you Daniel Samuels for test project.
2022-06-20 07:40:28 +02:00
8d160f154f
Fixed #33788 -- Added TrigramStrictWordSimilarity() and TrigramStrictWordDistance() on PostgreSQL.
2022-06-17 11:14:30 +02:00
3ef37a5245
Fixed #28897 -- Fixed QuerySet.update() on querysets ordered by annotations.
2022-06-17 10:06:17 +02:00
f4680a112d
Refs #28897 -- Added test for QuerySet.update() on querysets ordered by inline m2m annotation.
2022-06-17 10:06:12 +02:00
e286ce17ff
Fixed #24870 -- Added --update option to makemigrations command.
2022-06-17 07:50:39 +02:00
2a2bde52f3
Updated asgiref dependency for 4.1 release series.
2022-06-16 12:13:15 +02:00
d287294885
Fixed #33772 -- Added QuerySet.first()/last() error message on unordered queryset with aggregation.
2022-06-14 12:24:43 +02:00
db588d4f0e
Refs #27236 -- Split index_together and unique_together autodetector tests.
2022-06-13 09:03:36 +02:00
457cfd6f39
Refs #27236 -- Added test_autodetector.BaseAutodetectorTests.
2022-06-13 08:55:25 +02:00
de1c8320ce
Fixed #33773 -- Made Index with multiple fields respect DEFAULT_INDEX_TABLESPACE.
...
Thanks to Simon Charette for locating where issue lay.
2022-06-13 07:21:46 +02:00
4996eaa7b5
Made QuerySet.bulk_update() raise an error when batch_size is zero.
2022-06-13 06:25:25 +02:00
e96320c917
Fixed #33755 -- Moved ASGI body-file cleanup into request class.
2022-06-09 11:11:45 +02:00
c32858a8ce
Fixed #33565 -- Improved locale format validation for the makemessages command.
2022-06-08 16:17:12 +02:00
aaf00450d2
Removed obsolete assertions in BooleanFieldTests.test_return_type().
...
Added in e9bbdb39dee9103402c0
2022-06-03 21:28:46 +02:00
00639dbd6d
Refs #33765 -- Added tests for trailing whitespace in JavaScript source map references.
2022-06-03 20:07:35 +02:00
286e7d076c
Fixed #33764 -- Deprecated BaseUserManager.make_random_password().
2022-06-03 07:30:57 +02:00
a3a1290d47
Refs #27236 -- Moved models with Meta.index_together inside of test methods.
2022-06-03 06:32:11 +02:00
fbac2a4dd8
Fixed #33700 -- Skipped extra resolution for successful requests not ending with /.
...
By moving a should_redirect_with_slash call out of an if block, commit
9390da7fb6434d309ef6#24720 ).
Meanwhile, the logging issue #26293 that it targeted was subsequently
fixed more fully by commit 40b69607c7#26504 ), so it is no longer needed. This effectively reverts it.
This speeds up successful requests not ending with / when APPEND_SLASH
is enabled (the default, and still useful in projects with a mix of
URLs with and without trailing /). The amount of speedup varies from
about 5% in a typical project to nearly 50% on a benchmark with many
routes.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2022-06-02 15:15:04 +02:00
798b6c23ee
Fixed #31788 -- Fixed migration optimization after altering field to ManyToManyField.
...
This makes AddField() used for altering to ManyToManyField, dependent
on the prior RemoveField.
2022-06-02 12:10:27 +02:00
6f73eb9d90
Fixed #33742 -- Added id to GeoJSON serializer.
2022-06-01 19:11:26 +02:00
9a3b7e5e2b
Refs #32234 -- Removed hardcoded IntegerField in inspectdb test.
2022-06-01 19:10:38 +02:00
46efd03d26
Fixed #33733 -- Preserved wrapper assignment for manager methods.
2022-06-01 10:44:34 +02:00
0982cf2a01
Refs #33733 -- Added tests for attributes of manager methods.
2022-06-01 10:44:34 +02:00
93cedc82f2
Refs #33697 -- Fixed multipart parsing of headers with double quotes and semicolons.
...
See 1ef0c0349e
2022-06-01 10:11:07 +02:00
295249c901
Fixed #32234 -- Made inspectdb inform about composite primary keys.
2022-06-01 08:40:44 +02:00
1058fc7023
Fixed #33191 -- Avoided clearing cached reference when saving child after parent.
...
Thanks Barry Johnson for the report.
2022-05-31 10:19:54 +02:00
f1e0fc645b
Fixed #33754 -- Fixed crash with prematurely closed ASGI request body.
...
Regression in 441103a04d
2022-05-31 08:38:00 +02:00
292f372768
Fixed #33748 -- Fixed date template filter crash with lazy format.
...
Regression in 659d2421c7
2022-05-31 06:09:39 +02:00
8c0886b068
Fixed #22078 -- Fixed crash of Feed with decorated methods.
2022-05-26 10:39:51 +02:00
7e4656e4b2
Refs #22078 -- Added syndication test for feeds with static methods.
2022-05-26 09:08:34 +02:00
b949e40e8c
Fixed #23740 -- Fixed removing unique_together constraint if exists primary key/unique constraint on the same field.
2022-05-26 08:33:07 +02:00
8cf4de206c
Normalized decorator style for functools.wraps.
2022-05-25 10:58:48 +02:00
aff649a3bd
Normalized imports of functools.wraps.
...
@wraps is 10 times more common than @functools.wraps. Standardize to
the most common version.
2022-05-25 10:58:28 +02:00
6485894157
Renamed wrapped functions to wrapper.
...
All these functions are wrapping another function. They're the wrapper,
while the function they're wrapping is the wrapped.
2022-05-25 10:53:52 +02:00
241fe59b74
Refs #22078 -- Added syndication test for feeds with callable objects.
2022-05-23 06:16:26 +02:00
1733c888f4
Refs #33725 -- Replaced deprecated find_element_by_css_selector() with find_elements(By.CSS_SELECTOR, …).
...
Follow up to 90dcf271142ccc0b22db
2022-05-23 06:06:37 +02:00
90dcf27114
Fixed #33725 -- Made hidden quick filter in admin's navigation sidebar not focusable.
...
Regression in d915dd1c58780473d756
2022-05-21 13:37:53 +02:00
0dd2920909
Fixed #33653 -- Fixed template crash when calling methods for built-in types without required arguments.
...
Regression in 09341856ed
2022-05-20 07:53:05 +02:00
1a78ef2b85
Fixed #33715 -- Allowed keyboard interrupt to abort queries in MySQL dbshell.
2022-05-20 07:11:51 +02:00
41c4cb253c
Fixed #33719 -- Fixed test command crash when running in parallel.
...
Thanks Pēteris Caune for the report.
Regression in 3b3f38b3b0
2022-05-19 10:20:51 +02:00
981c23c0cc
Fixed #33717 -- Dropped support for PostgreSQL 11.
2022-05-19 09:26:48 +02:00
9f55489529
Fixed #33705 -- Fixed crash when using IsNull() lookup in filters.
...
Thanks Florian Apolloner for the report.
Thanks Simon Charette for the review.
2022-05-19 07:02:22 +02:00
19297de2fe
Fixed #33713 -- Dropped support for MariaDB 10.3.
2022-05-18 08:38:08 +02:00
2cec020f5b
Refs #33379 -- Fixed minimum supported version of MariaDB.
2022-05-17 14:59:28 +02:00
3c6f1fd1f8
Increased the default PBKDF2 iterations for Django 4.2.
2022-05-17 14:22:06 +02:00
cdb2f7f36c
Advanced deprecation warnings for Django 4.2.
2022-05-17 14:22:06 +02:00
d126eba363
Refs #32339 -- Deprecated default.html form template.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2022-05-17 11:16:54 +02:00
7f3cfaa12b
Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs.
...
Moved the functionality of URLResolver._is_callback(),
URLResolver._callback_strs, URLPattern.lookup_str() to
django.contrib.admindocs.
2022-05-17 10:50:09 +02:00
97f124f39e
Refs #27064 -- Made migrations generate RenameIndex operations when moving indexes from index_together to Meta.indexes.
2022-05-17 07:21:36 +02:00
c6cec3c2d2
Refs #27064 -- Made migrations generate RenameIndex operations when renaming Meta.indexes.
2022-05-16 17:46:24 +02:00
11310e9abb
Fixed #33710 -- Made RenameIndex operation a noop when the old and new name match.
2022-05-16 10:36:56 +02:00
76af861356
Fixed #27550 -- Allowed GEOSGeometry.normalize() to return a normalized clone.
2022-05-16 06:46:53 +02:00
d27e6b233f
Fixed #33681 -- Made Redis client pass CACHES["OPTIONS"] to a connection pool.
...
Thanks Ben Picolo for the report.
2022-05-16 06:17:40 +02:00
d3677043fc
Added backward compatibility test for ConnectionHandler.databases property.
...
The ConnectionHandler.databases property is no longer used within
Django, but it is maintained for backward compatibility with 3rd party
packages that have used this private API in the past.
2022-05-13 12:01:07 +02:00
c112f837d4
Fixed #33704 -- Updated postgres_tests migrations.
2022-05-13 11:23:21 +02:00
eacd4977f6
Refs #27064 -- Added RenameIndex migration operation.
2022-05-12 20:44:03 +02:00
3a82b5f655
Fixed #32559 -- Added 'step_size’ to numeric form fields.
...
Co-authored-by: Jacob Rief <jacob.rief@uibk.ac.at>
2022-05-12 14:16:52 +02:00
68da6b389c
Fixed #33543 -- Deprecated passing nulls_first/nulls_last=False to OrderBy and Expression.asc()/desc().
...
Thanks Allen Jonathan David for the initial patch.
2022-05-12 11:30:03 +02:00
2798c937de
Fixed #29538 -- Fixed crash of ordering by related fields when Meta.ordering contains expressions.
...
Thanks Simon Charette for the review.
2022-05-12 07:19:16 +02:00
34e2148fc7
Refs #33173 -- Removed use of deprecated cgi module.
...
https://peps.python.org/pep-0594/#cgi
2022-05-11 14:06:31 +02:00
02dbf1667c
Fixed #33691 -- Deprecated django.contrib.auth.hashers.CryptPasswordHasher.
2022-05-11 09:13:45 +02:00
262fde94de
Fixed #33622 -- Allowed customizing error messages for invalid number of forms.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2022-05-10 13:42:31 +02:00
667105877e
Fixed #30581 -- Added support for Meta.constraints validation.
...
Thanks Simon Charette, Keryn Knight, and Mariusz Felisiak for reviews.
2022-05-10 11:22:23 +02:00
439cd73c16
Refs #33173 -- Fixed test_dateparse tests on Python 3.11+.
...
date/datetime/time.fromisoformat() support any valid ISO 8601 format
in Python 3.11+, see https://github.com/python/cpython/issues/80010 .
2022-05-09 10:38:11 +02:00
dddc8bc47d
Fixed #33679 -- Fixed the last inline's id in admin for users without add permissions.
2022-05-06 08:36:04 +02:00
ec5659382a
Fixed #32339 -- Added div.html form template.
2022-05-05 14:32:43 +02:00
27b07a3246
Refs #30581 -- Moved CheckConstraint tests for conditional expressions to migrations.test_operations.
...
This allows avoiding warning in tests about using RawSQL in
CheckConstraints.
2022-05-05 06:44:34 +02:00
8f04473af1
Fixed #25105 -- Checked deferred constraints before updating rows on PostgreSQL.
2022-05-04 12:15:00 +02:00
5d91dc8ee3
Refs #30581 -- Added Q.check() hook.
2022-05-04 08:47:52 +02:00
37470bbd90
Fixed #33675 -- Dropped support for PostgreSQL 10 and PostGIS 2.4.
2022-05-04 06:28:51 +02:00
9d04711261
Refs #30581 -- Added Q.flatten().
2022-05-03 15:31:53 +02:00
aa8b9279e4
Fixed CoveringIndexTests.test_covering_partial_index() when DEFAULT_INDEX_TABLESPACE is set.
2022-05-03 14:22:34 +02:00
271a8e73ee
Refs #33646 -- Made QuerySet.raw() async-compatible.
2022-05-02 10:52:33 +02:00
aca9bb2a12
Fixed #33413 -- Made migrations propage collations to related fields.
2022-05-02 08:13:38 +02:00
694cf458f1
Removed 'tests' path prefix in a couple tests.
2022-05-02 06:21:18 +02:00
1b3a949ba2
Refs #33671 -- Fixed migrations crash when adding collation to a primary key on Oracle.
2022-04-29 21:43:55 +02:00
b34238addc
Fixed #33670 -- Fixed altering primary key on SQLite.
2022-04-29 20:16:34 +02:00
aa28c392b9
Fixed #33661 -- Corrected Catalan date-format localization.
...
Changed DATE_FORMAT, DATETIME_FORMAT and MONTH_DAY_FORMAT
to use E placeholder (Month, locale specific alternative)
to handle both “de gener” and contracted “d’abril” cases.
Thanks to Ferran Jovell for review.
2022-04-28 15:12:15 +02:00
476d4d5087
Refs #32339 -- Allowed renderer to specify default form and formset templates.
...
Co-authored-by: David Smith <smithdc@gmail.com>
2022-04-27 10:21:04 +02:00
58b27e0dbb
Fixed #33646 -- Added async-compatible interface to QuerySet.
...
Thanks Simon Charette for reviews.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2022-04-26 20:25:23 +02:00
27aa7035f5
Fixed #27471 -- Made admin's filter choices collapsable.
2022-04-26 08:44:31 +02:00
37602e4948
Fixed #33656 -- Fixed MultiWidget crash when compressed value is a tuple.
2022-04-26 07:06:26 +02:00
4282fd468f
Fixed #33655 -- Removed unnecessary constant from GROUP BY clause for QuerySet.exists().
2022-04-26 06:19:18 +02:00
dcebc5da48
Refs #2259 -- Disallowed primary keys in ModelAdmin.list_editable.
...
Refs #32728 .
2022-04-25 11:00:50 +02:00
0de89b6f8d
Refs #31223 -- Added __class_getitem__() to ForeignKey.
2022-04-22 14:13:12 +02:00
eeb0bb6379
Refs #27674 --- Deprecated django.contrib.gis.admin.OpenLayersWidget.
2022-04-22 11:36:27 +02:00
6f453cd298
Fixed #33509 -- Added "(no-op)" to sqlmigrate output for operations without SQL statement.
2022-04-21 12:25:16 +02:00
f15f7d395c
Refs #33509 -- Made sqlmigrate tests stricter and improved isolation.
2022-04-21 12:21:46 +02:00
cd4da34fc1
Fixed #33004 -- Made saving objects with unsaved GenericForeignKey raise ValueError.
...
This aligns to the behaviour of OneToOneField and ForeignKey fields.
Thanks Jonny Park for the initial patch.
2022-04-21 10:12:28 +02:00
1ed8ca43f6
Refs #13085 -- Removed unnecessary ManyToManyFields from generic_relations_regress test models.
2022-04-21 09:59:09 +02:00
5dfa6fca96
Refactored out RedirectURLMixin.get_success_url().
...
This also adds a default implementation of get_default_redirect_url().
2022-04-20 10:04:29 +02:00
04bc2564b6
Simplified LogoutView.get_success_url().
...
This preserves the behavior of redirecting to the logout URL without
query string parameters when an insecure ?next=... parameter is given.
It changes the behavior of a POST to the logout URL, as shown by the
test that is changed. Currently, this results in a GET to the logout
URL. However, such GET requests are deprecated. This change would be
necessary in Django 5.0 anyway. This commit merely anticipates it.
2022-04-20 10:04:29 +02:00
bf7c51a5f4
Fixed #33639 -- Enabled cached template loader in development.
2022-04-19 12:13:27 +02:00
f4f2afeb45
Refs #32226 -- Fixed JSON format of QuerySet.explain() on PostgreSQL when format is uppercased.
...
Follow up to aba9c2de66
2022-04-19 08:24:24 +02:00
5591a72571
Fixed #33648 -- Prevented extra redirect in LogoutView on invalid next page when LOGOUT_REDIRECT_URL is set.
2022-04-18 16:33:10 +02:00
8e89dfe1c2
Fixed various tests on MySQL with MyISAM storage engine.
2022-04-18 07:05:52 +02:00
331a460f8f
Fixed DatabaseFeatures.uses_savepoints/can_release_savepoints and related tests with MyISAM storage engine.
2022-04-18 07:05:52 +02:00
e12670016b
Fixed #33643 -- Fixed inspectdb crash on functional unique constraints on Oracle.
2022-04-16 15:29:51 +02:00
a1e4e86f92
Fixed #33607 -- Made PostgresIndex.create_sql() respect the "using" argument.
2022-04-15 22:00:28 +02:00
c72f6f36c1
Fixed #11803 -- Allowed admin select widgets to display new related objects.
...
Adjusted admin javascript to add newly created related objects to
already loaded select widgets.
In this version, applies only where limit_choices_to is not set.
2022-04-15 07:46:37 +02:00
1760ad4e8c
Relaxed some query ordering assertions in various tests.
...
It accounts for differences seen on MySQL with MyISAM storage engine.
2022-04-14 12:12:13 +02:00
5c67d906fd
Removed stale Windows asyncio test skips.
...
Underlying issue was fixed in Python 3.8.1, now many versions ago.
https://bugs.python.org/issue38563
2022-04-14 10:43:34 +02:00
a0bd006306
Made select_for_update() don't raise TransactionManagementError on databases that don't support transactions.
2022-04-14 07:53:15 +02:00
db83ac48d4
Expanded QuerySet.explain() error message if a backend supports no formats.
2022-04-14 06:46:42 +02:00
2eea361eff
Fixed #30511 -- Used identity columns instead of serials on PostgreSQL.
2022-04-13 21:51:51 +02:00
fdfb3086fc
Fixed DatabaseFeatures.supports_index_column_ordering and related tests with MyISAM storage engine.
2022-04-13 11:56:24 +02:00
1bdfde0857
Fixed typo in SchemaIndexesMySQLTests.test_no_index_for_foreignkey().
2022-04-13 11:56:24 +02:00
a65547c04a
Fixed tests on databases that don't support introspecting foreign keys.
2022-04-13 11:52:40 +02:00
0b63124c84
Improved ExplainTests.test_basic().
...
QuerySet.select_for_update() is not supported by all databases.
Moreover it cannot be used outside of a transaction.
2022-04-13 10:17:14 +02:00
27d52158b2
Fixed #33627 -- Improved nonexistent pk in ModelMultipleChoiceFieldTests.test_model_multiple_choice_field().
2022-04-13 08:31:23 +02:00
1bb9bd9724
Fixed #33633 -- Skipped some test_utils tests on databases that don't support transactions.
2022-04-12 13:37:44 +02:00
0ad5316f22
Fixed #24296 -- Made QuerySet.exists() clear selected columns for not sliced distinct querysets.
2022-04-12 08:18:22 +02:00
d2263b7b87
Refs #18414 -- Added tests for selected columns of sliced distinct querysets.
2022-04-12 08:18:22 +02:00
06ebaa9e28
Fixed #33626 -- Cleared cache when unregistering a lookup.
2022-04-12 06:24:02 +02:00
b8759093d8
Removed DatabaseFeatures.validates_explain_options.
...
Always True since 6723a26e59
2022-04-11 12:58:01 +02:00
6723a26e59
Fixed CVE-2022-28347 -- Protected QuerySet.explain(**options) against SQL injection on PostgreSQL.
2022-04-11 08:59:58 +02:00
93cae5cb2f
Fixed CVE-2022-28346 -- Protected QuerySet.annotate(), aggregate(), and extra() against SQL injection in column aliases.
...
Thanks Splunk team: Preston Elder, Jacob Davis, Jacob Moore,
Matt Hanson, David Briggs, and a security researcher: Danylo Dmytriiev
(DDV_UA) for the report.
2022-04-11 08:59:33 +02:00
62739b6e26
Fixed #33628 -- Ignored directories with empty names in autoreloader check for template changes.
...
Regression in 68357b2ca9
2022-04-11 07:37:30 +02:00
0b31e02487
Fixed #33618 -- Fixed MTI updates outside of primary key chain.
2022-04-07 07:54:56 +02:00
9ffd4eae2c
Fixed #33611 -- Allowed View subclasses to define async method handlers.
2022-04-07 07:05:59 +02:00
2ee4caf56b
Refs #33173 -- Fixed test_runner/test_utils tests on Python 3.11+.
...
Python 3.11 uses fully qualified test name in unittest output. See
755be9b150
2022-04-07 07:02:21 +02:00
bfe9665502
Skipped SchemaTests.test_alter_field_type_and_db_collation on databases that don't support collation on TextField.
2022-04-06 16:52:13 +02:00
65effbdb10
Fixed #33471 -- Made AlterField operation a noop when changing "choices".
...
This also allows customizing attributes of fields that don't affect
a column definition.
2022-04-06 13:05:57 +02:00
6991880109
Refs #31617 -- Added an id for helptext in admin forms.
2022-04-06 12:42:43 +02:00
50e1e7ef8e
Fixed #33348 -- Changed SimpleTestCase.assertFormError()/assertFormsetErrors() to take form/formset.
...
Instead of taking a response object and a context name for
the form/formset, the two methods now take the object directly.
2022-04-06 07:58:52 +02:00
1a7d75cf77
Moved remaining SimpleTestCase.assertFormError()/assertFormsetErrors() tests to test_utils.
...
This also removes redundant tests in test_client_regress.
Follow up to 68144f4049
2022-04-05 08:37:28 +02:00
2d5215c675
Fixed #33605 -- Fixed migration crash when altering RegexValidator to pre-compiled regular expression.
2022-04-04 07:38:15 +02:00
13a9cde133
Fixed #33613 -- Made createsuperuser detect uniqueness of USERNAME_FIELD when using Meta.constraints.
2022-04-01 11:39:41 +02:00
40b8a6174f
Fixed #33397 -- Corrected resolving output_field for DateField/DateTimeField/TimeField/DurationFields.
...
This includes refactoring of CombinedExpression._resolve_output_field()
so it no longer uses the behavior inherited from Expression of guessing
same output type if argument types match, and instead we explicitly
define the output type of all supported operations.
This also makes nonsensical operations involving dates
(e.g. date + date) raise a FieldError, and adds support for
automatically inferring output_field for cases such as:
* date - date
* date + duration
* date - duration
* time + duration
* time - time
2022-03-31 11:05:23 +02:00
c8459708a7
Refs #32339 -- Added use_fieldset to Widget.
2022-03-30 16:28:14 +02:00
04ad0f26ba
Refs #33397 -- Added extra tests for resolving an output_field of CombinedExpression.
2022-03-30 11:03:48 +02:00
fac662f479
Fixed #33598 -- Reverted "Removed unnecessary reuse_with_filtered_relation argument from Query methods."
...
Thanks lind-marcus for the report.
This reverts commit 0c71e0f9cf0c71e0f9cf
2022-03-30 07:31:56 +02:00
59ab3fd0e9
Refs #32365 -- Deprecated django.utils.timezone.utc.
2022-03-29 14:47:44 +02:00
baf9604ed8
Fixed #16406 -- Added ResolveMatch.captured_kwargs and extra_kwargs.
...
Thanks Florian Apolloner for the review and implementation idea.
2022-03-29 10:27:40 +02:00
eb07b5be0c
Fixed #15619 -- Deprecated log out via GET requests.
...
Thanks Florian Apolloner for the implementation idea.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2022-03-29 06:42:14 +02:00
abfdb4d7f3
Reverted "Fixed forms_tests.tests.test_renderers with Jinja 3.1.0+."
...
This reverts commit 1d9d082acf
2022-03-26 12:27:30 +01:00
2bee0b4328
Fixed #7497 -- Allowed overriding the order of apps and models in admin.
2022-03-25 10:33:44 +01:00
d44951b36e
Refs #7497 -- Added assertion for the default order of models in AdminSite.app_index().
2022-03-25 10:29:59 +01:00
1d9d082acf
Fixed forms_tests.tests.test_renderers with Jinja 3.1.0+.
...
See https://github.com/pallets/jinja/pull/1621 .
2022-03-25 08:48:32 +01:00
94d8ed55fa
Refs #15619 -- Logged out with POST requests in admin.
2022-03-24 17:41:53 +01:00
1b695fbbc2
Refs #33577 -- Used addCleanup() to remove .aux file in GDALBandTests.
...
Follow up to 970f5bf503
2022-03-24 09:13:24 +01:00
bb61f0186d
Refs #32365 -- Removed internal uses of utils.timezone.utc alias.
...
Remaining test case ensures that uses of the alias are mapped
canonically by the migration writer.
2022-03-24 06:29:50 +01:00
1cf60ce601
Fixed #33569 -- Added SECURE_PROXY_SSL_HEADER support for list of protocols in the header value.
2022-03-23 19:33:36 +01:00
d46e158ee2
Refs #32365 -- Made migration writer use datetime.timezone.utc.
2022-03-23 12:43:43 +01:00
7325d29152
Refs #30581 -- Fixed DatabaseFeatures.bare_select_suffix on MySQL < 8 and MariaDB < 10.4.
2022-03-22 09:45:59 +01:00
4b66a5e617
Fixed #33256 -- Fixed schema test failures when using --keepdb.
2022-03-21 20:54:48 +01:00
561761c660
Fixed #33592 -- Fixed "View on Site" links in custom admin site.
2022-03-21 10:07:32 +01:00
4b8e4f5060
Fixed #33582 -- Fixed deserializing natural keys with foreing key dependencies in a multiple database setup.
2022-03-18 20:57:08 +01:00
ed6db53542
Fixed isolation of FeaturesTests.test_supports_json_field_operational_error().
2022-03-18 20:57:08 +01:00
ba298a32b3
Refs #31169 -- Prevented infinite loop in parallel tests with custom test runner when using spawn.
...
Regression in 3b3f38b3b0
2022-03-17 10:20:13 +01:00
4f92cf87b0
Prevented initialization of unused database connections.
2022-03-17 07:40:57 +01:00
13378ad952
Moved ensure_defaults() and prepare_test_settings() logic to ConnectionHandler.configure_settings().
2022-03-17 07:36:34 +01:00
58ad9a99a7
Removed usage of django.db.utils.ConnectionHandler.databases.
2022-03-17 07:36:34 +01:00
bf524d229f
Refs #30581 -- Allowed sql.Query to be used without model.
2022-03-16 09:33:16 +01:00
970f5bf503
Fixed #33577 -- Confirmed support for GDAL 3.4.
2022-03-16 09:07:01 +01:00
3b3f38b3b0
Fixed #31169 -- Adapted the parallel test runner to use spawn.
...
Co-authored-by: Valz <ahmadahussein0@gmail.com>
Co-authored-by: Nick Pope <nick@nickpope.me.uk>
2022-03-15 16:23:55 +01:00
a88fab1bca
Fixed #33552 -- Fixed JSONField has key lookups with numeric keys on MariaDB, MySQL, Oracle, and SQLite.
2022-03-15 06:37:35 +01:00
859a87d873
Fixed #31357 -- Fixed get_for_models() crash for stale content types when model with the same name exists in another app.
2022-03-14 12:52:26 +01:00
8f7cda0831
Fixed #33572 -- Implemented CreateModel/AlterModelManagers reduction.
2022-03-11 07:03:51 +01:00
71017a68a6
Fixed #33571 -- Fixed static serving views crash when If-Modified-Since is empty.
...
Regression in d6aff369ad
2022-03-11 06:19:01 +01:00
d90e34c61b
Fixed #33561 -- Allowed synchronization of user attributes in RemoteUserBackend.
2022-03-10 12:57:19 +01:00
93803a1b5f
Fixed #33567 -- Avoided setting default text/html content type on responses.
2022-03-09 14:50:52 +01:00
a45f28f0ec
Rewrote strip_tags test file to lorem ipsum.
2022-03-08 14:50:06 +01:00
a8c15481f4
Rewrote some references to "master".
...
Following d9a266d657
2022-03-08 14:50:06 +01:00
d4fd31684a
Refs #33173 -- Used locale.getlocale() instead of getdefaultlocale().
...
locale.getdefaultlocale() was deprecated in Python 3.11, see
https://bugs.python.org/issue46659 .
2022-03-08 13:17:05 +01:00
58d357fc65
Fixed #33563 -- Fixed contenttype reverse data migration crash with a multiple databases setup.
2022-03-08 06:22:03 +01:00
f3bf6c4218
Refs #33562 -- Made HttpResponse.set_cookie() raise ValueError when both "expires" and "max_age" are passed.
...
This fixes the case where you might pass set_cookie(expires=val, max_age=val)
and max_age is silently ignored.
2022-03-07 08:04:18 +01:00
ae2da5ba65
Fixed #33562 -- Made HttpResponse.set_cookie() support timedelta for the max_age argument.
2022-03-07 07:57:14 +01:00
1882f6567d
Refs #33562 -- Added tests HttpRequest.get_signed_cookie() with timedeltas.
2022-03-07 07:29:43 +01:00
c6b4d62fa2
Fixed #29865 -- Added logical XOR support for Q() and querysets.
2022-03-04 12:55:37 +01:00
a46bc327e7
Refs #11293 -- Added test for filtering aggregates with negated & operator.
2022-03-04 09:51:52 +01:00
b811364421
Refs #33446 -- Allowed variable whitespace in CSS source map references.
...
Follow up to dc8bb35e39
2022-03-04 06:22:28 +01:00
9bde906fb2
Refs #10188 -- Added tests for BadHeaderErrors when HTTP header with newlines cannot be encoded/decoded.
2022-03-02 20:23:39 +01:00
445b075def
Fixed #33547 -- Fixed error when rendering invalid inlines with readonly fields in admin.
...
Regression in de95c82667
2022-03-01 08:09:58 +01:00
119f227aa6
Fixed #33524 -- Allowed overriding empty_label for ForeignKey in ModelAdmin.radio_fields.
2022-02-28 13:28:21 +01:00
26c166c3b0
Added test for removing through model from ManyToManyField.
2022-02-25 22:01:27 +01:00
2b6a3baebe
Fixed #31486 -- Deprecated passing unsaved objects to related filters.
...
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2022-02-25 07:51:37 +01:00
11cc227344
Fixed #33267 -- Added link to related item to related widget wrapper in admin.
2022-02-25 06:33:05 +01:00
18245b948b
Refs #7488 , Refs #19524 -- Removed obsolete ModelInheritanceTest.test_issue_7488() test.
...
Obsolete since e9c24bef74
2022-02-24 09:55:02 +01:00
7f4fc5cbd4
Fixed #33539 -- Fixed spaces in WITH SQL for indexes on PostgreSQL.
2022-02-24 09:03:58 +01:00
fe7dbef586
Fixed #28889 -- Prevented double submission of admin forms.
...
Added a JavaScript confirm() to catch double-submissions, when the
change form has already been submitted.
Thanks to Adam Johnson, Claude Paroz, Keryn Knight, and Thibaud Colas
for review.
2022-02-23 14:57:34 +01:00
d11944be34
Refs #33476 -- Added warning to optimizemigration/squashmigrations commands when black cannot be applied.
2022-02-23 07:29:15 +01:00
7c318a8bdd
Fixed #27844 -- Added optimizemigration management command.
2022-02-22 10:30:40 +01:00
847f46e9bf
Removed redundant QuerySet.all() calls in docs and tests.
...
Most QuerySet methods are mapped onto the Manager and, in general,
it isn't necessary to call .all() on the manager.
2022-02-22 10:29:38 +01:00
7ba6ebe914
Fixed #19580 -- Unified behavior of reverse foreign key and many-to-many relations for unsaved instances.
2022-02-22 09:16:40 +01:00
b7f263551c
Refs #33517 -- Prevented __second lookup from returning fractional seconds on PostgreSQL.
2022-02-22 07:26:44 +01:00
659d2421c7
Fixed #20296 -- Prevented mark_safe() from evaluating lazy objects.
2022-02-21 10:11:26 +01:00
1299bc33e1
Refs #33526 -- Made CSRF_COOKIE_SECURE/SESSION_COOKIE_SECURE/SESSION_COOKIE_HTTPONLY don't pass on truthy values.
2022-02-21 07:54:47 +01:00
e559070a7a
Fixed #33518 -- Added RemovedAfterNextVersionWarning.
2022-02-21 06:23:41 +01:00
fac3dd7f39
Refs #33173 -- Fixed MailTests.test_backend_arg() on Windows and Python 3.11+.
2022-02-19 20:36:01 +01:00
9ac3ef59f9
Fixed #33379 -- Added minimum database version checks.
...
Thanks Tim Graham for the review.
2022-02-18 13:37:49 +01:00
3079133c73
Fixed #33514 -- Added fallbacks to subsequent language codes in Select2 translations.
2022-02-18 08:34:49 +01:00
b2ed0d78f2
Refs #28358 -- Fixed infinite recursion in LazyObject.__getattribute__().
...
Regression in 97d7990abd
2022-02-17 14:52:17 +01:00
1e2e1be02b
Fixed #33515 -- Prevented recreation of migration for ManyToManyField to lowercased swappable setting.
...
Thanks Chris Lee for the report.
Regression in 4328970780#23916 .
2022-02-16 21:09:24 +01:00
97d7990abd
Fixed #28358 -- Prevented LazyObject from mimicking nonexistent attributes.
...
Thanks Sergey Fedoseev for the initial patch.
2022-02-16 10:51:15 +01:00
236e6cb588
Refs #31407 -- Handled potential exception in test cleanup.
...
The test view may not be called when running the tests with
--parallel=2 or greater. Catch the AttributeError for this case.
2022-02-15 14:38:19 +01:00
f7e0bffa2e
Refs #33348 -- Made SimpleTestCase.assertFormError() raise ValueError when "field" is passed without "form_index".
2022-02-15 10:30:20 +01:00
d4c9dab74b
Refs #33348 -- Fixed SimpleTestCase.assertFormError() error message raised for unbound forms.
2022-02-15 10:16:06 +01:00
d84cd91e90
Refs #33348 -- Improved messages raised by SimpleTestCase.assertFormError()/assertFormsetErrors().
...
This makes messages use BaseFormSet/BaseForm.__repr__() instead of
context, and adds the _assert_form_error() helper.
2022-02-15 07:15:44 +01:00
9bb13def5d
Refs #33348 -- Made SimpleTestCase.assertFormsetErrors() raise an error when form_index is too big.
2022-02-14 12:46:46 +01:00
261885e4c1
Simplified SimpleTestCase.assertFormError()/assertFormsetErrors() calls in admin_views tests.
2022-02-14 11:34:58 +01:00
1f749d6f12
Fixed field name in admin_views.tests.UserAdminTest.test_password_mismatch() assertion.
2022-02-14 11:29:45 +01:00
7986028e3f
Refs #33348 -- Made SimpleTestCase.assertFormError()/assertFormsetErrors() raise an error for unbound forms/formsets.
2022-02-14 08:43:46 +01:00
cdd4ff67d2
Refs #25684 -- Removed double newline from request/response output of runserver.
...
Follow up to 0bc5cd6280
2022-02-14 06:55:34 +01:00
3702819227
Refs #32502 -- Avoided table rebuild when removing fields on SQLite 3.35.5+.
...
ALTER TABLE ... DROP COLUMN was introduced in SQLite 3.35+ however
a data corruption issue was fixed in SQLite 3.35.5.
2022-02-11 22:21:58 +01:00
d113b5a837
Refs #33476 -- Made management commands use black.
...
Run black on generated files, if it is available on PATH.
2022-02-11 12:23:26 +01:00
f9ec777a82
Fixed #26287 -- Added support for addition operations to SimpleLazyObject.
2022-02-10 11:24:51 +01:00
4c76ffc2d6
Fixed #29490 -- Added support for object-based Media CSS and JS paths.
2022-02-10 08:48:27 +01:00
09e499a39e
Fixed #33501 -- Made order_with_respect_to respect database routers.
2022-02-09 13:31:49 +01:00
2d472ad05c
Fixed #33495 -- Improved debug logging message about adapting handlers for middlewares.
...
It's the wrapped handler that's adapted to the wrapping middleware.
2022-02-09 12:10:26 +01:00
d35ce682e3
Fixed #33506 -- Made QuerySet.bulk_update() perform atomic writes against write database.
...
The lack of _for_write = True assignment in bulk_update prior to
accessing self.db resulted in the db_for_read database being used to
wrap batched UPDATEs in a transaction.
Also tweaked the batch queryset creation to also ensure they are
executed against the same database as the opened transaction under all
circumstances.
Refs #23646 , #33501 .
2022-02-09 11:14:50 +01:00
7119f40c98
Refs #33476 -- Refactored code to strictly match 88 characters line length.
2022-02-07 20:37:05 +01:00
9c19aff7c7
Refs #33476 -- Reformatted code with Black.
2022-02-07 20:37:05 +01:00
f68fa8b45d
Refs #33476 -- Changed quotation marks in DebugViewTests.test_template_exceptions().
...
This prevents a failure after reformatting the code with Black.
2022-02-07 20:36:04 +01:00
6f185a53a2
Refs #33482 -- Fixed QuerySet selecting and filtering againts negated Exists() with empty queryset.
...
Regression in b7d1da5a62
2022-02-07 20:34:21 +01:00
4b8e9492d9
Refs #32559 -- Added selenium test for FloatField client-side validation.
...
step="any" is required for non-integer values. See:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number#step
Covers behaviour added in 7ec2a21be1
2022-02-03 13:50:37 +01:00
832adb31f2
Fixed #33473 -- Fixed detecting changes by autoreloader in .py files inside template directories.
2022-02-03 11:22:45 +01:00
c5cd878382
Refs #33476 -- Refactored problematic code before reformatting by Black.
...
In these cases Black produces unexpected results, e.g.
def make_random_password(
self,
length=10,
allowed_chars='abcdefghjkmnpqrstuvwxyz' 'ABCDEFGHJKLMNPQRSTUVWXYZ' '23456789',
):
or
cursor.execute("""
SELECT ...
""",
[table name],
)
2022-02-03 11:20:46 +01:00
b7d1da5a62
Fixed #33482 -- Fixed QuerySet filtering againts negated Exists() with empty queryset.
...
Thanks Tobias Bengfort for the report.
2022-02-02 07:54:19 +01:00
0dcd549bbe
Fixed #30360 -- Added support for secret key rotation.
...
Thanks Florian Apolloner for the implementation idea.
Co-authored-by: Andreas Pelme <andreas@pelme.se>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Co-authored-by: Vuyisile Ndlovu <terrameijar@gmail.com>
2022-02-01 11:12:24 +01:00
fc18f36c4a
Fixed CVE-2022-23833 -- Fixed DoS possiblity in file uploads.
...
Thanks Alan Ryan for the report and initial patch.
2022-02-01 07:41:40 +01:00
394517f078
Fixed CVE-2022-22818 -- Fixed possible XSS via {% debug %} template tag.
...
Thanks Keryn Knight for the report.
Co-authored-by: Adam Johnson <me@adamj.eu>
2022-02-01 07:40:51 +01:00
97a7274468
Fixed #33480 -- Fixed makemigrations crash when renaming field of renamed model.
...
Regression in aa4acc164d
2022-02-01 07:01:41 +01:00
71e7c8e737
Fixed #33468 -- Fixed QuerySet.aggregate() after annotate() crash on aggregates with default.
...
Thanks Adam Johnson for the report.
2022-01-31 11:33:24 +01:00
55022f75c1
Fixed #33465 -- Added empty __slots__ to SafeString and SafeData.
...
Despite inheriting from the str type, every SafeString instance gains
an empty __dict__ due to the normal, expected behaviour of type
subclassing in Python.
Adding __slots__ to SafeData is necessary, because otherwise inheriting
from that (as SafeString does) will give it a __dict__ and negate the
benefit added by modifying SafeString.
2022-01-29 13:50:34 +01:00
c5c7a15b09
Fixed #33461 -- Escaped template errors in the technical 500 debug page.
2022-01-28 07:07:12 +01:00
e87f57fdb8
Fixed #26142 -- Allowed model formsets to prevent new object creation.
...
Thanks Jacob Walls, David Smith, and Mariusz Felisiak for reviews.
Co-authored-by: parth <parthvin@gmail.com>
2022-01-27 20:45:21 +01:00
0af9a5fc7d
Fixed #33463 -- Fixed QuerySet.bulk_update() with F() expressions.
2022-01-27 19:03:26 +01:00
e972620ada
Fixed #33462 -- Fixed migration crash when altering type of primary key with MTI and foreign key.
...
This prevents duplicated operations when altering type of primary key
with MTI and foreign key. Previously, a foreign key to the base model
was added twice, once directly and once by the inheritance model.
Thanks bcail for the report.
Regression in 325d7710ce
2022-01-27 18:51:39 +01:00
d15a10afb5
Adjusted CBV resolver_match example in testing tools docs.
...
The view_class is available on the view callback, allowing that to be
checked, rather than the __name__.
2022-01-26 20:58:22 +01:00
f38c3cbadc
Increased test coverage for django.contrib.gis.gdal.layer.Layer.
2022-01-26 17:47:03 +01:00
edbf930287
Fixed #29984 -- Added QuerySet.iterator() support for prefetching related objects.
...
Co-authored-by: Raphael Kimmig <raphael.kimmig@ampad.de>
Co-authored-by: Simon Charette <charette.s@gmail.com>
2022-01-25 06:12:04 +01:00
efb4478e48
Fixed #33458 -- Fixed encoding of messages with empty string as extra_tags.
2022-01-24 07:05:53 +01:00
7c4f396509
Stopped including type="text/css" attributes for CSS link tags.
2022-01-22 16:38:14 +01:00
9dc65263d4
Fixed #33455 -- Improved error message when selenium is not installed.
2022-01-21 21:54:10 +01:00
2d8232fa71
Fixed #26760 -- Added --prune option to migrate command.
2022-01-21 17:10:31 +01:00
eeff1787b0
Fixed #33449 -- Fixed makemigrations crash on models without Meta.order_with_respect_to but with _order field.
...
Regression in aa4acc164d
2022-01-21 06:44:53 +01:00
f605e85af9
Fixed #33453 -- Dropped support for GDAL 2.1.
2022-01-20 18:54:29 +01:00
3fadf141e6
Fixed #33062 -- Made MultiPartParser remove non-printable chars from file names.
2022-01-20 07:19:52 +01:00
0f6946495a
Fixed #31685 -- Added support for updating conflicts to QuerySet.bulk_create().
...
Thanks Florian Apolloner, Chris Jerdonek, Hannes Ljungberg, Nick Pope,
and Mariusz Felisiak for reviews.
2022-01-19 20:17:42 +01:00
4a8ac604b1
Added tests for SpatialReference.to_esri()/from_esri().
2022-01-19 16:03:04 +01:00
dc8bb35e39
Fixed #33446 -- Added CSS source map support to ManifestStaticFilesStorage.
2022-01-18 12:53:14 +01:00
30a0144134
Fixed #29338 -- Allowed using combined queryset in Subquery.
...
Thanks Eugene Kovalev for the initial patch, Simon Charette for the
review, and Chetan Khanna for help.
2022-01-17 18:01:07 +01:00
f37face331
Fixed #33435 -- Fixed invalid SQL generatered by Subquery.as_sql().
2022-01-17 09:00:46 +01:00
0a17666045
Fixed #28135 -- Made simplify_regex() handle non-capturing groups.
2022-01-14 11:01:02 +01:00
fdfa97fb16
Fixed #33441 -- Restored immutability of models.Field.__hash__().
...
Regression in 502e75f9ed
2022-01-14 07:00:48 +01:00
45a42aabfa
Fixed #29708 -- Deprecated PickleSerializer.
2022-01-13 13:50:20 +01:00
436862787c
Refs #29708 -- Made SessionBase store expiry as string.
2022-01-13 13:05:42 +01:00
08d8bccbf1
Improved Model.__init__() properties loop.
...
This improves readability, accumulates unrecognized arguments raise an
exception with all of them, and avoids refetching the values.
2022-01-13 11:09:37 +01:00
0a4a5e5bac
Refs #32681 -- Fixed VariableDoesNotExist when rendering some admin template.
...
Regression in 84609b32054e5bbb6ef2
2022-01-13 10:10:48 +01:00
6815da6e94
Fixed #33396 -- Added view name to technical 500 debug page.
2022-01-13 07:02:41 +01:00
84e98ba194
Added exception to SuspiciousOperation logging.
...
This allows better debugging and filtering of errors.
2022-01-12 13:27:25 +01:00
dc9deea8e8
Fixed #11715 -- Changed default value of ModelAdmin.actions/inlines to empty tuples.
...
This clarifies the intended pattern of overwriting the default value
rather than mutating it.
2022-01-11 12:22:49 +01:00
fa235004dd
Fixed #13251 -- Made pre/post_delete signals dispatch the origin.
2022-01-11 08:06:18 +01:00
6f78cb6b13
Fixed #29026 -- Added --scriptable option to makemigrations.
2022-01-10 18:49:57 +01:00
f4b06a3cc1
Fixed #33426 -- Fixed ResolverMatch.__repr_() for class-based views.
...
Regression in 7c08f26bf0
2022-01-10 17:30:41 +01:00
3430093a46
Refs #32193 -- Removed python-memcached from test requirements.
...
Follow up to 05f3a6186e
2022-01-10 06:39:15 +01:00
2a66c102d9
Fixed #33425 -- Fixed view name for CBVs on technical 404 debug page.
...
Regression in 0c0b87725b
2022-01-08 13:05:55 +01:00
4c60c3edff
Fixed #33419 -- Restored marking forms.Field.help_text as HTML safe.
...
Regression in 456466d932
2022-01-07 15:35:31 +01:00
bdf3e156b4
Fixed #28628 -- Changed \d to [0-9] in regexes where appropriate.
2022-01-07 12:25:06 +01:00
fe76944269
Refs #28628 -- Added tests for intcomma with non-ASCII digits.
2022-01-07 12:23:33 +01:00
28c98d4113
Fixed #33216 -- Simpilified deconstructed paths for some expressions.
2022-01-07 11:19:29 +01:00
c67e1cf44f
Refs #33348 -- Deprecated passing errors=None to SimpleTestCase.assertFormError()/assertFormsetErrors().
2022-01-06 17:29:32 +01:00
bc174e6ea0
Fixed #33410 -- Fixed recursive capturing of callbacks by TestCase.captureOnCommitCallbacks().
...
Regression in d89f976bdd
2022-01-06 06:38:17 +01:00
806efe912b
Fixed #33400 -- Added support for msg_prefix and count arguments to assertTemplateUsed()/assertTemplateNotUsed() used as context managers.
2022-01-05 12:49:42 +01:00
f5233dce30
Fixed #32511 -- Corrected handling prefetched nested reverse relationships.
...
When prefetching a set of child objects related to a set of parent
objects, we usually want to populate the relationship back from the
child to the parent to avoid a query when accessing that relationship
attribute. However, there's an edge case where the child queryset
itself specifies a prefetch back to the parent. In that case, we want
to use the prefetched relationship rather than populating the reverse
relationship from the parent.
2022-01-05 09:49:05 +01:00
205f67cd5b
Refs #33216 -- Made @deconstructible do not change path for subclasses.
2022-01-04 13:15:29 +01:00
194ca77092
Refs #21275 -- Added more tests for @deconstructible decorator.
2022-01-04 13:08:36 +01:00
6d343d01c5
Fixed CVE-2021-45452 -- Fixed potential path traversal in storage subsystem.
...
Thanks to Dennis Brinkrolf for the report.
2022-01-04 10:04:12 +01:00
761f449e0d
Fixed CVE-2021-45116 -- Fixed potential information disclosure in dictsort template filter.
...
Thanks to Dennis Brinkrolf for the report.
Co-authored-by: Adam Johnson <me@adamj.eu>
2022-01-04 10:03:56 +01:00
968a3d01fa
Fixed CVE-2021-45115 -- Prevented DoS vector in UserAttributeSimilarityValidator.
...
Thanks Chris Bailey for the report.
Co-authored-by: Adam Johnson <me@adamj.eu>
2022-01-04 10:02:05 +01:00
482ee63b6f
Fixed #33402 -- Optimized multiple AlterFooTogether operations.
2022-01-04 06:24:03 +01:00
0ed2919814
Fixed #33406 -- Avoided creation of MaxLengthValidator(None) when resolving Value.output_field for strings.
...
This brings the behaviour in line with Field subclasses which append to
the validators within __init__(), like BinaryField, and prevents the
creation of a validator which incorrectly throws a TypeError, if it
were used.
2022-01-04 05:51:00 +01:00
b894199eb0
Refs #33406 -- Added test for not creating broken validators when resolving Value.output_field.
2022-01-04 05:51:00 +01:00
30613d6a74
Fixed #33408 -- Fixed adding nullable unique fields on SQLite.
...
Regression in 2f73e5406d
2022-01-04 05:50:00 +01:00
0ab58c1209
Refs #29026 -- Allowed customizing InteractiveMigrationQuestioner's prompt destination.
...
Previously, the questioner did not obey the value of stdout provided
to the command.
2022-01-03 12:30:51 +01:00
03a6488116
Refs #31026 -- Changed @jinja2_tests imports to be relative.
2022-01-03 06:11:30 +01:00
826701232c
Removed obsolete Oracle's test_client_encoding() test.
...
encoding and nencoding parameters were deprecated in cx_Oracle 8.2.
Moreover, encoding is handled internally between cx_Oracle and Oracle
Database and there is no need to test it.
2021-12-30 12:42:37 +01:00
aecfc40c88
Fixed #33300 -- Ensured hidden elements are not displayed on small screens.
2021-12-30 07:57:36 +01:00
92412aa94c
Fixed #23273 -- Avoided creation of django_migrations table when there are no migrations to apply.
2021-12-30 06:36:55 +01:00
950d697b95
Refs #31617 -- Removed redundant title text in filter.html.
...
Unnecessary since 269a767146
2021-12-28 13:42:35 +01:00
2d07e1aaeb
Refs #22983 -- Added tests for squashing migrations with functions from migration files.
...
Follow up to ebb13bbd88
2021-12-27 18:49:19 +01:00
59a66f0512
Refs #33342 -- Deprecated ExclusionConstraint.opclasses.
2021-12-27 08:55:18 +01:00
0e656c02fe
Fixed #33342 -- Added support for using OpClass() in exclusion constraints.
2021-12-24 11:39:00 +01:00
deec15a9a6
Refs #33355 -- Made trunc functions raise ValueError on invalid lookups on SQLite.
...
Co-Authored-By: Nick Pope <nick@nickpope.me.uk>
2021-12-23 11:47:13 +01:00
cb82ded4b2
Refs #32339 -- Added rendering tests for forms with CheckboxSelectMultiple and SelectMultiple widgets.
2021-12-23 07:38:05 +01:00
ca04659b4b
Refs #32355 -- Bumped required psycopg2 version to 2.8.4.
...
psycopg2 2.8.4 is the first release to support Python 3.8.
2021-12-22 20:32:55 +01:00
a8fa3e5cd7
Refs #33355 -- Added missing tests for database functions and expression on null values.
2021-12-22 11:46:18 +01:00
e95e6425ac
Refs #24121 -- Added __repr__() to BaseFormSet.
2021-12-21 12:06:05 +01:00
61b332499d
Used assertRaisesMessage() in test_client_regress.AssertFormErrorTests.
2021-12-21 11:09:45 +01:00
72b23c04d8
Fixed #33374 -- Fixed ExpressionWrapper annotations with full queryset.
2021-12-21 06:17:04 +01:00
03cadb912c
Removed a Python error message dependency in test_questioner_no_default_bad_user_entry_code().
2021-12-20 11:11:39 +01:00
1833a9eee9
Increased test coverage of django.db.migrations.questioner.
2021-12-20 11:11:39 +01:00
448145092c
Refs #27674 -- Added tests for GISModelAdmin.gis_widget_kwargs.
2021-12-20 08:12:12 +01:00
e8b4feddc3
Fixed #33367 -- Fixed URLValidator crash in some edge cases.
2021-12-20 07:30:22 +01:00
4fd3044ca0
Fixed #33368 -- Fixed parse_duration() crash on invalid separators for decimal fractions.
2021-12-20 06:46:34 +01:00
4328970780
Fixed #33366 -- Fixed case handling with swappable setting detection in migrations autodetector.
...
The migration framework uniquely identifies models by case insensitive
labels composed of their app label and model names and so does the app
registry in most of its methods (e.g. AppConfig.get_model) but it
wasn't the case for get_swappable_settings_name() until this change.
This likely slipped under the radar for so long and only regressed in
b9df2b74b9
2021-12-17 07:46:58 +01:00
40165eecc4
Fixed #33350 -- Reallowed using cache decorators with duck-typed HttpRequest.
...
Regression in 3fd82a6241
2021-12-16 20:13:17 +01:00
068b2c072b
Fixed #30127 -- Deprecated name argument of cached_property().
2021-12-16 18:52:27 +01:00
882647a82c
Used subTest() in forms.URLField() tests.
2021-12-16 06:35:44 +01:00
ac5cc6cf01
Fixed #33316 -- Added pagination to admin history view.
2021-12-15 10:54:08 +01:00
76ccce64cc
Fixed #16063 -- Adjusted admin changelist searches spanning multi-valued relationships.
...
This reduces the likelihood of admin searches issuing queries with
excessive joins.
2021-12-15 08:14:19 +01:00
e1d673c373
Fixed unescape_string_literal() crash on empty strings.
2021-12-14 20:19:44 +01:00
5d9c512e5b
Added test for ValueErrors in unescape_string_literal().
2021-12-14 20:18:43 +01:00
3b73f77ad4
Fixed #33358 -- Fixed handling timedelta < 1 day in schema operations on Oracle.
2021-12-14 09:08:25 +01:00
2f33217ea2
Fixed #33361 -- Fixed Redis cache backend crash on booleans.
2021-12-14 07:16:30 +01:00
c7902612ca
Refs #33361 -- Added Added DummyCache.set() test for boolean values.
2021-12-14 06:47:37 +01:00
e61abab6e0
Refs #33338 -- Added never_cache() tests for Expires header.
2021-12-13 15:32:24 +01:00
5111b636d9
Refs #33355 -- Fixed Trunc() with years < 1000 on SQLite.
...
Thanks to Nick Pope for spotting the bug in Code Review.
Co-Authored-By: Nick Pope <nick@nickpope.me.uk>
2021-12-13 11:50:45 +01:00
c66ecc5568
Refs #33355 -- Moved Trunc() assertions for invalid arguments and ISO 8601 week to separate tests.
2021-12-13 11:28:35 +01:00
75485d16a2
Fixed #33351 -- Made path()/re_path() raise TypeError when kwargs argument is not a dict.
2021-12-13 08:09:28 +01:00
2f73e5406d
Refs #32502 -- Avoided table rebuild when adding fields with no default on SQLite.
2021-12-10 17:13:05 +01:00
0d2435328a
Added test for field names of ManagementForm.
2021-12-10 10:01:33 +01:00
974e3b8750
Fixed inspectdb.tests.InspectDBTestCase.test_custom_fields() on SQLite 3.37+.
...
Use FlexibleFieldLookupDict which is case-insensitive mapping because
SQLite 3.37+ returns some data type names upper-cased e.g. TEXT.
2021-12-09 20:24:38 +01:00
17df72114e
Fixed #33340 -- Fixed unquoted column names in queries used by DatabaseCache.
2021-12-09 11:16:04 +01:00
eba9a9b7f7
Refs #32338 -- Added Boundfield.legend_tag().
2021-12-09 07:16:33 +01:00
81739a45b5
Fixed #33319 -- Fixed crash when combining with the | operator querysets with aliases that conflict.
2021-12-08 21:16:24 +01:00
cb383753c0
Fixed #33346 -- Fixed SimpleTestCase.assertFormsetError() crash on a formset named "form".
...
Thanks OutOfFocus4 for the report.
Regression in 456466d932
2021-12-08 20:33:03 +01:00
8a4e506760
Fixed #19721 -- Allowed admin filters to customize the list separator.
2021-12-08 15:25:52 +01:00
513441240f
Updated asgiref dependency for 4.0 release series.
2021-12-07 09:49:39 +01:00
d4dcd5b9dd
Fixed #30530 , CVE-2021-44420 -- Fixed potential bypass of an upstream access control based on URL paths.
...
Thanks Sjoerd Job Postmus and TengMA(@te3t123) for reports.
2021-12-07 06:28:08 +01:00
628b6a6869
Updated translations from Transifex.
...
This also fixes related i18n tests.
Forwardport of 4c5215ab03
2021-12-06 20:31:03 +01:00
1eaf38fa87
Fixed #33335 -- Made model validation ignore functional unique constraints.
...
Regression in 3aa545281e
2021-12-06 07:59:11 +01:00
d3a64bea51
Refs #33333 -- Fixed PickleabilityTestCase.test_annotation_with_callable_default() crash on Oracle.
...
Grouping by LOBs is not allowed on Oracle. This moves a binary field to
a separate model.
2021-12-04 15:55:03 +01:00
d3f4c2b95d
Fixed #33078 -- Added support for language regions in i18n_patterns().
2021-12-03 12:57:06 +01:00
4f7bbc6138
Refs #33078 -- Added extra assertions to MiscTests.test_get_language_from_path_real().
2021-12-03 12:03:30 +01:00
Nick Pope
David Wobrock
Msvstl
Simon Charette
Simon Kern
Mariusz Felisiak
Tobias Bengfort
Marcelo Galigniana
Yuri Konotopov
Vlastimil Zíma
Giebisch
HieuPham9720
Carlton Gibson
Sergio
Rasmus Magnell
Adam Johnson
Sarah Boyce
Gregor Gärtner
Shubh1815
Jack Linke
Dhanush
David Sanders
Lily Foote
sarahboyce
Antoine Lorence
Jacob Walls
JunKi Yoon
Moshe Nahmias
Florian Perucki
select-case
Alexander Kerkum
Kamil Turek
Allen Jonathan David
Anvesh Mishra
Sergey Fursov
Jimmy Angelakos
DevilsAutumn
James Beith
SirAbhi13
Mark Evans
Shai Berger
Mohamed Karam
Iuri de Silvio
Neeraj Kumar
Willem Van Onsem
Claude Paroz
Tom Carrick
Benoît Vinot
Haolun Chai
Fiza Ashraf
Fab
Alberto Planas
Jarrett Keifer
cheng
Ikko Ashimine
Stéphane "Twidi" Angel
Christos Kopanos
Vladimir Kochetkov
Shawn Dong
Ipakeev
Michael Manfre
Hrushikesh Vaidya
Mehrdad
Ankur
DhruvaPatil98
Florian Apolloner
Abhinav Yadav
Zainab Amir
Matt Brewer
Pablo Pissi
Bruce Cutler
Ebram Shehata
Jonas Lundberg
Ronnie van den Crommenacker
Ciaran McCormick
Anders Kaseorg
Samir Shah
Tim Graham
kshivakumar
Aymeric Augustin
Sankalp
Hasan Ramezani
David Smith
Alokik Vijay
Kapil Bansal
Ed Rivas
Marc Seguí Coll
Gagaro
Daniel Hahler
mpachas
Andrew Godwin
L
marcperrinoptel
siddhartha-star-dev
Collin Anderson
Scott
Alexandru Mărășteanu
SanderBeekhuis
zhangyangyu
Himanshu-Balasamanta
Manel Clos
Baptiste Mispelon
Brian Helba
Lucidiot
Luke Plant
René Fleschenberg
adontz
Thomas Schmidt
likecodingloveproblems
Stefan Wehrmeyer
François Granade
Sage Abdullah
Biel Frontera
Adrian Torres
Hameed Gifford
Ryan Heard
Keryn Knight
Albert Defler
nabil-rady
Theo Alexiou
saeedblanchette
David Smith
Matthias Kestenholz
rafrafek
Damian Posener
Aaron Chong
django-bot
tschilling
Markus Holtermann
Kirill Safronov
vgolubev
Jörg Breitbart
Carlton Gibson
Timothy McCurrach
Fabian Büchler
sean_c_hsu
Ayush Joshi
Ad Timmering
Petter Friberg
Jamie Matthews
Hannes Ljungberg
Alexander Filimonov
mendespedro
mdalp
Jeremy Lainé
mendespedro
Arsa
Ömer Faruk Abacı
Shreya Bamne
Maxim Piskunov