p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
31,969 Commits 28 Branches 411 Tags 641 MiB
Commit Graph

13058 Commits

Author SHA1 Message Date
th3nn3ss 3152f9de47 Refs #31949 -- Made http decorators to work with async functions. 2023-06-26 09:29:04 +02:00
th3nn3ss cd4c4c1905 Added more tests for http decorators. 2023-06-26 09:29:04 +02:00
Mariusz Felisiak 865a6650d0 Moved http decorator tests into decorators/test_http.py. 2023-06-26 09:29:01 +02:00
Andrew Northall 38cde27a89 Fixed #34676 -- Normalized Distance()/Area() exceptions for nonexistent units. 2023-06-25 13:09:30 +02:00
Mariusz Felisiak 650ce96782
Refs #34391 -- Updated asgiref dependency for 5.0 release series. 2023-06-23 21:52:04 +02:00
Jon Janzen 38e391e95f Refs #31949 -- Made @sensitive_variables/sensitive_post_parameters decorators to work with async functions. 
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2023-06-23 13:29:40 +02:00
Nick Pope f8092ee9ad Improved style of n-tuple wording in docs and comments. 2023-06-23 09:29:35 +02:00
Hrushikesh 107865780a Fixed #34345 -- Added system check for ManyToManyFields with intermediate tables in ModelAdmin.filter_horizontal/vertical. 2023-06-21 07:48:09 +02:00
Akash Kumar Sen 1754c2c802 Refs #34634 -- Fixed creating diamond-shaped MTI objects with ancestors inherited from different paths. 
Co-authored-by: Simon Charette <charette.s@gmail.com>
 2023-06-20 08:40:35 +02:00
Akash Kumar Sen 82a588a6bc Fixed #34634 -- Adjusted system check for clashing fields to warn about links to common parent for MTI models. 2023-06-20 08:10:53 +02:00
Yaser Amiri 3f1bc2222f Fixed #34656 -- Fixed unclosed div in admin password change template. 
Regression in 6991880109.
 2023-06-19 08:22:10 +02:00
François Freitag bcacc6321a Refs #34517 -- Restored skipping ImageFileField.update_dimension_fields without width/height fields. 
This avoids reading the image size when the dimensions fields
(image_width, image_height) do not exist, as that operation may be
expensive.

Partially reverts ea53e7c09f, that dropped
the check for the dimension fields in update_dimension_fields(), because
the post_init signal was no longer registered without dimension fields.

However, another code path to that function exists: when the
ImageFileField is save()d, the name from the storage is setattr()ed on
the field, and ImageFileDescriptor calls update_dimension_fields()
because the image size might have changed. Keep bailing out early when
dimensions are unused.

Besides, computing the image dimensions causes to close() the file,
resulting in a backward-incompatible change. The test protects against
that change.
 2023-06-19 05:24:42 +02:00
şuayip üzülmez 0c5146523b Fixed #34662 -- Corrected number in error messages for Array(Min/Max)LengthValidator. 2023-06-18 14:32:51 +02:00
sarahboyce 8b062eab8e Made SeleniumTests.test_inline_uuid_pk_add_with_popup less flaky by waiting until popup is closed. 2023-06-18 08:37:19 +02:00
Olivier Le Thanh Duong 1b754d638d Fixed #34629 -- Added filtering support to GIS aggregates. 2023-06-16 12:20:13 +02:00
Jacob Rief 1fe0b167af Fixed #34473 -- Fixed step validation for form fields with non-zero minimum value. 2023-06-16 08:38:28 +02:00
Akash Kumar Sen 5d20e02078 Fixed #33414 -- Fixed creating diamond-shaped MTI objects for common ancestor with primary key that has a default. 
Co-authored-by: Simon Charette <charette.s@gmail.com>
 2023-06-15 08:16:11 +02:00
Simon Charette 1c4f5f314e Refs #32143 -- Removed superflous constraints on excluded query. 
The outer query reference is not necessary when alias can be reused and
can even be harmful by confusing query planers.

Refs #34597.
 2023-06-14 09:44:49 +02:00
David Smith 0cfcab4eec
Fixed date_time_picker_shortcuts() tests on Windows. 
Windows does not allow overriding TIME_ZONE as time.tzset() is only
available on Unix.
 2023-06-14 08:01:14 +02:00
Mariusz Felisiak 06881341d4
Refs #30220 -- Bumped required version of Selenium to 3.8.0. 
Follow up to 8d010f3986.
 2023-06-13 10:12:52 +02:00
sarahboyce decbfa834f Made SeleniumTests.test_select_multiple less flaky by adding explicit Selenium wait. 2023-06-13 08:26:34 +02:00
Nina Menezes 1699f8b52a Fixed #34628 -- Improved icons accessibility of related widget wrapper in admin. 
This improves accessibility of icons by making them larger and grayscale
(when not selected).
 2023-06-12 08:31:28 +02:00
Nick Pope e042024b28 Allowed custom formatting of lazy() objects. 
This allows for formatting of lazy objects which have a custom formatter
defined by overriding the default implementation from `object`.
 2023-06-12 06:09:20 +02:00
Nick Pope fd97b0471b Allowed multiplication of lazy() objects with int return type. 2023-06-12 05:59:40 +02:00
Ran Benita ae94077e7d Made proxy class in lazy() prepare eagerly. 
Previously, the proxy class was prepared lazily:

  lazy_identity = lazy(identity, int)
  lazy_identity(10)  # prepared here
  lazy_identity(10)

This has a slight advantage that if the lazy doesn't end up getting
used, the preparation work is skipped, however that's not very likely.

Besides this laziness, it is also inconsistent in that the methods which
are wrapped directly (__str__ etc.) are prepared already when __proxy__
is defined, and there is a weird half-initialized state.

This change it so that everything is prepared already on the first line
of the example above.
 2023-06-12 05:45:44 +02:00
Nick Pope e0e0204477 Added more tests for django.utils.functional.lazy(). 2023-06-12 05:29:30 +02:00
XDEv11 221c27bd6a
Added tests for HttpResponseBase.charset/reason_phrase setters. 2023-06-10 20:43:05 +02:00
Mariusz Felisiak caf80cb41f
Fixed #34645 -- Restored alignment for admin date/time timezone warnings. 
Regression in 96a598356a.
 2023-06-09 21:37:23 +02:00
Anders Kaseorg b81e974e9e Fixed #34604 -- Corrected fallback SQL for n-ary logical XOR. 
An n-ary logical XOR Q(…) ^ Q(…) ^ … ^ Q(…) should evaluate to true
when an odd number of its operands evaluate to true, not when exactly
one operand evaluates to true.
 2023-06-08 20:41:18 +02:00
Ran Benita a57d5d9bbc Made bytes and str return types no longer mutually exclusive in lazy(). 
They are no longer special cased.
 2023-06-08 09:15:40 +02:00
Ran Benita f5817c24f4 Refs #34445 -- Fixed string-casting of non-string lazy objects when value may be bytes. 
If the result type is bytes, then calling bytes() on it does nothing.

If the result type is not bytes, we should not cast to bytes, just
because the return value may be bytes.
 2023-06-08 06:38:11 +02:00
benebsiny 7cc138a58f Added MultiPartParser tests for parsing base64-encoded fields. 2023-06-07 05:44:27 +02:00
devilsautumn 094b0bea2c Fixed #34609 -- Deprecated calling format_html() without arguments. 2023-06-06 14:14:57 +02:00
Mariusz Felisiak 4f6a51dfe6
Fixed lookup.tests.LookupTests.test_exclude() on PostgreSQL 16 beta 1. 
Order doesn't matter for this test, and on PostgreSQL 16 "%" is ordered
before "_", so switch to sort by "pub_date".
 2023-06-06 11:38:23 +02:00
Mariusz Felisiak 40a2c811e3
Refs #26706, Refs #34633 -- Added test for prefetch_related() cache invalidation in ManyRelatedManager.create(). 2023-06-06 07:33:59 +02:00
Coen van der Kamp 10d9d0ccb2 Fixed #34622 -- Improved accessibility of related widget wrapper in admin. 
This improves accessibility for screen reader users by adding
"aria-disabled" and removing "alt".

Thanks Thibaud Colas for the report.
 2023-06-05 14:43:51 +02:00
Howard Cox cd413bd78a Fixed #34621 -- Made admin site header render in <div> tag. 
This was problematic for screen reader users because they use headings
to navigate. Having two <h1> is confusing, and the one in the header
wasn’t particularly helpful since it’s the same on all pages.
 2023-06-05 11:55:06 +02:00
nessita 89c27d8672
Fixed #34601 -- Added field name to check message for ModelAdmin.readonly_fields. 
Co-authored-by: Rick van Hattem <wolph@wol.ph>
 2023-06-05 05:56:53 +02:00
Mariusz Felisiak f9936deed1
Fixed #34620 -- Fixed serialization crash on m2m fields without natural keys when base querysets use select_related(). 
Regression in 19e0587ee5.

Thanks Martin Svoboda for the report.
 2023-06-04 20:49:07 +02:00
Nina Menezes 27fed08e5f
Fixed #34618 -- Added icon descriptions in "Recent Actions" on the admin index. 2023-06-02 12:32:18 +02:00
Simon Charette 2cf76f2d5d Fixed #34612 -- Fixed QuerySet.only() crash on reverse relationships. 
Regression in b3db6c8dcb.

Thanks Ian Cubitt for the report.

This also corrected test_inheritance_deferred2() test which was
previously properly defined and marked as an expected failure but was
then wrongly adjusted to mask the lack of support for per-alias
deferral that was fixed by #21204.
 2023-06-01 19:50:47 +01:00
Simon Charette d9e7018796 Refs #34570 -- Added extra tests for QuerySet.only() noops. 2023-06-01 19:49:26 +01:00
Cheuk Ting Ho 65da6b2ae4
Fixed #34617 -- Enabled user zooming on mobile devices in the admin. 2023-06-01 13:37:25 +01:00
Kacper Wolkiewicz 91be6e1818
Fixed #34606 -- Fixed Right() function with zero length on Oracle and SQLite. 2023-05-31 11:57:40 +01:00
Tom Forbes ea8cbca579 Made MigrationRecorder cache has_table() result if django_migrations table exists. 2023-05-25 13:18:02 +02:00
David Sanders 0c1518ee42
Fixed #34590 -- Reverted "Refs #33308 -- Improved adapting DecimalField values to decimal." 
This reverts 7990d254b0.

Thanks Marc Odermatt for the report.
 2023-05-24 10:59:55 +02:00
minusf 8b053c1e3c
Fixed #34592 -- Removed Safari/Chrome workaround for system fonts. 2023-05-24 10:26:25 +02:00
Mariusz Felisiak fc9c90d9c4
Refs #34118 -- Fixed FunctionalTests.test_cached_property_reuse_different_names() on Python 3.12+. 
Python 3.12+ no longer wraps exceptions in __set_name__, see
55c99d97e1
 2023-05-23 12:56:33 +02:00
Ben Lomax 23abec9192 Refs #31949 -- Made @no_append_slash decorator to work with async functions. 2023-05-23 10:04:41 +02:00
Simon Charette e5c844d6f2 Fixed #34551 -- Fixed QuerySet.aggregate() crash when referencing subqueries. 
Regression in 59bea9efd2.

Refs #28477.

Thanks Denis Roldán and Mariusz for the test.
 2023-05-23 06:25:58 +02:00
Simon Charette 2ee01747c3 Refs #34551 -- Fixed QuerySet.aggregate() crash on precending aggregation reference. 
Regression in 1297c0d0d7.

Refs #31679.
 2023-05-23 06:25:27 +02:00
Andrii Kohut f8172f45fc Fixed #34587 -- Allowed customizing table name normalization in inspectdb command. 2023-05-22 16:48:06 +02:00
Arthur Moreira 061a8a1bd8 Fixed #34577 -- Added escapeseq template filter. 2023-05-22 09:58:03 +02:00
Ben Lomax 00f5d2d110 Refs #31949 -- Made @xframe_options_(deny/sameorigin/exempt) decorators to work with async functions. 2023-05-20 15:52:00 +02:00
Ben Lomax b43936f2ec Moved clickjacking decorator tests into decorators/test_clickjacking.py. 
This also adds extra assertions.
 2023-05-20 15:23:52 +02:00
rajeeshp a2da81fe08 Fixed #34578 -- Made "join" template filter respect autoescape for joiner. 2023-05-19 13:16:42 +02:00
HappyDingning 674c23999c Fixed #34565 -- Added support for async checking of user passwords. 2023-05-18 09:39:04 +02:00
Carlton Gibson 4a5753fb0a
Refs #32339 -- Fixed super() call in deprecated renderers. 
Missing function call `()` leads to:

TypeError: descriptor '__init__' of 'super' object needs an argument

Regression in b209518089.
 2023-05-17 11:11:43 -03:00
Mariusz Felisiak c52f4295f2
Fixed #34568 -- Made makemigrations --update respect --name option. 
Thanks David Sanders for the report.
 2023-05-17 13:14:43 +02:00
Simon Charette 99e5dff737 Fixed #34570 -- Silenced noop deferral of many-to-many and GFK. 
While deferring many-to-many and GFK has no effect, the previous
implementation of QuerySet.defer() ignore them instead of crashing.

Regression in b3db6c8dcb.

Thanks Paco Martínez for the report.
 2023-05-17 08:06:11 +02:00
Julie Rymer 0ec60661e6 Fixed #34539 -- Restored get_prep_value() call when adapting JSONFields. 
Regression in 5c23d9f0c3.
 2023-05-16 08:26:41 +02:00
Ian Foote 7414704e88 Fixed #470 -- Added support for database defaults on fields. 
Special thanks to Hannes Ljungberg for finding multiple implementation
gaps.

Thanks also to Simon Charette, Adam Johnson, and Mariusz Felisiak for
reviews.
 2023-05-12 19:11:40 +02:00
Mariusz Felisiak 72a86ceb33
Fixed #34558 -- Fixed QuerySet.bulk_create() crash with Now() on Oracle. 2023-05-11 18:22:55 +02:00
Simon Charette ffff17d4b0 Fixed #34553 -- Fixed improper % escaping of literal in constraints. 
Proper escaping of % in string literals used when defining constaints
was attempted (a8b3f96f6) by overriding quote_value of Postgres and
Oracle schema editor. The same approach was used when adding support for
constraints to the MySQL/MariaDB backend (1fc2c70).

Later on it was discovered that this approach was not appropriate and
that a preferable one was to pass params=None when executing the
constraint creation DDL to avoid any form of interpolation in the first
place (42e8cf47).

When the second patch was applied the corrective of the first were not
removed which caused % literals to be unnecessary doubled. This flew
under the radar because the existings test were crafted in a way that
consecutive %% didn't catch regressions.

This commit introduces an extra test for __exact lookups which
highlights more adequately % doubling problems but also adjust a
previous __endswith test to cover % doubling problems (%\% -> %%\%%).

Thanks Thomas Kolar for the report.

Refs #32369, #30408, #30593.
 2023-05-10 17:25:57 +02:00
Simon Charette e0f8104a96 Refs #34553 -- Split constraint escaping test in subtests. 
This ensures that constraint violations are tested in isolation from
each other as an IntegrityError only ensures a least one constraint is
violated.

For example, the assertion added in 42e8cf4 break both the
name_constraint_rhs and the rebate_constraint constraints and thus
doesn't constitute a proper regression test. Refs #32369.
 2023-05-10 17:25:57 +02:00
Mariusz Felisiak 6e32d1fa1d
Fixed #34554 -- Fixed Reverse(Value(…)) crash on Oracle. 2023-05-10 17:22:45 +02:00
Akash Kumar Sen 92f0017133 Refs #34534 -- Reduced Add/RemoveConstraint and Add/RenameIndex operations when optimizing migrations. 2023-05-09 12:45:09 +02:00
Mariusz Felisiak 1586a09b79
Fixed #34544 -- Avoided DBMS_LOB.SUBSTR() wrapping with IS NULL condition on Oracle. 
Regression in 09ffc5c121.

Thanks Michael Smith for the report.

This also reverts commit 1e4da43955.
 2023-05-08 19:34:30 +02:00
Mariusz Felisiak fcfbf08abe
Fixed MultipleFileFieldTest.test_file_multiple_validation() test if Pillow isn't installed. 
Follow up to fb4c55d9ec.
 2023-05-04 08:09:02 +02:00
Jan Pieter Waagmeester f5b39b77e3 Fixed #34535 -- Fixed SQLite dbshell crash on pathlib.Path when handling CommandError. 
Regression in 5b884d45ac.
 2023-05-04 06:07:12 +02:00
Mariusz Felisiak fb4c55d9ec Fixed CVE-2023-31047, Fixed #31710 -- Prevented potential bypass of validation when uploading multiple files using one form field. 
Thanks Moataz Al-Sharida and nawaik for reports.

Co-authored-by: Shai Berger <shai@platonix.com>
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
 2023-05-03 13:42:00 +02:00
Mariusz Felisiak 8e2460d599
Fixed #34529, Refs #34525 -- Reduced index operations with Meta.indexes/index_together when optimizing migrations. 
This makes squashing migrations an available path for changing
Meta.index_together, which is deprecated, to Meta.indexes.

Follow up to f810325721.
 2023-05-03 13:06:19 +02:00
Orhan Hirsch ea53e7c09f Fixed #34517 -- Avoided connection post_init signal to ImageField without width/height fields. 2023-05-03 06:35:19 +02:00
Paul Brown 3b62d8c83e
Refs #31369 -- Improved hint message in NullBooleanField's deprecation warning. 2023-05-02 15:42:11 -03:00
Bakdolot c61219a7ae
Fixed #34513 -- Added system check for relational fields in ModelAdmin.list_display. 2023-05-02 06:46:22 +02:00
Mariusz Felisiak 0e444e84f8 Fixed #34515 -- Made LocaleMiddleware prefer language from paths when i18n patterns are used. 
Regression in 94e7f471c4.

This reverts commit 94e7f471c4
(refs #34069) and
partly reverts commit 3b4728310a.

Thanks Anthony Baillard for the report.

Co-Authored-By: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
 2023-05-02 06:04:18 +02:00
Mariusz Felisiak 191f6a9a45
Fixed #34528 -- Reduced Add/RemoveIndex operations when optimizing migrations. 2023-05-01 18:57:24 +02:00
4the4ryushin 0b0998dc15 Fixed #33759 -- Avoided unnecessary subquery in QuerySet.delete() with self-referential subqueries if supported. 2023-05-01 10:20:20 +02:00
Coen van der Kamp 7bbbadc693 Fixed #34380 -- Allowed specifying a default URL scheme in forms.URLField. 
This also deprecates "http" as the default scheme.
 2023-04-28 06:58:10 +02:00
Marc Gibbons 070cbac0db
Restored multiprocessing concurrency on coverage.py settings 
* Revert "Reverted "Fixed #33213 -- Doc'd testing code coverage in parallel and used it.""

This reverts commit 78da5ca0c1.

* Restored coverage multiprocess concurrency with threads

Investigating https://github.com/nedbat/coveragepy/issues/1585 revealed
that thread tracing gets disabled when passing
`concurrency = multiprocessing`. Adding `thread` restores it, and
ensures that the `auser()` is reported as covered since the test suite
uses `AsyncToSync` to execute this middleware (which spawns threads).
 2023-04-27 17:02:55 -03:00
Mariusz Felisiak 720abed343
Avoided creating default form fields in fields_for_model() when declared on form. 2023-04-27 15:26:23 +02:00
David Sanders 7d0e566208
Fixed #34518 -- Fixed crash of random() template filter with an empty list. 2023-04-26 14:17:57 +02:00
Mariusz Felisiak 9440f6ba41
Fixed #34512 -- Restored breadcrumbs on admin app index view. 
Thanks Adam (ataylor32) for the report.

Regression in 872b61193b.
 2023-04-26 08:36:56 +02:00
Claude Paroz 453cfa2815 Replaced docutils link by PyPI reference. 2023-04-25 12:41:06 +02:00
Ben Lomax 4dfc6ff8a8 Refs #31949 -- Made @never_cache and @cache_control() decorators to work with async functions. 
Thanks Carlton Gibson and Mariusz Felisiak for reviews.
 2023-04-25 10:08:03 +02:00
Ben Lomax a14ddc8cfc Added more tests for @cache_control decorator. 2023-04-25 10:04:49 +02:00
Bakdolot c813fb327c
Fixed #34481 -- Added system check for reverse related fields in ModelAdmin.list_display. 2023-04-24 08:14:35 -03:00
Simon Charette d660cee5bc Fixed #33766 -- Resolved FilteredRelation.condition at referencing time. 
The previous implementation resolved condition at Join compilation time
which required introducing a specialized expression resolving mode to
alter the join reuse logic solely during that phase.

FilteredRelation.condition is now resolved when the relation is first
referenced which maintains the existing behavior while allowing the
removal of the specialized resolving mode and address an issue where
conditions couldn't spawn new joins.
 2023-04-24 08:32:44 +02:00
Petter Friberg 8ed25d65ea Fixed #34505 -- Skipped varchar_pattern_ops/text_pattern_ops index creation when db_collation is set in related field. 2023-04-21 10:31:22 +02:00
Mariusz Felisiak 765b96734c Added SchemaTests._add_ci_collation() hook. 2023-04-21 10:00:09 +02:00
Marcelo Galigniana 8a6c0203c4 Fixed #34488 -- Made ClearableFileInput preserve "Clear" checked attribute when form is invalid. 2023-04-21 07:48:27 +02:00
Hielke Walinga fb535e0a90 Fixed #34496 -- Fixed handling source maps with data URI in ManifestStaticFilesStorage. 
Regression in 781b44240a.
 2023-04-21 05:42:06 +02:00
David Wobrock 8b1ff0da4b Refs #16055 -- Deprecated get_joining_columns()/get_reverse_joining_columns() methods. 2023-04-18 12:46:27 +02:00
David Wobrock 9bbf97bcdb Fixed #16055 -- Fixed crash when filtering against char/text GenericRelation relation on PostgreSQL. 2023-04-18 12:41:14 +02:00
sarahboyce 594fcc2b74 Fixed #22569 -- Made ModelAdmin.lookup_allowed() respect get_list_filter(). 
Thank you Simon Meers for the initial patch.
 2023-04-17 14:09:38 +02:00
Mariusz Felisiak 198a19b692
Refs #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates on different days and interval less than 1 day. 
Follow up to 813015d67e.
Regression in 8d67e16493.
 2023-04-14 17:41:03 +02:00
Scott Macpherson 53aee470d5 Fixed #34486 -- Fixed DatabaseOperations.compose_sql() crash with no existing database connection on PostgreSQL. 
Regression in 09ffc5c121.
 2023-04-14 10:11:33 +02:00
nessita 813015d67e
Fixed #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates and interval less than 1 day. 
Regression in 8d67e16493.

Thanks Lorenzo Peña for the report.
 2023-04-13 13:16:33 -03:00
Mariusz Felisiak 173034b005 Refs #34482 -- Reverted "Fixed #32969 -- Fixed pickling HttpResponse and subclasses." 
This reverts commit d7f5bfd241.

Thanks Márton Salomváry for the report.
 2023-04-12 18:52:43 +02:00
Mariusz Felisiak 280ca147af Fixed #34484, Refs #34482 -- Reverted "Fixed #29186 -- Fixed pickling HttpRequest and subclasses." 
This reverts commit 6220c445c4.

Thanks Adam Johnson and Márton Salomváry for reports.
 2023-04-12 18:52:43 +02:00
Marcelo Galigniana dfc720c521 Fixed #27505 -- Allowed customizing Paginator's error messages. 2023-04-12 14:02:28 +02:00
sarahboyce 041b0a359a Fixed #34394 -- Added FORCE_SCRIPT_NAME handling to ASGIRequest. 
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2023-04-12 12:50:48 +02:00
Jacob Walls c3d7a71f83 Fixed #34480 -- Fixed crash of annotations with Chr(). 2023-04-11 05:56:47 +02:00
sarahboyce 3b4728310a Fixed #34455 -- Restored i18n_patterns() respect of prefix_default_language argument when fallback language is used. 
Regression in 94e7f471c4.

Thanks Oussama Jarrousse for the report.
 2023-04-10 08:49:54 +02:00
Mariusz Felisiak 2eb1f37260
Refs #34118 -- Fixed CustomChoicesTests.test_uuid_unsupported on Python 3.11.4+. 
5342f5e713

Follow up to 38e63c9e61.
 2023-04-07 11:07:54 +02:00
Mariusz Felisiak 5b8a043bf5
Fixed #34470 -- Enforced UTF-8 encoding on PostgreSQL. 
Regression in 6a21658163.
 2023-04-07 10:11:41 +02:00
Anders Kaseorg 73cbb372ba Fixed #34466 -- Reallowed setting cursor_factory in DATABASES["options"] on PostgreSQL. 
Regression in 09ffc5c121.
 2023-04-07 08:02:34 +02:00
Simon Charette 9daf8b4109 Fixed #34464 -- Fixed queryset aggregation over group by reference. 
Regression in 59bea9efd2.

Refs #28477.

Thanks Ian Cubitt for the report.
 2023-04-07 06:57:32 +02:00
Mariusz Felisiak 4bf4222010 Fixed #34459 -- Fixed SearchVector() crash for parameters with % symbol. 
Thanks Patryk Zawadzki for the report.

Regression in 09ffc5c121.
 2023-04-06 13:32:47 +02:00
Mariusz Felisiak 02a04ab79a Moved SearchVectorIndexTests.test_search_vector_index to postgres_tests.test_indexes. 2023-04-06 13:32:47 +02:00
Mariusz Felisiak 38e63c9e61
Refs #34118 -- Fixed CustomChoicesTests.test_uuid_unsupported on Python 3.12+. 
2a4d8c0a9e
 2023-04-05 13:59:10 +02:00
Simon Charette 87c63bd8df Fixed #34458 -- Fixed QuerySet.defer() crash on attribute names. 
Thanks Andrew Cordery for the report.

Regression in b3db6c8dcb.
 2023-04-05 05:38:10 +02:00
Simon Charette 0e1aae7a5f Fixed #34450 -- Fixed multi-valued JOIN reuse when filtering by expressions. 
Thanks Roman Odaisky for the report.
 2023-04-04 14:35:21 +02:00
Ben Lomax f2b97fbf06 Moved cache decorators tests into decorators/test_cache.py. 2023-04-04 09:53:31 +02:00
th3nn3ss 1d1ddffc27 Fixed #33738 -- Allowed handling ASGI http.disconnect in long-lived requests. 2023-04-03 14:01:48 +02:00
Ran Benita 066aabcb77 Fixed #34445 -- Fixed string-casting of non-string lazy objects. 
This removes __text_cast() as it's the same as __cast().
_delegate_bytes and __delegate_text are mutually exclusive so the
`if self._delegate_bytes` branch in __cast() is unreachable.

Co-Authored-By: David Sanders <shang.xiao.sanders@gmail.com>
 2023-03-30 11:42:10 +02:00
Mariusz Felisiak 7330408ac3
Reverted "Refs #31949 -- Enabled @sensitive_variables to work with async functions." 
This reverts commits 23cbed2187 and
203a15cadb.
 2023-03-30 10:22:23 +02:00
David Sanders 5dba5fda55
Fixed #34427 -- Improved error message when context processor does not return a dict. 2023-03-29 08:54:04 +02:00
Mariusz Felisiak 996c802229
Fixed #34443 -- Fixed filtering by transforms on reverse relations. 
Regression in ce6230aa97.
 2023-03-28 21:03:24 +02:00
Mariusz Felisiak 3afdc9e9b4
Refs #29799 -- Added field instance lookups to suggestions in FieldErrors. 
Bug in cd1afd553f.
 2023-03-28 19:18:48 +02:00
Gary Jarrel fcc7dc5781 Fixed #34438 -- Reallowed extending UserCreationForm. 
Regression in 298d02a77a.
 2023-03-28 11:33:20 +02:00
sarahboyce 45ecd9acca Fixed #28384 -- Fixed ModelAdmin.lookup_allowed() for OneToOneField primary keys and nested relations. 2023-03-28 09:26:39 +02:00
Tom Carrick d687febce5 Fixed #34383 -- Fixed layout of admin fieldsets with multiple fields on the same line. 
Thanks Antonio Candido Nazareth junior for the report.

Regression in 96a598356a.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2023-03-27 14:05:24 +02:00
David Wobrock 21757bbdcd Refs #28948 -- Removed superfluous messages from cookie through bisect. 2023-03-27 09:22:00 +02:00
David Wobrock 9d0c878abf Refs #28948 -- Precomputed once serialized cookie messages. 
When the cookie size is too long, the same messages were serialized
over and over again.
 2023-03-27 09:14:54 +02:00
David Wobrock 67208a5ad6 Fixed typo in tests/messages_tests/test_cookie.py. 2023-03-27 08:55:48 +02:00
Simon Charette cb13792938
Fixed #34437 -- Made values() resolving error mention selected annotations. 
While the add_fields() call from set_values() does trigger validation it
does so after annotations are masked resulting in them being excluded
from the choices of valid options surfaced through a FieldError.
 2023-03-25 20:22:45 +01:00
David Smith cad376f844 Fixed #34077 -- Added form field rendering. 2023-03-24 10:16:30 +01:00
David Wobrock d6b6e5d0fd Fixed #28553 -- Fixed annotation mismatch with QuerySet.values()/values_list() on compound queries. 
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
 2023-03-24 06:09:27 +01:00
Jon Janzen 23cbed2187
Refs #31949 -- Enabled @sensitive_variables to work with async functions. 2023-03-22 10:21:04 +01:00
Jure Slak d22209cb42 Fixed #34424 -- Fixed SelectDateWidget crash for inputs raising OverflowError. 2023-03-22 07:59:39 +01:00
Jure Slak b4870e7196 Refs #34434 -- Added assertion for cleaning 0-0-0 for forms.DateField. 2023-03-22 07:50:03 +01:00
Carlton Gibson 02c356f2f3
Fixed #34428 -- Made ASGIStaticFilesHandler adapt response to async iterator. 
Bug in 0bd2c0c901.
 2023-03-21 20:51:53 +01:00
T. Franzel a2eaea8f22 Fixed #34388 -- Allowed using choice enumeration types directly on model and form fields. 2023-03-21 19:44:41 +01:00
David Smith 051d5944f8 Refs #33134, Refs #34077 -- Adjusted form rendering recursion test. 
Adjusted recursion depth test to use str() rather than the form or
field’s render() method.
 2023-03-21 15:12:56 +01:00
Liyang Zhang f9f9215d3e
Fixed some typos in comments, docstrings, and tests. 2023-03-20 08:07:23 +01:00
Andy Chosak b295b31171 Fixed #34420 -- Corrected the order of imports in generated migration files. 2023-03-20 06:23:08 +01:00
Mariusz Felisiak e10c1688f9
Fixed #34322 -- Made ES module support to ManifestStaticFilesStorage optional. 
Co-authored-by: Author: Claude Paroz <claude@2xlibre.net>
 2023-03-18 14:05:41 +01:00
hb6h057 2ffa815c73 Fixed #34421 -- Fixed QuerySet.update() on querysets in descending order by annotations. 2023-03-18 13:19:40 +01:00
sarahboyce d2b688b966 Fixed #1873 -- Handled multi-valued query parameters in admin changelist filters. 2023-03-16 08:38:44 +01:00
sarahboyce 8d6f959be2 Refs #1873 -- Added test for IncorrectLookupParameters when list of values is passed to RelatedFieldListFilter. 2023-03-16 08:34:26 +01:00
Mariusz Felisiak 78da5ca0c1
Reverted "Fixed #33213 -- Doc'd testing code coverage in parallel and used it." 
This reverts commit 69352d85fa.

Test coverage for async methods was no longer calculated with this
change.
 2023-03-15 13:05:48 +01:00
David Wobrock de0c7744be Refs #28329 -- Fixed Cast() with ForeignKey to integer fields on MySQL. 2023-03-14 08:32:17 +01:00
Mariusz Felisiak 254ad2e345
Fixed #34405 -- Fixed setting Content-Type header in FileResponse for compress and brotli. 
Thanks Chamal De Silva for the report.
 2023-03-14 05:45:30 +01:00
Claude Paroz 03bc92af97 Fixed #34407 -- Reported filename when decoding fails in collectstatic's post_process. 2023-03-12 16:54:20 +01:00
Durval Carvalho 4b1bfea284 Fixed #34333 -- Fixed migration operations ordering when adding index/constraint on new foreign key. 
Thanks Simon Charette and David Wobrock for reviews.
 2023-03-10 07:05:11 +01:00
Simon Charette dde2537fbb Fixed #27397 -- Prevented integer overflows on integer field lookups. 
This prevents a sqlite3 crash and address a potential DDoS vector on
PostgreSQL caused by full-table-scans on overflows.
 2023-03-09 15:55:10 +01:00
Hrushikesh Vaidya a52bdea5a2 Fixed #33985 -- Used app_config.verbose_name in ContentType.__str__(). 2023-03-09 10:27:08 +01:00
David Wobrock 2396933ca9 Fixed #34384 -- Fixed session validation when rotation secret keys. 
Bug in 0dcd549bbe.

Thanks Eric Zarowny for the report.
 2023-03-08 10:48:04 +01:00
Carlton Gibson 9b22457987
Refs #32172 -- Used asgiref coroutine shim in async signals tests. 
Bug in e83a88566a.
 2023-03-08 09:53:25 +01:00