9bbb6e2d25
Fixed #26522 -- Fixed a nondeterministic AssertionError in QuerySet combining.
...
Thanks Andrew Brown for the test case.
2017-03-06 13:40:17 -05:00
b6fbf3e8e5
Fixed #27879 -- Fixed crash if enclosures aren't provided to Atom1Feed.add_item().
...
Regression in 75cf9b5ac0
2017-02-24 09:46:31 -05:00
e124d2da94
Fixed #26551 -- Fixed negated Q() queries that span relations.
...
Prevented queries from reusing trimmed joins.
2017-02-09 11:20:33 -05:00
b5393028bf
Fixed #27767 -- Added distinct argument to ArrayAgg.
2017-02-04 13:57:39 -05:00
245f209109
Fixed alphabetization of Tom's in AUTHORS.
2017-02-04 13:56:41 -05:00
ac5f886c56
Fixed #27800 -- Fixed QuerySet.annotate(Length(...)).distinct() crash.
2017-01-31 18:45:55 -05:00
d5b573d872
Fixed #26993 -- Increased User.last_name max_length to 150 characters.
2017-01-28 09:29:00 -05:00
e585c43be9
Fixed #25809 -- Added BrinIndex support in django.contrib.postgres.
...
Thanks Tim Graham and Markus Holtermann for review.
2017-01-15 13:37:18 +01:00
ede59ef6f3
Fixed #27518 -- Prevented possibie password reset token leak via HTTP Referer header.
...
Thanks Florian Apolloner for contributing to this patch and
Collin Anderson, Markus Holtermann, and Tim Graham for review.
2017-01-13 09:17:54 -05:00
d57ecf40eb
Fixed #27673 -- Made admin's checks run at check time instead of during registration.
...
Thanks Morgan Aubert for the test.
2017-01-10 07:02:13 -05:00
8b734d2f99
Fixed #27432 -- Made app_label arguments limit showmigrations --plan output.
2017-01-06 19:50:31 -05:00
1c12df4aa6
Fixed #25912 -- Added binary left/right shift operators to F expressions.
...
Thanks Mariusz Felisiak for review and MySQL advice.
2017-01-03 14:15:46 -05:00
d20e046bbd
Fixed #27653 -- Added Ukrainian locale formats.
2016-12-29 07:31:32 -05:00
5cf4894836
Fixed #27628 -- Fixed unarchiving a file without permission data.
2016-12-28 19:14:58 -05:00
aaecf038ca
Fixed #27370 -- Prevented Select widget from using 'required' with a non-empty first value.
2016-12-28 10:45:22 -05:00
f6671c5d78
Fixed #27647 -- Fixed Windows segmentation fault in runserver autoreload.
2016-12-28 08:04:09 -05:00
6af23a4521
Fixed #27377 -- Clarified that prepopulated_fields doesn't work with OneToOneField.
2016-12-19 08:33:46 -05:00
98359109eb
Fixed #17002 -- Allowed using a ManyToManyField through model that inherits another.
2016-12-07 17:50:51 -05:00
794b7d8033
Refs #27546 -- Tested some __repr__() methods.
2016-12-01 08:09:38 -05:00
6573274161
Refs #27003 -- Fixed SimpleArrayField crash on converted values.
2016-11-15 18:10:45 -05:00
9da45ff352
Fixed #26985 -- Doc'd that ForeignKey.to_field reference must be unique.
2016-11-15 11:09:23 -05:00
0a63ef3f61
Fixed #27463 -- Fixed E741 flake8 warnings.
2016-11-14 17:40:28 -05:00
fd78fb82d6
Fixed #27138 -- Restored pre-Python 3.6 behavior of localtime() and make_naive() on Python 3.6.
...
Reverted test changes in a7a7ecd2b0e43ea36b76#27025 ).
2016-11-07 19:07:18 -05:00
29563cfb80
Added Emmanuelle Delescolle to AUTHORS.
...
(Fixed #23604 in 2014 and was not added before.)
2016-11-06 10:18:36 +01:00
37809b891e
Fixed #27346 -- Stopped setting the Content-Length header in ConditionalGetMiddleware.
2016-11-05 22:24:54 +01:00
a09c058918
Fixed import typos in the docs.
2016-09-29 12:06:52 -04:00
65ec8fa8ca
Fixed #20892 -- Allowed configuring memcached client using OPTIONS.
...
Previously, the MemcachedCache backend ignored `OPTIONS` and
PyLibMCCache used them to set pylibmc behaviors. Both backends now
pass `OPTIONS` as keyword arguments to the client constructors.
2016-08-31 12:50:14 -04:00
2315114090
Fixed #27067 -- Deprecated string_concat() in favor of format_lazy().
2016-08-25 16:12:40 -04:00
bc1e2d8e8e
Fixed #27018 -- Fixed admindocs crash with a view in a class.
...
Generated correct admindocs URLs on Python 3. URLs generate 404s on
Python 2, as in older versions of Django.
2016-08-20 10:01:57 -04:00
4f138fe5a4
Fixed #22288 -- Fixed F() expressions with the __range lookup.
2016-08-19 13:40:56 -04:00
72d541b61c
Fixed #27007 -- Handled non-UTF-8 bytes objects for text/* attachments.
...
The fallback logic which allows non-UTF-8 encoded files to be passed to
attach_file() even when a `text/*` mime type has been specified is
moved to attach(). Both functions now fall back to a content type of
`application/octet-stream`.
A side effect is that a file's content is decoded in memory instead of
opening it in text mode and reading it into a string.
Some mimetype-related logic in _create_attachment() has become
obsolete as the code moved from attach_file() to attach() already
handles this.
2016-08-12 16:35:09 -04:00
0814566bf1
Fixed #26960 -- Added PasswordResetConfirmView option to automatically log in after a reset.
2016-08-10 10:23:16 -04:00
013ee21cf8
Fixed #26976 -- Added LiveServerTestCase.server_thread_class to ease subclassing.
2016-08-01 16:15:41 -04:00
f8bfa80680
Fixed #26868 -- Changed MySQL version detection to use a query.
...
Workaround a bug with MariaDB and MySQL native client not stripping the
`5.5.5-` prefix.
2016-07-15 10:05:03 -04:00
d44afd8892
Fixed #26804 -- Fixed a race condition in QuerySet.update_or_create().
2016-07-14 12:10:19 -04:00
5ebebd1159
Fixed #26707 -- Added QueryDict.fromkeys()
2016-06-06 08:54:25 -04:00
bed2055506
Added Jack Moffitt to AUTHORS for 3df7266056.
2016-06-03 17:06:20 -04:00
f6517a5335
Fixed #26672 -- Fixed HStoreField to raise ValidationError instead of crashing on non-dict JSON input.
2016-06-02 16:28:01 -04:00
f1e408ff40
Fixed #25044 -- Fixed migrations for renaming ManyToManyField's through model.
2016-05-30 10:17:45 -04:00
85ef98dc6e
Fixed #24305 -- Allowed overriding fields on abstract models.
...
Fields inherited from abstract base classes may be overridden like
any other Python attribute. Inheriting from multiple models/classes
with the same attribute name will follow the MRO.
2016-05-16 07:32:21 -04:00
32dc8c0beb
Added David Sanders to AUTHORS
2016-05-13 10:16:05 -04:00
509379a161
Fixed #25945 , #26292 -- Refactored MigrationLoader.build_graph()
2016-05-08 13:53:26 +02:00
ec009ef1d8
Fixed #25986 -- Fixed crash sending email with non-ASCII in local part of the address.
...
On Python 3, sending emails failed for addresses containing non-ASCII
characters due to the usage of the legacy Python email.utils.formataddr()
function. This is fixed by using the proper Address object on Python 3.
2016-05-06 14:34:11 -04:00
1206eea11e
Fixed #26558 -- Removed need for request context processor on admin login page.
2016-05-04 09:43:24 -04:00
c1aec0feda
Fixed #25847 -- Made User.is_(anonymous|authenticated) properties.
2016-04-09 14:54:18 -04:00
b7ea494d65
Fixed #24016 -- Added documentation about third-party app data migrations
...
There was confusion about how to migrate data from third-party
applications when you are going to uninstall the application later on.
Thanks to Markus, Marten and Sergei for help and review.
2016-04-03 17:20:35 +02:00
55c843f2ef
Fixed #14131 -- Added note to docs about Pagination and large Querysets
2016-04-02 16:03:34 +02:00
39a16dd2e0
Fixed #25658 -- Allowed inspectdb to inspect a specific set of tables.
2016-03-18 08:41:15 -04:00
44c0ecdd92
Fixed #25364 -- Added generic way to test on all browsers supported by selenium.
...
Browser names should be passed as a comma separated list to the --selenium flag.
Thanks Tim Graham, Simon Charette and Moritz Sichert for review and discussion.
2016-03-15 13:10:32 -04:00
60633ef3de
Fixed #26304 -- Ignored unmanaged through model in table introspection.
2016-03-02 13:54:27 -05:00
3389c5ea22
Fixed #21608 -- Prevented logged out sessions being resurrected by concurrent requests.
...
Thanks Simon Charette for the review.
2016-02-26 18:56:56 -05:00
d4dc775620
Fixed #25735 -- Added support for test tags to DiscoverRunner.
...
Thanks Carl Meyer, Claude Paroz, and Simon Charette for review.
2016-02-17 09:44:18 -05:00
b09b71bf34
Updated my entry in AUTHORS.
2016-02-16 10:53:50 -05:00
468d8211df
Fixed #23971 -- Added "Has date"/"No date" choices for DateFieldListFilter.
2016-02-02 12:04:14 -05:00
8bf8d0e0ec
Fixed #7923 -- Added links to objects displayed by ModelAdmin.raw_id_fields.
2016-02-01 07:36:10 -05:00
31817dd2eb
Fixed #26136 -- Removed URL reversing by dotted path from JavaScript catalog example.
2016-01-27 08:58:12 -05:00
5c048f95cc
Fixed typo in docs/index.txt.
2016-01-18 10:01:23 -05:00
b643386668
Fixed #24855 -- Allowed using contrib.auth.login() without credentials.
...
Added an optional `backend` argument to login().
2016-01-07 08:56:07 -05:00
7cc2efc2d6
Fixed #26035 -- Prevented user-tools from appearing on admin logout page.
2016-01-06 13:48:02 -05:00
549eb35d5f
Added Sergey Fedoseev to AUTHORS
2015-12-18 19:48:05 +01:00
d693074d43
Fixed #20223 -- Added keep_lazy() as a replacement for allow_lazy().
...
Thanks to bmispelon and uruz for the initial patch.
2015-12-12 14:46:48 -05:00
34d88944f4
Fixed #25812 -- Restored the ability to use custom formats with the date template filter.
2015-11-28 08:38:45 -05:00
2085d8d5bc
Fixed #25170 -- Made assertXMLEqual()/assertXMLNotEqual() ignore leading and trailing whitespace.
...
Thanks Jacek Bzdak for indepdently contributing a similar fix.
2015-11-09 15:53:30 -05:00
1679472165
Fixed #25473 -- Changed underscores in url() names to dashes in docs.
...
To improve consistency, sample URL names that had underscores
in them now use dashes instead. That excludes URL names that
have some relation to the code, such as those generated by
the admin.
Thanks guettli for reporting this.
2015-11-07 21:58:45 +01:00
c4b4a7430b
Updated my email address in AUTHORS.
2015-10-27 08:46:12 -04:00
87d2bdd212
Removed duplicated entry from AUTHORS.
2015-10-21 11:02:31 -04:00
230d8c7301
Fixed #25578 -- Corrected the casing of "GitHub".
2015-10-21 07:31:11 -04:00
a76309f007
Added myself to AUTHORS.
2015-10-07 07:47:09 -04:00
914167abf1
Fixed #25503 -- Fixed system check crash on ForeignKey to abstract model.
2015-10-06 19:22:37 -04:00
ac09d22f79
Fixed #25481 -- Added field.help_text to "Looping over a form's fields" docs.
2015-10-02 12:52:14 -04:00
1335aa2fb9
Fixed #15760 -- Added JavaScript events for admin inline forms.
2015-09-21 15:34:44 -04:00
d8d853378b
Fixed #24944 -- Added extra_email_context parameter to password_reset() view.
2015-09-18 18:56:04 -04:00
e34226fc37
Fixed #25259 -- Added comments to header of generated migration files
2015-08-31 22:14:21 +10:00
22bb548900
Fixed #22634 -- Made the database-backed session backends more extensible.
...
Introduced an AbstractBaseSession model and hooks providing the option
of overriding the model class used by the session store and the session
store class used by the model.
2015-08-27 15:00:09 -04:00
4bc00defd0
Fixed #14217 -- Added validation for field name collision when using model inheritance.
2015-08-25 16:16:54 -04:00
4ce433e811
Fixed #25302 -- Prevented BrokenLinkEmailsMiddleware from reporting 404s when Referer = URL.
2015-08-24 19:35:49 -04:00
d3fdaf907d
Fixed #23727 -- Inhibited the post_migrate signal when using serialized_rollback.
...
When using a TransactionTestCase with serialized_rollback=True,
after creating the database and running its migrations (along with
emitting the post_migrate signal), the contents of the database
are serialized to _test_serialized_contents.
After the first test case, _fixture_teardown() would flush the
tables but then the post_migrate signal would be emitted and new
rows (with new PKs) would be created in the django_content_type
table. Then in any subsequent test cases in a suite,
_fixture_setup() attempts to deserialize the content of
_test_serialized_contents, but these rows are identical to the
rows already in the database except for their PKs. This causes an
IntegrityError due to the unique constraint in the
django_content_type table.
This change made it so that in the above scenario the post_migrate
signal is not emitted after flushing the tables, since it will be
repopulated during fixture_setup().
2015-08-24 08:59:20 -04:00
1f7b25c1a7
Fixed #24986 -- Added support for annotations in DISTINCT queries.
2015-08-15 08:23:32 -04:00
c9fb4f3c45
Fixed #25205 -- Removed doc references to deprecated GeoManager class.
2015-08-11 10:14:44 -04:00
5aba3f0a45
Added Chris Jones and Kenneth Love to AUTHORS.
...
contrib.auth.mixins is based on our work with django-braces.
2015-07-21 21:09:40 -04:00
db97a88495
Fixed #24375 -- Added Migration.initial attribute
...
The new attribute is checked when the `migrate --fake-initial` option
is used. initial will be set to True for all initial migrations (this
is particularly useful when initial migrations are split) as well as
for squashed migrations.
2015-07-13 15:57:40 -04:00
b91a2a499f
Fixed #23190 -- Made Paginator.page_range an iterator
2015-07-03 11:34:34 -04:00
a570701e02
Fixed #25029 -- Added PersistentRemoteUserMiddleware for login-page-only external authentication.
2015-07-02 17:38:10 -04:00
9a5cfa05a0
Fixed #24997 -- Enabled bulk_create() on proxy models
2015-07-02 13:53:51 -04:00
e75b614640
Fixed #25009 -- Allowed User.objects.create_user(...,is_staff=True) to work.
2015-06-22 11:34:26 -04:00
b3d5dc6932
Fixed #24834 -- Fixed get_current_site() when Host header contains port.
...
When the Host header contains a port, looking up the Site record fails
as the host will never match the domain.
2015-06-18 10:18:12 -04:00
e5cb4e1411
Fixed #24914 -- Added authentication mixins for CBVs
...
Added the mixins LoginRequiredMixin, PermissionRequiredMixin and
UserPassesTestMixin to contrib.auth as counterparts to the respective
view decorators.
The authentication mixins UserPassesTestMixin, LoginRequiredMixin and
PermissionRequiredMixin have been inspired by django-braces
<https://github.com/brack3t/django-braces/ >
Thanks Raphael Michel for the initial patch, tests and docs on the PR
and Ana Balica, Kenneth Love, Marc Tamlyn, and Tim Graham for the
review.
2015-06-17 23:19:10 +02:00
9aac99e96d
Refs #9619 -- Added a test that Field.from_db_value() is called on QuerySet.values()
2015-06-17 12:20:32 -04:00
afa82aa41a
Added Sutrisno Efendi to AUTHORS.
2015-06-10 22:16:49 -04:00
818a325a6d
Added myself to AUTHORS
2015-06-09 12:48:02 -04:00
8957b1682c
Added Markus Amalthea Magnuson to AUTHORS.
...
Made some contributions in the past, seems like I never got around to adding myself :)
https://github.com/django/django/commits?author=alimony
2015-06-06 01:03:53 +01:00
40f0a84cb1
Fixed #24159 -- Made compilemessages run across all apps.
...
Updated the command to match the documentation, which states it
runs over all .po files.
2015-06-04 21:02:02 -04:00
e60cce4e40
Fixed #24846 -- Added support to MySQL SchemaEditor for all blob/text data types
2015-05-30 20:37:57 -04:00
b0b8f56d3a
Added myself to AUTHORS
2015-05-19 12:34:08 -04:00
70e3e2e08e
Fixed #24774 -- Made contrib.site's Site.domain field unique
2015-05-16 08:43:42 -04:00
37682368a6
Fixed #24656 -- Added missing imports to query expressions doc.
2015-04-24 10:54:19 -04:00
b5e0eede40
Fixed #22394 -- Refactored built-in datetime lookups to transforms.
2015-04-20 15:11:11 -04:00
923da0274a
Fixed #24611 -- Fixed update() crash with related UUID pk object.
2015-04-13 12:18:24 -04:00
e8e4f978dd
Fixed #24278 -- Fixed serialization of migration operations.
...
Fixed MigrationWriter.serialize() to correctly handle migration
operations by utilizing OperationWriter.
Thanks Piotr Maliński for the report.
2015-04-05 20:26:21 +02:00
8f98732379
Added Ryan Hall to AUTHORS. Refs #24554
2015-04-01 19:05:32 -04:00
e4cf8c8420
Fixed #24301 -- Added PostgreSQL-specific aggregate functions
2015-03-30 10:44:37 -04:00
1f2abf784a
Fixed #24469 -- Refined escaping of Django's form elements in non-Django templates.
2015-03-27 19:46:20 -04:00
2444c231e1
Added Alex Hill to AUTHORS.
2015-03-21 10:31:36 +01:00
d898ba1bec
Fixed #24419 -- Added sendtestemail management command
2015-03-20 12:03:50 -04:00
a535e4acdc
Added myself to AUTHORS; refs #24226 .
2015-03-12 19:26:22 -04:00
b4d8b16e51
Fixed #24364 -- Doc'ed that ManifestStaticFileStorage shouldn't be used during testing.
2015-03-12 09:23:00 -04:00
668d53cd12
Fixed #21495 -- Added settings.CSRF_HEADER_NAME
2015-03-05 15:03:40 -05:00
00fbd8fd52
Broke long lines in code examples.
...
The website only renders code blocks at 96 chars, and therefore
long code lines get wrapped. Manually breaking the lines prevents
the wrapping from occurring.
2015-02-23 07:45:37 -05:00
e215d325a8
Updated my email address in AUTHORS.
2015-02-09 09:46:00 -05:00
250aa7c39b
Fixed #24240 -- Allowed GZipping a Unicode StreamingHttpResponse
...
make_bytes() assumed that if the Content-Encoding header is set, then
everything had already been dealt with bytes-wise, but in a streaming
situation this was not necessarily the case.
make_bytes() is only called when necessary when working with a
StreamingHttpResponse iterable, but by that point the middleware has
added the Content-Encoding header and thus make_bytes() tried to call
bytes(value) (and dies). If it had been a normal HttpResponse,
make_bytes() would have been called when the content was set, well
before the middleware set the Content-Encoding header.
This commit removes the special casing when Content-Encoding is set,
allowing unicode strings to be encoded during the iteration before they
are e.g. gzipped. This behaviour was added a long time ago for #4969 and
it doesn't appear to be necessary any more, as everything is correctly
made into bytes at the appropriate places.
Two new tests, to show that supplying non-ASCII characters to a
StreamingHttpResponse works fine normally, and when passed through the
GZip middleware (the latter dies without the change to make_bytes()).
Removes the test with a nonsense Content-Encoding and Unicode input - if
this were to happen, it can still be encoded as bytes fine.
2015-02-03 18:18:12 +01:00
beed786b81
Updated my e-mail address in AUTHORS.
2015-01-19 15:42:44 -05:00
65246de7b1
Fixed #24031 -- Added CASE expressions to the ORM.
2015-01-12 18:15:34 -05:00
54085b0f9b
Fixed #23998 -- Added datetime.time support to migrations questioner.
2014-12-22 07:24:54 -05:00
3dbbb8a89c
Fixed #23983 -- Fixed a crash in migrations when adding order_with_respect_to to non-empty table.
2014-12-16 10:48:49 -05:00
4fada6f1c9
Fixed #23893 : Added tzinfo to constant datetime in unit test
...
Added tzinfo to y2k constant (01/01/2000) in
custom_lookups.tests.DateTimeLookupTests.test_datetime_output_field
to fix warning message regarding naive datetimes.
2014-12-16 02:54:59 -07:00
018d110ef5
Fixed #23911 -- Added support for buffer file uploads in the test client
2014-12-04 07:42:03 -05:00
b872134bfc
Fixed #23768 -- Rewrote template tests as unit tests.
2014-12-02 19:18:35 -05:00
4df3a3e0e9
Added GDAL prototypes for raster support
...
Refs #23804 .
2014-12-02 19:56:35 +01:00
17fe0bd808
Fixed #23423 -- Added unaccent lookup in django.contrib.postgres
2014-11-28 18:22:20 -05:00
deb607648e
Fixed #23728 -- Added the --exit option to makemigrations.
...
If no changes that need migrations are found, `makemigrations --exit`
exits with error code 1.
2014-11-28 07:48:39 -05:00
21e21c7bc2
Fixed #23844 -- Used topological sort for migration operation dependency resolution.
...
This removes the concept of equality between operations to guarantee
compatilibity with Python 3.
Python 3 requires equality to result in identical object hashes. It's
impossible to implement a unique hash that preserves equality as
operations such as field creation depend on being able to accept
arbitrary dicts that cannot be hashed reliably.
Thanks Klaas van Schelven for the original patch in
13d613f800
2014-11-20 12:49:49 -05:00
83d104d61a
Revert "Use topological sort for migration operation dependency resolution"
...
This commit broke the tests on Python 3.
This reverts commit 13d613f800
2014-11-15 15:28:04 +01:00
f59fd15c49
Fixed #14030 -- Allowed annotations to accept all expressions
2014-11-15 14:00:43 +00:00
13d613f800
Use topological sort for migration operation dependency resolution
...
rather than an ad-hoc algorithm
2014-11-15 14:45:42 +01:00
b7a5b6ab86
Fixed #23750 -- Allowed core.checks.register to be used as a function
2014-11-11 16:29:32 +01:00
7b42036752
Fixed #5405 -- Added admindocs support for reStructured text in model docstrings
...
Thanks elvard and gkmngrgn for work on the patch and Markus H. for review.
2014-11-03 15:30:46 -05:00
ed2f96819c
Fixed #23715 -- Prevented urlize from treating a trailing ! as part of an URL
...
Thanks to 57even for the report.
2014-10-31 08:06:40 -04:00
db7b393aff
Added Bashar Al-Abdulhadi to AUTHORS
...
made django 100% arabized https://www.transifex.com/projects/p/django/language/ar/ , https://twitter.com/_Bashar/status/468845303668695040
2014-10-15 22:20:08 +03:00
466b38ea3d
Added Jaap Roes to AUTHORS
2014-10-10 10:04:32 -04:00
322cbe0db7
Updated my AUTHORS entry.
2014-10-10 08:00:44 -04:00
8a4e9be3e5
Add myself to AUTHORS and register authorship of ed37f7e
...
This commit is a record that ed37f7e
2014-10-08 04:28:23 +07:00
d1e87aebf7
Refactored model lookup tests; refs #18586 .
2014-10-07 12:04:56 -04:00
fe2afcd318
Fixed #23569 -- Allowed using configs besides dictConfig in LOGGING_CONFIG.
2014-09-30 17:13:27 -04:00
d8e157d5ab
Refactored m2m_through tests. Refs #18586
...
Refactored old tests that were rewritten 1:1 from doctests.
2014-09-26 01:28:32 +07:00
6613ea6e3f
Fixed #23370 -- defer() + select_related() crashed with inherited models.
2014-08-30 07:14:44 -04:00
d074dfc016
Alphabetized AUTHORS by first name.
2014-08-24 20:13:34 -04:00
11d9cbe2f4
Fixed #23316 -- Added datetime.time serialization in migrations.
2014-08-19 13:31:46 -04:00
01801edd37
Fixed #22646 : Added support for the MySQL ssl-ca option to dbshell.
2014-08-13 18:29:42 -04:00
98e8da3709
Fixed #16311 -- Added a RelatedOnlyFieldListFilter class in admin.filters.
2014-08-04 09:39:02 -04:00
cdc25ac474
Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types..
...
Thanks Mattias Lindvall for the report and inital patch.
2014-07-31 15:29:46 -04:00
fa3cf006b2
Fixed #23078 -- Regression in update_contenttypes() interactivity.
...
Thanks raymond at adaptiv.nl for the report.
2014-07-23 08:45:09 -04:00
d88333661b
Removed primary authors section from AUTHORS.
2014-07-10 07:17:53 -04:00
e0e8e1e383
Fixed an alphabetization in AUTHORS
...
"Eric Palakovich Carr" should be sorted by "P", not "C".
2014-07-05 20:16:36 -04:00
27ee608b55
Fixed #22940 -- Added missing string iterpolation parameters in migrations.writer error.
...
Forwardport of f5740af868
2014-07-02 12:45:02 -04:00
29c1151a55
Fixed #22756 -- Added view name to technical 404 template if Http404 is raised.
...
Thanks Keryn Knight for the suggestion.
2014-06-30 15:34:35 -04:00
407d070329
Fixed #22782 -- Added i18n attr to Sitemap class
...
It makes possible to have your sitemap in multiple languages when
using i18n in URLs.
2014-06-20 13:04:41 -04:00
d862fae5bb
Refs #12663 -- Added tests for methods in db.models.options.
...
Thanks Russell Keith-Magee and Tim Graham for reviews.
2014-06-19 12:56:36 -04:00
87d0a3384c
Fixed #22778 -- Added a model Meta option to define default_related_name.
...
Thanks jorgecarleitao and mmardini for reviews.
2014-06-18 13:53:07 -04:00
2d425116e2
Fixed #22349 -- Added a note clarifying `RawQuerySet` has no `__len__`.
...
Thanks cdestigter for the report.
2014-06-12 16:41:49 -04:00
2e4d667ec1
Added note to alphabetize AUTHORS.
2014-06-11 16:03:36 -04:00
f97c53c098
Fixed #22801 -- Added 'www.' to diveintopython.net links
2014-06-10 15:38:25 -04:00
72f055e535
Fixed #20550 -- Added keepdb argument to destroy_test_db
2014-06-05 23:17:27 +01:00
11f0899bbe
Fixed #11776 -- Added CSS class for non-field/top of form errors.
...
Thanks Daniel Pope for the suggestion.
2014-06-02 15:22:15 -04:00
32586b0ba4
Fixed #22684 -- Added `empty_label` option on `django.forms.extras.widets.SelectDateWidget`
...
Thanks danielsamuels for the report
2014-05-28 13:23:28 -04:00
a5de0df58b
Fixed #22502 -- Fixed microseconds/default/form interaction
...
Made explicit lack of microsecond handling by built-in datetime form
fields. Used that explicitness to appropriately nix microsecond
values in bound fields. Thanks Claude Paroz for the review.
2014-05-10 10:56:39 +02:00
a5f6cbce07
Refactored DjangoTranslation class
...
Also fixes #18192 and #21055 .
2014-04-30 18:36:25 +02:00
0707b824fe
Fixed #22328 -- Added --exclude option to compilemessages and makemessages.
2014-04-26 17:07:44 +07:00
d3b71b976d
Fixed #21760 -- prefetch_related used an inefficient query for reverse FK.
...
Regression introduced by commit 9777442#21410 .
2014-04-13 00:34:16 +07:00
5e4e0b6fe9
Fixed #22306 -- Deprecated future versions of cycle and firstof template tags.
2014-03-28 18:55:06 -04:00
d22b291890
Fixed #22001 -- Ensure db_type is respected.
...
db_parameters should respect an already existing db_type method and
return that as its type string. In particular, this was causing some
fields from gis to not be generated.
Thanks to @bigsassy and @blueyed for their work on the patch.
Also fixed #22260
2014-03-14 22:32:17 +00:00
95c74b9d69
Fixed #22206 -- Passed models.TextField.max_length to forms.CharField.maxlength
2014-03-05 20:09:28 +01:00
bb2ca9fe6c
Fixed #22172 -- Allowed index_together to be a single list (rather than list of lists)..
...
Thanks EmilStenstrom for the suggestion.
2014-03-01 15:44:42 -05:00
94b5bc361a
Fixed #22002 -- Documented avoiding database interaction in AppConfig.ready().
...
Thanks Marc Tamlyn for the suggestion.
2014-02-15 13:50:31 -05:00
8bbdcc76e4
Fixed #19299 -- Fixed Nullification of Foreign Keys To CharFields
...
Thanks tunixman for the report and Baptiste Mispelon and
Shai Berger for reviews.
2014-02-15 09:47:32 -05:00
eefc88feef
Fixed #2445 -- Allowed limit_choices_to attribute to be a callable.
...
ForeignKey or ManyToManyField attribute ``limit_choices_to`` can now
be a callable that returns either a ``Q`` object or a dict.
Thanks michael at actrix.gen.nz for the original suggestion.
2014-02-11 14:05:12 -05:00
5d263dee30
Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string().
...
Thanks Aymeric Augustin for the suggestion and review.
2014-02-08 11:12:19 -05:00
09d1e0486a
Added ticket #14007 contributors to AUTHORS
2014-01-25 21:56:51 +07:00
19e5cd77f0
Fixed #21497 -- Forced conversion to bytes for very long index names
2013-11-24 13:15:50 -05:00
3ac823fc5b
Fixed #21460 -- Reenabled proper template precedence in find_template
...
Refs #20806 . Thanks Unai Zalakain for the review.
2013-11-22 11:09:51 +01:00
c3936c0d79
Fixed #9523 -- Restart runserver after translation MO files change
...
Thanks to Krzysztof Kulewski for the initial patch.
2013-11-02 10:29:07 +01:00
15f82c7011
Fixed #9722 - used pyinotify as change detection system when available
...
Used pyinotify (when available) to replace the "pool-every-one-second"
mechanism in `django.utils.autoreload`.
Thanks Chris Lamb and Pascal Hartig for work on the patch.
2013-10-30 11:45:43 -04:00
d07d6ae116
Fixed #20910 -- Added a "snippet" sphinx directive to allow prefixing a filename.
...
Thanks Marc Tamlyn for the suggestion.
2013-10-14 13:00:57 -04:00
e077224f4a
Fixed #20962 -- Documented that template tag render() may raise exceptions.
...
Thanks Keryn Knight for the report.
2013-10-14 11:53:15 -04:00
1ab27e9a65
Fixed #18866 -- added validation error for verbose_name longer than 39 characters
...
Added a validation error check when creating the permissions for model, to avoid
cryptic database error when the verbose_name is longer than 39 characters
thanks elena for reporting it
2013-10-14 14:19:35 +01:00
671757b507
Fixed #21161 -- Timezone-related tests on Windows.
...
Thanks Xelnor for the patch.
2013-10-05 18:50:20 +02:00
2004f86b85
Add myself to authors file
2013-09-30 13:19:53 -04:00
a834bc84d8
Fixed #20931 -- Fixed select widgets nested choice rendering
...
ChoiceFieldRenderer was not rendering nested choices. Added recursion
to ChoiceFieldRenderer to take nested choices and render them as
<ul>'s.
2013-09-28 17:25:32 -07:00
f5f662fa5f
Fixed #21112 -- Make sure sitemaps with no lastmod date work correctly.
...
Thanks to Matthias Kestenholz for the report and patch.
2013-09-17 10:21:11 -04:00
18ffdb1772
Fixed #17627 -- Renamed util.py files to utils.py
...
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
2013-09-16 12:52:05 -04:00
5e1c7d4cf6
Add myself to authors file
2013-09-09 09:03:50 -04:00
04415bf81b
Fixed #21013 -- Ensure that ModelAdmin.get_queryset is considered for the admin history view.
2013-09-07 14:53:29 -05:00
6d2be870d7
adding myself to authors file
...
Alex requested I add myself in IRC, so I am. =)
2013-09-07 13:16:36 -05:00
55a11683f7
Fixed #20836 -- Ensure that the ForeignKey's to_field attribute is properly considered by the admin's interface when creating related objects.
...
Many thanks to Collin Anderson for the report and patch and to Peter Sheats for the test.
2013-09-07 12:14:07 -05:00
ded40142a9
Fixed #20007 -- Configured psycopg2 to return UnicodeArrays
...
Thanks hogbait for the report.
2013-09-06 20:43:58 -04:00
926bc421d9
Merge pull request #1566 from adamsc64/ticket_11857
...
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
2013-09-06 17:38:37 -07:00
0756a4d664
Added Christopher Adams to the AUTHORS file.
...
- Note that 'Chris Adams' and 'Christopher Adams' are two different
contributors.
2013-09-06 20:36:42 -04:00
70440a8bd1
Merge pull request #1581 from mburst/patch-1
...
Added myself to the contributors list for work on #21049
2013-09-06 16:44:11 -07:00
4f5faa1916
Merge pull request #1582 from rca/12756-missing-yaml-module-serializer-error-message
...
Fixed #12756 : Improved error message when yaml module is missing.
2013-09-06 16:05:02 -07:00
01a5359477
Cleanup commit after peer review.
2013-09-06 22:45:31 +00:00
0ac5e8d8e9
Added name to AUTHORS (per Russell Keith-Magee)
2013-09-06 22:26:13 +00:00
77da814827
Added myself to the contributors list.
2013-09-06 17:16:40 -05:00
122020fdb9
Merge pull request #1579 from ianawilson/ticket_21058
...
Fixed #21058 -- Fixed debug view blowing up when no template is provided to the template rendering functions.
Assistance on this commit from @jambonrose.
2013-09-06 15:06:57 -07:00
c1bbc8cae9
Added Rudy Mutter to AUTHORS for his work, ref #20821 .
2013-09-06 16:05:53 -05:00
9b7f4aab32
adds fix and test for when a template is not specified at all to render(). fixes #21058 . by jambonrose and ianawilson
2013-09-06 15:50:18 -05:00
082b0638ef
Added myself to the committers list.
2013-08-21 16:10:51 +02:00
22c6497f99
Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value
...
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
2013-08-15 19:47:26 -04:00
ff410565bf
Fixed #20709 -- Allowed {% widthratio %} to accept an "as" parameter.
...
Thanks clay.evil@ for the suggestion.
2013-08-14 12:40:19 -04:00
71c491972e
Fixed #11400 -- Passed kwargs from AbstractUser.email_user() to send_mail()
...
Thanks Jug_ for suggestion, john_scott for the initial patch,
and Tim Graham for code review.
2013-08-14 07:46:11 -04:00
4eeb8ec147
Fixed #20864 -- Made the test client use common method for performing requests.
2013-08-13 19:08:13 -04:00
0cac4fbf69
Fixed #18356 -- Gave the test client signals.template_rendered call a unique dispatch_uid
...
This prevents the test client context from being lost when the client
is used in a nested fashion.
2013-08-09 12:22:42 -04:00
6d88d47be6
Fixed #20832 -- Enabled HTML password reset email
...
Added optional html_email_template_name parameter to password_reset view
and PasswordResetForm.
2013-08-05 09:47:28 -04:00
94d7fed775
Fixed #20859 - Clarified Model.clean() example.
2013-08-05 09:06:09 -04:00
1123f45511
Fixed #20649 -- Allowed blank field display to be defined in the initial list of choices.
2013-07-31 14:12:03 -04:00
bb145e2c47
Fixed #13629 -- Added CSS classes to the `<body>` tag of some admin templates to allow style customizations per app or per model.
2013-07-21 20:17:14 +00:00
a269ea4fe0
Fixed #14656 -- Added Atom1Feed `published` element
...
Some feed aggregators make use of the `published` element as well as
the `updated` element (within the Atom standard -- http://bit.ly/2YySb ).
The standard allows for these two elements to be present in the same
entry. `Atom1Feed` had implemented the `updated` element which was
incorrectly taking the date from `pubdate`.
2013-07-19 10:38:34 -04:00
6272d2f155
Fixed #20429 -- Added QuerySet.update_or_create
...
Thanks tunixman for the suggestion and Loic Bistuer for the review.
2013-07-12 08:26:35 -04:00
273dc550a4
Fixed #20462 -- null/non-string regex lookups are now consistent
...
Thanks to noirbizarre for the report and initial patch.
2013-06-26 08:13:26 -04:00
338ec9333d
Fixed a very old email address of mine still lingering in the AUTHORS file
2013-06-23 00:18:23 +02:00
ef37b23050
Fixed #18872 -- Added prefix to FormMixin
...
Thanks @ibustama for the initial patch and dragonsnaker for opening the
report.
2013-06-22 12:12:43 +01:00
552a90b444
Fixed #20290 -- Allow override_settings to be nested
...
Refactored override_settings to store the underlying settings._wrapped
value seen at runtime, not instantiation time.
2013-06-21 16:57:47 +02:00
18e79f1425
Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists.
...
Thanks to kux for the report, and Russ Webber for the patch.
2013-06-20 18:55:27 +08:00
b6f86fbeb1
Added myself to the commiters list.
2013-06-17 12:30:41 +02:00
92c49d6f01
Revert "Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields."
...
This reverts commit 64041f0e6e
2013-06-11 17:55:19 -04:00
64041f0e6e
Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields.
2013-06-11 14:13:40 -04:00
69373f3420
Fixed #19925 - Added validation for REQUIRED_FIELDS being a list
...
Thanks Roman Alexander for the suggestion.
2013-06-07 19:58:41 -04:00
a2967d5204
Fixed #20242 - Added a regression test for prefetch_related.
...
Issue was fixed by removal of chunked reads from
QuerySet iteration in 70679243d1
2013-05-28 13:37:44 -04:00
d194714c0a
Fixed #11603 - Added django.test.SimpleTestCase.assertFormsetError
...
Thank-you Martin Green for the patch.
2013-05-27 12:25:35 -04:00
f940e564e4
Fixed #20099 -- Eased subclassing of BrokenLinkEmailsMiddleware
...
Thanks Ram Rachum for the report and the initial patch, and Simon
Charette for the review.
2013-05-25 12:10:53 +02:00
48424adaba
Fixed #17648 -- Add `for_concrete_model` to `GenericForeignKey`.
...
Allows a `GenericForeignKey` to reference proxy models. The default
for `for_concrete_model` is `True` to keep backwards compatibility.
Also added the analog `for_concrete_model` kwarg to
`generic_inlineformset_factory` to provide an API at the form level.
2013-05-23 19:03:14 -04:00
ef8a9bc7fa
Fixed #17048 - Added docs for upgrading Django.
...
Thanks Donald Stufft for the suggestion and
Susan Tan and Brian Fabian Crain for the patch.
2013-05-22 08:52:46 -04:00
e83ff42792
Fixed #20459 - Improved example for setting HTTP header fields.
...
Thanks Jérémie Blaser.
2013-05-19 12:30:53 -04:00
2d309a7043
Fixed #15961 -- Modified ModelAdmin to allow for custom search methods.
...
This adds a get_search_results method that users can override to
provide custom search strategies.
Thanks to Daniele Procida for help with the docs.
2013-05-19 16:45:00 +02:00
f88700d610
Fix #19664 -- Illegal Characters In Session Key Give Fatal Error On File Backend Only
2013-05-19 15:33:05 +02:00
761bbbbbae
Added Baptiste to AUTHORS.
2013-05-19 14:36:38 +02:00
1fe587d80b
Add missing imports and models to the examples in the admin documentation
2013-05-19 13:35:19 +02:00
04e0fc029f
Merge pull request #1094 from senko/ticket_11160
...
Fixed #11160 : Formset non_form_errors returns ErrorList() if is_valid is not called
2013-05-19 03:56:14 -07:00
33c361ef9d
Merge pull request #1129 from frog32/master
...
Add needed Imports to the Documentation
2013-05-19 01:37:25 -07:00
7d77e9786a
Fixed #20246 -- Added non-breaking spaces between values an units
2013-05-18 23:01:48 +02:00
caf56ad174
Fixed #20440 -- Ensured CharField's max_length/min_length are integers
2013-05-18 22:30:24 +02:00
a4a761ada2
add Leandra Finger, Silvan Spross and Marc Egli to AUTHORS
2013-05-18 18:39:28 +02:00
63a9555d57
Fixed #19436 -- Don't log warnings in ensure_csrf_cookie.
2013-05-18 16:17:46 +02:00
dc43fbc2f2
Fixed #18998 - Prevented session crash when auth backend removed
...
Removing a backend configured in AUTHENTICATION_BACKENDS should not
raise an exception for existing sessions, but should make already
logged-in users disconnect.
Thanks Bradley Ayers for the report.
2013-05-18 15:58:29 +02:00
89955cc35f
Fixed #9595 -- Allow non-expiring cache timeouts.
...
Also, streamline the use of 0 and None between cache backends.
2013-05-18 15:39:42 +02:00
1c921cfac3
Fixed #20235 -- Use self.object_list if object_list not present in get_context_data kwargs.
...
This is so MultipleObjectMixin can be used in the same way as
SingleObjectMixin.
2013-05-18 14:10:40 +02:00
b11b036145
Added myself to AUTHORS
2013-05-18 13:49:13 +02:00
ee11d325a4
Reorganize committers list chronologically.
...
This completes the removal of the distinction between core devs and
specialists.
Patch by Simon Meers.
2013-05-18 10:29:01 +02:00
31d98d4ab5
Added myself to committers.
2013-05-17 17:24:17 +02:00
291250f7b6
Added clarification to the docs, pointing out that unique_for_date only considers the date portion of DateTime fields.
2013-05-03 08:46:53 -05:00
a506b6981b
Fixed #18231 -- Made JavaScript i18n not pollute global JS namespace.
...
Also, use Django templating for the dynamic generated JS code and use
more idiomatic coding techniques.
Thanks Matthew Tretter for the report and the patch.
2013-04-14 17:45:01 -03:00
2bcbca3451
Updated some 'Dive Into Python' links
2013-04-01 14:04:41 +02:00
705591508d
Add Donald Stufft to the AUTHORS file
2013-03-26 13:27:03 -04:00
ccb87f97ad
Reordered AUTHORS in last name alphabetic order
2013-03-20 10:21:40 +01:00
9a85ad89c2
Fixed #16319 -- added SuccessMessageMixin to contrib.messages
...
Thanks martinogden for the initial patch and d1ffuz0r for tests.
2013-03-19 21:02:55 -07:00
1fe90b281b
Reworded Mark Pilgrim section in AUTHORS.
...
Removed the RIP, which seemed callous given today's news of Malcolm's death.
2013-03-19 12:35:10 -05:00
9d6ecc6bc6
Fixed #19327 -- Added handling of double login attempts in admin.
...
Thanks to Krzysztof Jurewicz for initial patch and
adupin for tests.
2013-03-18 17:11:07 -07:00
d7bc4fbc94
Implemented an 'atomic' decorator and context manager.
...
Currently it only works in autocommit mode.
Based on @xact by Christophe Pettus.
2013-03-11 14:48:55 +01:00
6983a1a540
Fixed #15363 -- Renamed and normalized to `get_queryset` the methods that return a QuerySet.
2013-03-08 10:11:45 -05:00
4cccb85e29
Fixed #19997 -- Added custom EMPTY_VALUES to form fields
...
Thanks Loic Bistuer for the report and the patch.
2013-03-07 15:22:03 +01:00
d9330d5be2
Fixed #6585 -- Admin relationship widgets: Respect ordering defined by target model's ModelAdmin.
...
Thanks Gary Wilson for the report and Juan Pedro Fisanotti, Carlos
Matías de la Torre for the fix.
2013-03-04 18:08:53 -03:00
3ea0c7d35a
Fixed #19838 -- Admin: Don't leak a 500 HTTP status when trying to delete protected FKs.
...
Thanks rafadev for the report and Javier Mansilla for the fix.
2013-03-04 13:30:59 -03:00
Bo Marchman
Pavlo Kapyshin
François Freitag
orf
Tim Graham
Lex Berezhny
Thom Wiggers
Mads Jensen
Romain Garrigues
Adam Chainz
Sebastian Spiegel
anabelensc
Illia Volochii
Anton Samarchyan
Josef Rousek
Aleksi Häkli
Henry Dang
InvalidInterrupt
Keda87
Brandon Chinn
Jonatas CD
Ramin Farajpour Cami
Joachim Jablon
Erik Romijn
Adam Malinowski
Frank Wiles
Ed Morley
Mattias Loverot
Helen Sherwood-Taylor
Matthew Wilkes
Michael Schwarz
jordij
Chris Jerdonek
Marc-Aurèle Brothier
Jensen Cochran
wim glenn
Corey Farwell
Brad Melin
Vytis Banaitis
Aron Podrigal
David Sanders
Jarek Glowacki
Sergei Maertens
Dan Stephenson
Jeremy Lainé
rixx
Daniel Jilg
José Tomás Tocino
Akshesh
Matthew Schinckel
Tore Lundqvist
Jakub Paczkowski
F. Malina
rynomster
Hugo Osvaldo Barrera
Yoong Kang Lim
auvipy
Paulo Poiati
Scott Pashley
Claude Paroz
Iacopo Spalletti
Gagaro
Mattia Larentis
Thijs van Dien
Chris Lamb
Sergey Fedoseev
Yusuke Miyazaki
Jonas Haag
Mariusz Felisiak
John Moses
ramez
sujayskumar
Tyson Clugg
Sergey Kolosov
sarthakmeh
Maxime Lorant
Tommy Beadle
Valentina Mukhamedzhanova
Brendan Hayward
Kenneth Love
Andrei Kulakov
Rigel Di Scala
Jan Pazdziora
William Schwartz
Francisco Albarran
Nick Pope
Markus Holtermann
JensDiemer
Sutrisno Efendi
girishkumarkh
Markus Amalthea Magnuson
Matthew Somerville
Riccardo Magliocchetti
Piotr Jakimiak
Nicolas Noé
Jon Dufresne
Jay Wineinger
Marten Kenbeek
Ryan Hall
Andriy Sokolovskiy
Moritz Sichert
Aymeric Augustin
Loek van Gent
ifedapo olarewaju
Aksel Ethem
Grzegorz Slusarek
Ian Lee
Justine Alexandra Roberts Tunney
Jakub Wilk
Michał Modzelewski
Oscar Ramirez
Andriy Sokolovskiy
Michael Hall
Thomas Tanner
Preston Timmons
Daniel Wiesmann
Thomas Chaumeny
Tim Heap
Patryk Zawadzki
Josh Smeaton
Klaas van Schelven
averybigant
Zan Anderle
Bashar Al-Abdulhadi
Jaap Roes
Batiste Bieler
André Ericson
Browniebroke
Seth Hill
Davide Ceretti
Akis Kesoglou
Halit Alptekin
Lee Sanghyuck
zsoldosp
Stanislas Guerra
Niclas Olofsson
Nick Sandford
Eric Palakovich Carr
Colin Wood
Julia Matsieva
Luan Pablo
Daniel Pyrathon
Renaud Parent
Moayad Mardini
Maxime Turcotte
Greg Chapple
Nick Presta
Guillaume Pannatier
Stephen Burrows
Doug Beck
Ana Krivokapic
valtron
Marc Tamlyn
Chris Wilson
Anubhav Joshi
Zbigniew Siciarz
Albert Wang
Christopher Adams
Berker Peksag
Mark Sandstrom
Joel Bohman
Pablo Martín
Bouke Haarsma
Unai Zalakain
M Nasimul Haque
joaoxsouls
Dan Johnson
Christopher Babiak
Simon Charette
Curtis Maloney
Juan Catalano
Garry Polley
Julien Phalip
Eric Boersma
Russell Keith-Magee
Roberto Aguilar
Max Burstein
Ian Wilson
evildmp
Alasdair Nicol
Jonathan Slenders
SusanTan
Krzysztof Jurewicz
Bojan Mihelac
Justin Michalicek
Jimmy Song
Alex Couper
Thomas Sorrel
Matt Deacalion Stevens
Karol Sikora
Andrew Clark
Remco Wendt
Gilberto Gonçalves
Oliver Beattie
Baptiste Mispelon
Axel Haustant
Chris Streeter
Gavin Wahl
Bozidar Benko
Erik Romijn
vkuzma
Andrew Godwin
Emil Stenström
Tome Cvitan
Marc Egli
Olivier Sels
Jorge Bastida
Jacob Burch
Senko Rasic
Aaron Cannon
Matthew Tretter
Donald Stufft
Paul Collins
Adrian Holovaty
Deric Crago
Loic Bistuer
Juan Pedro Fisanotti
Javier Mansilla