Commit Graph

9376 Commits

Author SHA1 Message Date
Honza Král aee9db9b3e Preventing problems possibly introduced by r14662
acquire a lock before entering a try block that ends with the lock's
release. Thanks for the catch Alex.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14668 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 17:34:21 +00:00
Honza Král 65b380e74a Fixed #11418 -- formset.cleaned_data no longer raises AttributeError when is_valid is True. Thanks mlavin!
This also introduces a slightly backwards-incompatible change in
FormSet's behavior, see the release docs for details.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14667 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 17:27:01 +00:00
Ramiro Morales 752bd8bf75 Added printing of the name of test database being created/destroyed, at verbosity level 2. Refs #14415.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14666 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 17:18:26 +00:00
Ramiro Morales 6774207394 Fixed #14453 -- Changed handling of microseconds part in typecast_timestamp() DB backend helper function to be more correct. Thanks philipn for the report and fix.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14664 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 15:08:53 +00:00
Honza Král f27e6f0dd1 Fixed #14533 -- Make django signals more thread-safe. Thanks milosu for the patch!
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14662 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 14:54:23 +00:00
Honza Král 14abb7c52c Fixed #14741 -- CZ Localflavor clean() incorrectly called super.__init__. Thanks for the report and patch idangazit!
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14660 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 14:06:32 +00:00
Honza Král 70b3ac1f07 Few improvements to FormPreview, thanks Andy!
This commit adds several new hooks in backwards-compatible way:
 * get_initial to specify initial data based on request
 * get_auto_id to enable different AUTO_ID values
 * get_context for overriding and extending default context contents

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14659 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 13:47:38 +00:00
Chris Beaven b8a78804b5 Fixes #13804 -- URLField validation failure for a url containing '://' on the path and no scheme
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14657 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 10:08:28 +00:00
Chris Beaven f6ead36969 Fixed #4552 -- minor tidy up of the {% for %} tag's comma splitting
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14656 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 08:03:58 +00:00
Carl Meyer 9b432cb67b Fixed #5768 -- Added support for ManyToManyFields and reverse relations in values() and values_list(). Thanks to mrmachine for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14655 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 02:28:25 +00:00
Justin Bronn 7592d68541 Now possible to run the GeoDjango test suite with a minimal settings file. Refs #10420, #14439.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14653 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 23:54:59 +00:00
Alex Gaynor d4bb8313f7 Reformated some code for readability.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14652 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 21:00:41 +00:00
Luke Plant e364f9ca7a Fixed typo in docs.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14651 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 20:40:16 +00:00
Luke Plant d4c6abcbd1 Documented migration path for change object_list -> ListView regarding different context variables
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14650 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 20:38:52 +00:00
Russell Keith-Magee ece3a7c3c7 Corrected a markup problem with an example in the class-based view docs. Thanks to apollo13 for the report.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14649 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 11:33:43 +00:00
Russell Keith-Magee 790f0eb7fe Corrected a typo in the docs for {% load %}. Thanks to Jannis for the report.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14648 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 11:16:43 +00:00
Gabriel Hurley 58b6c65fa9 Replaced an inappropriate UTF8 character in the admindocs docs. Thanks to Luke Plant for the report.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14646 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 11:10:48 +00:00
Gabriel Hurley a56e47400f Fixed #14727 -- Corrected three minor issues in the docs. Thanks to OldTroll for the report and the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14644 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 10:49:42 +00:00
Russell Keith-Magee 7ff5580d95 Fixed #14389, #9666 -- Started the migration path to make the first argument to url and ssi template tags syntactically consistent with other tags. Thanks to Sean Brant for the draft patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14643 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 06:22:28 +00:00
Russell Keith-Magee 591ad8afbf Fixed #14512 -- Added documentation on how to apply decorators to class-based generic views. Thanks to Łukasz Rekucki for his work on the issue.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14642 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 05:10:13 +00:00
Luke Plant ec7c49f253 Fixed hyperlinking of template tags for Sphinx >= 1.0
Follow on from incomplete fix in [14477], and [14631] which removed
compatibility for Sphinx < 1.0

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14639 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 01:37:54 +00:00
Ian Kelly 58eca97e71 Updated an old workaround described in the Oracle backend notes with more modern advice.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14637 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 01:11:34 +00:00
Carl Meyer 61a89f8e1b Fixed poorly-constructed test from r14612. Thanks to Alex Gaynor for the eagle eyes.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14635 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-20 00:05:11 +00:00
Ramiro Morales f609306349 Removed compatibility with Sphinx < 1.0 workarounds in our extension code. Also, started to use the 'needs_sphinx' Sphinx config var.
Follow up on r14624.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14631 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 23:19:56 +00:00
Ian Kelly c0adc62fcc Fixed #13351: Added documentation about the cx_Oracle 'threaded' option to the oracle backend notes.
Thanks to Skaffen for the suggestion.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14630 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 23:19:23 +00:00
Ramiro Morales 0e26f58dae Corrected change in behavior regarding the page shown after the 'Save' button is pressed when adding a user through the admin.
It had been introduced in trunk (r13503) and between 1.2.1 and 1.2.2 (r13504). The original fix intended to correct a similar problem introduced between 1.1 and 1.2 (r12218) this time in the 'Save and add another' button.
We have now tests for the three buttons present in the Add User admin form to avoid future regressions.
Thanks to Juan Pedro Fisanotti and Cesar H. Roldan for their work.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14628 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 22:45:51 +00:00
Alex Gaynor a3e7ee7c40 Began converting localflavor doctests into unittests, starting with the German ones. Also introduced a new base class to facilitate ease of testing form fields. We have always been at war with doctests. Thanks to Idan Gazit for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14626 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 19:33:07 +00:00
Carl Meyer 59c84b4391 Bumped documentation-building requirements to Sphinx 1.0.2 and Pygments 1.1. The use of 'console' highlight in staticfiles docs requires Pygments 1.1.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14624 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 16:10:23 +00:00
Russell Keith-Magee 99d247f4cb Fixed #13795 -- Added a site-wide cache prefix and cache versioning. Thanks to bruth for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14623 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 15:39:35 +00:00
Carl Meyer 261aee26c1 Fixed #14728 -- Broadened warning about django-admin.py missing .py suffix to include more than just Ubuntu, since at least Fedora also does this. Thanks to giallu for the report.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14621 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 14:26:01 +00:00
Alex Gaynor 49d831380f Corrected the way databases were compared. This allows running the test suite with two in memory SQLite databases.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14619 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 08:08:08 +00:00
Alex Gaynor f777ddf3e6 Fixed a failing test caused by [14614].
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14618 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-19 03:42:20 +00:00
Alex Gaynor 3ede430b9a Converted the model_regress doctests into unittests. We have always been at war with doctests.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18 23:32:01 +00:00
Carl Meyer 008f333bac Fixed pk uniqueness validation for new objects created outside of a ModelForm. Also removed need for ModelForm to poke at Model._state.adding, keeping it an internal ORM concern.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14613 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18 23:29:58 +00:00
Carl Meyer 38ba3775ec Fixed #14234 -- Re-validating a model instance added via ModelForm no longer throws spurious PK uniqueness errors. Thanks to David Reynolds and Jeremy Dunck.
Also moved Model._adding to Model._state.adding to reduce instance namespace footprint.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14612 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18 22:43:46 +00:00
Luke Plant 9cebb526f2 Fixed incorrect path to MultipleObjectMixin in docs.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14611 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18 01:53:38 +00:00
Luke Plant a205fe9378 Added notes in old generic views howto about the new class based approach.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14610 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18 01:29:41 +00:00
Luke Plant 9712f4c7a4 Corrected link in release notes.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14609 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18 01:29:25 +00:00
Jannis Leidel 9b6535b894 Fixed #7077 and #7431 -- Use getpass.getuser instead of pwd.getpwuid to determine the current system user's username in the createsuperuser management command to enable the feature on Windows. getpass.getuser automatically falls back to the previous method.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14607 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 20:28:33 +00:00
Alex Gaynor 0aeb6c964a Added a hidden toctree pointing at the index file in the docs to silence a sphinx warning.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14605 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 20:26:20 +00:00
Alex Gaynor 204253ed40 Fixed #14713 -- documented that resolve can raise Http404. Thanks to Adam for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14603 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 20:03:15 +00:00
Alex Gaynor fc47f8c65a Fixed #14257 -- removed ManyToManyField.isValidIDList which was completely dead code (unused since magic-removal). Thanks to andrewsk for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14602 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 17:00:40 +00:00
Alex Gaynor 0eb31d3dc9 Fixed #14423 -- corrected incorrect SQL being generated when a nullable, inherited field was used in an exclude. Thanks to PhiR_42 for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14600 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 16:46:50 +00:00
Alex Gaynor c0248f6f07 Corrected some syntax issues in the docs.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14598 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 16:08:28 +00:00
Jannis Leidel 8a7a8f465b Removed stale directory not removed by git-svn in r14592.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14597 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 15:46:11 +00:00
Jannis Leidel 17b329ae08 Fixed #10004 and #12320 -- Enabled the makemessages management command to collect comments for translators that start with the "Translators" keyword. Thanks for the report and patches, martinb and Claude Paroz.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14595 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 15:37:33 +00:00
Jannis Leidel d7ad02ff72 Fixed a bunch of code examples in the form media documentation.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14594 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 15:36:58 +00:00
Jannis Leidel 96af304747 Fixed #10636 -- Added check to make sure the ADMIN_MEDIA_PREFIX setting is properly set before serving files with the AdminMediaHandler.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14593 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 15:36:42 +00:00
Jannis Leidel 33d8fcde8a Fixed #14693, #14709 -- Backwards incompatible change to rectify the confusion around the STATICFILES_URL and STATICFILES_ROOT settings.
* Two new global settings that will be used by -- **but are not limited to** -- the staticfiles app: STATIC_ROOT and STATIC_URL.

  * Moving the 'django.contrib.staticfiles.templatetags.staticfiles' template tag to the core ('django.templatetags.static') and renaming it to 'get_static_prefix'.

  * Moving the context processor 'django.contrib.staticfiles.context_processors.staticfiles' to the core ('django.core.context_processors.static') and renaming it to 'static'.

  * Paths in media definitions will use STATIC_URL as the prefix if the value is not None, and falls back to the previously used MEDIA_URL.

Thanks again to the community for constructive criticism and Carl and Russ for sanity-inducing discussions on IRC.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14592 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 15:36:26 +00:00
Russell Keith-Magee 9b45f6cd54 Migrated model_formsets doctests. Thanks to Gregor Müllegger for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14590 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 13:30:44 +00:00