Commit Graph

13891 Commits

Author SHA1 Message Date
Maryam Yusuf 7e00fee3bd Fixed #35546 -- Emphasised accepted ticket requirement in contributing docs. 2024-07-29 15:12:43 +02:00
Maryam Yusuf 9d10c7ab33 Referenced joining the triage and review team as motivation to do PR reviews. 2024-07-29 14:46:10 +02:00
Lorenzo Peña 0e94f292cd Fixed #35627 -- Raised a LookupError rather than an unhandled ValueError in get_supported_language_variant().
LocaleMiddleware didn't handle the ValueError raised by
get_supported_language_variant() when language codes were
over 500 characters.

Regression in 9e9792228a.
2024-07-25 09:38:46 +02:00
Sarah Boyce 2c024c9ac0 Added contributor guidelines for performance optimizations. 2024-07-25 09:25:25 +02:00
Simon Charette f359990e49 Fixed #35625 -- Fixed a crash when adding a field with db_default and check constraint.
This is the exact same issue as refs #30408 but for creating a model with a
constraint containing % escapes instead of column addition. All of these issues
stem from a lack of SQL and parameters separation from the BaseConstraint DDL
generating methods preventing them from being mixed with other parts of the
schema alteration logic that do make use of parametrization on some backends
(e.g. Postgres, MySQL for DEFAULT).

Prior to the addition of Field.db_default and GeneratedField in 5.0
parametrization of DDL was never exercised on model creation so this is
effectively a bug with db_default as the GeneratedField case was addressed by
refs #35336.

Thanks Julien Chaumont for the report and Mariusz Felisiak for the review.
2024-07-25 07:48:53 +02:00
Sarah Boyce 8d6a20b656 Fixed #35604, Refs #35326 -- Made FileSystemStorage.exists() behaviour independent from allow_overwrite.
Partially reverts 0b33a3abc2.

Storage.exists(name) was documented to "return False if
the name is available for a new file." but return True if
the file exists. This is ambiguous in the overwrite file
case. It will now always return whether the file exists.

Thank you to Natalia Bidart and Josh Schneier for the
review.
2024-07-24 14:55:10 +02:00
arjunomray 5559011c2b Fixed #35541 -- Fixed paginator border in admin CSS. 2024-07-24 12:28:23 +02:00
Mariusz Felisiak df35cf578f Updated asgiref dependency for 5.1 release series. 2024-07-24 08:21:07 +02:00
Matthew Somerville fb7be022cb Updated example links in urlize docs.
goo.gl links are being removed in 2025:
https://developers.googleblog.com/en/google-url-shortener-links-will-no-longer-be-available/
2024-07-23 14:02:30 +02:00
nessita cf03aa4e94
Refs #10941 -- Reorganized querystring template tag docs. 2024-07-22 10:31:54 -03:00
Hisham Mahmood 182f262b15 Fixed #35606, Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox for models with a __html__ method.
Thank you Claude Paroz for the report.

Regression in 85366fbca7.
2024-07-18 08:09:37 +02:00
Simon Charette adc0b6aac3 Fixed #35594 -- Added unique nulls distinct validation for expressions.
Thanks Mark Gensler for the report.
2024-07-17 12:52:17 +02:00
Sarah Boyce 27043bde5b
Refs #10941 -- Renamed query_string template tag to querystring. 2024-07-15 13:28:55 -03:00
Maryam Yusuf b5f4d76bc4 Fixed #35464 -- Updated docs to note fieldsets have limited impact on TabularInlines. 2024-07-15 12:43:42 +02:00
Tim Graham dfd63ff434
Refs #35506 -- Reverted "global URLconf" to "root URLconf" in tutorial 1. 2024-07-12 15:09:28 -03:00
Natalia e095c7612d Added CVE-2024-38875, CVE-2024-39329, CVE-2024-39330, and CVE-2024-39614 to security archive. 2024-07-09 11:58:27 -03:00
Natalia 9c356144d7 Added stub release notes for 5.0.8. 2024-07-09 11:41:28 -03:00
Natalia 1062bf7302 Made cosmetic edits to 5.0.7 release notes. 2024-07-09 09:36:54 -03:00
Sarah Boyce 9e9792228a Fixed CVE-2024-39614 -- Mitigated potential DoS in get_supported_language_variant().
Language codes are now parsed with a maximum length limit of 500 chars.

Thanks to MProgrammer for the report.
2024-07-09 09:21:19 -03:00
Natalia fe4a0bbe20 Fixed CVE-2024-39330 -- Added extra file name validation in Storage's save method.
Thanks to Josh Schneier for the report, and to Carlton Gibson and Sarah
Boyce for the reviews.
2024-07-09 09:21:19 -03:00
Michael Manfre 5d86458579 Fixed CVE-2024-39329 -- Standarized timing of verify_password() when checking unusuable passwords.
Refs #20760.

Thanks Michael Manfre for the fix and to Adam Johnson for the review.
2024-07-09 09:21:19 -03:00
Adam Johnson d666457453 Fixed CVE-2024-38875 -- Mitigated potential DoS in urlize and urlizetrunc template filters.
Thank you to Elias Myllymäki for the report.

Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-07-09 09:21:19 -03:00
lucas-r-oliveira 2c931fda5b Fixed 35506 -- Clarified initial references to URLconf in tutorial 1. 2024-07-08 22:02:13 -03:00
Mariusz Felisiak f302343380
Removed outdated note about limitations in Clickjacking protection.
There is no need to list old browser versions or point users to
workarounds.
2024-07-04 18:08:19 -03:00
Andreu Vallbona 55a2e3136b Replaced usage of "patch" with more precise terms in contributing docs. 2024-07-04 17:52:19 -03:00
Kudz 82c71f0168 Relocated database setup details to install docs to simplify tutorial 2.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-07-04 15:30:52 -03:00
Mark Gensler 1005c2abd1 Fixed #35560 -- Made Model.full_clean() ignore GeneratedFields for constraints.
Accessing generated field values on unsaved models caused a crash when
validating CheckConstraints and UniqueConstraints with expressions.
2024-07-04 11:45:15 +02:00
Carlton Gibson 704192e478 Removed unneeded hyphens in "counterintuitive".
Follow-up to 65ad4ade74 which added
counterintuitive to the wordlist. Removes unneeded (antiquated)
hyphenated usages.

See e.g. https://www.merriam-webster.com/dictionary/counterintuitive
2024-07-04 08:30:19 +02:00
Natalia 89557d4c66 Added stub release notes and release date for 5.0.7 and 4.2.14. 2024-07-03 14:09:34 -03:00
Simon Charette 65ad4ade74 Refs #28900 -- Made SELECT respect the order specified by values(*selected).
Previously the order was always extra_fields + model_fields + annotations with
respective local ordering inferred from the insertion order of *selected.

This commits introduces a new `Query.selected` propery that keeps tracks of the
global select order as specified by on values assignment. This is crucial
feature to allow the combination of queries mixing annotations and table
references.

It also allows the removal of the re-ordering shenanigans perform by
ValuesListIterable in order to re-map the tuples returned from the database
backend to the order specified by values_list() as they'll be in the right
order at query compilation time.

Refs #28553 as the initially reported issue that was only partially fixed
for annotations by d6b6e5d0fd.

Thanks Mariusz Felisiak and Sarah Boyce for review.
2024-07-03 16:36:25 +02:00
alexgmin 2e47dde438 Fixed #35511 -- Documented when the py binary is unavailable on Windows. 2024-07-03 16:28:17 +02:00
Andrew Miller aa74c4083e Fixed #23790 -- Warned about renaming AppConfig.label in docs/ref/applications.txt. 2024-07-01 21:52:04 -03:00
Michael 289f48c71b
Fixed typo in source file linking Sphinx extension. 2024-07-01 11:32:48 -03:00
Mariusz Felisiak 8719a6181e
Refs #22712 -- Corrected deprecation of "all" argument in django.contrib.staticfiles.finders.find().
Features deprecated in Django 5.2 should be removed in Django 6.1.
2024-06-28 08:39:55 -03:00
Andreu Vallbona 0fdcf1029c Fixed #22712 -- Avoided name shadowing of "all" in django.contrib.staticfiles.finders.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-06-27 23:37:12 -03:00
raffaella 88966bc2fe Added references to the Django Discord server inside the FAQ docs. 2024-06-26 12:37:17 +02:00
Sarah Boyce 72b7b59680 Optimized admin docs images. 2024-06-25 17:45:20 -03:00
Sarah Boyce a6dde9fbd5 Refs #35380 -- Updated screenshots in intro docs. 2024-06-25 17:45:20 -03:00
Sarah Boyce e510bb1ab1
Fixed #35558 -- Increased inline H3 headers color prominence in admin change page. 2024-06-25 14:03:21 -03:00
nessita bcc327aa32
Refs #35380 -- Updated screenshots in admin docs.
When listing users, ensure that user first and last name are diverse.
2024-06-25 10:58:36 -03:00
arjunomray d9bd58c3b8 Fixed #35540 -- Fixed the padding on admin login page. 2024-06-25 11:35:07 +02:00
lufafajoshua 136a5f9409 Fixed #34886 -- Modified sample use of lazy in delayed translations.
Modified example to use python standard library function
to lower the case of the string.
2024-06-25 08:59:38 +02:00
Claude Paroz 4686541691
Migrated setuptools configuration to pyproject.toml.
This branch migrates setuptools configuration from setup.py/setup.cfg to
pyproject.toml. In order to ensure that the generated binary files have
consistent casing (both the tarball and the wheel), setuptools version
is limited to ">=61.0.0,<69.3.0".

Configuration for flake8 was moved to a dedicated .flake8 file since
it cannot be configured via pyproject.toml.

Also, __pycache__ exclusion was removed from MANIFEST and the
extras/Makefile was replaced with a simpler build command.

Co-authored-by: Nick Pope <nick@nickpope.me.uk>
2024-06-24 15:34:43 -03:00
lufafajoshua 3ac0e43207 Fixed #35306 -- Documented fallback localization formats in templates when localization is disabled. 2024-06-24 18:06:44 +02:00
Rosana Rufer 72b7aecbbf Fixed #35461 -- Updated misleading django-debug-toolbar instructions.
The DjDT "handle" isn't visible on the polls application as the templates
are missing <body> tags for brevity.
2024-06-21 12:01:34 +02:00
Ronny Vedrilla 5fef6d2445 Fixed #35528 -- Added EmailMultiAlternatives.body_contains() helper method. 2024-06-21 12:00:56 +02:00
Sarah Boyce 7a0cd09f9f Cleaned up EmailMultiAlternatives docs. 2024-06-21 09:43:10 +02:00
Jake Howard aba0e541ca Fixed #35537 -- Changed EmailMessage.attachments and EmailMultiAlternatives.alternatives to use namedtuples.
This makes it more descriptive to pull out the named fields.
2024-06-20 09:43:40 +02:00
John Higgins 60acad933d Fixed #35441 -- Documented Context and RequestContext keyword arguments. 2024-06-20 09:34:55 +02:00
Baptiste Mispelon 62300b81cf Fixed #12978 -- Added support for RSS feed stylesheets. 2024-06-18 17:25:43 +02:00
stefan.ivic ce1ad98565 Fixed #35505 -- Added extrabody block to admin/base.html. 2024-06-18 16:49:53 +02:00
Sarah Boyce 1b21feeb7b Restructured the EmailMultiAlternatives docs. 2024-06-18 11:22:49 +02:00
lufafajoshua 8733e9af99 Fixed #35470 -- Separated i18n and l10n globalization settings docs. 2024-06-13 09:09:46 +02:00
lufafajoshua e2428292ab Fixed #35401 -- Documented the conditional_page() decorator. 2024-06-12 13:11:29 +02:00
lufafajoshua 708b01c795 Refs #35401 -- Linked the CsrfViewMiddleware docs to the csrf_protect() decorator. 2024-06-12 13:11:29 +02:00
Andreu Vallbona f812b927a5
Moved confirmation about dev server running to earlier in tutorial 1. 2024-06-09 14:51:40 -03:00
Andreu Vallbona 85240139ca Replaced usage of "patch" with more precise terms in faq, howto, and intro docs. 2024-06-09 14:38:04 -03:00
Andreu Vallbona 3556f63c4c
Simplified tutorial 1 when describing how to run the dev server. 2024-06-09 04:42:21 -03:00
Ismael 6efbeb997c
Fixed #35503 -- Removed distracting PHP reference in tutorial 1. 2024-06-08 09:41:41 -03:00
Natalia adae619426 Updated release date for Django 5.0.7. 2024-05-31 10:45:30 -03:00
Mariusz Felisiak 0f694ce2eb
Made cosmetic edits to code snippets reformatted with blacken-docs. 2024-05-30 09:42:05 -03:00
Jake Howard ff308a0604
Fixed 35467 -- Replaced urlparse with urlsplit where appropriate.
This work should not generate any change of functionality, and
`urlsplit` is approximately 6x faster.

Most use cases of `urlparse` didn't touch the path, so they can be
converted to `urlsplit` without any issue. Most of those which do use
`.path`, simply parse the URL, mutate the querystring, then put them
back together, which is also fine (so long as urlunsplit is used).
2024-05-29 10:48:27 -03:00
samruddhiDharankar 02dab94c7b Fixed #35473 -- Fixed CVE number in security archive.
Updated to CVE-2009-3695 from CVE-2009-3965.
2024-05-29 09:26:07 +02:00
Simon Törnqvist d3a7ed5bcc Fixed #35443 -- Changed ordinal to return negative numbers unchanged.
Previously, `-1` was converted to `"-1th"`. This has been updated to
return negative numbers "as is", so that for example `-1` is
converted to `"-1"`. This is now explicit in the docs.

Co-authored-by: Martin Jonson <artin.onson@gmail.com>
2024-05-27 10:54:25 +02:00
Mariusz Felisiak b049bec7cf Fixed #35479 -- Dropped support for PostgreSQL 13 and PostGIS 3.0. 2024-05-27 09:49:25 +02:00
い。 718ed69751 Fixed #35430 -- Corrected docs on timezone conversion in templates. 2024-05-23 12:35:20 +02:00
Adam Zapletal 99273fd525 Fixed #24076 -- Added warnings on usage of dates with DateTimeField and datetimes with DateField. 2024-05-23 12:03:57 +02:00
Natalia 04a208d7f1 Increased the default PBKDF2 iterations for Django 5.2. 2024-05-22 15:44:07 -03:00
Natalia 3a748cd0f5 Advanced deprecation warnings for Django 5.2. 2024-05-22 15:44:07 -03:00
Natalia 05cce083ad Removed versionadded/changed annotations for 5.0.
This also removes remaining versionadded/changed annotations for older
versions.
2024-05-22 15:44:07 -03:00
Natalia ec44247f59 Added stub release notes for 5.2. 2024-05-22 15:44:07 -03:00
Natalia b625764744 Bumped version; main is now 5.2 pre-alpha. 2024-05-22 15:44:07 -03:00
Natalia b7c7209c67 Updated man page for Django 5.1 alpha. 2024-05-22 11:29:45 -03:00
Natalia 59b649c7df Made cosmetic edits to 5.1 release notes. 2024-05-22 11:29:45 -03:00
Natalia 8e68c50341 Removed empty sections from 5.1 release notes. 2024-05-22 11:29:45 -03:00
Hisham Mahmood c7fc9f20b4 Fixed #31405 -- Added LoginRequiredMiddleware.
Co-authored-by: Adam Johnson <me@adamj.eu>
Co-authored-by: Mehmet İnce <mehmet@mehmetince.net>
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-05-22 08:51:17 +02:00
Marijke Luttekes 7857507c7f Refs #35189 -- Removed no longer necessary JavaScript file collapse.js. 2024-05-22 00:13:55 -03:00
Natalia 676060d683 Refs #35189 -- Updated ModelAdmin.fieldsets screenshot in admin docs. 2024-05-22 00:13:55 -03:00
Marijke Luttekes e4a693f50a Fixed #35189 -- Improved admin collapsible fieldsets by using <details> elements.
This work improves the accessibility of the add and change pages in the
admin site by adding <details> and <summary> elements to the collapsible
fieldsets. This has the nice side effect of no longer requiring custom
JavaScript helpers to implement the fieldsets' show/hide capabilities.

Thanks to James Scholes for the accessibility advice, and to Sarah Boyce
and Tom Carrick for reviews.

Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-05-22 00:13:55 -03:00
John Parton 9c5fe93349 Fixed #35139 -- Prevented file read after ImageField is saved to storage. 2024-05-22 00:25:56 +02:00
Berker Peksag 4971a9afe5 Fixed #18119 -- Added a DomainNameValidator validator.
Thanks Claude Paroz for the review.

Co-authored-by: Nina Menezes <77671865+nmenezes0@users.noreply.github.com>
2024-05-21 23:11:12 +02:00
Adam Johnson b9838c65ec Fixed #35405 -- Converted get_cache_name into a cached property in FieldCacheMixin.
FieldCacheMixin is used by related fields to track their cached values.
This work migrates get_cache_name() to be a cached property to optimize
performance by reducing unnecessary function calls when working with
related fields, given that its value remains constant.

Co-authored-by: Simon Charette <charette.s@gmail.com>
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-05-21 16:19:29 -03:00
David Smith 15fff62d5d
Refs #29942 -- Fixed docs build on Python < 3.9 avoiding dict union operator.
The docs build process was failing on djangoproject.com since it uses Python 3.8 and the dict union operator was added in Python 3.9.
2024-05-21 09:15:29 -03:00
Mariusz Felisiak 480ccf9055 Refs #35326 -- Made cosmetic edits to 5.1 release notes. 2024-05-21 11:23:44 +02:00
Ben Cail 0b33a3abc2 Fixed #35326 -- Added allow_overwrite parameter to FileSystemStorage. 2024-05-21 07:28:12 +02:00
SaJH 8f205acea9 Fixed #35428 -- Increased parallelism of the ScryptPasswordHasher. 2024-05-17 17:13:58 +02:00
Adam Johnson 50852b2c2c Replaced fictional class 'extrapretty' in admin fieldsets docs. 2024-05-16 21:25:23 -03:00
Sarah Boyce d4f6e6c088 Moved FileSystemStorage note in docs to the correct place. 2024-05-16 11:17:57 +02:00
Jonny Park c0b0ce85ed Fixed #35384 -- Raised FieldError when saving a file without a name to FileField. 2024-05-15 12:02:45 +02:00
Joachim Jablon b691accea1 Fixed #29942 -- Restored source file linking in docs by using the Sphinx linkcode ext.
Co-authored-by: David Smith <smithdc@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-05-14 22:08:29 -03:00
Mariusz Felisiak f030236a86 Fixed #35275 -- Fixed Meta.constraints validation crash on UniqueConstraint with OpClass().
This also introduces Expression.constraint_validation_compatible that
allows specifying that expression should be ignored during a constraint
validation.
2024-05-14 10:34:30 +02:00
ZeyadMoustafaKamal a09082a9be Replaced djangosites.org with builtwithdjango.com. 2024-05-13 09:48:12 +02:00
nessita 1a36dce9c5
Updated docs for the Django release process. 2024-05-10 19:45:19 -03:00
r3a96 0e445badd5 Removed Redis parser_class reference from docs. 2024-05-08 08:41:13 +02:00
Natalia b79ac89c57 Added stub release notes for 5.0.7. 2024-05-07 15:06:02 -03:00
Sarah Boyce 90175e110e Added release notes for 5.0.6 and 4.2.13. 2024-05-07 17:21:21 +02:00
Sarah Boyce 34a503162f Added release date for 5.0.5 and 4.2.12. 2024-05-06 14:35:57 +02:00
alexgmin dba05042dd Added link to the csrf template tag in the csrf page. 2024-05-06 13:25:30 +02:00
sobolevn 9a27c76021 Fixed #35426 -- Updated querysets to be a required argument of GenericPrefetch. 2024-05-04 11:30:36 +02:00
Shamil 32d163e680 Fixed #35427 -- Corrected help text for makemessages --extension in docs/ref/django-admin.txt. 2024-05-03 22:48:17 -03:00