04b15022e8
Fixed #26261 -- Fixed queryset crash when excluding reverse GenericRelation.
...
Thanks Amir Hadi for the report.
2022-11-18 10:13:31 +01:00
cd4da34fc1
Fixed #33004 -- Made saving objects with unsaved GenericForeignKey raise ValueError.
...
This aligns to the behaviour of OneToOneField and ForeignKey fields.
Thanks Jonny Park for the initial patch.
2022-04-21 10:12:28 +02:00
1ed8ca43f6
Refs #13085 -- Removed unnecessary ManyToManyFields from generic_relations_regress test models.
2022-04-21 09:59:09 +02:00
9c19aff7c7
Refs #33476 -- Reformatted code with Black.
2022-02-07 20:37:05 +01:00
7bb0605a8c
Fixed isolation of GenericRelationTests.test_filter_targets_related_pk().
2021-07-08 13:13:40 +02:00
16adf4d6b1
Fixed GenericRelationTests.test_annotate when primary key values are large.
...
On CockroachDB, primary key values stored in this fields are larger
than they accept.
2020-11-04 06:41:48 +01:00
555e3a848e
Removed unused __str__() methods in tests models.
...
Follow up to 6461583b6c
2020-04-30 09:13:23 +02:00
335c9c94ac
Simplified imports from django.db and django.contrib.gis.db.
2020-02-04 13:20:06 +01:00
b5c7cb4d33
Fixed #29653 -- Fixed missing related_query_name reverse accessor if GenericRelation is declared on an abstract base model.
...
Regression in 4ab027b944
2018-08-10 12:17:26 -04:00
5fa4f40f45
Fixed #29227 -- Allowed BooleanField to be null=True.
...
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
2018-03-20 12:10:10 -04:00
4ab027b944
Fixed #28988 -- Fixed queries when a GenericRelation is used with multi-table inheritance.
2018-03-12 22:42:48 -04:00
a9e5ac823d
Refs #28856 -- Added test for caching of a GenericForeignKey pointing to a model that uses more than one level of MTI.
...
Forwardport of test and release notes of
3522203502
2017-12-08 14:06:28 -05:00
e50add6ca1
Fixed #28856 -- Fixed a regression in caching of a GenericForeignKey pointing to a MTI model.
...
Regression in b9f8635f58
2017-11-30 09:28:44 -05:00
f9e5f9ae9f
Fixed #28418 -- Fixed queryset crash when using a GenericRelation to a proxy model.
2017-07-21 18:21:13 -04:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
4c5ed3e683
Refs #23919 -- Removed __nonzero__() methods (for Python 2).
...
Thanks Tim for the review.
2017-01-19 11:26:26 -05:00
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
0a63ef3f61
Fixed #27463 -- Fixed E741 flake8 warnings.
2016-11-14 17:40:28 -05:00
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
0c1f71635f
Fixed #27203 -- Replaced assertQuerysetEqual(..., lambda o: o) with assertSequenceEqual().
2016-09-13 10:07:37 -04:00
c9ae09addf
Replaced use of TestCase.fail() with assertRaises().
...
Also removed try/except/fail antipattern that hides exceptions.
2016-06-28 11:21:26 -04:00
1c8c0837c6
Sorted single letter imports per the latest version of isort.
2016-03-28 11:45:31 -04:00
3d0dcd7f5a
Refs #26022 -- Used context manager version of assertRaises in tests.
2016-01-29 12:32:18 -05:00
c2e70f0265
Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField
2015-07-27 18:28:13 -04:00
b68212f539
Refs #24267 -- Implemented lookups for related fields
...
Previously related fields didn't implement get_lookup, instead
related fields were treated specially. This commit removed some of
the special handling. In particular, related fields return Lookup
instances now, too.
Other notable changes in this commit is removal of support for
annotations in names_to_path().
2015-03-25 08:05:22 -04:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
fb48eb0581
Fixed #12663 -- Formalized the Model._meta API for retrieving fields.
...
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
2015-01-06 19:25:12 -05:00
1c5cbf5e5d
Fixed #24002 -- GenericRelation filtering targets related model's pk
...
Previously Publisher.objects.filter(book=val) would target
book.object_id if book is a GenericRelation. This is inconsistent to
filtering over reverse foreign key relations, where the target is the
related model's primary key.
2014-12-17 10:04:52 +02:00
e8223b889a
Corrected test assertion from refs #21403 .
2014-12-15 12:04:07 -05:00
f7969b0920
Fixed #23620 -- Used more specific assertions in the Django test suite.
2014-11-03 11:56:37 -05:00
f676305ece
Fixed #22982 -- Added GenericRelatedObjectManager.__str__. to prevent crash.
...
Thanks bendavis78 for the report.
Forwardport of 29585e9b6a
2014-08-07 14:44:20 -04:00
f8df55050c
PEP8 cleanup
2014-07-16 12:48:49 +03:00
6e2b82fdf6
Fixed #22998 -- Updated the fast_delete logic for GFKs
2014-07-16 12:28:00 +03:00
b77f26313c
Fixed #22207 -- Added support for GenericRelation reverse lookups
...
GenericRelation now supports an optional related_query_name argument.
Setting related_query_name adds a relation from the related object back to
the content type for filtering, ordering and other query operations.
Thanks to Loic Bistuer for spotting a couple of important issues in
his review.
2014-03-05 22:37:53 +02:00
10e3faf191
Fixed #19774 -- Deprecated the contenttypes.generic module.
...
It contained models, forms and admin objects causing undesirable
import side effects. Refs #16368 .
Thanks to Ramiro, Carl and Loïc for the review.
2014-01-26 14:42:30 -05:00
3411af3cd1
Fixed #21403 : Corrected test code
...
A test for annotations incorrectly assumed that the first instance
(in the test) of a model using AutoField for PK will always get pk=1.
The test was changed to compare against actual instance id instead.
2013-11-25 16:16:04 +02:00
0e079e4331
Fixed #21428 -- editable GenericRelation regression
...
The GenericRelation refactoring removed GenericRelations from
model._meta.many_to_many. This had the side effect of disallowing
editable GenericRelations in ModelForms. Editable GenericRelations
aren't officially supported, but if we don't fix this we don't offer any
upgrade path for those who used the ability to set editable=True
in GenericRelation subclass.
Thanks to Trac alias joshcartme for the report and stephencmd and Loic
for working on this issue.
2013-11-16 20:07:35 +02:00
76da053641
Fixed #10461 -- bug in generic relation + annotate() case
...
This issue was fixed when the contenttype restriction was moved from
where clause to the join clause. So, this is tests only addition.
2013-11-05 20:02:24 +02:00
7a61c68c50
PEP8 cleanup
...
Signed-off-by: Jason Myers <jason@jasonamyers.com>
2013-11-02 23:50:49 -05:00
c3aa2948c6
Fixed #21298 -- Fixed E301 pep8 warnings
2013-10-23 13:45:03 +01:00
31fd64ad8a
Fixed #20564 -- Generic relations exclude() regression
...
The patch for #19385 caused a regression in certain generic relations
.exclude() filters if a subquery was needed. The fix contains a
refactoring to how Query.split_exclude() and Query.trim_start()
interact.
Thanks to Trac alias nferrari for the report.
2013-06-06 01:54:46 +03:00
8c5b805ca1
PEP 8 cleanup
2013-06-05 21:18:56 +03:00
c9a96075fa
Fixed #20378 -- regression in GenericRelation on abstract model
...
When a GenericRelation was defined on abstract model, queries on childs
of the abstract model didn't work. The problem was in the way fields and
in particular field.rel was copied from models to their children.
The regression was likely caused by #19385 . Thanks to Gavin Wahl for
spotting the regression.
2013-05-20 18:02:10 +03:00
89f40e3624
Merged regressiontests and modeltests into the test root.
2013-02-26 14:36:57 +01:00
roman_p
sarahboyce
Mariusz Felisiak
django-bot
Tim Graham
Nick Pope
Ramiro Morales
robwa
Morgan Wahl
Simon Charette
Rachel Tobin
chillaranand
Claude Paroz
Ramin Farajpour Cami
za
Mads Jensen
Hasan
Flavio Curella
Anssi Kääriäinen
Daniel Pyrathon
Anssi Kääriäinen
Berker Peksag
Jacob Haslehurst
Gavin Wahl
Gabe Jackson
Shai Berger
Jason Myers
Alasdair Nicol
Florian Apolloner