Commit Graph

8820 Commits

Author SHA1 Message Date
François Freitag ec05ff086c Refs #25546 -- Added detailed comments for prefetch_related test. 2017-05-04 09:19:54 -04:00
François Freitag c0a2b9508a Fixed #27554 -- Fixed prefetch_related() crash when fetching relations in nested Prefetches. 2017-05-04 09:17:29 -04:00
Simon Charette b91868507a Fixed #28161 -- Fixed return type of ArrayField(CITextField()).
Thanks Tim for the review.
2017-05-04 00:02:14 -04:00
Simon Charette f37467ec7a Added a test for ArrayField(HStoreField()). 2017-05-03 23:53:08 -04:00
Tim Graham 67702f3505 Converted sessions_tests to use assertIs() rather than assertTrue/False(). 2017-05-03 20:21:39 -04:00
Tim Graham 578e576c31 Fixed #28167 -- Fixed cache backend's SessionStore.exists() if session_key is None. 2017-05-03 12:39:07 -04:00
Tim Graham 584e10c76e Fixed #28166 -- Fixed Model._state.db on MTI parent model after saving child model.
Regression in 38575b007a.
2017-05-03 12:14:15 -04:00
Alexander Kavanaugh 362fba87c9 Fixed #28159 -- Fixed BaseInlineFormSet._construct_form() crash when using save_as_new.
Regression in 4a246a02bd.
2017-05-03 07:45:51 -04:00
Tim Graham d302e2c09c Fixed #28157 -- Fixed choice ordering in form fields with grouped and non-grouped options.
Regression in b52c73008a.
2017-05-03 07:21:44 -04:00
Tim Graham d0e43f225f Refs #28052 -- Cleaned up some indexes in schema tests. 2017-05-01 22:19:05 -04:00
Markus Holtermann 663e48947f Fixed #28052 -- Prevented dropping Meta.indexes when changing db_index to False.
Thanks Marc Tamlyn for the report and Ian Foote/Tim Graham for review.
2017-05-01 11:31:48 -04:00
Ian Foote 63afe3a2bf Fixed #28043 -- Prevented AddIndex and RemoveIndex from mutating model state. 2017-05-01 09:32:44 -04:00
Jon Dufresne b39aabc6c6 Refs #27795 -- Reworked get_or_create test erroneously mixing bytes and str.
As CharField.to_python() now always calls str(), assigning bytes to a
CharField is no longer correct usage. Doing so results in a warning:

  django/db/models/fields/__init__.py:1061: BytesWarning: str() on a bytes instance

Use a unique constraint violation to trigger the database error instead.

Warning introduced in 301de774c2.
2017-05-01 08:47:49 -04:00
Dylan Verheul 75aeebebfe Fixed #28105 -- Fixed crash in BaseGeometryWidget.get_context() when overriding existing attrs. 2017-04-30 20:19:12 -04:00
Tim Graham 1ebd295082 Fixed #28040 -- Updated SplitArrayWidget to use template-based widget rendering.
Thanks Preston Timmons for review.
2017-04-29 19:00:21 -04:00
Tim Graham c920db1e57 Removed blank line in tests/model_fields/test_decimalfield.py per isort. 2017-04-29 07:42:12 -04:00
Tim Graham f04a404917 Fixed #28130 -- Fixed formset min_num validation with initial, unchanged forms.
Regression in f5c6295797.
2017-04-28 09:32:40 -04:00
Mariusz Felisiak f32ee6d0ec Refs #6767 -- Added test for fetching decimal values without rounding error on Oracle. 2017-04-28 06:07:28 +02:00
Tim Graham 309c10c2cb Refs #20094 -- Removed obsolete tests/utils_tests/test_itercompat.py
The is_iterator() function was removed in 2456ffa42c.
2017-04-26 10:54:06 -04:00
Paolo Melchiorre fcb5dbfec0 Fixed #27996 -- Added RandomUUID function and CryptoExtension to contrib.postgres. 2017-04-25 20:21:36 -04:00
Paolo Melchiorre a78fd2abd4 Alphabetized CITextExtension in test migration. 2017-04-25 19:32:39 -04:00
Tim Graham 56970c5b61 Fixed #28122 -- Fixed crash when overriding views.static.directory_index()'s template. 2017-04-25 11:01:21 -04:00
Mariusz Felisiak 562bca67b9 Added test for reraising backend-specific database exceptions. 2017-04-25 08:03:48 +02:00
Mariusz Felisiak e776dd2db6 Fixed #28116 -- Used error code filtering in PostgreSQL test database creation.
Thanks Claude Paroz and Tim Graham for reviews.
2017-04-25 06:01:25 +02:00
Michiel Beijen 5e8625ba64 Renamed "Mac OS X" to "macOS" in docs. 2017-04-24 20:16:09 -04:00
Carles Pina Estany 9f2e8b5bb7 Fixed #28120 -- Checked that CharField.max_length is not a boolean. 2017-04-24 18:49:31 -04:00
Tim Graham 851874fe0a Removed obsolete Widget.format_output() in tests.
Obsolete since b52c73008a.
2017-04-24 13:41:34 -04:00
Simon Charette 8ef35468b6 Fixed #28101 -- Fixed a regression with nested __in subquery lookups and to_field.
Thanks Kristian Klette for the report and Tim for the help.
2017-04-23 00:21:27 -04:00
Claude Paroz 3f1ba76851 Fixed #28115 -- Fixed IP address validation in geoip2 module
Regression in 277a4dd4b4.
Thanks Tim Graham for the test.
2017-04-22 20:10:24 +02:00
Simon Charette c0f12a098c Fixed #28109 -- Corrected the stack level of unordered queryset pagination warnings.
Refs #26290.

Thanks Tim for the review.
2017-04-22 14:08:57 -04:00
Jon Dufresne 581879a510 Fixed #28075 -- Prevented ChoiceWidget from localizing option values. 2017-04-21 12:14:40 -04:00
Tim Graham d2cb7a2bc1 Fixed #28039 -- Fixed crash in BaseGeometryWidget.subwidgets(). 2017-04-20 11:36:40 -04:00
Tim Graham af1f986360 Fixed #28059 -- Restored class attribute in <ul> of widgets that use multiple_input.html.
Regression in b52c73008a
2017-04-20 10:06:34 -04:00
Claude Paroz 43b4a1618e Fixed #28096 -- Allowed prefetch calls with ModelIterable subclasses
Regression in 7ec330eeb9.
Thanks Tim Graham for the review.
2017-04-19 19:32:46 +02:00
Tim Graham dff559ff83 Fixed #28097 -- Fixed layout of ReadOnlyPasswordHashWidget. 2017-04-19 12:59:30 -04:00
Mariusz Felisiak 81f8449402 Refs #28066 -- Fixed nondeterministic ordering test failure in sessions_tests.
Thanks Tim Graham for the review.
2017-04-18 17:56:59 +02:00
InvalidInterrupt dda596ca32 Fixed #28066 -- Prevented SessionBase.cycle_key() from discarding data. 2017-04-17 09:58:19 -04:00
Tim Graham c09bf8d767 Fixed #28058 -- Restored empty BoundFields evaluating to True.
Regression in b52c73008a
2017-04-17 08:32:29 -04:00
Tim Graham 8c6a3062dd Fixed #28079 -- Restored "No POST data" (rather than an empty table) in HTML debug page.
Regression in 7b6dccc82f
2017-04-15 09:21:35 -04:00
Mariusz Felisiak e1253bc26f Refs #25406 -- Removed exception hiding in MySQL test database creation during --keepdb.
Thanks Adam Johnson, Simon Charette and Tim Graham for reviews.
2017-04-13 20:20:01 +02:00
Claude Paroz ea542a9c72 Fixed #28007 -- Moved debug templates to the filesystem
Thanks Tim Graham for the review.
2017-04-12 11:36:47 -04:00
Claude Paroz 2eb1f15f62 Tested template info in debug view's text traceback 2017-04-12 10:38:50 -04:00
petedmarsh 14671affc3 Fixed #28064 -- Removed double-quoting of key names in MultiValueDictKeyError. 2017-04-11 12:44:52 -04:00
Ran Benita 2a6b4e6521 Updated docs after changing select_for_update() to raise NotSupportedError.
Follow up to 054a44d6f0.
2017-04-11 11:52:53 -04:00
Sergey Fedoseev e7afef13f5 Fixed #26788 -- Fixed QuerySet.update() crash when updating a geometry to another one. 2017-04-10 13:26:26 -04:00
Mariusz Felisiak 64264c9a19 Fixed #25406 -- Removed exception hiding in PostgreSQL test database creation during --keepdb.
Thanks Markus Holtermann and Tim Graham for reviews.
2017-04-10 13:04:00 -04:00
Mariusz Felisiak 054a44d6f0 Used NotSupportedError instead of DatabaseError in SQLCompiler.as_sql(). 2017-04-10 12:49:27 -04:00
Tim Graham fce7827101 Fixed #28047 -- Fixed QuerySet.filter() crash when it uses the name of a OneToOneField pk.
Regression in 1bc249c2a6.
2017-04-10 09:51:51 -04:00
Collin Anderson a19b373d89 Changed assertQuerysetEqual()s that use default Model.__str__() to assertSequenceEqual(). 2017-04-10 08:59:29 -04:00
Tim Graham eb9a3bd63a Refs #26605 -- Isolated a migrations state test. 2017-04-10 08:13:45 -04:00
kalombo dd00184892 Fixed #28042 -- Fixed crash when using a two-tuple in EmailMessage's attachments arg. 2017-04-07 18:02:34 -04:00
kalombo aedfe0ddd7 Tested EmailMessage(attachments=[MIMEText]) 2017-04-07 18:01:31 -04:00
Simon Charette a354c69055 Fixed #28038 -- Restored casting to text of builtin lookups on PostgreSQL.
Reverted 658f1e8 which broke code using __icontains's implicit cast to ::text
on ArrayField.

Thanks Peter J. Farrell for the report.
2017-04-07 16:47:52 -04:00
Ingo Klöcker 67b2b1f116 Refs #26605 -- Added migrations state test for a swappable model inheriting an abstract model inheriting concrete model.
Thanks Sébastien Diemer for the report and test.
2017-04-07 13:41:07 -04:00
Markus Holtermann d3cf75ec6f Fixed #28051 -- Made migrations respect Index's name argument.
Thanks Marc Tamlyn for the report and Tim Graham for the review.
2017-04-07 11:47:53 -04:00
Ingo Klöcker c4536c4a54 Fixed #27777 -- Made File.open() work with the with statement (#8310)
Fixed #27777 -- Made File.open() work with the with statement
2017-04-07 14:21:06 +02:00
Mariusz Felisiak 695d4dd790 Fixed #23147 -- Disabled a limit/offset on a query with select_for_update on Oracle.
Thanks Shai Berger and Tim Graham for the reviews.
2017-04-07 14:08:07 +02:00
Raphael Michel bde814142a Fixed #22654 -- Broken decimal validation 2017-04-07 12:45:08 +02:00
Sergey Fedoseev fd892f3443 Fixed #28006 -- Allowed using D with lookups on Distance annotations. 2017-04-06 19:27:45 -04:00
kapil garg dbfcedb499 Fixed #28001 -- Updated comment and tested context popping in ForNode.render(). 2017-04-06 19:04:29 -04:00
Tim Graham 5ea48a70af Fixed #27912, CVE-2017-7233 -- Fixed is_safe_url() with numeric URLs.
This is a security fix.
2017-04-04 10:42:06 -04:00
Tim Graham a1f948b468 Fixed CVE-2017-7234 -- Fixed open redirect vulnerability in views.static.serve().
This is a security fix.
2017-04-04 10:42:06 -04:00
Claude Paroz 389c3ffc04 Updated tests after French translation update 2017-04-04 13:07:47 +02:00
kapil garg 002fe07622 Fixed #27974 -- Kept resolved templates constant during one rendering cycle.
Thanks Florian Apolloner for the initial patch.
2017-04-03 22:29:39 -04:00
Adam Johnson 7f8a924b45 Refs #27834 -- Removed Value wrapping from StrIndex's substring param. 2017-04-03 08:39:57 -04:00
Tim Graham d4d79d0f20 Refs #27025 -- Fixed "invalid escape sequence" warning in auth_tests on Python 3.6. 2017-04-02 20:02:55 -04:00
Sergey Fedoseev 898e623db0 Fixed #27573 -- Made Distance on geodetic coordinates return a raw value on MySQL. 2017-04-02 17:06:01 -04:00
Simon Charette 35c0025151 Fixed #27928 -- Avoided SET/DROP DEFAULT unless a field changes from null to non-null.
Thanks Christophe Pettus, Matteo Pietro Russo for reports and Tim for review.
2017-04-02 16:34:03 -04:00
Sergey Fedoseev 5e710cf4a5 Fixed #11854 -- Added Azimuth GIS function. (#8286) 2017-04-02 14:24:06 -04:00
Claude Paroz 4f99ba84b3 Removed unused code in i18n view_tests
Unused since 2b20e4148f.
2017-04-02 19:58:18 +02:00
Chris Sinchok 66150f7cf6 Fixed #27954 -- Allowed keyboard interrupt to abort queries in PostgreSQL dbshell.
Thanks Tim Martin for review.
2017-04-01 21:01:08 -04:00
Jon Dufresne 7bbb5161ea Removed implicit default store_true/false argparse args.
argparse automatically sets the default value for store_true/false
arguments to its opposite.
2017-04-01 20:03:56 -04:00
Stefan Wehrmeyer 1aa8e8605c Fixed #27989 -- Preserved empty QueryDicts for form's data/files args. 2017-04-01 18:43:39 -04:00
Sergey Fedoseev 24023c6a8f Fixed #25874 -- Made GEOSGeometry read SRID from GeoJSON input. 2017-04-01 15:35:30 -04:00
Sergey Fedoseev ede4f6d48c Fixed #12410 -- Added LineLocatePoint GIS function. 2017-04-01 15:02:09 -04:00
Sergey Fedoseev 0a13b249e2 Fixed #26967 -- Added MySQL support for AsGeoJSON, GeoHash, IsValid functions, and isvalid lookup. 2017-04-01 13:43:53 -04:00
Claude Paroz 9a9e228321 Fixed #27848 -- Prevented crash when attaching a .eml file to a message
Thanks Sébastien Ramage for the report.
2017-04-01 16:19:03 +02:00
Sergey Fedoseev bde86ce9ae Fixed #25605 -- Made GIS DB functions accept geometric expressions, not only values, in all positions. 2017-04-01 09:47:49 -04:00
Claude Paroz e487ffd3f0 Fixed #27866 -- Made ChoiceWidget.format_value() return a list
Thanks Tim Graham for the review.
2017-04-01 12:24:05 +02:00
Carlton Gibson 6b3724fa11 Fixed #27359 -- Made Engine.get_default() return the first DjangoTemplates engine if multiple are defined. 2017-03-31 17:26:42 -04:00
Carlton Gibson 7019724101 Added tests for template's Engine.get_default(). 2017-03-31 10:59:00 -04:00
heathervm 7d1e237753 Fixed #27993 -- Fixed model form default fallback for SelectMultiple. 2017-03-31 10:10:08 -04:00
Sergey Fedoseev 6ecccad711 Fixed #25873 -- Made GEOSGeometry handle the srid parameter more predictably. 2017-03-30 09:38:26 -04:00
Sergey Fedoseev 068d75688f Refs #18247 -- Fixed SQLite QuerySet filtering on decimal result of Least and Greatest. 2017-03-29 13:29:53 -04:00
Sergey Fedoseev 4bc355079c Fixed #27973 -- Fixed GeoJSON representation of LinearRing and custom GEOSGeometry subclasses. 2017-03-29 13:17:31 -04:00
Sergey Fedoseev 9cd6ba991f Made isvalid lookup use IsValid function to decrease code redundancy. 2017-03-29 08:56:58 -04:00
Mariusz Felisiak 1d070d027c Fixed #25414 -- Fixed QuerySet.annotate() with pk in values() on MySQL.
Thanks Tim Graham and Simon Charette for the reviews.
2017-03-29 06:47:07 +02:00
Sergey Fedoseev d47de2e09d Refs #27736 -- Used decorators for GIS lookup registration. 2017-03-27 22:20:18 -04:00
Mariusz Felisiak 1b6f05e91f Fixed #21160 -- Fixed QuerySet.in_bulk() crash on SQLite when requesting more than 999 ids.
Thanks Andrei Picus and Anssi Kääriäinen for the initial patch
and Tim Graham for the review.
2017-03-27 18:43:40 +02:00
Tim Graham e643ba8bcf Fixed #27956 -- Fixed display of errors in an {% extends %} child.
Thanks Ling-Xiao Yang for the report and test, and
Preston Timmons for the fix.
2017-03-25 08:22:12 -04:00
Mariusz Felisiak f42c7cc87b Refs #21160 -- Replaced DatabaseFeatures.supports_1000_query_parameters by a DatabaseFeatures.max_query_params. 2017-03-24 18:37:03 +01:00
Sergey Fedoseev 1b1ea63f6a Fixed #27962 -- Allowed lookups on Area annotations. 2017-03-23 20:06:16 -04:00
Sergey Fedoseev e9149d3eb0 Fixed #27603 -- Fixed AsKML when queryset is evaluated more than once. 2017-03-23 19:09:04 -04:00
Kapil Garg 7e09fa7f51 Fixed #27969 -- Fixed models.Field.formfield() setting 'disabled' for fields with choices. 2017-03-23 13:22:04 -04:00
James Beith 216bb2e8fb Fixed #27975 -- Fixed crash if ModelChoiceField's queryset=None.
Regression in 9153d8fbd6385db9f48793662de789fc3d686841.
2017-03-22 08:51:12 -04:00
Mariusz Felisiak 43380e9110 Fixed #27966 -- Bumped required psycopg2 version to 2.5.4.
Thanks Tim Graham for the review.
2017-03-21 17:23:17 +01:00
Tim Graham 3d19d1428a Fixed #27915 -- Allowed Meta.indexes to be defined in abstract models.
Thanks Markus Holtermann for review.
2017-03-21 10:53:21 -04:00
Sergey Fedoseev 816c5753ac Fixed #27965 -- Fixed precision comparison in a geoforms test (refs #27939). 2017-03-21 09:04:41 -04:00
Jon Dufresne 7edeeb74fe Fixed #27957 -- Removed technical terms from InlineForeignKeyField/ModelMultipleChoiceField error messages. 2017-03-20 13:12:55 -04:00
Tim Graham 0c6c859d4e Fixed #27890 -- Fixed FileNotFoundError cleanup exception in runtests.py on Python 3.6+. 2017-03-20 11:35:46 -04:00