885d98d24a
Fixed #20028 -- Made atomic usable on callable instances.
...
Thanks Anssi for the report.
2013-03-12 10:52:16 +01:00
f8a634afa2
Fixed tests that relied on MANAGERS not being empty.
...
Regression in d0561242
2013-03-11 23:30:02 +01:00
d056124269
Remove a special case for comment tests from runtests.py.
2013-03-11 15:38:53 -05:00
b746f8a9e3
Adjusted query counts to account for new savepoints.
2013-03-11 21:07:19 +01:00
55a9be8ecf
Ran a test that closes the database connection outside of a transaction.
2013-03-11 19:42:59 +01:00
9b74a8391d
Removed forced settings in runtests
...
Tests that require USE_I18N, LOGIN_URL or certain MIDDLEWARE_CLASSES
should be decorated appropriately.
2013-03-11 17:46:56 +01:00
e654180ce2
Improved the API of set_autocommit.
2013-03-11 15:10:58 +01:00
86fd920f67
Removed a test that no longer makes any sense.
...
Since unmanaged == autocommit, there's nothing to commit or roll back.
2013-03-11 15:05:04 +01:00
0cee3c0e43
Updated a test that doesn't make sense with autocommit.
2013-03-11 15:05:04 +01:00
107d9b1d97
Added an option to disable the creation of savepoints in atomic.
2013-03-11 15:05:04 +01:00
ac37ed21b3
Deprecated TransactionMiddleware and TRANSACTIONS_MANAGED.
...
Replaced them with per-database options, for proper multi-db support.
Also toned down the recommendation to tie transactions to HTTP requests.
Thanks Jeremy for sharing his experience.
2013-03-11 15:04:05 +01:00
7c46c8d5f2
Added some assertions to enforce the atomicity of atomic.
2013-03-11 14:48:55 +01:00
d7bc4fbc94
Implemented an 'atomic' decorator and context manager.
...
Currently it only works in autocommit mode.
Based on @xact by Christophe Pettus.
2013-03-11 14:48:55 +01:00
4b31a6a9e6
Added support for savepoints in SQLite.
...
Technically speaking they aren't usable yet.
2013-03-11 14:48:55 +01:00
3bdc7a6a70
Deprecated transaction.is_managed().
...
It's synchronized with the autocommit flag.
2013-03-11 14:48:54 +01:00
ba5138b1c0
Deprecated transaction.commit/rollback_unless_managed.
...
Since "unless managed" now means "if database-level autocommit",
committing or rolling back doesn't have any effect.
Restored transactional integrity in a few places that relied on
automatically-started transactions with a transitory API.
2013-03-11 14:48:54 +01:00
af9e9386eb
Enabled autocommit for PostgreSQL.
...
For users who didn't activate autocommit in their database options, this
is backwards-incompatible in "non-managed" aka "auto" transaction state.
This state now uses database-level autocommit instead of ORM-level
autocommit.
Also removed the uses_autocommit feature which lost its purpose.
2013-03-11 14:48:54 +01:00
8717b0668c
Separated autocommit and isolation level handling for PostgreSQL.
...
Autocommit cannot be manipulated independently from an open connection.
This commit introduces a minor change in behavior: entering transaction
management forces opening a databasse connection. This shouldn't be
backwards incompatible in any practical use case.
2013-03-11 14:48:54 +01:00
7aacde84f2
Made transaction.managed a no-op and deprecated it.
...
enter_transaction_management() was nearly always followed by managed().
In three places it wasn't, but they will all be refactored eventually.
The "forced" keyword argument avoids introducing behavior changes until
then.
This is mostly backwards-compatible, except, of course, for managed
itself. There's a minor difference in _enter_transaction_management:
the top self.transaction_state now contains the new 'managed' state
rather than the previous one. Django doesn't access
self.transaction_state in _enter_transaction_management.
2013-03-11 14:48:53 +01:00
ce76fbfc5a
Fixed #20019 -- Ensured HttpRequest.resolver_match always exists.
...
Obviously it isn't set until the URL is resolved.
2013-03-10 23:28:19 +01:00
7fca4416c7
Made (make|compile)messages check for availability of gettext commands.
...
Refs #19584 .
2013-03-10 17:31:11 -03:00
6a91b63842
Fixed #19923 -- Display tracebacks for non-CommandError exceptions
...
By default, show tracebacks for management command errors when the
exception is not a CommandError.
Thanks Jacob Radford for the report.
2013-03-09 12:38:45 +01:00
cbfb8ed53b
Fixed a regression in forms changed_data
...
Thanks Loic Bistuer for spotting the regression and the initial
patch. Refs #16612 .
2013-03-08 18:19:24 +01:00
6983a1a540
Fixed #15363 -- Renamed and normalized to `get_queryset` the methods that return a QuerySet.
2013-03-08 10:11:45 -05:00
477d737e1e
Merge pull request #850 from bmispelon/ticket-19916
...
Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments
2013-03-07 12:12:29 -08:00
bbbd698c7a
Added a ManyToManyField(db_constraint=False) option, this allows not creating constraints on the intermediary models.
2013-03-07 11:24:51 -08:00
81804ae474
Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments.
2013-03-07 19:30:38 +01:00
4cccb85e29
Fixed #19997 -- Added custom EMPTY_VALUES to form fields
...
Thanks Loic Bistuer for the report and the patch.
2013-03-07 15:22:03 +01:00
e2ee02c5bd
Fixed #19951 -- Admin: Invalid model PK values shouldn't cause 500 status.
...
Avoid ValueError in admin when passing a string as PK for an inherited
model with an integer PK field.
Thanks ikks for the patch. See also #11191 .
2013-03-06 21:38:44 -03:00
c31a9793c6
Merge pull request #882 from loic/testfix
...
Fixed minor warnings in tests.
2013-03-06 16:22:06 -08:00
876fc39128
PEP8 cleanup of functional.py
2013-03-06 16:14:46 -08:00
0ea5bf88dd
Fixed #19543 -- implemented SimpleLazyObject.__repr__
...
Thanks to Florian Hahn for the patch
2013-03-06 16:13:12 -08:00
b3aa853ec5
Used more precise test assertions.
2013-03-06 15:33:35 +01:00
9ba0e4e4ee
Fixed minor warnings in tests.
2013-03-06 01:13:36 +07:00
d9330d5be2
Fixed #6585 -- Admin relationship widgets: Respect ordering defined by target model's ModelAdmin.
...
Thanks Gary Wilson for the report and Juan Pedro Fisanotti, Carlos
Matías de la Torre for the fix.
2013-03-04 18:08:53 -03:00
3ea0c7d35a
Fixed #19838 -- Admin: Don't leak a 500 HTTP status when trying to delete protected FKs.
...
Thanks rafadev for the report and Javier Mansilla for the fix.
2013-03-04 13:30:59 -03:00
60dd4eabe7
Removed mentions of modeltests.
2013-03-03 18:44:06 -03:00
804366327d
Fixed #19915 - Made blocktrans tag honor TEMPLATE_STRING_IF_INVALID.
...
Thanks Natalia Bidart for the report and Matías Bordese for the fix.
2013-03-03 16:10:11 -03:00
384c180e41
Fixed #19917 -- Added microseconds in default TIME_INPUT_FORMATS
...
Thanks minddust for the report.
2013-03-02 18:11:10 +01:00
e0449316eb
Fixed #18130 -- Made the isolation level configurable on PostgreSQL.
...
Thanks limscoder for the report and niwi for the draft patch.
2013-03-02 15:05:49 +01:00
c5a25c2771
Add introspection support for BinaryField
2013-03-02 10:29:03 +01:00
d680a3f447
Added support for serializing BinaryField
2013-03-02 10:29:02 +01:00
8ee1eddb7e
Add a BinaryField model field
...
Thanks Michael Jung, Charl Botha and Florian Apolloner for review
and help on the patch.
2013-03-02 10:29:02 +01:00
0f306cad84
Import `CaptureQueriesContext` from its original module.
2013-03-02 03:45:42 -05:00
fb3d85bd14
Fixed #10399 -- Tested that o2o field updates are not constrained by an inner query.
2013-03-02 03:24:08 -05:00
952ba5237e
Added a context manager to capture queries while testing.
...
Also made some import cleanups while I was there.
Refs #10399 .
2013-03-02 02:41:14 -05:00
3318595c0b
Fixed #18898 -- Added tests with a fix for ModelMultipleChoiceField
2013-03-01 09:35:18 +01:00
892bc91cb0
Fixed #16612 -- Improved has_changed detection for localized field values
...
Thanks Simon Charette for the review.
2013-03-01 09:35:04 +01:00
cf30469164
Fixed tests broken in 2ee21d9.
2013-02-28 17:08:16 +01:00
2ee21d9f0d
Implemented persistent database connections.
...
Thanks Anssi Kääriäinen and Karen Tracey for their inputs.
2013-02-28 15:28:13 +01:00
aa089b106b
Fixed #5241 -- Kept active transalation in LocaleMiddleware.process_response.
2013-02-28 14:21:48 +01:00
06de130dae
Fixed #12823 -- Was already fixed in master, tests added
...
Also added a little improvement to sql/query.py to get rid of
non-necessary IS NOT NULL check.
2013-02-28 15:05:48 +02:00
af3321a1e8
use the real path to fix OS X /var/folders vs. /private/var/folders mismatch
2013-02-27 23:33:47 +01:00
21189cb80b
Made dateformat tests reactivate original language
2013-02-27 23:48:17 +02:00
7aaa8a7779
Fixed a test that relied on database exceptions not being wrapped.
2013-02-27 21:12:48 +01:00
b2c697b029
Fixed a PendingDeprecationWarning in template_tests.
2013-02-27 21:09:27 +01:00
50328f0a61
Fixed #19861 -- Transaction ._dirty flag improvement
...
There were a couple of errors in ._dirty flag handling:
* It started as None, but was never reset to None.
* The _dirty flag was sometimes used to indicate if the connection
was inside transaction management, but this was not done
consistently. This also meant the flag had three separate values.
* The None value had a special meaning, causing for example inability
to commit() on new connection unless enter/leave tx management was
done.
* The _dirty was tracking "connection in transaction" state, but only
in managed transactions.
* Some tests never reset the transaction state of the used connection.
* And some additional less important changes.
This commit has some potential for regressions, but as the above list
shows, the current situation isn't perfect either.
2013-02-27 17:54:27 +02:00
40b9f4fb8b
[py3] Always fed hashlib with bytes.
2013-02-27 10:02:07 +01:00
a28e2e7c4d
Removed a .mo file incorrectly put under Git control.
2013-02-26 22:45:08 -03:00
f0bd553922
Simplified compilemessages tests a bit.
2013-02-26 22:30:49 -03:00
dfa9324966
Don't use os.system() in compilemessages.
...
Fixes #19584 .
This implies stop storing file path command line arguments in envvars as
a security measure to start relying on with Popen's shell=False instead,
and addition of an 'utils' module.
Thanks kmichel_wgs for the report.
2013-02-26 21:31:53 -03:00
58a2fc820e
Fixed i18n test to match changed translation
...
Forward port of ab6ff2e0ac
2013-02-26 21:51:06 +01:00
33234aa8f7
Fixed discovery of the Django installation during tests.
...
If Django was symlinked into site-packages the previous approach to discover
the tests subdirectory would fail. The revised version now always points to
the location of the source and not the import path.
2013-02-26 21:04:32 +01:00
0fe11fca40
Changed test_runner tests to use full python path for settings files.
2013-02-26 16:02:24 +01:00
1535fcfdba
fixed admin_scripts tests on python 3.3
2013-02-26 15:38:11 +01:00
0dc7ff6b7a
Ensured that we have an absolute path to RUNTESTS_DIR.
...
This is needed to make 'python runtests.py' work, otherwise only
'python ./runtests.py' would work.
2013-02-26 15:20:37 +01:00
4d9f39f307
Renamed a template to be found by the loaders.
2013-02-26 14:36:58 +01:00
33836cf88d
Renamed some tests and removed references to modeltests/regressiontests.
2013-02-26 14:36:57 +01:00
737a5d71f0
Adjusted coveragerc
2013-02-26 14:36:57 +01:00
fc074db29c
Adjusted runtests to the new layout.
2013-02-26 14:36:57 +01:00
89f40e3624
Merged regressiontests and modeltests into the test root.
2013-02-26 14:36:57 +01:00
b3d2ccb5bf
Removed __init__.py files.
2013-02-26 14:36:57 +01:00
41d7a9a907
Moved test_templates to templates to prevent issues with regressiontests/templates later on.
2013-02-26 14:36:57 +01:00
8dd8400f7e
Updated an inaccurate comment.
...
Tests can run nearly as fast under PostgreSQL and MySQL as under SQLite
with a bit of configuration and the speedup is always a good thing.
2013-02-26 10:00:14 +01:00
6a8f95d812
Fixed a caching test on Python 3.
2013-02-25 18:12:55 -07:00
6a057e1595
Fixed #18191 -- Don't consider Accept-Language redundantly in cache key.
...
Thanks to choongmin for the original patch.
2013-02-25 16:10:57 -07:00
e76147a83a
Fixed #19634 -- Added proper __hash__ methods.
...
Classes overriding __eq__ need a __hash__ such that equal objects have
the same hash.
Thanks akaariai for the report and regebro for the patch.
2013-02-25 23:05:20 +01:00
509798ae06
Use built-in fixture support rather than calling loaddata in setUp().
2013-02-25 12:13:10 -07:00
86b96038f2
Merge pull request #847 from fhahn/ticket_18176
...
Fixed #18176 -- Added test for year lookups with year < 1000
2013-02-25 09:26:56 -08:00
906dc8522a
Fixed #19854 -- Turn Django's own Selenium tests off by default.
2013-02-25 10:14:42 -07:00
f28c301a47
Fixed #18176 -- Added test for year lookups with year < 1000
...
Thanks Tomas Ehrlich for the initial test
2013-02-25 17:13:27 +01:00
6d52bcbb7c
Fixed #19903 -- Fixed unbalanced setUp/tearDown calls in LiveServerAddress test
2013-02-25 08:58:11 +01:00
7b49da1c38
Changed testing strategy used in 6b03179e.
...
Avoid polluting the app cache as it causes unrelated test failures.
Refs #19688 .
2013-02-25 00:09:13 +01:00
ae2a8bb456
Fixed a test that was failing in Python 3.
...
The issue was that as of Python 3, the generators' `next()`
method becomes `__next()`. Thanks Alex Gaynor for noticing that.
Refs #19890 .
2013-02-24 13:47:14 -08:00
a8449d4362
Merge pull request #824 from ambv/languagecode
2013-02-24 12:56:14 -08:00
6b03179e12
Fixed #19688 -- Allow model subclassing with a custom metaclass using six.with_metaclass
2013-02-24 17:32:34 +01:00
636c45fc58
Fixed #19890 -- ifchanged templatetag rendered its content twice
...
The content of ifchanged template tag was rendered twice: first time, to
compare it with the previous value and the second time, to return the
rendered output.
2013-02-24 16:49:28 +01:00
8503120c10
Fixed #15849 -- Made IfChanged node thread safe.
...
Previously, the ifchanged node stored state on `self._last_seen`,
thereby giving undesired results when the node is reused by another
thread at the same time (e.g. globally caching a Template object).
Thanks to akaihola for the report and Diederik van der Boor and
Bas Peschier for the patch.
2013-02-24 16:06:55 +01:00
0a8402eb05
Test case and docs for custom context data in feeds
...
Thanks Paul Winkler for the initial patch. (Ref #18112 ).
2013-02-24 08:33:20 -06:00
4506ae0497
Merge pull request #717 from slurms/ticket_19746
...
Fixed #19746 -- Allow deserialization of pk-less data
2013-02-24 06:31:14 -08:00
8c8f94fe9d
Fixes #19763 - LocaleMiddleware should check for supported languages in settings.LANGUAGE_CODE
2013-02-24 14:43:45 +01:00
99edbe0e27
Fixed #19253 -- Extracted template cache key building logic
...
Introduced a public function
django.core.cache.utils.make_template_fragment_key
Thanks @chrismedrela for fruitful cooperation.
2013-02-24 14:32:45 +01:00
7106a1e594
Merge pull request #819 from erikr/master
...
Fixed #16302 -- Ensured contrib.comments is IPv6 capable.
2013-02-24 05:02:00 -08:00
ade992c61e
Fixed #16302 -- Ensure contrib.comments is IPv6 capable
...
Changed the ip_address field for Comment to GenericIPAddressField. Added
instructions to the release notes on how to update the schema of existing
databases.
2013-02-24 13:58:38 +01:00
5a9b2bce24
Fixed #19810 -- MemcachedCache now uses pickle.HIGHEST_PROTOCOL
2013-02-24 13:56:15 +01:00
f07a5f0a21
Fixed #11295 : If ModelAdmin.queryset returns a filtered QS don't require a 2nd count call
...
Original patch rewritten, added tests and get_filters_params method for ChangeList class.
Thanks Alex for the report.
2013-02-24 13:23:23 +01:00
e4ee3d8fca
Fixed a few ResourceWarnings.
2013-02-24 13:11:19 +01:00
e4e1287590
Merge pull request #817 from rybaktomasz/ticket_5568
...
Fixes #5568 -- DROP INDEX subcommand
2013-02-24 04:02:26 -08:00
cbb9f629b8
Revert "fixes #19263" - Fails if not SQLite
...
This reverts commit 2b76f19f2b
2013-02-24 12:38:32 +01:00
d7429defe6
Add sqldropindexes to manage
...
Change patch from https://code.djangoproject.com/ticket/5568
to work on modern Django.
Add special case for MySQL which has different syntax for DROP INDEX.
Add unit tests for the new functionality.
2013-02-24 12:38:28 +01:00
Aymeric Augustin
Jacob Kaplan-Moss
Claude Paroz
Ramiro Morales
Loic Bistuer
Alex Gaynor
Baptiste Mispelon
Igor Támara
Preston Holmes
Juan Pedro Fisanotti
Javier Mansilla
matiasb
Simon Charette
Anssi Kääriäinen
Łukasz Langa
Florian Apolloner
Carl Meyer
Florian Hahn
Julien Phalip
Christopher Medrela
Diederik van der Boor
Zbigniew Siciarz
Tomek Paczkowski
Erik Romijn
Bas Peschier
Wiktor Kolodziej
Honza Král
Tomasz Rybak