baa33cd8fa
Fixed #16218 -- date_list order in generic CBVs.
...
Thanks nnrcschmdt for the report and bpeschier for the initial
version of the patch.
2012-09-22 11:47:34 +02:00
26ff2be787
Imported getLogger directly from logging module
...
This was a remainder of some 2.4 compatibility code.
2012-09-20 21:03:24 +02:00
4e9a74b81d
Revert "Fixed #16865 -- Made get_or_create use read database for initial get query."
...
Thanks to Jeremy Dunck for pointing out the problem with this change. If in a
single transaction, the master deletes a record and then get_or_creates a
similar record, under the new behavior the get_or_create would find the record
in the slave db and fail to re-create it, leaving the record nonexistent, which
violates the contract of get_or_create that the record should always exist
afterwards. We need to do everything against the master here in order to ensure
correctness.
This reverts commit 901af86550
2012-09-19 11:15:12 -06:00
901af86550
Fixed #16865 -- Made get_or_create use read database for initial get query.
...
Thanks Rick van Hattem for the report and trbs for the patch.
2012-09-19 10:06:53 -06:00
40e62a5ccd
Fixed #18980 -- Fixed assertContains regression when passed an object
2012-09-18 21:05:41 +02:00
319e135519
Fixed #18800 -- Support numbers bigger than max float in `numberformat`.
...
Thanks to jbvsmo for the patch and Brad Pitcher for the tests.
2012-09-18 19:43:50 +02:00
23d0136314
Merge branch 'lotheac-fix_uploaded_file_exec'
2012-09-17 22:54:26 +02:00
e8c6aff3bf
Fixed #18947 -- Don't make uploaded files executeable by default.
...
Thanks to Lauri Tirkkonen for the patch.
2012-09-17 22:53:10 +02:00
a630d08483
Merge pull request #360 from calebsmith/add-permalink-wraps-test
...
Ticket #12836 - Added a test to assure permalink wraps method attributes
2012-09-16 14:00:51 -07:00
f399a804c9
Fixed #17485 regression -- only + select_related interaction
...
When doing deeper than one level select_related() + only queries(), the
code introduced in b6c356b7bb
2012-09-16 22:58:40 +03:00
c555741aa7
Fixed #18530 -- Fixed a small regression in the admin filters where wrongly formatted dates passed as url parameters caused an unhandled ValidationError. Thanks to david for the report.
2012-09-15 16:20:56 -07:00
b1fb6f4820
Modernized views.DebugViewTests
2012-09-15 21:07:42 +02:00
859aa2a6c4
Fixed #18790 -- Encoded database password on Python 2
...
Thanks thcourbon@gmail.com for the report.
2012-09-12 10:16:49 +02:00
f1bdfbd24b
Document and test 'type' usage in Widget attrs
...
Refs #16630 .
2012-09-10 19:31:11 +02:00
2e92858386
Fixed a couple of test failures on Windows.
2012-09-09 15:07:04 -04:00
a3b2136b28
Remove an outdated import inadvertently introduced in tests.
2012-09-08 18:22:03 -06:00
a78dd109e6
Fixed #15552 -- LOGIN_URL and LOGIN_REDIRECT_URL can take URLpattern names.
...
Thanks UloPe and Eric Florenzano for the patch, and Malcolm Tredinnick for
review.
2012-09-08 16:58:35 -06:00
307706d082
Fixed #18545 -- Make the 'no DJANGO_SETTINGS_MODULE' error message more useful.Thanks Nick Coghlan for the report, and Malcolm Tredinnick for review.
2012-09-08 14:26:33 -06:00
4754f122dd
Moved the admin inline JS to new JS files for cleanliness.
2012-09-08 15:09:37 -04:00
210fd7c658
refs #12836 - Added a test to assure permalink wraps method attributes
2012-09-08 11:58:48 -04:00
ccd1bb0d81
Remove Admin's swallowing of AttributeError ( #16655 , #18593 , #18747 )
...
During the new-admin changes, catching of AttributeError was added to
the admin. This patch removes that as it's no longer possible to add a
value to a ModelAdmin that is not available. Adding an attribute that
can not be called causes an ImproperlyConfigured exception to be raised.
2012-09-08 11:20:05 -04:00
9b07b5edeb
Fixed #18916 -- Allowed non-ASCII headers.
...
Thanks Malcolm Tredinnick for the review.
2012-09-07 19:08:57 -04:00
b865009d41
Fixed #12397 -- allow safe_join to work with the root file system path, which means you can have your root template or file upload path at this location. You almost certainly don't want to do this, except in *very* limited sandboxed situations.
2012-09-07 16:49:22 -04:00
5999eb42eb
Removed another usage of the bear "except:" (rawr!).
2012-09-07 15:34:48 -04:00
335a9f9cf1
Removed many uses of bare "except:", which were either going to a) silence real issues, or b) were impossible to hit.
2012-09-07 15:08:07 -04:00
6a5a12ea3e
Fixed #17888 -- no longer silence exceptions inside of check_test. Thanks to brutasse for the patch.
2012-09-07 14:37:21 -04:00
a92b81b0e8
Fixed tests that I broke a few commits ago.
2012-09-07 14:01:46 -04:00
f47af9df1d
Cleaned up several test cases, to better isolate state.
2012-09-07 13:47:12 -04:00
292322f977
[py3k] Silence many warnings while running the tests.
2012-09-07 13:17:34 -04:00
0e296131bb
Cleaned up some small bits of the ORM, including removing an import *.
2012-09-07 10:58:17 -04:00
5262a288df
Fixed #18687 : Removed test_performance_scalability
...
Even after repeated adjustment of the constants, this test still fails
randomly. It has educated us to ignore messages from Jenkins, to a
point where we missed some actual failures. In addition, it accounts
for a non-negligible percentage of the run time of the test suite
just by itself. Since no one has proposed a convincing patch in months,
I'm going to remove the patch. We can't keep a randomly failing test
forever.
2012-09-05 23:02:33 -04:00
22f85b9057
Fixed #18824 -- Allow deleting a setting from overriden settings
2012-09-04 09:41:12 +02:00
cc9b767fc6
Fixed #18902 -- Made force_bytes properly handle exception input
...
Thanks Aymeric Augustin for the report and the initial patch.
2012-09-04 09:27:28 +02:00
28fd876bae
Fixed #17892 -- Do not include whole RegexURLPattern lists in RegexURLResolver repr
...
Thanks milosu for the report and the initial patch.
2012-09-01 22:20:46 +02:00
306d34873c
Fixed #18212 -- Standardized arguments of GenericIPAddressField
...
Unlike other model fields, the newly introduced (1.4)
GenericIPAddressField did not accept verbose_name and name as the
first positional arguments. This commit fixes it.
Thanks Dan McGee for the report and the patch.
2012-09-01 18:38:55 +02:00
879b245baa
Fixed #5725 -- Fixed varchar column size introspection for MySQL
...
Thanks ferdonline for the initial patch and Karen Tracey for the
related post on django-users.
2012-08-30 19:28:13 +02:00
4e70ad11d2
Made FileSystemStorage accept both text and byte streams
...
Thanks Alexey Boriskin for his help on the patch.
2012-08-29 16:37:37 +02:00
b5240d25c1
Removed unnecessary bytes prefix for ContentFile
2012-08-29 11:32:18 +02:00
361d6738f8
Fixed #11739 -- Made ContentFile support Unicode input
2012-08-29 11:21:33 +02:00
ebc773ada3
Replaced many smart_bytes by force_bytes
...
In all those occurrences, we didn't care about preserving the
lazy status of the strings, but we really wanted to obtain a
real bytestring.
2012-08-29 11:20:32 +02:00
9eafb6592e
[py3] Fixed test failures introduced in 3afb5916b2.
2012-08-29 00:04:34 +02:00
3afb5916b2
Fixed #18091 -- Non-ASCII templates break `django-admin.py startproject --template=TEMPLATE`.
...
Thanks to Claude Huchet and Tomáš Ehrlich for the patch.
2012-08-28 23:23:07 +02:00
5a9e127efc
Made model instance history admin view link not hard-coded. Refs #15294 .
2012-08-26 17:54:49 -03:00
28ea4d4b07
Fixed #18852 -- Restored backwards compatibility
...
in django.core.signing. Specifically, kept the same return types
(str/unicode) under Python 2. Related to [92b2dec918
2012-08-25 22:22:32 +02:00
01b9c3d519
Fixed #16715 -- Fixed join promotion logic for nested nullable FKs
...
The joins for nested nullable foreign keys were often created as INNER
when they should have been OUTER joins. The reason was that only the
first join in the chain was promoted correctly. There were also issues
with select_related etc.
The basic structure for this problem was:
A -[nullable]-> B -[nonnull]-> C
And the basic problem was that the A->B join was correctly LOUTER,
the B->C join not.
The major change taken in this patch is that now if we promote a join
A->B, we will automatically promote joins B->X for all X in the query.
Also, we now make sure there aren't ever join chains like:
a LOUTER b INNER c
If the a -> b needs to be LOUTER, then the INNER at the end of the
chain will cancel the LOUTER join and we have a broken query.
Sebastian reported this problem and did also major portions of the
patch.
2012-08-25 14:14:45 +03:00
f5ea730dac
Fixed #18843 -- Replaced more special chars in column names (inspectdb)
...
Thanks airstrike for the report.
2012-08-23 22:59:45 +02:00
395c6083af
Fixed #12460 -- Improved inspectdb handling of special field names
...
Thanks mihail lukin for the report and elijahr and kgibula for their
work on the patch.
2012-08-23 21:46:57 +02:00
10d32072af
Fixed #18798 -- Renamed conflicting test methods in i18n tests
2012-08-23 11:27:56 +02:00
44c09de555
Fixed #18678 -- HttpResponse init arguments allowed for subclasses
...
Thanks hp1337@gmail.com for the report.
2012-08-23 10:59:22 +02:00
7cfe8e8fce
Fixed #11340 -- Prevented HttpResponseNotModified to have content/content-type
...
The HTTP 1.1 spec tells that the 304 response MUST NOT contain a
message body.
Thanks aparajita for the report.
2012-08-22 20:55:24 +02:00
dfe63a52ef
Revert "Fixed #18063 -- Avoid unicode in Model.__repr__ in python 2"
...
This reverts commit 3fce0d2a91
2012-08-22 11:48:47 +10:00
4353a6163c
Fixed #18196 -- Improved loaddata error messages.
2012-08-21 21:52:25 +02:00
a193372753
Fixed #17886 -- Fixed join promotion in ORed nullable queries
...
The ORM generated a query with INNER JOIN instead of LEFT OUTER JOIN
in a somewhat complicated case. The main issue was that there was a
chain of nullable FK -> non-nullble FK, and the join promotion logic
didn't see the need to promote the non-nullable FK even if the
previous nullable FK was already promoted to LOUTER JOIN. This resulted
in a query like a LOUTER b INNER c, which incorrectly prunes results.
2012-08-21 21:23:57 +03:00
e89bc39935
Reverted type check added in 62954ba04c.
...
Refs #17040 .
2012-08-21 09:00:55 +02:00
62954ba04c
[py3] Fixed #17040 -- ported django.utils.crypto.constant_time_compare.
...
This is a private API; adding a type check is acceptable.
2012-08-20 22:50:49 +02:00
3fce0d2a91
Fixed #18063 -- Avoid unicode in Model.__repr__ in python 2
...
Thanks guettli and mrmachine.
2012-08-20 16:47:30 +10:00
9729f77326
Reordered import statements for clarity.
2012-08-19 21:50:07 +02:00
2f59e94a41
Fixed #18728 -- Made colon optional in tzinfo
...
Made two-digit hours and minutes mandatory in tzinfo (the code used
to crash if a one-digit representation was provided).
Added standalone tests for django.utils.dateparse.
2012-08-19 21:47:41 +02:00
536b030363
[py3] Supported integers in HttpResponse
...
Fixed #18764 .
2012-08-19 16:38:21 +02:00
e945842042
Merge pull request #291 from uruz/ticket18793
...
Fixed #18793 : Removed duplicate test_head_no_get in generic_views.base
Thanks uruz.
2012-08-18 17:12:54 -07:00
f29032eac6
Fixed #18793 : Duplicate test test_head_no_get in generic_views.base
2012-08-19 01:04:08 +04:00
5b09fc8ad2
Merge pull request #288 from mjtamlyn/date-list-period
...
Fixed #3542 -- Add support for changing granularity on ArchiveView.
2012-08-18 09:10:52 -07:00
8d5c11caad
Fixed #3542 -- Add support for changing granularity on ArchiveView.
...
Resolving the concept from a very old ticket in a more class-based-view
manner.
2012-08-18 17:03:57 +01:00
afc1bd7ab8
[py3] Made 212b9826bd Python 3-friendly
2012-08-18 17:51:16 +02:00
f04bb6d798
Fixed #17228 -- params context variable is inconsistent
...
Remove the params variable from the context and just put the variables
in directly.
This had not been committed previously as the original pattern was used
in the functional generic views and we wanted consistency between them,
but django.views.generic.simple.direct_to_template is now gone so we can
do it 'right'.
2012-08-18 15:07:21 +01:00
212b9826bd
Fixed #14516 -- Extract methods from removetags and slugify template filters
...
Patch by @jphalip updated to apply, documentation and release notes
added.
I've documented strip_tags as well as remove_tags as the difference
between the two wouldn't be immediately obvious.
2012-08-18 15:07:21 +01:00
58683e9c82
Fixed #16744 -- Class based view should have the view object in the context
...
Updated the most recent patch from @claudep to apply again and updated
the documentation location.
2012-08-18 15:07:21 +01:00
547b181046
[py3] Ported django.utils.safestring.
...
Backwards compatibility aliases were created under Python 2.
2012-08-18 16:04:06 +02:00
bfa9fc69bf
Fixed #18779 -- URLValidator can't validate url with ipv6.
...
Validation is reasonably 'soft', as for the ipv4. False positives don't
matter too much here.
2012-08-18 12:08:44 +01:00
85e7a5e140
[py3] Stopped attempting to translate bytes.
...
That goes actively against the goal of cleaning string handling.
2012-08-18 11:36:09 +02:00
c03cf0b096
Cleaned up a test slightly.
...
We should catch all exceptions in the thread to ensure it doesn't die
with an unhandled exception. The type of the exception is already
checked further in the test.
2012-08-18 11:02:28 +02:00
6cb76cb140
[py3] Fixed templates tests.
2012-08-18 10:18:24 +02:00
ad11dbf670
[py3] Fixed __unicode__ methods missed in d4a0b278
...
due to non-standard syntax (a stray comma). Thanks dmishe for the report.
2012-08-17 14:11:23 +02:00
37a894b48c
[py3k] Fixed pagination_regress tests.
2012-08-16 10:54:45 -04:00
fcc8de0598
[py3] Ported django.core.servers.
2012-08-16 13:01:16 +02:00
8c356acf2e
[py3] Fixed test_utils tests of doctests.
2012-08-16 10:26:18 +02:00
e98cb05edf
[py3] Fixed the str tests.
...
These tests don't look very meaningful. They were ported from
doctests...
2012-08-16 09:44:42 +02:00
befa1dd7a5
Fixed the generic_inline_admin tests for python3.
2012-08-15 23:12:08 -04:00
0c257f5a23
Fixed the admin_changelist tests for python3.
2012-08-15 23:09:01 -04:00
24de85c419
[py3] Fixed more encoding issues in cache tests
2012-08-15 22:48:09 +02:00
37e05357cd
Used settings config for memcached tests.
...
By using settings config, we take advantage of custom settings like
KEY_PREFIX which allows for example to run tests in parallel.
2012-08-15 22:48:09 +02:00
f7c2e82d76
[py3] Fixed middleware tests.
...
Removed several inappropriate .encode('utf-8') calls in the process.
2012-08-15 22:42:18 +02:00
60f5e10230
[py3] Fixed dispatch tests
2012-08-15 18:19:21 +02:00
27192564c3
Run memcache tests if any cache is configured
2012-08-15 18:07:03 +02:00
a9facb455f
[py3] Fix some more encoding issues in tests
2012-08-15 17:41:38 +02:00
607665a396
[py3] Fixed bad unicode test
2012-08-15 16:40:12 +02:00
0ab570217a
[py3] Fixed paginator tests.
2012-08-15 14:58:43 +02:00
c1584890b1
[py3] Properly encode hashlib.md5 and zip.compress args in the tests.
2012-08-15 14:29:40 +02:00
5d01f3caea
[py3] Removed map() calls used for side-effects only
2012-08-15 13:23:41 +03:00
814fde32d9
Made the validation tests python3 friendly.
2012-08-15 03:02:32 -07:00
ea1e8b38b3
Ensured that the archive module consistantly explicitly closed all files.
2012-08-15 02:53:40 -07:00
ca6015ca71
Close files in the module_loading tests always.
2012-08-15 02:47:02 -07:00
fc99f127d8
Explicitly close a file during the email tests.
2012-08-15 02:16:28 -07:00
dfbcbf2124
Always close files in the file_storage tests.
2012-08-15 02:05:03 -07:00
e0d67f3440
[py3] Fixed test_client_regress tests
2012-08-15 10:58:26 +02:00
cca01c96d1
Converted the modeladmin tests to run on python 2 and 3.
2012-08-15 01:46:31 -07:00
54afdbf378
Fixed usage of several deprecated aliases in unittest.
2012-08-15 01:38:04 -07:00
2048bbee8c
Explicitly close files in the staticfiles tests.
2012-08-15 01:25:01 -07:00
c7734491f8
Use a name that exists in both python2 and 3,
2012-08-15 01:13:09 -07:00
e0ec7507ac
[py3] Fixed jsi18n test.
...
Also refactored said test to avoid leaking state (ie. active
translation) when an error occurs.
2012-08-15 09:45:28 +02:00
Aymeric Augustin
Claude Paroz
Carl Meyer
Jeremy Dunck
Florian Apolloner
Florian Apolloner
Anssi Kääriäinen
Julien Phalip
Karen Tracey
Travis Swicegood
Caleb Smith
Travis Swicegood
Alex Gaynor
Ramiro Morales
Alexey Boriskin
Simon Meers
Karen Tracey
Andrew Godwin
Marc Tamlyn
Alex Gaynor