3a9aa155e2
Fixed #23915 -- Made sure m2m fields through non-pk to_field are allowed in the admin.
...
refs #23754 , #23862
2014-11-25 15:28:21 -05:00
f9c4e14aec
Fixed #23754 -- Always allowed reference to the primary key in the admin
...
This change allows dynamically created inlines "Add related" button to work
correcly as long as their associated foreign key is pointing to the primary
key of the related model.
Thanks to amorce for the report, Julien Phalip for the initial patch,
and Collin Anderson for the review.
2014-11-25 13:26:50 -05:00
8e7b384d89
Fixed #23898 -- Added missing context to admin's deleted_selected view.
...
Thanks Redouane Zait for the report.
2014-11-25 11:22:15 -05:00
392e11945f
Fixed flake8 warnings.
2014-11-25 11:20:40 -05:00
ff3d746e8d
Fixed bug in circular dependency algo for migration dependencies.
...
Previous algo only worked if the first item was a part of the loop,
and you would get an infinite loop otherwise (see test).
To fix this, it was much easier to do a pre-pass.
A bonus is that you now get an error message that actually helps you debug
the dependency problem.
2014-11-25 15:37:34 +00:00
056a3c6c37
Fixed #23682 -- Enhanced circular redirects detection in tests.
...
When the test client detects a redirect to a URL seen in the
currently followed chain it will now raise a RedirectCycleError
instead of just returning the first repeated response.
It will also complain when a single chain of redirects is longer
than 20, as this often means a redirect loop with varying URLs,
and even if it's not actually one, such long chains are likely
to be treated as loops by browsers.
Thanks Preston Timmons, Berker Peksag, and Tim Graham for reviews.
2014-11-25 10:12:28 -05:00
a973fb2d68
Fixed and restored assertions in OneToOneTests.test_foreign_key.
...
These assertions had been removed in 34ba86706f7fe554b2a3
2014-11-25 09:47:32 -05:00
9a30acad8a
Fixed #21587 -- Added a warning for changing default of RedirectView.permanent.
2014-11-25 09:22:18 -05:00
d43dd03ca3
Fixed #23890 -- Silenced numpy DeprecationWarnings in template tests.
2014-11-25 09:09:13 -05:00
e22c64dfc0
Fixed #23742 -- Added an option to reverse tests order.
...
This is useful for debugging side effects affecting tests that
are usually executed before a given test. Full suite and pair
tests sort cases more or less deterministically, thus some test
cross-dependencies are easier to reveal by reversing the order.
Thanks Preston Timmons for the review.
2014-11-24 19:24:11 -05:00
31f85bae1e
Changed test_runner imports to name objects imported from test.runner.
2014-11-24 17:31:39 -05:00
1e9ac504e4
Fixed #23888 -- Fixed crash in File.__repr__() when name contains unicode.
2014-11-24 15:54:57 -05:00
47a131b944
Encapsulated TEMPLATE_STRING_IF_INVALID in Engine.
2014-11-23 11:53:53 +01:00
29a977ab14
Moved template loaders management in Engine.
...
Passed the engine instance to loaders. This is a prerequisite for
looking up configuration on the engine instance instead of global
settings.
This is backwards incompatible for custom template loaders that override
__init__. However the documentation doesn't talk about __init__ and the
way to pass arguments to custom template loaders isn't specified. I'm
considering it a private API.
2014-11-23 11:52:12 +01:00
17012b6936
Deprecated dirs argument to override TEMPLATE_DIRS.
...
Cancels 2f0566fa#4278 .
2014-11-23 09:29:33 +01:00
da2a35cf9e
Silenced a flake8 warning.
...
../tests/shortcuts/views.py:45:1: E302 expected 2 blank lines, found 1
2014-11-22 21:39:06 +02:00
7331788300
Avoided rewrapping Contexts in render_to_response.
...
This change preserves backwards-compatibility for a very common misuse
of render_to_response which even occurred in the official documentation.
It fixes that misuse wherever it happened in the code base and docs.
Context.__init__ is documented as accepting a dict and nothing else.
Since Context is dict-like, Context(Context({})) could work to some
extent. However, things get complicated with RequestContext and that
gets in the way of refactoring the template engine. This is the real
rationale for this change.
2014-11-22 17:58:38 +01:00
bf1bd0fbc9
Moved tests for render shortcuts to their own app.
2014-11-22 17:52:43 +01:00
b38637d581
Fixed #23887 -- Returned Bad Request for multipart parsing fails
...
Thanks Antti Häyrynen and Tim Graham for the report, and Aymeric
Augustin for the review.
2014-11-22 14:23:37 +01:00
c7087bc777
Fixed #23862 -- Made ManyToManyRel.get_related_field() respect to_field.
2014-11-21 16:02:31 -05:00
343162410f
Fixed #21753 -- Raised exception when both `form_class` and `fields` are specified.
2014-11-21 14:23:17 -05:00
5b26a014a8
Fixed #23865 -- documented how to assign errors to a field in Model.clean()
...
Also added a unit test wit the simpler syntax which we have documented,
where the dictionary values are strings.
2014-11-21 13:01:28 -05:00
8330b50c85
Fixed #23863 -- Made runtests accept the keepdb option.
...
refs #20550
2014-11-21 11:41:13 -05:00
72729f844e
Fixed #23794 -- Fixed migrations crash when removing a field that's part of index/unique_together.
2014-11-21 10:55:19 -05:00
f957e2b04c
Added a test for model pre/post_init signals.
2014-11-21 10:39:37 -05:00
5b17dcd8ef
Fixed #23883 -- Stopped flatatt modifying its argument
2014-11-21 09:45:08 +01:00
d8f00e1918
Added a comment for test of refs #20278 .
2014-11-20 16:26:25 -05:00
4c709cc0ef
Fixed duplicate index error on Oracle; refs #23859 .
...
Refers to regression introduced in 7b4a994599
2014-11-20 14:42:39 -05:00
cfa26f29bd
Reduced reduce() usage; refs #23796 .
...
django.core.exceptions.ValidationError.messages() and
django.db.backends.schema.BaseDatabaseSchemaEditor._alter_field():
Replaced reduce(operator.add, ...) w/uncoupled, explicit sum()
2014-11-20 14:31:14 -05:00
f273cedc76
Added test for ValidationError.messages
2014-11-20 14:31:14 -05:00
5c481db295
Fixed #23605 -- Fixed nested subquery regression
...
Added relabeled_clone() method to sql.Query to fix the problem. It
manifested itself in rare cases where at least double nested subquery's
filter condition might target non-existing alias.
Thanks to Trac alias ris for reporting the problem.
2014-11-20 13:38:08 -05:00
21e21c7bc2
Fixed #23844 -- Used topological sort for migration operation dependency resolution.
...
This removes the concept of equality between operations to guarantee
compatilibity with Python 3.
Python 3 requires equality to result in identical object hashes. It's
impossible to implement a unique hash that preserves equality as
operations such as field creation depend on being able to accept
arbitrary dicts that cannot be hashed reliably.
Thanks Klaas van Schelven for the original patch in
13d613f800
2014-11-20 12:49:49 -05:00
788fa9fffa
Fixed #12098 -- Simplified HttpRequest.__repr__().
2014-11-20 08:45:11 -05:00
51f2de1530
Added another migration-executor test to avoid regressions.
2014-11-19 19:43:12 -07:00
ab2819aa7b
Fixed #23410 -- Avoided unnecessary rollbacks in related apps when migrating backwards.
2014-11-19 16:11:44 -07:00
47b7f601ee
Fixed #23872 -- Removed sensitivity of migrations tests to CWD.
2014-11-19 15:03:47 -07:00
b69b4008d1
Removed usage of a global variable.
2014-11-19 21:35:40 +01:00
f88ad710fa
Simplified caching of template context processors.
2014-11-19 21:35:39 +01:00
a97e72aaab
Simplified caching of templatetags modules.
2014-11-19 21:35:39 +01:00
2331650835
Cleaned up and reformatted autodetector tests
2014-11-19 11:09:38 -05:00
f17acd5930
Formatted model states in autodetector tests
2014-11-19 11:09:38 -05:00
cf7a2a000e
Fixed #22248 -- Made RenameModel reversible
2014-11-19 14:11:35 +02:00
5617508fb9
Removed nonexistent module django.test._doctest from coveragerc.
2014-11-19 06:01:39 -05:00
d63703f1cd
Fixed #18714 -- Added 'fuzzy' compilemessages option
2014-11-18 22:44:16 +01:00
d188101319
Fixed #23799 -- Made makemigrations respect --no-optimize.
...
Thanks to yamila-moreno for the idea of a skip message.
2014-11-18 07:37:06 +01:00
87f187b960
Adjusted tests for previous commit.
...
The test was testing a use case that doesn't happen in real world
projects: developers don't assign settings at run time (and Django
explicitly doesn't support it).
2014-11-17 23:26:04 +01:00
a37f452513
Removed superfluous newline.
2014-11-17 22:27:00 +01:00
7b4a994599
Fixed #23859 -- Fixed a migration crash when a field is renamed that is part of an index_together
2014-11-17 19:15:07 +01:00
bb4a92d784
Fixed #23840 -- Fixed makemessages find_files method
...
Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.
2014-11-17 09:21:24 +01:00
580e9d0045
Fixed a test to correctly calculate a fixture's relative path.
2014-11-17 02:32:04 +01:00
9eeb788cfb
Refactored getting the list of template loaders.
...
This provides the opportunity to move utility functions specific to the
Django Template Language outside of django.template.loader.
2014-11-16 21:41:44 +01:00
b503fee7ec
Removed override_template_loaders and override_with_test_loader.
...
They can be replaced with override_settings and that makes the
corresponding tests much more obvious.
2014-11-16 21:40:50 +01:00
2577ae6a08
Moved all template loaders under django.template.loaders.
...
Reformatted the code of base.Loader according to modern standards.
Turned the test template loader into a regular locmem.Loader -- but
didn't document it.
Added a normal deprecation path for BaseLoader which is a public API.
Added an accelerated deprecation path for TestTemplateLoader which is
a private API.
2014-11-16 21:28:26 +01:00
dec93d8991
Fixed #21612 -- Made QuerySet.update() respect to_field
2014-11-16 15:44:13 +01:00
f61256da3a
Renamed qn to compiler
2014-11-16 13:19:34 +01:00
68ef44c565
Removed references to the deprecated assertRaisesRegexp method.
2014-11-16 02:12:36 +01:00
013b5eacea
Added tests/README.rst
2014-11-15 19:47:05 +01:00
d2d6c0c097
Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign().
2014-11-15 19:36:33 +01:00
35dac5070b
Added a new GeoJSON serialization format for GeoDjango
...
Thanks Reinout van Rees for the review.
2014-11-15 18:07:18 +01:00
c5def493d0
Fixed #23835 : Changed circular dependency in DFS to be less infinite
2014-11-15 17:39:02 +01:00
9a5a4361c5
Merge pull request #3531 from ddaan/ticket_23834
...
fixed #23834 -- added test and fix to check for default null on ArrayField
2014-11-15 15:37:03 +00:00
a7c58eaca4
added test and fix to check for default null on ArrayField
2014-11-15 15:20:11 +00:00
83d104d61a
Revert "Use topological sort for migration operation dependency resolution"
...
This commit broke the tests on Python 3.
This reverts commit 13d613f800
2014-11-15 15:28:04 +01:00
f59fd15c49
Fixed #14030 -- Allowed annotations to accept all expressions
2014-11-15 14:00:43 +00:00
13d613f800
Use topological sort for migration operation dependency resolution
...
rather than an ad-hoc algorithm
2014-11-15 14:45:42 +01:00
d552da1f8d
Fixed #22407 -- Added AdminEmailHandler.send_mail().
2014-11-15 09:38:19 +01:00
a305695f28
Merge pull request #3481 from manfre/ticket-16358
...
Fixed #16358 - Made memcache backend delete old value on a failure to set.
2014-11-13 22:10:22 -05:00
c24a2e6cbd
Fixed #23765 -- Removed BooleanField default check which often yielded false positives.
2014-11-13 20:12:29 +01:00
e118e3af37
Fixed #23761 -- Added test for MySQL validator and db_type is None.
...
The issue was fixed on master in e9103402c02d12a59938
2014-11-13 11:06:59 +01:00
dec7da3c4c
Fixed flake8 warning.
2014-11-13 10:07:44 +01:00
311feae8ba
Fixed #23806 -- Added a test case for settings.DISALLOWED_USER_AGENTS.
2014-11-13 09:45:14 +01:00
bc8abe36ba
Fixed #16358 - Made memcache backend delete old value on a failure to set.
...
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
2014-11-13 00:46:03 -05:00
bfb11b9562
Fixed #23795 -- Fixed a regression in custom form fields
...
Custom form fields having a `queryset` attribute but no
`limit_choices_to` could no longer be used in ModelForms.
Refs #2445 .
Thanks to artscoop for the report.
2014-11-12 22:38:18 +01:00
42b5e4feea
Fixed #23730 -- Moved support for SimpleCookie HIGHEST_PROTOCOL pickling to http.cookie.
...
This fix is necessary for Python 3.5 compatibility (refs #23763 ).
Thanks Berker Peksag for review.
2014-11-12 19:04:45 +01:00
c56c42b5c0
Fixed #22967 -- Made Model._do_update consistent
...
Made _do_update behave more strictly according to its docs,
including a corner case when specific concurent updates are
executed and select_on_save is set.
2014-11-12 12:53:30 +02:00
5ec367ccdd
Fixed #23788 -- Used new JavaScript support in recent gettext
...
JavaScript string extraction support has been added in gettext
0.18.3.
Thanks Aymeric Augustin for the review.
2014-11-11 22:52:30 +01:00
b8ba73cd0c
Raised SuspiciousFileOperation in safe_join.
...
Added a test for the condition safe_join is designed to prevent.
Previously, a generic ValueError was raised. It was impossible to tell
an intentional exception raised to implement safe_join's contract from
an unintentional exception caused by incorrect inputs or unexpected
conditions. That resulted in bizarre exception catching patterns, which
this patch removes.
Since safe_join is a private API and since the change is unlikely to
create security issues for users who use it anyway -- at worst, an
uncaught SuspiciousFileOperation exception will bubble up -- it isn't
documented.
2014-11-11 19:05:14 +01:00
b7a5b6ab86
Fixed #23750 -- Allowed core.checks.register to be used as a function
2014-11-11 16:29:32 +01:00
b748a8bc67
Fixed #23789 -- TemplateResponse handles context differently from render
2014-11-10 14:47:45 +00:00
c7c098cf97
Fixed #23770 -- Changed serialization strategy for floats with respect to NaN and Inf
...
Thanks to w0rp for the report
2014-11-06 15:30:30 +01:00
df0523debc
Fixed #23531 -- Added CommonMiddleware.response_redirect_class.
2014-11-04 17:56:57 -05:00
ca48cef3b4
Removed unused import.
2014-11-04 11:27:35 -05:00
74e1980cf9
Fixed #13181 -- Added support for callable choices to forms.ChoiceField
...
Thanks vanschelven and expleo for the initial patch.
2014-11-04 11:23:58 -05:00
36f514f065
Added HStoreField.
...
Thanks to `django-hstore` for inspiration in some areas, and many people
for reviews.
2014-11-04 09:26:40 +00:00
a71a2ea756
Fixed typos using https://github.com/vlajos/misspell_fixer
2014-11-03 20:59:30 -05:00
7b42036752
Fixed #5405 -- Added admindocs support for reStructured text in model docstrings
...
Thanks elvard and gkmngrgn for work on the patch and Markus H. for review.
2014-11-03 15:30:46 -05:00
2d06e3155a
Fixed #23300 -- Made assertTemplateUsed throw an error on responses not fetched using the test client.
...
Thanks zags for the report and bmispelon for the patch.
2014-11-03 14:31:23 -05:00
d89f56dc4d
Fixed #21281 -- Made override_settings act at class level when used as a TestCase decorator.
2014-11-03 14:14:39 -05:00
8b77b64f1c
Refactored URLValidator tests by moving URLs to text files.
2014-11-03 13:02:11 -05:00
ebc8e79cf3
Fixed #18523 -- Added stream-like API to HttpResponse.
...
Added getvalue() to HttpResponse to return the content of the response,
along with a few other methods to partially match io.IOBase.
Thanks Claude Paroz for the suggestion and Nick Sanford for review.
2014-11-03 12:29:19 -05:00
f7969b0920
Fixed #23620 -- Used more specific assertions in the Django test suite.
2014-11-03 11:56:37 -05:00
ceb1ffcc8d
Fixed #23420 - broken warning for unbound naive datetime objects
...
Fixed issue with warning message displayed for unbound naive datetime
objects when USE_TZ is True. Adds unit test that demonstrates the issue
(discoverable when using a custom lookup in MySQL).
2014-11-03 15:51:48 +02:00
c548c8d0d1
Fixed #18456 -- Added path escaping to HttpRequest.get_full_path().
2014-11-03 07:59:19 -05:00
934a16dc93
Fixed #23468 -- Added checks for duplicate fixtures directories in loaddata.
...
If settings.FIXTURE_DIRS contains duplicates or a default fixture
directory (app_name/fixtures), ImproperlyConfigured is raised.
Thanks to Berker Peksag and Tim Graham for review.
2014-10-31 18:21:54 -04:00
715ccfde24
Fixed #23738 -- Allowed migrating from NULL to NOT NULL with the same default value
...
Thanks to Andrey Antukh for the report.
2014-10-31 13:30:30 -04:00
ed2f96819c
Fixed #23715 -- Prevented urlize from treating a trailing ! as part of an URL
...
Thanks to 57even for the report.
2014-10-31 08:06:40 -04:00
98da408964
Fixed #23670 -- Prevented partial import state during module autodiscovery
...
Thanks kostko for the report.
2014-10-31 08:01:47 -04:00
c0c1bb9e64
Avoided using private API get_template_from_string.
2014-10-31 11:38:53 +01:00
f2ddc439b1
Fixed #23656 -- Made FormMixin.get_form's form_class argument optional.
...
Thanks Tim Graham for the review.
2014-10-30 19:10:52 -04:00
fd061b6591
Fixed #23733 -- Fixed squashing migrations that depend on multiple apps.
2014-10-30 14:39:11 -04:00
eb4f6de980
Fixed #8149 -- Made File.__iter__() support universal newlines.
...
The following are recognized as ending a line: the Unix end-of-line
convention '\n', the Windows convention '\r\n', and the old
Macintosh convention '\r'.
http://www.python.org/dev/peps/pep-0278
Thanks tchaumeny for review.
2014-10-30 11:52:59 -04:00
85086c8158
Fixed #23556 -- Raised a more meaningful error message when migrations refer to an unavailable node
2014-10-30 00:17:29 +01:00
5c9c1e029d
Fixed #23614 -- Changed the way the migration autodetector orders unique/index_together
...
Thanks to Naddiseo for the report and Tim Graham for the review
2014-10-29 13:05:42 -04:00
1e64a1e7b1
Fixed flake8 warnings.
2014-10-28 10:12:10 -04:00
28634394f5
Fixed #23606 -- Implemented Client and RequestFactory trace() methods.
...
Thanks KevinEtienne for the suggestion.
2014-10-28 10:11:12 -04:00
ae7cb992bc
Fixed #23721 -- check_related_objects without calling __iter__
...
Refs #14334
2014-10-28 10:13:50 +02:00
00aa562884
Fixed #23493 -- Added bilateral attribute to Transform
2014-10-28 10:02:10 +02:00
528c9af543
Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
2014-10-27 13:56:25 +01:00
dd1ea70779
Fixed #23699 -- Prevented flush from loading initial data for apps with migrations.
2014-10-27 06:56:44 -04:00
7f089ac2e3
Fixed #23446 -- Officially recommended mysqlclient as MySQL driver
...
Thanks Corey Farwell for the report and Tim Graham for the review.
Thanks also to Inada Naoki for creating and maintaining mysqlclient.
2014-10-27 09:11:33 +01:00
45db842c9b
Fixed #23652 -- Restored database name after destroying test database
...
Thanks Bjarkias for the report.
2014-10-24 17:04:43 +02:00
2c9a03d487
Fixed #23707 -- Prevented discovery of duplicated tests
2014-10-23 21:03:57 +02:00
92269b7b53
Fixed #23702 -- Fixed adding an explicit id field on SQLite.
...
Thanks gavinwahl for the report.
2014-10-23 12:24:34 -04:00
2d75515a4c
Fixed #23444 -- Deprecated django.contrib.admin.helpers.InlineAdminForm.original_content_type_id
2014-10-23 09:49:24 -04:00
70428902c0
Added missing available app in migrations test case
...
In some test combinations, having contrib.auth available but not
contrib.contenttypes can produce failures while creating permissions.
2014-10-23 15:39:26 +02:00
41b337efa0
Fixed #23630 -- Made AlterModelTable rename auto-created M2M tables.
...
Thanks Naddiseo for the report, Andrew Godwin for guidance,
and Shai Berger for review.
2014-10-23 08:05:39 -04:00
bc6caa5d45
Made a doctest compatible with Python 2
...
That test might not always execute, but can be executed when the
parent test label is explicitely given.
2014-10-23 11:16:17 +02:00
ef9e3c5ed8
Fixed flake8 warning.
2014-10-22 21:21:02 -04:00
28da093ae2
Allowed test from refs #23612 to be run from a directory other than tests.
2014-10-22 15:24:33 -04:00
b62f72498a
Improved warning message when reloading models. Refs #23621 .
...
Thanks dfunckt and Tim Graham.
2014-10-23 01:46:04 +07:00
8c4ca16c65
Fixed #23621 -- Warn for duplicate models when a module is reloaded.
...
Previously a RuntimeError was raised every time two models clashed
in the app registry. This prevented reloading a module in a REPL;
while it's not recommended to do so, we decided not to forbid this
use-case by turning the error into a warning.
Thanks @dfunckt and Sergey Pashinin for the initial patches.
2014-10-23 00:55:02 +07:00
eb82fb0a9d
Refactored color_style() and no_style() to improve testability. Refs #23663 .
...
This includes the following improvements:
- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
from a config string. Before the only way to get a style object was
through the environ and it also required that the terminal supported
colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
other Style objects. Previously it allowed anything to pass through
with __getattr__.
2014-10-22 11:27:00 +07:00
bdb4118b1a
Fixed #23686 -- Tweak color output of the system check framework.
...
Thanks Tim Graham for the review.
2014-10-22 11:27:00 +07:00
494ba051bb
Made testing of stdout and stderr more consistent.
...
Refs #23663 .
2014-10-22 09:25:50 +07:00
533532302a
Fixed #23663 -- Initialize output streams for BaseCommand in __init__().
...
This helps with testability of management commands.
Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
2014-10-22 09:25:50 +07:00
494cd857c8
Fixed #23653 -- Fixed Windows failure of a logging test added in refs #23569 .
2014-10-21 18:32:46 -04:00
bbc3505ef8
Removed unneeded override_system_checks
...
Refs #23685 .
2014-10-21 20:54:32 +02:00
8b4cc9df9c
Fixed #23583 -- More selectively ignored static/media roots
...
Fixed a regression introduced by 28efafa24c
2014-10-21 20:18:21 +02:00
c34e13e17c
Fixed #23107 -- Made runserver output respect --no-color.
...
This commit reverts 67d7da5fb9
2014-10-22 01:03:15 +07:00
9f1202c166
Fixed #23695 -- Made condition decorator work for HEAD requests without ETag.
2014-10-21 11:13:29 -04:00
0e16c3e3cd
Fixed #23396 -- Ensured ValueQuerySets are not checked by check_related_objects.
2014-10-21 10:02:51 -04:00
f0bb3c98cc
Fixed #21740 -- Allowed test client data to be an empty string
...
This fixes a regression introduced by 2a31d00933
2014-10-21 09:16:57 +02:00
edcb33c92e
Fix SettingsCustomLoggingTest on Windows when path contains \u
2014-10-20 21:49:44 -04:00
dbf7a3df45
Fixed #23688 -- Updated cached_property to preserve docstring of original function
2014-10-20 17:59:07 -04:00
54e695331b
Fixed #20221 -- Allowed some functions that use mark_safe() to result in SafeText.
...
Thanks Baptiste Mispelon for the report.
2014-10-20 17:08:29 -04:00
4fe6824ffd
Fixed #23679 -- Fixed null introspection for char/text fields
...
Thanks Paul Dejean for the report.
2014-10-20 22:37:19 +02:00
5732424bee
Fixed #23629 -- Allowed autodetector to detect changes in Meta.db_table.
...
Thanks Naddiseo for reporting.
2014-10-20 13:14:44 -04:00
6d11bb102d
Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times"
...
This reverts commit 8d6e1afe0b
2014-10-20 17:26:00 +02:00
685edab9da
Fixed #23685 -- Made call_command skip checks by default
...
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
2014-10-20 17:26:00 +02:00
968510e5d7
Moved a test case that caused deprecation warnings.
...
`cache.tests.TestEtagWithAdmin` loaded views from the `admin_views` test
package. This is problematic because when the `cache` test package is
run in isolation, `admin_views` isn't in INSTALLED_APPS, and therefore
loading its models isn't allowed since the app loading refactor.
2014-10-20 00:22:48 +07:00
6c79d32977
Fixed #23684 -- Used correct package name for Pillow in Error hint.
2014-10-19 13:46:46 +07:00
825ea83858
Fixed #21196 -- Removed index on test field causing MySQL specific warning.
2014-10-19 13:44:39 +07:00
8d6e1afe0b
Fixed #23650 -- Prevented migrate from calling checks 3 times
...
Thanks Ilya Baryshev for the report and Tim Graham for the review.
2014-10-17 20:20:56 +02:00
7ae03204ac
Fixed #23469 -- Removed test runner compatibility check which often yielded false positives.
2014-10-17 10:31:49 -04:00
a5c77417a6
Fixed #23615 -- Validate that a Model instance's "check" attribute is a method.
...
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.
This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
2014-10-16 23:49:21 +07:00
157f9cf240
Minor cleanup in the check_framework test package.
2014-10-16 23:49:21 +07:00
b962653060
Fixed #23664 -- Provided a consistent definition for OrderedSet.__bool__
...
This also defines QuerySet.__bool__ for consistency though this should not have any consequence as bool(qs) used to fallback on QuerySet.__len__ in Py3.
2014-10-16 14:16:24 +02:00
374c14b7fd
Fixed #23659 -- Kept annotate() args ordering
...
Thanks Loic Bistuer and Simon Charette for the review.
2014-10-16 09:27:20 +02:00
f6c208d95c
Fixed a flake8 warning.
2014-10-15 16:36:11 -04:00
a6a8268d19
Fixed #23660 -- Moved sort_dependencies to core.
2014-10-16 03:04:13 +07:00
10b17a22be
Fixed #19508 -- Implemented uri_to_iri as per RFC.
...
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
2014-10-16 02:31:17 +07:00
3af5af1a61
Fixed remaining test failure in jslex tests.
2014-10-15 17:36:19 +02:00
2ccbaba1f2
Added unicode_literals to the jslexer.
...
This ensure that ''.join(c) in jslex.py always returns text.
2014-10-15 15:09:35 +02:00
7a893ee771
Fixed #23651 -- Isolated non-existent fixture tests
...
Previous versions of the tests were buggy, as initial_data.json
did exist and the test wasn't failing. It was finally failing on
Python 3.4.2.
Thanks Raphaël Hertzog for the report (and Debian bug #765117
contributors).
2014-10-15 09:17:44 +02:00
7131efa154
Adapted invalid cookie test to all Python versions
...
Refs #23638 . Older Python versions are less strict when parsing
invalid cookie content. The test just has to ensure Django doesn't
crash.
2014-10-14 09:30:26 +02:00
59d487e7fc
Fixed #23638 -- Prevented crash while parsing invalid cookie content
...
Thanks Philip Gatt for the report and Tim Graham for the review.
2014-10-13 17:37:58 +02:00
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
06b11b617e
Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter.
...
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
2014-10-10 12:10:32 -04:00
115c307184
Fixed #23613 -- Deprecated django.utils.checksums
2014-10-10 09:22:20 -04:00
4ef9618e12
Avoided requiring sqlparse for a test.
...
Refs #23426 . Thanks Markus Holtermann for the suggestion.
2014-10-09 14:59:33 -04:00
16ed35fafc
Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows.
2014-10-09 14:58:20 -04:00
92a17eaae0
Fixed #23627 -- Allowed register_lookup to work as a decorator.
2014-10-09 18:44:58 +01:00
d6a87eefd8
Skip another test if sqlparse is not available
...
Refs #23426
2014-10-09 11:54:42 -04:00
f633ba778d
Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows
...
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
2014-10-09 21:32:06 +07:00
30b44cea38
Fixed flake8 warning.
2014-10-08 18:10:50 -04:00
88b6cf4ae4
Fixed #23600 -- Made default_storage aware of more settings changes.
...
Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
2014-10-08 18:10:47 -04:00
ca61195827
Fixed #23555 -- Avoided suppressing IndexError in QuerySet.first() and .last()
2014-10-08 14:28:38 -04:00
0eccf8fbea
Fixed misplaced test case.
2014-10-08 05:11:09 +07:00
ed37f7e979
Fixed #23611 -- update_or_create failing from a related manager
...
Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.
2014-10-08 03:27:31 +07:00
c1ef234e31
Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes
2014-10-07 13:06:39 -04:00
d1e87aebf7
Refactored model lookup tests; refs #18586 .
2014-10-07 12:04:56 -04:00
9dff5ce7c7
Fixed #23593 -- Fixed crash in AdminEmailHandler with non-ASCII characters in request.
...
Thanks edevil for the report and Simon Charette for review.
2014-10-06 17:35:53 -04:00
6f6e7d01dc
Merge pull request #3308 from aericson/ticket_22064
...
Fixed #22064 -- Add check for related_name
2014-10-06 14:06:33 -06:00
ec2fd02bb3
Fixed #23594 -- Fixed deepcopy on ErrorList.
...
Thanks Troy Grosfield for the report and Tim Graham for the tests.
2014-10-07 00:09:55 +07:00
2f16ff5a6c
Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs.
2014-10-06 09:31:39 -04:00
a24cf21722
Fixed #23604 -- Allowed related m2m fields to be references in the admin.
...
Thanks Simon Charette for review.
2014-10-06 08:35:16 -04:00
1e5e2a4707
Fixed #22064 -- Add check for related_name
...
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.
Thanks Konrad Świat for the initial work.
2014-10-04 20:47:26 -03:00
8c581ff394
Fixed #23482 -- Added SingleObjectMixin.query_pk_and_slug
...
Enabling the attribute causes get_object() to perform its lookup
using both the primary key and the slug.
2014-10-02 15:42:30 -04:00
85f6d89313
Fixed #23426 -- Allowed parameters in migrations.RunSQL
...
Thanks tchaumeny and Loic for reviews.
2014-10-02 11:52:40 -04:00
fe2afcd318
Fixed #23569 -- Allowed using configs besides dictConfig in LOGGING_CONFIG.
2014-09-30 17:13:27 -04:00
c7b5883c78
Fixed flake8 warnings.
2014-09-30 13:24:20 -04:00
f5cfd09c25
Fixed #7361 -- Added cancel link to admin delete views.
2014-09-30 08:45:04 -04:00
a407b846b4
Fixed #23365 -- Added support for timezone-aware datetimes to migrations.
2014-09-29 20:45:43 -04:00
311b3ad9db
Fixed #23567 -- Made assertQuerysetEqual check Counter equality when ordered=False
2014-09-29 12:00:14 -04:00
4b257cf261
Fixed flake8 warnings.
2014-09-29 08:13:40 -04:00
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
c1ae0621ba
Fixed #22738 -- made finer distinctions for when Boolean is not detected on Oracle
...
Thanks Claude Paroz for partial fix and Simon Charrette for review
2014-09-27 09:49:50 +03:00
dbdae3a755
Fixed #22738 -- Abstracted boolean field type introspection
...
Thanks maxi for the report, Shai Berger for his help with the patch
and Tim Graham for the review.
2014-09-26 20:03:44 +02:00
b23d47412c
Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imports.
...
Thanks Tim Graham for the review.
2014-09-27 00:36:28 +07:00
ef5f9b6ae8
Fixed #23460 -- Added literal `%s` support to extra() QuerySets.
2014-09-26 13:01:27 -04:00
17557d068c
Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query.
...
Thanks lidaobing for the suggestion.
2014-09-26 12:12:40 -04:00
45bd7b3bd9
Fixed #23455 -- Forced related_name to be a unicode string during deconstruction.
2014-09-25 17:49:44 -04:00
d8e157d5ab
Refactored m2m_through tests. Refs #18586
...
Refactored old tests that were rewritten 1:1 from doctests.
2014-09-26 01:28:32 +07:00
215aa4f53b
Fixed #23415 -- Added fields for unmanaged and proxy model migrations.
...
Thanks sky-chen for the report.
2014-09-25 10:25:03 -04:00
e077c29155
Fixed #23551 -- Fixed bash autocompletion crash on Python 3.
2014-09-25 07:44:22 -04:00
d7ab2cefb7
Revert "Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations."
...
This reverts commit abcf28a076
2014-09-24 15:49:30 -04:00
a4f23eba2e
Fixed #23421 -- Corrected TEST SERIALIZE setting.
...
Thanks gkoller for the report.
2014-09-24 14:46:10 -04:00
b9a670b227
Fixed #23426 -- Don't require double percent sign in RunSQL without parameters
2014-09-24 07:20:57 -04:00
0aca91cf7f
Fixed flake8 warnings.
2014-09-24 06:32:42 -04:00
cf43a1ee90
Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin.
2014-09-24 06:32:42 -04:00
2f3a4cd573
Removed numbering from the models.py header of some test packages.
...
This is a reliqua from the early days of the modeltests/regressiontests era.
2014-09-24 17:28:56 +07:00
d128eac316
Changed Oracle test-user creation to grant privileges instead of roles
...
because the roles (specifically RESOURCE) are deprecated.
Also added optional support for creating views in tests, and made an
introspection test fail (rather than skip) if a view cannot be created
due to lacking privileges.
Refs #18782
Thanks Tim Graham for review, and Josh Smeaton
2014-09-24 04:58:33 +03:00
e043aae9bb
Fixed #23550 -- Normalized get_queryset() of RelatedObjectDescriptor
...
and ReverseSingleRelatedObjectDescriptor so they actually return QuerySet
instances.
Also ensured that SingleRelatedObjectDescriptor.get_queryset() accounts
for use_for_related_fields=True.
This cleanup lays the groundwork for #23533 .
Thanks Anssi Kääriäinen for the review.
2014-09-24 02:03:12 +07:00
1fd6e13bf2
Consolidated some many_to_one tests.
2014-09-24 02:03:12 +07:00
2a1bdf5ced
Called table_names instead of get_table_list in migrations
2014-09-23 20:13:31 +02:00
ed297061a6
Fixed #18782 -- Prevented sql_flush to flush views
...
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
2014-09-23 20:13:31 +02:00
463952d940
Fixed #23503 -- Fixed renaming of model with self-referential m2m field.
2014-09-23 10:03:37 -04:00
83cd18633f
Fixed #23065 -- Quoted constraint names in SQL generated by migrations.
2014-09-23 09:25:31 -04:00
3c6ac0bab8
Consolidated some text utils into the utils_tests test package.
2014-09-23 19:45:59 +07:00
0dab07e5da
Merged custom_managers_regress into the custom_managers test package.
2014-09-23 03:56:19 +07:00
d42a45de40
Merged custom_columns_regress into the custom_columns test package.
2014-09-23 03:56:19 +07:00
7fe554b2a3
Merged one_to_one_regress into the one_to_one test package.
2014-09-23 03:56:19 +07:00
aeb48b9bc5
Fixed an i18n test with native string
...
Refs commit 11f307a5a8
2014-09-21 17:28:37 +02:00
11f307a5a8
Fixed #23196 -- Short-circuited empty string translation
...
Translating an empty string used to return the gettext catalog
metadata instead of the empty string.
Thanks Ned Batchelder for the suggestion, Tim Graham for the review
and Anton Berezin and Claude Paroz for contributions to the patch.
2014-09-21 17:08:17 +02:00
9d30412a5a
Fixed some flake8 errors.
...
Originally I added migrations to flake8 exclude because of long lines
in migration files, but there are other directories named migrations we
do want to check. We are not warning on line lengths yet anyway.
2014-09-19 12:31:15 -04:00
e008a10c2f
Fixed #23443 -- Corrected erroneous FieldError message.
...
Thanks Tim Graham for the review.
2014-09-19 01:01:31 +07:00
abc11b0a33
Fixed #23514 -- Prevented queries in PostGISOperations init
...
Thanks Mattia Procopio for the report.
2014-09-18 20:00:35 +02:00
fc2b8ddcc8
Fixed #23495 -- Stopped swallowing real settings import error
...
Thanks papaloizouc for the report.
2014-09-17 17:15:44 +02:00
d63ac5b595
Fixed #23492 -- Restored F.__deepcopy__.
...
This reverts commit 3a66035107
2014-09-16 12:19:00 +02:00
ed7821231b
Fixed #19463 -- Added UUIDField
...
Uses native support in postgres, and char(32) on other backends.
2014-09-16 10:08:09 +01:00
abcf28a076
Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations.
2014-09-15 14:56:59 -04:00
8ed7834fb2
Fixed occasional selenium test failure on Jenkins with Chrome 36+.
...
Previously find_element_by_id('id_password') on the next line failed with
NoSuchElementException and selenium.page_source was
<html xmlns="http://www.w3.org/1999/xhtml "><head></head><body></body></html>.
Possibly related: https://code.google.com/p/selenium/issues/detail?id=1969 .
2014-09-14 20:31:10 -04:00
e1424b2370
Fixed #23397 -- Stripped whitespace from base64 during chunking
...
This insures the actual base64 content has a length a multiple of 4.
Also added a test case for the failure.
2014-09-13 19:06:21 +02:00
22bfc45146
Fixed #23466 -- Removed seconds from all locale time output formats.
2014-09-13 13:00:42 -04:00
5472d18e31
Fixed #23461 -- Added EMAIL_TIMEOUT setting
2014-09-13 09:33:21 -04:00
5e32605ce9
Fixed #23483 -- Prevented ImproperlyConfigured with dotted app names
...
Made sure the app labels stay unique for the AppConfigStubs, so
migrations wouldn't fail if two dotted app names has the same last part
(e.g. django.contrib.auth and vendor.auth)
2014-09-12 14:58:54 -06:00
52ef6a4726
Fixed #17101 -- Integrated django-secure and added check --deploy option
...
Thanks Carl Meyer for django-secure and for reviewing.
Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
2014-09-12 15:05:23 -04:00
00535e8e6b
Fixed #20743 -- Added support for keyfile/certfile in SMTP connections.
...
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
2014-09-10 11:14:20 -04:00
61f56e239f
Corrected grammar in migrations error message.
2014-09-10 10:32:33 -04:00
6d5958c7a3
Fixed #23452 -- Prevented infinite migrations for empty unique/index_together.
...
Thanks fwkroon for the report.
2014-09-10 07:54:16 -04:00
b9d9287f59
Fixed urlize after smart_urlquote rewrite
...
Refs #22267 .
2014-09-09 21:59:35 +02:00
4b8a1d2c0d
Fixed #22267 -- Fixed unquote/quote in smart_urlquote
...
Thanks Md. Enzam Hossain for the report and initial patch, and
Tim Graham for the review.
2014-09-09 21:58:07 +02:00
9562ffea97
Avoid the word "stupid".
...
There's always a better word.
2014-09-09 20:55:57 +02:00
c53f2451a8
Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS
2014-09-09 12:29:30 -04:00
c32bc1a7a7
Fixed #11775 -- Made ABSOLUTE_URL_OVERRIDES work with models that don't define get_absolute_url().
...
Thanks jukvalim for the report and initial patch,
and Preston Timmons for review.
2014-09-09 11:05:31 -04:00
f7eee04ebe
Fixed #23451 -- Fixed typo in inlineformset_factory() error message.
2014-09-08 17:22:23 -04:00
b161c01c48
Fixed #22920 -- Avoid masking some exceptions.
...
If loading an application trigger an ImportError, the details of that
error were lost in some cases. Thanks Ben Davis for the report.
2014-09-08 23:16:50 +02:00
d3543af750
Added sorting to some admin_view tests to prevent transient failures; refs #23380 .
2014-09-08 17:10:58 -04:00
16548cfc7c
Fixed broken test from da160d440f; refs #23418 .
2014-09-08 16:49:06 -04:00
d28b5f13b3
Fixed #23418 -- Fail when migration deconstruct produces invalid import
2014-09-08 21:27:34 +02:00
342ccbddc1
Fixed #23431 -- Allowed inline and hidden references to admin fields.
...
This fixes a regression introduced by the 53ff096982#23329 .
2014-09-08 13:49:07 -04:00
4680d25df2
Fixed #22951 -- Checked for types during deep_deconstruct migration serialization process.
...
Thanks Sam Hartsfield for the report.
2014-09-08 07:39:09 -04:00
14c8456ffe
Fixed #23416 -- Make sure DatabaseCreation respects checks.
...
Migrations respected Field.db_parameters()['check'], but
DatabaseCreation was still using just Field.db_type().
2014-09-06 19:01:06 +01:00
f7d3a6255c
Fixed #23380 -- Fixed flaky test: admin_filters.tests.ListFiltersTests.test_relatedfield
2014-09-05 20:05:51 -04:00
3ab36d0046
Fix Python 3 incompatability
2014-09-05 15:47:20 -07:00
b878c73fc3
switch out recursive dfs for stack based approach, to avoid possibly hitting the recursion limit
2014-09-05 15:26:05 -07:00
885ff6845e
Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting"
...
This reverts commit 66757fee7e#22734 .
2014-09-05 20:06:02 +02:00
f8bb8436e5
Corrected deprecation warning silencing of SubfieldBase.
2014-09-05 09:12:14 -04:00
e9103402c0
Fixed #18757 , #14462 , #21565 -- Reworked database-python type conversions
...
Complete rework of translating data values from database
Deprecation of SubfieldBase, removal of resolve_columns and
convert_values in favour of a more general converter based approach and
public API Field.from_db_value(). Now works seamlessly with aggregation,
.values() and raw queries.
Thanks to akaariai in particular for extensive advice and inspiration,
also to shaib, manfre and timograham for their reviews.
2014-09-03 20:36:03 +01:00
1435cfbe8d
Fixed #23302 -- Added --name/-n option to makemigrations command
2014-09-02 21:09:18 -04:00
Simon Charette
Redouane Zait
Tim Graham
Luke Plant
wrwrwr
Adam Alton
Berker Peksag
Sergey Fedoseev
Aymeric Augustin
Claude Paroz
Alasdair Nicol
Andrzej Pragacz
Jay
Tim Heap
Anssi Kääriäinen
Markus Holtermann
Brad Walker
Patryk Zawadzki
Carl Meyer
Stratos Moros
Anton Baklanov
Tillmann Karras
Ilja Maas
Julien Phalip
Karen Tracey
Josh Smeaton
Danilo Bargen
Andrew Godwin
Marc Tamlyn
Daan Vielen
Klaas van Schelven
Michael Manfre
Adam DePue
Sean Wang
Baptiste Mispelon
Jozef Knaperek
averybigant
Peter Inglesby
Veres Lajos
Zan Anderle
Davide Ceretti
Thomas Chaumeny
Michael Kelly
Andy Chosak
Unai Zalakain
Konrad Świat
twidi
Jon Dufresne
Rigel Di Scala
Collin Anderson
Tony Zhu
a1tus
Loic Bistuer
Anton Novosyolov
Gabe Jackson
John-Scott Atlakson
Tianyi Wang
Nicholas Serra
Thomas Chaumeny
Anubhav Joshi
Florian Apolloner
Jaap Roes
Brandon Taylor
Duncan Parkes
Artem Rizhov
Browniebroke
Emmanuelle Delescolle
André Ericson
Seth Hill
Nick Sandford
Rudy Mutter
Shai Berger
Matt Robenolt
Davide Ceretti
Marco Buttu
Justin Caratzas
Yuri Kriachko
valtron
Jason Hobbs
Malte Beckmann
José Padilla
Szilveszter Farkas
Andi Albrecht
Markus Bertheau
Aymeric Augustin
Flavio Curella
Petras Zdanavičius
Andrew Pinkham
Baylee Feore
Ben Reilly
Raffaele Salmaso