Commit Graph

32656 Commits

Author SHA1 Message Date
Sarah Boyce 8b53560eea Fixed #35350 -- Fixed save() with pk set on models with GeneratedFields.
Thanks Matt Hegarty for the report and Simon Charette and Natalia Bidart for the reviews.

Regression in f333e35.
2024-04-10 15:43:50 +02:00
Carlton Gibson ca5cd3e3e8 Refs #35354 -- Clarified FORCE_SCRIPT_NAME docs. 2024-04-05 15:13:54 +02:00
Carlton Gibson bcd255cd5c Fixed #35354 -- Simplified ASGIRequest path handling.
Following the ASGI HTTP Connection Scope docs[0], the provided `path`
is already the correct value that Django requires.

In combination with `root_path`, from which `script_name` is derived,
the `path_info` variable is set. It's then redundant to
re-calculate `path` from `script_name` and `path_info`.

See also, a clarifying discussion on the ASGIref repo[1].

[0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-scope
[1]: https://github.com/django/asgiref/issues/424
2024-04-05 11:35:38 +02:00
Carlton Gibson 4d2ef9bb82 Refs #35169 -- Added test for ASGIRequest root_path handling. 2024-04-05 11:30:33 +02:00
Adam Johnson ba4ffdc877
Refs #31710 -- Improved multiple file upload docs. 2024-04-04 19:18:36 -03:00
Lang Tran e279c724c1
Fixed #35347 -- Clarified choice_set attribute in tutorial 2. 2024-04-04 16:05:18 -03:00
Natalia 4636baec17 Added stub release notes for 5.0.5. 2024-04-03 12:21:28 -03:00
Natalia 81da153e5f Added release date for 5.0.4. 2024-04-03 11:12:03 -03:00
Sarah Boyce 89403dbedd Fixed SeleniumTests.test_related_object_update_with_camel_casing() assert.
A selenium web element was compared to a string rather than its innerHTML.
2024-04-03 09:29:01 +02:00
devin13cox 8665cf03d7
Fixed #35330 -- Fixed the update of related widgets when the referenced model is camel case named.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-04-02 22:00:25 -03:00
Simon Charette 888b9042b3
Fixed #35336 -- Addressed crash when adding a GeneratedField with % literals.
A longer term solution is likely to have a better separation of parametrized
DDL altogether to handle checks, constraints, defaults, and generated fields
but such a change would require a significant refactor that isn't suitable
for a backport.

Thanks Adrian Garcia for the report.
2024-04-02 17:33:31 -03:00
Johannes Westphal 5f18021640 Fixed #35344, Refs #34838 -- Corrected output_field of resolved columns for GeneratedFields in aliased tables.
Thanks Simon Charette for the review.
2024-04-01 18:54:38 +01:00
Mariusz Felisiak 425b26092f
Refs #35234 -- Skipped CheckConstraint system checks if not supported.
Thanks Tim Graham for the report.

Regression in 0fb104dda2.
2024-03-30 14:15:03 +01:00
Taishi Endo 0df520979a
Restored django.db.models.F import in final code snippet added at the beginning of tutorial 4. 2024-03-29 12:33:08 -03:00
Matthias Kestenholz 5f3cdf219d
Fixed typo in docs/topics/signals.txt. 2024-03-28 13:45:04 -03:00
Fabian Braun 944745afe2 Fixed #34977 -- Improved accessibility in the UserChangeForm by replacing the reset password link with a button.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-03-27 16:40:41 -03:00
Giannis Terzopoulos d658a3162f Fixed #35233 -- Moved template engine system checks to backend methods.
Thanks Adam Johnson for reviews.
2024-03-27 08:14:54 +01:00
Mariusz Felisiak b98271a6e4
Fixed #35329 -- Fixed migrations crash when adding partial unique constraints with nulls_distinct.
Bug in 595a2abb58.

Thanks Lucas Lemke Saunitti for the report.
2024-03-26 22:58:47 +01:00
Mariusz Felisiak ae10146793
Removed unused _alter_column_collation_sql() in PostgreSQL DatabaseSchemaEditor.
Unused since ae0899be0d.
2024-03-25 08:50:26 +01:00
Mariusz Felisiak a2dcc4ecbb
Increased test coverage for django.db.migrations.operations.special. 2024-03-25 08:31:32 +01:00
Ben Cail 07c8d979ae Fixed #35323 -- Prevented file_move_safe() from trying to overwrite existing file when allow_overwrite is False. 2024-03-24 16:05:36 +01:00
David Sanders b6e2b83901 Fixed #34841 -- Avoided rendering apps on state still requiring mutation. 2024-03-22 21:29:59 +01:00
Mariusz Felisiak 1c11dba835
Added ModelState.from_model() test for abstract model with unnamed indexes. 2024-03-22 13:31:33 +01:00
Ben Cail 8dbfef4695 Fixed #35320 -- Removed unnecessary django.core.files.move._samefile() hook.
os.path.samefile() uses the same implementation on Windows as all other
platforms since Python 3.4.
2024-03-21 20:15:41 +01:00
sharonwoo 6a37e9bfae Fixed #35257 -- Corrected resolving output_field for IntegerField/DecimalField with NULL. 2024-03-21 10:13:54 +01:00
Adam Zapletal fd2514d17d
Added RowNumber() link in Rank() docs. 2024-03-21 05:52:07 +01:00
Mariusz Felisiak 6f7c0a4d66
Fixed ResourceWarning from unclosed SQLite connection in test_utils on Python 3.13+.
On SQLite, close() doesn't explicitly close in-memory connections.

Follow up to 921670c694 and
dd45d5223b.
2024-03-20 11:44:30 +01:00
Laurent Lyaudet f2388a4b73 Fixed #35309 -- Made prefetch clear ordering for single-valued relationships. 2024-03-20 05:26:18 +01:00
Mariusz Felisiak 921670c694
Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.
On SQLite, close() doesn't explicitly close in-memory connections.

Follow up to dd45d5223b.
2024-03-19 10:03:12 +01:00
Mariusz Felisiak 0a6ed278d8
Stopped using byte-compiled 3rd-party packages in daily builds for byte-compiled Django. 2024-03-18 19:37:04 +01:00
Mariusz Felisiak 9c17010358
Refs #34059, Refs #34060 -- Removed outdated warning about validation of JSONField constraints.
Known issues have been fixed in:
- 0d8fbe2ade,
- c991602ce5, and
- 26aae56144.
2024-03-18 16:11:38 +01:00
Claude Paroz 10b31eea33 Refs #31014 -- Added srid argument to FromWKB/FromWKT() GIS functions. 2024-03-18 09:45:33 +01:00
Adam Johnson 7646b9023d
Fixed #35301 -- Fixed Options._property_names for overriden properties.
Regression in faeb92ea13.
2024-03-17 09:43:04 +01:00
Mariusz Felisiak b07e2d57a0
Stopped skipping model_fields.test_jsonfield.TestQuerying.test_usage_in_subquery on Oracle 23c. 2024-03-16 11:50:59 +01:00
Mariusz Felisiak b231bcd19e
Refs #34900 -- Fixed SafeMIMEText.set_payload() crash on Python 3.13.
Payloads with surrogates are passed to the set_payload() since
f97f25ef5d
2024-03-15 12:51:40 +01:00
Mariusz Felisiak 36a000858b
Refs #33996 -- Updated CheckConstraint validation on NULL values on Oracle 23c+.
Oracle 23c supports comparing boolean expressions.
2024-03-15 12:34:54 +01:00
Adam Johnson cbf1e87398 Fixed #35294 -- Fixed TEXT format of QuerySet.explain() for long plans.
co-authored-by: Gordon <gordon.wrigley@gmail.com>
co-authored-by: Simon Charette <charette.s@gmail.com>
2024-03-15 06:58:14 +01:00
Ben Cail 593067a8ee Fixed #28541 -- Fixed migrations crash when changing primary key on SQLite. 2024-03-14 20:56:43 +01:00
Johannes Maron 3d7235c67b Refs #34488 -- Made ClearableFileInput preserve "Clear" checked attribute when form is invalid. 2024-03-14 14:03:14 +01:00
Johannes Maron e69019555d Fixed #35273 -- Fixed rendering AdminFileWidget's attributes.
Regression in 8a6c0203c4.
2024-03-14 14:03:09 +01:00
Mariusz Felisiak 175b04942a Fixed #35295 -- Used INSERT with multiple rows on Oracle 23c. 2024-03-14 11:11:15 +01:00
Mariusz Felisiak 912f72a6f0 Refs #35295 -- Added BaseDatabaseOperations.bulk_insert_sql().
Co-authored-by: Nick Pope <nick@nickpope.me.uk>
2024-03-14 11:11:15 +01:00
Nick Pope 95ae37839c
Refs #30686 -- Made django.utils.html.VOID_ELEMENTS a frozenset. 2024-03-14 05:56:22 +01:00
Jon Janzen f5c340684b Fixed #34901 -- Added async-compatible interface to session engines.
Thanks Andrew-Chen-Wang for the initial implementation which was posted
to the Django forum thread about asyncifying contrib modules.
2024-03-13 17:55:15 +01:00
Mariusz Felisiak 33c06ca0da
Refs #32673, Refs #35295 -- Avoided wrapping rhs direct values in lookups. 2024-03-13 17:46:37 +01:00
Mariusz Felisiak 80fe2f4391
Removed unused clean() method in file-based session.
Unused since its introduction in bcf7e9a9fe.
2024-03-12 13:31:22 +01:00
Mariusz Felisiak c925448498
Used SessionBase.__setitem__() in setdefault(). 2024-03-12 10:48:04 +01:00
Mariusz Felisiak 3592e9fcb1
Optimized DatabaseOperations.bulk_insert_sql() a bit on Oracle. 2024-03-11 13:24:18 +01:00
Ryan Cheley f2c3524959 Fixed #14831 -- Extended template style guide in docs. 2024-03-11 11:05:54 +01:00
Adam Zapletal 7326513a8f Fixed #25595 -- Doc'd that URLValidator rejects file:// URIs without a host. 2024-03-11 08:17:49 +01:00