p31829507
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
24,171 Commits 28 Branches 411 Tags 641 MiB
Commit Graph

9864 Commits

Author SHA1 Message Date
Tim Graham 6d1394182d Added stub release notes for 1.10.5. 2016-12-02 08:46:06 -05:00
Tim Graham 9ea9686532 Added release dates for 1.10.4, 1.9.12, 1.8.17. 2016-12-01 17:15:04 -05:00
Ed Morley dd2e4d7b5d Refs #27558 -- Added test for no index on InnoDB ForeignKey. 
The refactor in 3f76d1402d fixed the creation
of redundant indexes.

Forwardport of 82ce55dbbe from stable/1.10.x
 2016-12-01 13:25:48 -05:00
Tim Graham e6262aaaf8 Refs #27358 -- Removed invalid/unneeded FileField.upload_to in tests/docs. 2016-11-30 17:05:31 -05:00
Simon Charette ad8f6a45eb Replaced RawSQL with Cast in Coalesce doc example. 2016-11-30 12:08:26 -05:00
Sergey Fedoseev 4464b9b9ad Fixed #27556 -- Added Oracle support for IsValid function and isvalid lookup. 2016-11-30 11:22:56 -05:00
patjouk bc6bd93cea Added my bio. 2016-11-30 10:20:48 -05:00
Raphael Michel ddf169cdac Refs #16859 -- Allowed storing CSRF tokens in sessions. 
Major thanks to Shai for helping to refactor the tests, and to
Shai, Tim, Florian, and others for extensive and helpful review.
 2016-11-30 08:57:27 -05:00
Sergey Fedoseev 21322f9271 Fixed #27552 -- Added docs/test for GEOSGeometry.normalize(). 2016-11-30 07:39:03 -05:00
Adam Chainz 71609a5b90 Fixed #27555 -- Removed django.utils.functional.lazy_property. 2016-11-29 19:01:12 -05:00
Adam Chainz 95627cb0aa Added my bio 2016-11-29 22:42:29 +00:00
Henry Dang 7cddd8a02e Fixed #27358 -- Added a system check to prevent FileField's upload_to from starting with a slash. 
Thanks Frank Bijlsma for the initial patch.
 2016-11-29 16:12:24 -05:00
Krzysztof Urbaniak b8a815e9df Fixed #27402 -- Fixed incorrect LocaleMiddleware redirects with prefix_default_language=False. 2016-11-29 13:06:35 -05:00
Andrew Nester ade52ef71f Fixed #27544 -- Fixed QuerySet.update(dt=F('dt') + timedelta) crash on SQLite. 2016-11-29 12:23:44 -05:00
Tim Graham d7e6b8febd Fixed typo in docs/topics/auth/customizing.txt. 2016-11-28 16:39:54 -05:00
Adam Chainz 95238a7de8 Fixed #27321 -- Added detection for table case name sensitivity on MySQL. 2016-11-28 13:29:21 -05:00
Mads Jensen aa2cb4c622 Refs #26327 -- Renamed JsonAgg to JSONBAgg. 
Thanks to Christian von Roques for the report.
 2016-11-28 06:57:01 -05:00
Adam Chainz 6252fd6314 Fixed #27532 -- Deprecated Model._meta.has_auto_field 2016-11-25 13:24:11 -05:00
Aymeric Augustin cb7bbf97a7
Fixed #25966 -- Made get_user_model() work at import time. 
This makes it equivalent to: `from django.contrib.auth.models import User`.

Thanks Aymeric Augustin for the initial patch and Tim Graham for the
review.
 2016-11-25 14:15:49 +01:00
Luke Murphy c238da8942 Fixed #27509 -- Removed redundant gdal-bin dependency listing. 2016-11-25 07:19:10 -05:00
Daniel Musketa df2a5227c9 Rephrased an ambiguous sentence in docs/topics/signals.txt. 2016-11-24 05:50:39 -05:00
Alex Scott da4c0e8cc9 Fixed typo in docs/topics/auth/customizing.txt. 2016-11-24 05:41:21 -05:00
Tim Graham 93a081946d Normalized casing of "custom user model". 2016-11-23 15:14:28 -05:00
Krzysztof Gogolewski d02a03d574 Fixed #24370 -- Recommended starting with a custom user model. 2016-11-23 14:43:17 -05:00
Daniel Musketa b5ef90192f Fixed typo in docs/topics/signals.txt. 2016-11-23 06:54:58 -05:00
Jackie Leng 50613d957a Fixed #26920 -- Made GEOSGeometry equality check consider the srid 2016-11-23 09:23:06 +01:00
Henry Dang b1a9041535 Fixed #27221 -- Doc'd how to escape a percent symbol in ugettext(). 2016-11-22 13:49:18 -05:00
Quentin Fulsher f62abfc03d Fixed #27295 -- Added a system check to prohibit model names that start or end with an underscore or contain double underscores. 2016-11-22 10:14:10 -05:00
Daniel Musketa 66505b72c5 Updated doc links to virtualenv website. 2016-11-22 08:36:41 -05:00
Tim Graham 55adfc0760 Fixed #27511 -- Corrected Field.related_model docs about GenericRelation. 2016-11-21 12:30:54 -05:00
François Freitag 0783aa7deb Refs #23811 -- Corrected git bisect run example usage. 2016-11-21 06:55:03 -05:00
Jonatas CD b28c6ca763 Fixed #27482 -- Doc'd an example of Case() in QuerySet.filter(). 2016-11-17 12:39:35 -05:00
Tim Graham 0d9ff873d9 Fixed #27467 -- Made UserAttributeSimilarityValidator max_similarity=0/1 work as documented. 
Thanks goblinJoel for the report and feedback.
 2016-11-16 17:40:37 -05:00
Sergey Fedoseev 45e01df373 Fixed #27488 -- Added SpatiaLite suppport for IsValid, MakeValid, and __isvalid. 2016-11-16 09:43:54 -05:00
Tim Graham 3ce212a23c Fixed #27494 -- Fixed typos in docs/topics/db/models.txt. 2016-11-16 07:28:20 -05:00
Mitchel Humpherys ae660cde5a Fixed incorrect word choice in docs/topics/migrations.txt. 2016-11-16 06:57:30 -05:00
Simon Charette 31a56e30cf Fixed #27407 -- Made Model.delete(keep_parents=True) preserve parent reverse relationships. 
Thanks Tim for the review.
 2016-11-15 20:16:06 -05:00
akki 74ed20b49a Replaced "django" with "Django" in spelling_wordlist. 2016-11-15 17:00:50 -05:00
Jonatas CD 9da45ff352 Fixed #26985 -- Doc'd that ForeignKey.to_field reference must be unique. 2016-11-15 11:09:23 -05:00
Simon Charette 9e4fd3301d Refs #25284 -- Corrected an obsolete implicit __in lookup example. 
Thanks IRC alias rpkilby for the report.
 2016-11-15 08:25:02 -05:00
Ramin Farajpour Cami 0a63ef3f61 Fixed #27463 -- Fixed E741 flake8 warnings. 2016-11-14 17:40:28 -05:00
Claude Paroz df3e92a41c Documented GEOS 3.5 support 2016-11-12 17:42:12 +01:00
Claude Paroz 8c7778884b Dropped support for GDAL 1.7 and 1.8 2016-11-12 17:28:03 +01:00
Jacob Rief b3162cab94 Fixed #27386 -- Wrapped admin's readonly fields in <div> rather than <p>. 2016-11-12 10:02:57 -05:00
Jezeniel Zapanta 48f45431eb Fixed typo in docs/topics/db/multi-db.txt. 2016-11-11 12:40:06 -05:00
Mads Jensen 1446902be4 Fixed #25240 -- Added ExtractWeek and exposed it through the __week lookup. 
Thanks to Mariusz Felisiak and Tim Graham for review.
 2016-11-11 08:01:40 -05:00
Daniel Wiesmann 2dc07da497 Fixed #27421 -- Added shape, size, and offset controls to GDALRaster constructor. 
Thanks Tim Graham for the review.
 2016-11-11 07:09:38 -05:00
Ian Lee 501c993010 Fixed typo in docs/ref/settings.txt. 2016-11-11 07:01:48 -05:00
za 321e94fa41 Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. 2016-11-10 21:30:21 -05:00
Paweł Marczewski 50f9e736fa Fixed #27438 -- Added the diffsettings --default option. 2016-11-10 07:50:49 -05:00
Joseph Kahn 373c6c409c Fixed #27461 -- Fixed incorrect allow_migrate() arguments in makemigrations. 2016-11-09 10:27:19 -05:00
Tim Graham 0d6c7cae7c Inlined a note in docs/ref/models/expressions.txt. 2016-11-09 08:20:59 -05:00
Jop Reyntjes f8fab6f902 Fixed #27414 -- Doc'd that F() expressions on relations return pk values. 2016-11-09 07:11:46 -05:00
Mariusz Felisiak c4b04e1598 Fixed #27420 -- Quoted the Oracle test user password in queries. 2016-11-08 16:30:22 -05:00
Tim Graham ee1bf0e8b5 Corrected release note location of BaseCommand.can_import_settings removal. 2016-11-07 14:54:21 -05:00
Maxime Lorant cb3fb34b86 Fixed #27378 -- Added support for serialization of uuid.UUID in migrations. 
Thanks Yuriy Korobko for the initial patch and Tobias McNulty for review.
 2016-11-06 13:53:00 +01:00
Tim Graham 7301770254 Fixed typo in docs/ref/middleware.txt. 2016-11-06 13:22:08 +01:00
Krzysztof Żuraw eaa6ea2f37 Fixed #27133 -- Doc'd how to provide initial data with migrations. 2016-11-06 12:51:36 +01:00
Tobias McNulty d9b65f6397 Added myself to the Ops team. (#7518) 2016-11-06 12:07:35 +01:00
Adam Malinowski 37809b891e Fixed #27346 -- Stopped setting the Content-Length header in ConditionalGetMiddleware. 2016-11-05 22:24:54 +01:00
Krzysztof Gogolewski d1dbaeaadb Adjusted documentation of migration related commands. 2016-11-05 21:56:13 +01:00
Rivo Laks 802dd1ffc5 Readded 'pytz' to spelling wordlist. 2016-11-05 13:28:42 +01:00
Aymeric Augustin 24c9cce1c9 Removed myself from the ops team. 2016-11-05 12:47:59 +01:00
Tim Graham b741fe397a Updated "fork Django on GitHub" link. 2016-11-04 05:47:49 +01:00
Pamela McA'Nulty 2c4d15e319 Fixed typo in docs/topics/testing/tools.txt. 2016-11-04 05:12:42 +01:00
Tim Graham 58eca7c49c Fixed #27425 -- Removed obsolete "developers for hire" FAQ. 2016-11-03 12:42:36 +01:00
Tim Graham b8ae2c16cf Added CVE-2016-9013,14 to the security release archive. 2016-11-01 10:48:11 -04:00
Tim Graham 7fe2d8d940 Fixed CVE-2016-9014 -- Validated Host header when DEBUG=True. 
This is a security fix.
 2016-11-01 09:30:57 -04:00
Marti Raudsepp da7910d483 Fixed CVE-2016-9013 -- Generated a random database user password when running tests on Oracle. 
This is a security fix.
 2016-11-01 09:30:57 -04:00
Tim Graham 9e9c81d3c2 Added stub release notes for 1.9.11/1.8.16. 2016-11-01 09:30:57 -04:00
Andrew Nester 1ce04bcce0 Fixed #27363 -- Replaced unsafe redirect in SessionMiddleware with SuspiciousOperation. 2016-11-01 07:15:56 -04:00
Henry Dang 9c2e1ad6a5 Fixed #27400 -- Documented {% static %} encoding change in 1.10. 2016-10-31 16:07:00 -04:00
Timothy Allen 5595db9504 Updated docs/topics/db/queries.txt examples to use print() function. 2016-10-31 15:22:32 -04:00
Tim Graham de91c172cf Fixed #27410 -- Clarified when static files is enabled in STATIC_ROOT docs. 2016-10-31 15:17:40 -04:00
Mariusz Felisiak 55993d1e4e Updated Oracle docs links to Oracle 12c. 2016-10-31 14:32:50 -04:00
Krzysztof Urbaniak a01d887a3a Fixed #27063 -- Prevented i18n_patterns() from using too much of the URL as the language. 2016-10-31 14:32:01 -04:00
Anssi Kääriäinen 9513903086 Updated by bio. 2016-10-31 09:55:48 -04:00
medmunds d3708aeb26 Fixed #27382 -- Doc'd that ugettext_lazy() should be converted to text for non-Django code. 2016-10-29 07:23:57 -04:00
Michael Scott ec9ed07488 Fixed #27188 -- Allowed using unique=True with FileField. 
Thanks Tim Graham for the initial patch.
 2016-10-28 20:11:03 -04:00
Aymeric Augustin 625cd5bcb3 Added require_ready argument to get_model methods. 
This allows bringing back the behavior of Django < 1.7.

Also fixed the check for the app registry being ready in
AppConfig.get_model(s), which was inconsistent with the equivalent check in
Apps.get_model(s). That part is a backwards-incompatible change.
 2016-10-28 19:08:57 -04:00
Aymeric Augustin efcb7e1ebf Modified readiness check in AppConfig.get_model(s). 
It was inconsistent with the equivalent check in Apps.get_model(s)
because I made incorrect assumptions when I wrote that code and
needlessly complicated readiness checks.

This is a backwards-incompatible change.
 2016-10-28 18:42:29 -04:00
Adam Chainz 968f61b991 Documented that cache keys are strings rather than bytes. 2016-10-27 15:49:24 -04:00
mark-summerfield 4584bc3a1e Described PostgreSQL as more scalable than SQLite. 2016-10-27 09:14:04 -04:00
Tim Graham 414ad25b09 Fixed #27327 -- Simplified time zone handling by requiring pytz. 2016-10-27 08:53:20 -04:00
Tim Graham d84ffcc22b Updated "running the tests" to use 'pip install -e'. 2016-10-27 08:18:56 -04:00
Jon Dufresne c74378bb77 Fixed #27299 -- Documented the Widget.use_required_attribute() method. 
Thanks Tim Graham for the review and edits.
 2016-10-26 19:29:16 -07:00
Thomas Güttler 7cdc2015e3 Clarified when the post_migrate signal is sent during migrate. 2016-10-26 11:01:04 -04:00
Jon Dufresne f3ea0c4bbd Reverted "Fixed #26401 -- Added BaseAuthConfig to use auth without migrations." 
This reverts commit 1ec1633cb2 as it
doesn't handle ContentType's auth.Permission dependency. Thus, it
doesn't allow auth without migrations.
 2016-10-25 17:32:59 -07:00
David Barragán Merino b3bd3aa07c Fixed #27385 -- Fixed QuerySet.bulk_create() on PostgreSQL when the number of objects is a multiple plus one of batch_size. 2016-10-25 19:21:08 -04:00
Tim Graham a9d1d95284 Replaced Outputting PDF's "Further Resources" with a link to Django Packages. 2016-10-25 11:58:19 -04:00
Marti Raudsepp 51fbe2a60d Updated postgresql.org links to https and made them canonical. 2016-10-25 11:43:32 -04:00
Julian Andrews adc93e8599 Fixed #26357 -- Allowed admin popups to work on links added after page load. 2016-10-24 20:17:31 -04:00
Tim Graham 6fdb12cdcc Documented how to request CVE IDs. 2016-10-24 15:02:55 -04:00
Alvin Lindstam 6b5106b1ce Fixed #27374 -- Made JavaScriptCatalog respect the packages argument. 2016-10-22 19:26:08 -04:00
Zach Borboa 90c3b11e87 Fixed #27361 -- Used "from django import forms" in forms api docs. 2016-10-19 09:55:21 -04:00
Markus Holtermann b5fc192b99 Fixed #27352 -- Doc'd social media fingerprinting consideration with login's redirect_authenticated_user. 2016-10-18 11:37:56 -04:00
Riccardo Magliocchetti a4e9e834e3 Fixed ModelAdmin.get_max_num() example if obj is None. 2016-10-17 07:33:38 -04:00
Tim Graham af98a0a25e Updated security policy according to current practices. 
Also added security release date notifications to django-announce.
 2016-10-15 07:53:08 -04:00
David D Lowe 424187ec4b Fixed #27349 -- Doc'd the CSRF_FAILURE_VIEW setting in view topic guide. 2016-10-14 13:46:54 -04:00
Tim Graham 61f9243e51 Fixed #27345 -- Stopped setting the Date header in ConditionalGetMiddleware. 2016-10-14 12:48:03 -04:00
Kevin Christopher Henry 9eb49af821 Refs #19705 -- Documented decorator ordering with @condition(). 2016-10-14 07:36:01 -04:00
Kevin Christopher Henry ad332e5ca9 Refs #19705 -- Made GZipMiddleware make ETags weak. 
Django's conditional request processing can now produce 304 Not Modified
responses for content that is subject to compression.
 2016-10-13 14:22:54 -04:00
Tim Graham cd09524f27 Fixed #27200 -- Provided makemigration's allow_migrate() with model_name. 2016-10-13 11:04:58 -04:00
Tim Graham 51b83d9e51 Fixed #27342 -- Corrected QuerySet.update_or_create() example. 2016-10-13 11:02:02 -04:00
Nick Pope 81463ce0a1 Fixed typo in docs/ref/checks.txt. 2016-10-11 10:32:32 -04:00
Tim Graham 80f5a4d87a Doc'd the need to provide initial for formset submissions. 2016-10-10 15:36:21 -04:00
Denis Cornehl a840710e1e Fixed #26447 -- Deprecated settings.USE_ETAGS in favor of ConditionalGetMiddleware. 2016-10-10 14:55:59 -04:00
Tim Graham 19a140a1b3 Added template syntax highlighting in docs/topics/i18n/timezones.txt. 2016-10-08 08:07:06 -04:00
Zach Borboa bf91be83d5 Fixed #24941 -- Added ModelAdmin.get_exclude(). 
Thanks Ola Sitarska for the initial patch.
 2016-10-07 18:49:28 -04:00
Tim Graham c60feb6999 Fixed #25475 -- Doc'd how to use a literal % in Func.template. 2016-10-07 10:24:45 -04:00
Markus Holtermann f8deed7199 Updated security team roster. 2016-10-07 10:14:22 -04:00
Adam Chainz 224fe22bf1 Doc'd that model instances with pk=None don't compare equal. 2016-10-07 09:01:18 -04:00
Mads Jensen 0a26f3c338 Fixed #26327 -- Added JsonAgg to contrib.postgres. 
Thanks Tim Graham for review.
 2016-10-07 07:52:03 -04:00
Tim Graham e261337eea Fixed docs typos in lines ending with a dash. 2016-10-06 11:01:20 -04:00
Aymeric Augustin 5d35181de4 Documented AppRegistryNotReady. 2016-10-06 10:21:57 -04:00
Jonatas CD e8728f03f0 Refs #11078 -- Doc'd Meta inheritance in proxy models. 2016-10-04 19:53:24 -04:00
Corey Farwell 24da355686 Documented render_to_string()'s `using` parameter. 2016-10-04 18:58:50 -04:00
Tim Graham 0083a4c8e9 Refs #18974 -- Deprecated @models.permalink() decorator. 2016-10-04 14:39:49 -04:00
Tim Graham e262f00231 Fixed #27292 -- Removed unnecessary password assignment in auth backend example. 2016-10-04 14:02:06 -04:00
aruseni 9e26a8331d Fixed typos in docs/ref/contrib/admin/javascript.txt. 2016-10-04 10:18:08 -04:00
aruseni 12b9aa279f Fixed typo in docs/ref/contrib/admin/javascript.txt. 2016-10-04 10:13:10 -04:00
Simon Charette 040bd7c938 Fixed #27279 -- Fixed a migration performance regression related to RenameModel operations. 
Thanks Trac alias mtomiyoshi for the report, Marten Kenbeek for the initial
patch and Tim for the review.
 2016-10-04 08:35:15 -04:00
Reto Aebersold 3ab55c1a8a Fixed #27309 -- Added CallableBool.__hash__(). 2016-10-04 07:44:19 -04:00
Tim Graham fe1aee6b98 Fixed #27307 -- Added missing url names in sitemaps docs. 2016-10-03 16:04:30 -04:00
Claude Paroz 122c90a43b Fixed #27305 -- Removed BaseCommand.can_import_settings unused attribute 
Thanks Tim Graham for the review.
 2016-10-02 20:31:56 +02:00
Tim Graham bae1160c3f Added stub release notes for 1.10.3. 2016-10-01 16:11:54 -04:00
Claude Paroz 67eee5e4fa Fixed #27302 -- Fixed ModelAdmin.construct_change_message() changed field detection 
Thanks Ramiro Morales for the report and Tim Graham for the review.
 2016-10-01 20:14:27 +02:00
Tim Graham aa7dc2dc39 Added release date for 1.10.2. 2016-10-01 11:48:11 -04:00
Claude Paroz fa2f55cfd5 Refs #26940 -- Re-allowed makemessages without settings 
Thanks Tim Graham for the review.
 2016-10-01 14:57:16 +02:00
Tim Graham 87c5e7efeb Refs #27186 -- Fixed model form default fallback for CheckboxSelectMultiple. 2016-09-30 14:49:50 -04:00
Lewis Cowles 1d25eb9688 Fixed #27294 -- Documented UserCreationForm's fields. 2016-09-30 13:56:53 -04:00
Tim Graham 79c91070e5 Confirmed support for PostGIS 2.3. 2016-09-30 10:00:04 -04:00
Tim Graham cc282fa731 Updated links to the current version of PostGIS docs. 2016-09-30 09:26:20 -04:00
Tim Graham 9819676676 Updated links to the current version of MySQL docs. 2016-09-30 09:14:17 -04:00
Laurent bceade84a7 Fixed typos in docs/howto/deployment/checklist.txt. 2016-09-29 19:59:00 -04:00
Tim Graham eb4d4376fc Normalized spelling of "Web server/page" in docs. 2016-09-29 19:51:59 -04:00
Frank Wiles a09c058918 Fixed import typos in the docs. 2016-09-29 12:06:52 -04:00
Christian Bundy 9c522d2ed8 Fixed typo in docs/ref/contrib/gis/install/postgis.txt. 2016-09-28 14:24:49 -04:00
Tim Graham f2ff1b2fab Fixed #27289 -- Corrected View.as_view() explanation. 
Thanks Graham Wideman for the report.
 2016-09-28 11:26:32 -04:00
Rinat Khabibiev 9e07a9b5fe Fixed #27226 -- Removed patch_response_headers()'s setting of the Last-Modified header. 2016-09-28 09:09:09 -04:00
Alasdair Nicol 3203171832 Fixed 27283 -- Fixed typo in 1.8 release notes. 2016-09-28 06:50:49 -04:00
Austin Simmons 0f6829a68a Fixed #27076 -- Documented contrib.admin.sites.AdminSite.register(). 2016-09-27 12:16:44 -04:00
levental 617e36dc1e Fixed #20705 -- Allowed using PasswordResetForm with user models with an email field not named 'email'. 2016-09-27 11:59:00 -04:00
Berker Peksag f7e91cac68 Fixed #27053 -- Documented contrib.auth.get_user(). 2016-09-27 10:41:14 -04:00
Sergey Fursov 6709ea4ae9 Fixed #27271 -- Fixed a crash in runserver logging. 
Allowed ServerFormatter to handle simple string messages or messages with
formatting arguments. The formatter will set the server_time variable on
the log record if it's required by the format string but wasn't passed in
extra parameters.
 2016-09-27 09:46:07 -04:00
Tim Graham 6fe846a8f0 Added CVE-2016-7401 to the security release archive. 2016-09-26 18:01:19 -04:00
Tim Graham a46742e738 Added a CVE role for Sphinx. 2016-09-26 15:48:40 -04:00
Tim Graham 8d233a2132 Fixed #27278 -- Fixed an anchor in docs/topics/forms/formsets.txt. 2016-09-26 13:55:39 -04:00
Tim Graham c6a3109e20 Added release notes for 1.9.10 and 1.8.15 releases. 2016-09-26 13:55:21 -04:00
Jonatas CD 6d6d1b1001 Fixed #27276 -- Doc'd how to reverse admin's login view. 2016-09-26 10:38:34 -04:00
Tim Graham 8110673aaf Fixed #27270 -- Clarified a paragraph in docs/topics/forms/formsets.txt. 
Thanks Kifsif for the suggestion.
 2016-09-26 09:54:55 -04:00
François Freitag a5e13a0b92 Fixed #27118 -- Made QuerySet.get_or_create()/update_or_create() error for a non-field in their arguments. 2016-09-24 20:16:16 -04:00
Berker Peksag 0a6ed6b1d9 Simplified has_perm() example in topics/auth/customizing.txt. 2016-09-23 15:28:32 -04:00
Tim Graham 3507d4e773 Fixed #27186 -- Fixed model form default fallback for MultiWidget, FileInput, SplitDateTimeWidget, SelectDateWidget, and SplitArrayWidget. 
Thanks Matt Westcott for the review.
 2016-09-22 12:20:58 -04:00
Claude Paroz 92323d54fd Fixed #27056 -- Allowed migrating geometry field dimension on PostGIS 
Thanks Tim Graham for the review.
 2016-09-22 16:40:27 +02:00
Jon Dufresne 2c716c1dc7 Fixed #27256 -- Changed Select widget's selected attribute to use HTML5 boolean syntax. 2016-09-21 15:12:13 -07:00
Tim Graham ddef397b0d Doc'd how to use GitHub's "Squash and merge" button. 2016-09-21 12:13:21 -04:00
Mads Jensen 094d630ae8 Fixed #26610 -- Added CITextField to contrib.postgres. 2016-09-21 12:11:37 -04:00
Markus Holtermann 7eda99f03f Added myself to ops team (#7273) 2016-09-21 09:42:00 +02:00
Alasdair Nicol 911d9f4ed1 Fixed #27238 -- Disabled check_pattern_startswith_slash if settings.APPEND_SLASH=False. 
Thanks strycore for the report and timgraham for suggesting the
solution.
 2016-09-19 21:00:12 -04:00
aruseni cdde2eac5b Fixed a typo in docs/topics/auth/default.txt. 2016-09-17 20:09:15 -04:00
zhuanyenan 17677d510f Corrected docs for return type of Field.formfield(). 2016-09-17 14:26:54 -04:00
Kevin Christopher Henry 22e303887b Refs #27083 -- Updated conditional header comparison to match RFC 7232. 2016-09-16 15:45:53 -04:00
Tim Graham 5a51b44936 Fixed #26697 -- Removed contrib.gis.maps. 2016-09-16 15:21:46 -04:00
Tim Graham 43c471e81c Fixed typo in docs/ref/settings.txt. 2016-09-15 19:52:49 -04:00
Michael Scott 3c447b108a Fixed #15143 -- Doc'd how to set the language for the test client. 2016-09-14 20:08:06 -04:00
Gavin Wahl f0f3de3c96 Fixed #23155 -- Added request argument to user_login_failed signal. 2016-09-12 20:30:34 -04:00
Aleksej Manaev 4b9330ccc0 Fixed #25187 -- Made request available in authentication backends. 2016-09-12 20:11:53 -04:00
Tim Graham c2e94bd8df Fixed #27212 -- Fixed typo in docs/howto/static-files/index.txt. 2016-09-12 16:05:27 -04:00
Simon Charette 767ba00976 Fixed #27209 -- Fixed typo in docs/ref/models/database-functions.txt. 
Thanks Valentin Ignatyev for the report.
 2016-09-12 08:07:30 -04:00
Claude Paroz d389125606 Fixed #27098 -- Deprecated DatabaseIntrospection.get_indexes 
Thanks Akshesh <aksheshdoshi@gmail.com> for help with the PostgreSQL query.
Thanks Tim Graham for the review.
 2016-09-12 09:26:33 +02:00
Jon Dufresne 1ec1633cb2 Fixed #26401 -- Added BaseAuthConfig to use auth without migrations. 2016-09-10 16:38:05 -07:00
Alexander Gaevsky 536db42cf0 Fixed #26097 -- Added password_validators_help_text_html to UserCreationForm. 2016-09-10 18:23:18 -04:00
Alexander Gaevsky 2d26b4637f Fixed #27207 -- Replaced <p> tag with <div> in admin help texts. 2016-09-10 16:54:10 -04:00
Kevin Christopher Henry 4ef0e019b7 Fixed #27083 -- Added support for weak ETags. 2016-09-10 08:14:52 -04:00
Tim Graham ef021412d5 Normalized spelling of ETag. 2016-09-09 11:00:21 -04:00
Rinat Khabibiev ca9c69a968 Fixed #27199 -- Made AdminIntegerFieldWidget use NumberInput. 2016-09-09 09:42:39 -04:00
Jon Dufresne 331ca5391e Fixed #27175 -- Deprecated silencing exceptions from the {% include %} template tag. 
Thanks Tim Graham for the review.
 2016-09-08 18:24:22 -07:00
Jon Dufresne 66e1ebbffc Fixed #26956 -- Added success_url_allowed_hosts to LoginView and LogoutView. 
Allows specifying additional hosts to redirect after login and log out.
 2016-09-07 19:56:25 -07:00
Jon Dufresne f227b8d15d Refs #26956 -- Allowed is_safe_url() to validate against multiple hosts 2016-09-07 19:56:25 -07:00
Nicola Jordan 978a00e39f Fixed #27143 -- Allowed combining SearchQuery with more than one & or | operators. 2016-09-07 15:26:52 -04:00
Ankur Gupta 40d5011471 Fixed #27174 -- Explained where PollsConfig comes from in tutorial 2. 2016-09-07 14:12:53 -04:00
Markus Gerards 2b64ff68cc Fixed #27180 -- Fixed a crash in MySQL checks where SELECT @@sql_mode doesn't return a result. 2016-09-07 11:15:41 -04:00
Chris Jerdonek ccf7adb064 Fixed #27172 -- Closed database cursor explicitly in two doc examples 2016-09-07 12:14:29 +02:00
Tim Graham 6a2af01452 Fixed #24865 -- Added remove_stale_contenttypes management command. 
Thanks Simon Charette for the review.
 2016-09-06 09:48:58 -04:00
Tim Graham 277fe2e8f2 Fixed #25788 -- Enabled the cached template loader if debug is False. 2016-09-03 09:06:33 -04:00
Claude Paroz 2ced2f785d Replaced smart_* by force_* calls whenever possible 
The smart_* version should only be used when a lazy string should keep
its lazy status.
 2016-09-03 13:46:41 +02:00
Daniel Hahler b1d6b0a7b1 Fixed #26098 -- Used cdnjs.cloudflare for OpenLayers.js. 2016-09-03 06:52:25 -04:00
Tim Graham 5bd967e1c5 Doc'd how to remove old references in migration files. 2016-09-02 09:59:40 -04:00
Jeff Willette bd3dc670b5 Fixed #27099 -- Documented list filter's has_output() method. 2016-09-02 09:41:13 -04:00
Shai Berger c93ac9cf42 Refs #25850, #27142, #27110 -- Documented migration history consistency checks. 2016-09-01 18:49:10 -04:00
Tim Graham de7f9758ac Added stub release notes for 1.10.2. 2016-09-01 16:27:45 -04:00
Tim Graham 894df3e327 Added release date for 1.10.1. 2016-09-01 16:24:46 -04:00
Tim Graham 098c07a032 Fixed #27142, #27110 -- Made makemigrations consistency checks respect database routers. 
Partially reverted refs #27054 except for one of the tests as this
solution supersedes that one.

Thanks Shai Berger for the review.
 2016-09-01 16:19:29 -04:00
Sergei Maertens 32c02f2a0e Fixed #5908 -- Added {% resetcycle %} template tag. 
Thanks to Simon Litchfield for the report, Uninen for the initial
patch, akaihola, jamesp, b.schube, and Florian Appoloner for
subsequent patches, tests, and documentation.
 2016-09-01 15:52:21 -04:00
Ed Morley 2cfd48bccd Updated roadmap link for 1.11. 2016-09-01 15:18:55 -04:00
Riccardo Magliocchetti 7ed8b98f42 Clarified URL regex check message with respect to include(). 2016-09-01 14:06:45 -04:00
Claude Paroz 6b54504e66 Refs #27162 -- Complemented docs related to CreateExtension 
Thanks Tim Graham for the review.
 2016-09-01 15:59:46 +02:00
Tim Graham 789f9c9b29 Refs #27164 -- Fixed typo in docs/topics/db/multi-db.txt 2016-09-01 09:53:24 -04:00
Jon Dufresne ff1e7b4eb4 Fixed #25181 -- Added localdate() function to get date in a different time zone. 
Thanks Konrad Świat for the original patch.
 2016-08-31 17:19:33 -07:00
Ed Morley d8ef5b0e65 Fixed #27152 -- Supported comma delimiter in memcached LOCATION string. 2016-08-31 17:23:41 -04:00
Ed Morley 65ec8fa8ca Fixed #20892 -- Allowed configuring memcached client using OPTIONS. 
Previously, the MemcachedCache backend ignored `OPTIONS` and
PyLibMCCache used them to set pylibmc behaviors. Both backends now
pass `OPTIONS` as keyword arguments to the client constructors.
 2016-08-31 12:50:14 -04:00
Ed Morley 1d54fb4483 Made settings docs link to cache parameters more specific. 2016-08-31 12:31:30 -04:00
Olexander Yermakov b7fb608142 Fixed #27154 -- Allowed comparing CallableBool with bitwise or. 
Thanks Tim for the review.
 2016-08-31 08:27:37 -04:00
Mike Fiedler b961b51eaf Fixed typo in docs/topics/testing/overview.txt 2016-08-31 07:34:52 -04:00
Tim Graham 3f16e4df49 Fixed #27145 -- Updated Storage.save() docs for refs #18899. 2016-08-30 21:35:12 -04:00
Kevan Swanberg 35504f74a8 Fixed #26685 -- Added dwithin lookup support on SpatiaLite. 2016-08-30 20:45:47 -04:00
Tim Graham 38cf9ef390 Added Django 1.11, 2.0 to Python version support table. 2016-08-26 17:21:46 -04:00
Baptiste Mispelon 61b45dff6b Fixed #27126 -- Made {% regroup %} return a namedtuple to ease unpacking. 2016-08-26 16:59:21 -04:00
Baptiste Mispelon 7968bb7fad Fixed incorrect variable name in {% regroup %} docs. 2016-08-26 16:25:18 -04:00
Chris Jerdonek 42dcceba61 Fixed #26942 -- Added support for subtests during parallel testing. 2016-08-26 14:24:27 -04:00
Berker Peksag a02b5848ae Replaced property() usage with decorator in several places. 2016-08-25 20:06:22 -04:00
Mattias Loverot 2315114090 Fixed #27067 -- Deprecated string_concat() in favor of format_lazy(). 2016-08-25 16:12:40 -04:00
Claude Paroz 13c3e5d5a0 Fixed #25995 -- Added an encoder option to JSONField 
Thanks Berker Peksag and Tim Graham for the reviews.
 2016-08-25 21:42:42 +02:00
Akshesh 989f6108d3 Added class-based indexes to 1.11 release notes. 2016-08-25 09:51:54 -04:00
Tim Graham 4bc6b93994 Fixed #27039 -- Fixed empty data fallback to model field default in model forms. 2016-08-24 17:50:10 -04:00
Berker Peksag 426bca002c Fixed #26816 -- Corrected an admin check to require inlines to subclass InlineModelAdmin. 2016-08-24 17:34:32 -04:00
Berker Peksag 3c18f8a3d2 Fixed #27111 -- Fixed KeyError if USERNAME_FIELD isn't in UserCreationForm.fields. 2016-08-24 13:20:12 -04:00
Mattias Loverot 9aaeec337e Fixed #26866 -- Added format_lazy function 
Added format_lazy function to django.utils.text module.
Useful when dealing with relative complex lazy string concatenations
(e.g. in urls.py when translating urls in regular expressions).
 2016-08-24 18:18:17 +02:00
Tim Graham cf2cd4053f Fixed #27104 -- Corrected shell example in tutorial 5. 2016-08-24 09:11:50 -04:00
Tim Graham b40d24960c Fixed #27115 -- Corrected a screenshot in the tutorial. 2016-08-24 08:59:49 -04:00
Simon Charette d5c4ea5246 Fixed #27100 -- Included already applied migration changes in the pre-migrate state. 
Refs #24100.

Thanks Tim for the review.
 2016-08-24 01:17:48 -04:00
Simon Charette d1757d8df4 Fixed #27044 -- Included already applied migration changes in the post-migrate state when the execution plan is empty. 
Refs #24100.

Thanks tkhyn for the report and Tim for the review.
 2016-08-24 01:17:18 -04:00
Tim Graham ad25fe7350 Fixed #27089 -- Added database alias to InconsistentMigrationHistory message. 2016-08-23 17:39:58 -04:00
Tim Graham 80c03b06ad Fixed #24650 -- Documented how to change an unmanaged model to managed. 2016-08-23 17:35:42 -04:00
Collin Anderson 384f89f8f8 Fixed #26998 -- Reverted some admin checks from checking field.many_to_many back to isinstance(field, models.ManyToManyField). 
This partially reverts 983c158da7
 2016-08-23 16:00:12 -04:00
Chris Jerdonek a3db480393 Fixed #27061 -- Added a TEST['TEMPLATE'] setting for PostgreSQL. 2016-08-23 15:08:20 -04:00
Helen Sherwood-Taylor bc1e2d8e8e Fixed #27018 -- Fixed admindocs crash with a view in a class. 
Generated correct admindocs URLs on Python 3. URLs generate 404s on
Python 2, as in older versions of Django.
 2016-08-20 10:01:57 -04:00
Tim Graham 9f27735612 Fixed #27013 -- Clarified commands to install argon2/bcrypt packages. 2016-08-19 19:23:12 -04:00
Przemysław Suliga 1f68bb5683 Refs #26902 -- Protected against insecure redirects in set_language(). 2016-08-19 19:16:00 -04:00
Przemysław Suliga 549b90fab3 Refs #26902 -- Protected against insecure redirects in Login/LogoutView. 2016-08-19 19:01:01 -04:00
Tim Graham 44c306218f Fixed #27085 -- Corrected a screenshot in the tutorial. 2016-08-19 18:04:57 -04:00
Abhishek Bera f3b601f11a Fixed #26987 -- Documented using QuerySet.get() without arguments. 2016-08-19 17:15:33 -04:00
Tim Graham 1d1e246db6 Removed DateTimeAwareJSONEncoder alias. 2016-08-19 15:00:16 -04:00
Tim Graham 1357e5796c Added technical board for 1.11 release cycle. 
The current board has been re-elected.
 2016-08-19 14:55:54 -04:00
Tim Graham d60386d0f5 Fixed #26571 -- Corrected recommendation for converting timestamps to tz-aware datetimes. 2016-08-19 14:47:06 -04:00
Matthew Wilkes 4f138fe5a4 Fixed #22288 -- Fixed F() expressions with the __range lookup. 2016-08-19 13:40:56 -04:00
Vincent Zhang 7b08e01c13 Refs #26747 -- Corrected a method name in tutorial05. 2016-08-19 11:10:28 -04:00
Brightcells d301c61bcb Replaced old DateTimeAwareJSONEncoder with DjangoJSONEncoder in docs. 2016-08-19 09:13:53 -04:00
Tim Graham f8c338ec6a Refs #25854 -- Completed a RequestContext docs example. 2016-08-18 21:11:27 -04:00
Tim Graham 518eaf1fa2 Fixed #26807 -- Documented how to replicate SubfieldBase's assignment behavior. 2016-08-18 20:59:40 -04:00
Jon Dufresne f5c6d3c8d9 Fixed #27068 -- Unified form field initial data retrieval. 2016-08-18 17:55:47 -07:00
Ian Foote 39f35d4b9d Fixed #25871 -- Added expressions support to QuerySet.values(). 2016-08-18 16:05:15 -04:00
Loïc Bistuer d4eefc7e2a Fixed #27073 -- Removed duplicated managers in `Model._meta.managers`. 2016-08-19 01:24:45 +07:00
Timothy Allen 8cd900c819 Corrected text from Python's Windows installer. 2016-08-18 14:05:12 -04:00
Jim Nicholls 76ab885118 Fixed #27054 -- Fixed makemigrations crash with a read-only database. 2016-08-18 08:27:40 -04:00
Chris Lamb 97513269d7 Refs #26983 -- Added test for isnull lookup to CharField with primary_key=True. 2016-08-17 21:08:15 -04:00
Mattias Loverot 35ea6d83c8 Fixed #27069 -- Doc'd which gettext functions may be aliased as _. 2016-08-17 16:34:54 -04:00
Andreas Pelme e76981b433 Fixed #26840 -- Added test.utils.setup/teardown_databases(). 2016-08-17 13:55:04 -04:00
Kevin Christopher Henry ff445f4c19 Fixed #26616 -- Clarified model usage in AppConfig.ready(). 2016-08-17 10:34:51 -04:00
Jon Dufresne 4773ed2e31 Fixed incorrect doc reference to Field.initial. 2016-08-17 10:27:33 -04:00
Tim Graham 8fb53c50ce Fixed #19222 -- Documented that default managers aren't used for related queries. 2016-08-16 13:12:55 -04:00
Akshesh 7c9bd07f69 Clarified when activating the btree_gin extension is necessary. 2016-08-16 09:03:13 -04:00
Tim Graham 7549eb0004 Fixed #27009 -- Made update_session_auth_hash() rotate the session key. 2016-08-15 19:29:12 -04:00
Tim Graham 937d752d3d Fixed #27058 -- Reallowed the {% for %} tag to unpack any iterable. 
Thanks Sergei Maertens for the report and patch.
 2016-08-15 15:39:22 -04:00
Daniel Wiesmann 89f17e7caf Fixed #27014 -- Fixed annotations with database functions on PostGIS. 
Thanks Sean Mc Allister for providing a test.
 2016-08-15 14:23:10 -04:00
Timothy Allen df92f6f2e3 Documented how allow_migrate() interacts with makemigrations. 2016-08-15 13:34:54 -04:00
Victor Oliveira da Silva d7804662f8 Made cosmetic edits to Field.default docs. 2016-08-15 10:44:39 -04:00
Tim Graham c6cd9f4ae2 Fixed typo in docs/releases/1.11.txt 2016-08-13 08:33:58 -04:00
Chris Jerdonek 5890b1613c Fixed #27008 -- Added --debug-mode option to DiscoverRunner. 2016-08-12 20:43:17 -04:00
Tim Graham 9556005425 Fixed #27048 -- Documented that refresh_from_db() doesn't reload @cached_properties. 2016-08-12 18:49:21 -04:00
Akshesh 6e07ec3f65 Fixed #27030 -- Added contrib.postgres.indexes.GinIndex. 2016-08-12 18:37:03 -04:00
Akshesh 236baa0f0e Refs #27030 -- Added BtreeGinExtension operation. 2016-08-12 18:37:00 -04:00
Tim Graham e1acc9dc66 Removed some unnecessary repetition in PostgreSQL operations docs. 2016-08-12 18:03:19 -04:00
Michael Schwarz 72d541b61c Fixed #27007 -- Handled non-UTF-8 bytes objects for text/* attachments. 
The fallback logic which allows non-UTF-8 encoded files to be passed to
attach_file() even when a `text/*` mime type has been specified is
moved to attach(). Both functions now fall back to a content type of
`application/octet-stream`.

A side effect is that a file's content is decoded in memory instead of
opening it in text mode and reading it into a string.

Some mimetype-related logic in _create_attachment() has become
obsolete as the code moved from attach_file() to attach() already
handles this.
 2016-08-12 16:35:09 -04:00
Akshesh 311a8e8d50 Fixed #20888 -- Added support for column order in class-based indexes. 2016-08-12 15:52:16 -04:00
Jon Dufresne fab46ce6f5 Fixed #27037 -- Prevented required attribute on ClearableFileInput when initial data exists. 2016-08-12 13:59:01 -04:00
Akshesh f842d1011c Refs #20888 -- Added index order introspection. 2016-08-12 11:51:09 -04:00
Tim Graham 5eab1f6f83 Fixed typo in docs/releases/1.9.txt 2016-08-12 07:29:29 -04:00
Kevin Christopher Henry b785927b44 Documented the cache_control() decorator. 2016-08-11 16:46:58 -04:00
Moritz Sichert 08b8c46971 Refs #23960 -- Documented how to restore absolute redirect URLs. 2016-08-11 16:35:59 -04:00
Tim Graham 4c2a6fe75b Clarified session verification with respect to the current session. 2016-08-11 12:08:50 -04:00
Tim Graham 6b83f61e72 Fixed #27050 -- Corrected django.setup()'s parameter name in docs. 2016-08-11 07:01:55 -04:00
Tim Graham e2dfa81ff7 Refs #18682 -- Edited explanation in stale content type deletion. 
Follow up to 8db889eaf7.
 2016-08-10 21:19:09 -04:00
Ed Morley 7399fee6c3 Refs #26947 -- Added a deployment system check for SECURE_HSTS_PRELOAD. 2016-08-10 20:31:01 -04:00
Ed Morley 3c2447dd13 Fixed #26947 -- Added an option to enable the HSTS header preload directive. 2016-08-10 20:23:54 -04:00
an0o0nym c412aaca73 Fixed #26957 -- Corrected authenticate() docs regarding User.is_active. 2016-08-10 19:52:01 -04:00
Sergey Fedoseev 0d18b06562 Documented GeoHash's precision parameter. 2016-08-10 16:32:08 -04:00
Chris Jerdonek 7f9fd42b93 Fixed #27019 -- Made teardown_test_environment() restore the old DEBUG. 2016-08-10 16:24:41 -04:00
Tim Graham 796cc62026 Fixed #27045 -- Documented that AUTH_PASSWORD_VALIDATORS aren't applied at the model level. 2016-08-10 15:52:16 -04:00
Tim Graham 1e32e1cc95 Fixed #26973 -- Fixed views.static.serve() crash with show_indexes enabled. 2016-08-10 11:27:03 -04:00
jordij 0814566bf1 Fixed #26960 -- Added PasswordResetConfirmView option to automatically log in after a reset. 2016-08-10 10:23:16 -04:00
an0o0nym 2b759c94c5 Fixed #26952 -- Added tips for installing test suite dependencies. 2016-08-09 18:37:09 -04:00
Tim Graham cd58f13fb6 Removed obsolete note about Sphinx version required for building docs. 2016-08-09 18:11:26 -04:00
Chris Jerdonek a3a5ef4d0e Fixed #27035 -- Eased changing settings.DEBUG for DiscoverRunner. 2016-08-09 13:40:29 -04:00
Claude Paroz ade681b9ad Unified SpatiaLite spelling 2016-08-09 18:46:28 +02:00
Tim Graham 79a9603ba8 Corrected Django 1.8 EOL in 1.11 release notes. 2016-08-09 10:24:35 -04:00
Ville Skyttä f95bd89e82 Fixed #27041 -- Documented that built-in middleware are compatible with MIDDLEWARE and MIDDLEWARE_CLASSES. 2016-08-09 08:06:47 -04:00
Ed Morley 8c3bc5cd78 Fixed docs to refer to HSTS includeSubdomains as a directive. 
The spec refers to it as a 'directive' rather than a 'tag':
https://tools.ietf.org/html/rfc6797#section-6.1.2
 2016-08-08 20:20:49 -04:00
Claude Paroz a6baada7bd Fixed #26940 -- Removed makemessages from no_settings_commands whitelist 
As makemessages uses several settings for proper run (FILE_CHARSET,
LOCALE_PATHS, MEDIA_ROOT, and STATIC_ROOT), we should require settings
configuration for this command.
 2016-08-08 19:52:57 +02:00
Simon Charette b8e6e1b43b
Fixed #26500 -- Added SKIP LOCKED support to select_for_update(). 
Thanks Tim for the review.
 2016-08-08 12:01:43 -04:00
Johannes Dollinger 46509cf13d Moved EmpytResultSet to django.core.exceptions. 
This removes the need for some inner imports.
 2016-08-08 10:43:34 -04:00
Chris Jerdonek e7fb724cd2 Fixed #27032 -- Prevented setup_test_environment() from being called twice. 2016-08-08 10:40:29 -04:00
Claude Paroz 1b0287b4b8 Fixed typos in db-api GIS docs 2016-08-08 15:16:28 +02:00
Sjoerd Job Postmus 3246d2b4bb Fixed #27026 -- Fixed state initialization of bulk_create() objects if can_return_ids_from_bulk_insert. 2016-08-06 10:24:57 -04:00
Ben Demboski fc8f097117 Fixed #27027 -- Restored Client.force_login() defaulting to the first auth backend. 2016-08-06 08:41:41 -04:00
Adam Zapletal 4f113483d7 Fixed a few grammar issues in working-with-git doc. 2016-08-06 08:11:48 -04:00
Akshesh 6a8372e6ec Fixed #26808 -- Added Meta.indexes for class-based indexes. 
* Added the index name to its deconstruction.
* Added indexes to sqlite3.schema._remake_table() so that indexes
  aren't dropped when _remake_table() is called.

Thanks timgraham & MarkusH for review and advice.
 2016-08-05 18:12:51 -04:00
Jarek Glowacki d117567c7d Fixed #27004 -- Made migrations consistency check ignore unapplied squashed migrations. 2016-08-05 18:01:55 -04:00
Chris Jerdonek 42f9d65107 Edited docs of test.utils.setup/teardown_test_environment(). 2016-08-05 17:38:49 -04:00