Commit Graph

10503 Commits

Author SHA1 Message Date
Simon Charette 453a5bf302 [3.0.x] Fixed #31735 -- Fixed migrations crash on namespaced inline FK addition on PostgreSQL.
The namespace of the constraint must be included when making the
constraint immediate.

Regression in 22ce5d0031.

Thanks Rodrigo Estevao for the report.

Backport of 2e8941b6f9 from master
2020-06-24 09:00:22 +02:00
Mariusz Felisiak e2cdbc585a
[3.0.x] Refs #31660 -- Fixed annotations.tests crash on MySQL.
Follow up to be7a295141.
2020-06-11 10:36:24 +02:00
Nicolas Baccelli 2b2500021b [3.0.x] Fixed #31664 -- Reallowed using non-expressions having filterable attribute as rhs in queryset filters.
Regression in 4edad1ddf6.

Backport of b38d44229f from master
2020-06-08 09:20:08 +02:00
Mariusz Felisiak be7a295141 [3.0.x] Fixed #31660 -- Fixed queryset crash when grouping by m2o relation.
Regression in 3a941230c8.

Thanks Tomasz Szymański for the report.
Backport of 78ad4b4b02 from master
2020-06-08 07:23:33 +02:00
Mariusz Felisiak e8723af44b [3.0.x] Fixed #31654 -- Fixed cache key validation messages.
Backport of 926148ef01 from master
2020-06-05 07:22:52 +02:00
Mariusz Felisiak 88dc69fcec [3.0.x] Refs CVE-2020-13254 -- Fixed cache.tests when KEY_PREFIX is defined.
Follow up to 2c82414914.

Backport of 229c9c6653 from master
2020-06-03 13:01:21 +02:00
Dan Palmer 84b2da5552 [3.0.x] Fixed CVE-2020-13254 -- Enforced cache key validation in memcached backends. 2020-06-03 09:33:20 +02:00
Jon Dufresne 1f2dd37f6f [3.0.x] Fixed CVE-2020-13596 -- Fixed potential XSS in admin ForeignKeyRawIdWidget. 2020-06-03 09:32:35 +02:00
Carlton Gibson 2638627db4 [3.0.x] Fixed #31570 -- Corrected translation loading for apps providing territorial language variants with different plural equations.
Regression in e3e48b0012.

Thanks to Shai Berger for report, reproduce and suggested fix.

Backport of dd1ca50b09 from master
2020-06-01 09:27:53 +02:00
Mariusz Felisiak 0ba5aadb33 [3.0.x] Fixed #31607 -- Fixed evaluated Subquery equality.
Regression in 691def10a0.

Backport of a125da6a7c from master
2020-05-19 22:51:01 +02:00
Mariusz Felisiak 92acf1022f [3.0.x] Fixed #31584 -- Fixed crash when chaining values()/values_list() after Exists() annotation and aggregation on Oracle.
Oracle requires the EXISTS expression to be wrapped in a CASE WHEN in
the GROUP BY clause.

Regression in efa1908f66.
Backport of 3a941230c8 from master
2020-05-14 15:11:18 +02:00
Simon Charette 49bbf6570d [3.0.x] Fixed #31568 -- Fixed alias reference when aggregating over multiple subqueries.
691def10a0 made all Subquery() instances
equal to each other which broke aggregation subquery pushdown which
relied on object equality to determine which alias it should select.

Subquery.__eq__() will be fixed in an another commit but
Query.rewrite_cols() should haved used object identity from the start.

Refs #30727, #30188.

Thanks Makina Corpus for the report.

Backport of adfbf653dc from master
2020-05-14 10:26:16 +02:00
Simon Charette afceb2241b [3.0.x] Fixed #31566 -- Fixed aliases crash when chaining values()/values_list() after annotate() with aggregations and subqueries.
Subquery annotation references must be resolved if they are excluded
from the GROUP BY clause by a following .values() call.

Regression in fb3f034f1c.

Thanks Makina Corpus for the report.

Backport of 42c08ee465 from master
2020-05-14 08:40:40 +02:00
Mariusz Felisiak 48ed73fb74 [3.0.x] Fixed E128, E741 flake8 warnings.
Backport of 0668164b4a from master.
2020-05-12 08:55:06 +02:00
Adam Johnson cdf320dfb2 [3.0.x] Fixed a/an typos in "SQL" usage.
Backport of 1c2c6f1b51 from master
2020-05-06 06:36:16 +02:00
Mariusz Felisiak fdd5eb4309 [3.0.x] Fixed #31538 -- Fixed Meta.ordering validation lookups that are not transforms.
Regression in 440505cb2c.

Thanks Simon Meers for the report.
Backport of b73e66e758 from master
2020-05-05 09:09:17 +02:00
Hasan Ramezani 8e23b89ffd [3.0.x] Fixed #31521 -- Skipped test_parsing_rfc850 test on 32-bit systems.
Backport of f121621073 from master
2020-04-30 07:13:25 +02:00
Hasan Ramezani 22a2e97fc3 [3.0.x] Fixed #31420 -- Fixed crash when filtering subquery annotation against a SimpleLazyObject.
Thanks Simon Charette for the solution and analysis.

Backport of 4237050684 from master
2020-04-06 08:15:51 +02:00
Hasan Ramezani 72652bcb1b [3.0.x] Fixed #31377 -- Disabled grouping by aliases on QuerySet.values()/values_list() when they collide with field names.
Regression in fb3f034f1c.

Thanks Holovashchenko Vadym for the report.

Backport of 10866a10fe from master
2020-03-25 09:49:51 +01:00
Claude Paroz d9f1792c76 [3.0.x] Fixed #30439 -- Added support for different plural forms for a language.
Thanks to Michal Čihař for review.
Backport of e3e48b0012 from master
2020-03-10 15:57:36 +01:00
Mariusz Felisiak 8e30512e7a [3.0.x] Fixed GeoQuerySetTest.test_unionagg_tolerance() test on Oracle 18c.
Backport of 5ca76baa72 from master
2020-03-05 08:56:09 +01:00
Mariusz Felisiak 26a5cf8345 [3.0.x] Fixed CVE-2020-9402 -- Properly escaped tolerance parameter in GIS functions and aggregates on Oracle.
Thanks to Norbert Szetei for the report.
2020-03-04 09:16:03 +01:00
Mariusz Felisiak c5cfaad2f1 [3.0.x] Fixed #31150 -- Included subqueries that reference related fields in GROUP BY clauses.
Thanks Johannes Hoppe for the report.

Regression in fb3f034f1c.

Co-authored-by: Simon Charette <charette.s@gmail.com>

Backport of 7b8fa1653f from master
2020-03-03 11:26:36 +01:00
Mariusz Felisiak 94e192a580 [3.0.x] Refs #31312 -- Fixed FTimeDeltaTests.test_date_case_subtraction() test.
Follow up to 16cacdcb3f.
2020-02-27 20:18:53 +01:00
Simon Charette 16cacdcb3f [3.0.x] Fixed #31312 -- Properly ordered temporal subtraction params on MySQL.
Regression in 9bcbcd599a.

Thanks rick2ricks for the report.

Backport of 41ebe60728 from master
2020-02-27 09:20:30 +01:00
Mariusz Felisiak 2448b3182c [3.0.x] Fixed #31271 -- Preserved ordering when unifying query parameters on Oracle.
This caused misplacing parameters in logged SQL queries.

Regression in 79065b55a7.

Thanks Hans Aarne Liblik for the report.
Backport of 2a038521c4 from master
2020-02-18 11:46:01 +01:00
Abhijeet Viswa 8faaaf4e71 [3.0.x] Fixed #31246 -- Fixed locking models in QuerySet.select_for_update(of=()) for related fields and parent link fields with multi-table inheritance.
Partly regression in 0107e3d105.

Backport of 1712a76b9d from master
2020-02-11 21:36:05 +01:00
Florian Apolloner 4e8d6a1baf [3.0.x] Fixed #31240 -- Properly closed FileResponse when wsgi.file_wrapper is used.
Thanks to Oskar Persson for the report.

Backport of 41a3b3d186 from master
2020-02-11 20:40:24 +01:00
Florian Apolloner 22c25bea54 [3.0.x] Reverted "Fixed #30565 -- Closed HttpResponse when wsgi.file_wrapper closes file-like object."
This reverts commit cce47ff65a.

Backport of 549445519c from master
2020-02-11 20:40:17 +01:00
Jon Dufresne 7540b7eb31 [3.0.x] Fixed #31253 -- Fixed data loss possibility when using caching from async code.
Case missed in a415ce70be.

Backport of e3f6e18513 from master
2020-02-11 10:12:53 +01:00
Simon Charette 505826b469 [3.0.x] Fixed CVE-2020-7471 -- Properly escaped StringAgg(delimiter) parameter. 2020-02-03 08:32:54 +01:00
Mariusz Felisiak 673444da5e [3.0.x] Fixed #31217 -- Made QuerySet.values()/values_list() group by not selected annotations with aggregations used in order_by().
Regression in 59b4e99dd0.

Thanks Jon Dufresne for the report and Simon Charette for the review.
Backport of 6b178a3e93 from master
2020-02-03 07:48:53 +01:00
Eugene Hatsko a56e45a2bf [3.0.x] Fixed #31190 -- Fixed prefetch_related() crash for GenericForeignKey with custom ContentType foreign key.
Regression in dffa3e1992.

Backport of 0b013564ef from master
2020-01-22 08:25:23 +01:00
Sergey Fedoseev d7e4d6463c [3.0.x] Fixed #31195 -- Relaxed GeometryDistance test for PROJ 5.2+.
Backport of 31e2ab345b from master
2020-01-21 22:51:45 +01:00
Mariusz Felisiak 5b6778b8b9 [3.0.x] Refs #31097 -- Added django.db.models.Q import to contrib.postgres aggregates tests. 2020-01-17 09:13:11 +01:00
Carlton Gibson 57468eaff3 [3.0.x] Fixed #31124 -- Fixed setting of get_FOO_display() when overriding inherited choices.
Regression in 2d38eb0ab9

Backport of 29c126bb34 from master
2020-01-15 15:36:28 +01:00
Mariusz Felisiak a24686987f [3.0.x] Refs #31136 -- Made QuerySet.values()/values_list() group only by selected annotation.
Regression in 0f843fdd5b.
Backport of 59b4e99dd0 from master
2020-01-15 09:33:36 +01:00
David Wobrock 0e6cf4393c [3.0.x] Fixed #31097 -- Fixed crash of ArrayAgg and StringAgg with filter when used in Subquery.
Backport of 2f565f84ac from master
2020-01-14 09:49:56 +01:00
Mariusz Felisiak 92866682c6 [3.0.x] Fixed #31155 -- Fixed a system check for the longest choice when a named group contains only non-string values.
Regression in b6251956b6.

Thanks Murat Guchetl for the report.
Backport of 6f7998adc7 from master
2020-01-11 19:49:38 +01:00
Adam Johnson 16297e7d5e [3.0.x] Fixed #31154 -- Added support for using enumeration types in templates.
Enumeration helpers are callables, so the template system tried to call
them with no arguments.

Thanks Rupert Baker for helping discover this.

Backport of 5166097d7c from master
2020-01-10 09:13:36 +01:00
Mariusz Felisiak 0379da59bd [3.0.x] Fixed #31141 -- Relaxed system check of translation settings for sublanguages.
Regression in 4400d8296d.

Thanks Enrique Matías Sánchez for the report.
Backport of 53d8646f79 from master
2020-01-08 08:06:33 +01:00
Mariusz Felisiak f9110a1b6d [3.0.x] Fixed timezones tests for PyYAML 5.3+.
Backport of 8be477be5c from master
2020-01-07 09:55:15 +01:00
Mariusz Felisiak 4f81f6d236 [3.0.x] Fixed #31136 -- Disabled grouping by aliases on QuerySet.values()/values_list().
Regression in fb3f034f1c.

Thanks Sigurd Ljødal for the report.
Backport of 0f843fdd5b from master
2020-01-04 20:49:43 +01:00
Simon Charette 02cda09b13 [3.0.x] Fixed #31133 -- Fixed crash when subtracting against a subquery annotation.
The subtract_temporals() database operation was not handling expressions
returning SQL params in mixed database types.

Regression in 3543129822.

Thanks Reupen Shah for the report.

Backport of 9bcbcd599a from master
2020-01-03 10:35:44 +01:00
Mariusz Felisiak 09b4224e11 [3.0.x] Refs #31040 -- Fixed crypt.crypt() call in test_hashers.py.
An empty string is invalid salt in Python 3 and raises exception since
Python 3.9, see https://bugs.python.org/issue38402.
Backport of 1960d55f8b from master
2020-01-03 07:47:56 +01:00
Simon Charette 7db4ab8439 [3.0.x] Fixed #31071 -- Disabled insert optimization for primary keys with defaults when loading fixtures.
Model.save_base() is called directly when loading fixtures and assumes
existing rows will be updated. Branching of "raw" allows to maintain
the optimization introduced in #29260 while supporting this edge case.

Regression in 85458e94e3.

Thanks Reupen Shah for the report.

Backport of 5779cc938a from master
2019-12-30 08:30:44 +01:00
Mariusz Felisiak 0f8041abd5 [3.0.x] Fixed #31106 -- Fixed migrations crash on PostgreSQL 10+ when adding FK constraints inline and changing data.
This allows adding foreign key constraints inline and changing data in
the same migration on PostgreSQL 10+.

Regression in 738faf9da2.

Thanks Janne Rönkkö for the report and Simon Charette for the
implementation idea and review.
Backport of 22ce5d0031 from master
2019-12-23 23:30:30 +01:00
Mariusz Felisiak 1e45b06cfd [3.0.x] Refs #31115 -- Added test for nested subquery that references related fields.
Thanks Dmitriy Gunchenko for the report and Simon Charette for the
analysis and tests.

Regression in 5a4d7285bd.

Fixed in 5a4d7285bd.
Backport of 45bcc6feac from master
2019-12-23 12:18:52 +01:00
Simon Charette 7b065c41e4 [3.0.x] Fixed #31109 -- Disabled grouping by aliases on QuerySet.exists().
Clearing the SELECT clause in Query.has_results was orphaning GROUP BY
references to it.

Thanks Thierry Bastian for the report and Baptiste Mispelon for the
bisect.

Regression in fb3f034f1c.

Backport of 720de4d044 from master
2019-12-23 09:24:37 +01:00
Simon Charette fd9050589f [3.0.x] Fixed #31094 -- Included columns referenced by subqueries in GROUP BY on aggregations.
Thanks Johannes Hoppe for the report.

Regression in fb3f034f1c.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>

Backport of 5a4d7285bd from master
2019-12-19 11:10:33 +01:00