f855058c35
[1.6.x] Fixed #11811 -- Data-loss bug in queryset.update.
...
It's now forbidden to call queryset.update(field=instance) when instance
hasn't been saved to the database ie. instance.pk is None.
Conflicts:
tests/queries/tests.py
Backport of b4cd8169
2013-09-06 21:59:28 -05:00
2a2ac5c140
Merge pull request #1566 from adamsc64/ticket_11857
...
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
Backport of 926bc42
2013-09-06 19:44:25 -05:00
3df9647ad9
[1.6.x] Merge pull request #1582 from rca/12756-missing-yaml-module-serializer-error-message
...
Fixed #12756 : Improved error message when yaml module is missing.
Backport of 4f5faa1916
2013-09-06 19:01:24 -05:00
99952bab30
[1.6.x] Merge pull request #1580 from ianawilson/ticket_16502
...
Fixed #16502 -- Fixed a TemplateDoesNotExist error that should be an ImproperlyConfigured.
Assistance on the patch from #jambronrose.
Backport of 9b2dc12b83
2013-09-06 17:39:16 -05:00
b917458f47
Merge pull request #1579 from ianawilson/ticket_21058
...
[1.6.x] Fixed #21058 -- Fixed debug view blowing up when no template is provided to the template rendering functions.
Assistance on this commit from @jambonrose.
Backport of 122020fdb9
2013-09-06 17:11:07 -05:00
180b9955cc
[1.6.x] Fixed #21035 -- Changed docs to treat the acronym SQL phonetically.
...
The documentation and comments now all use 'an' to
refer to the word SQL and not 'a'.
Backport of 4d13cc56de
2013-09-05 20:16:14 -04:00
77cf0d6519
[1.6.x] Fixed #21041 -- Removed a duplicate form in tests.
...
Thanks tuxcanfly.
Backport of bab039d74c
2013-09-05 06:32:26 -04:00
115318051c
[1.6.x] Replaced "not PY3" by "PY2", new in six 1.4.0.
...
Conflicts:
django/db/backends/oracle/base.py
django/db/backends/sqlite3/base.py
django/db/models/base.py
Backport of 365c3e8b
2013-09-03 07:34:45 -05:00
21a3efcf48
[1.6.x] Fixed #20999 - Allow overriding formfield class with choices, without subclass restrictions.
...
Refs #18162 . Thanks claudep and mjtamlyn for review.
Backport of 7211741fc5
2013-08-30 17:45:14 -06:00
76e38a2177
[1.6.x] Fixed #20988 -- Added model meta option select_on_save
...
The option can be used to force pre 1.6 style SELECT on save behaviour.
This is needed in case the database returns zero updated rows even if
there is a matching row in the DB. One such case is PostgreSQL update
trigger that returns NULL.
Reviewed by Tim Graham.
Refs #16649
Backport of e973ee6a98
2013-08-30 09:47:34 +03:00
10d15f79e5
[1.6.x] Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False.
...
Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.
Backport of f19a3669b8
2013-08-29 12:14:40 -04:00
ef1259342b
[1.6.x] Fixed #16433 -- Fixed a help_text/read only field interaction that caused an admin crash.
...
Thanks chris at cogdon.org for the report and admackin for the patch.
Backport of af953c45cc
2013-08-29 09:45:02 -04:00
2c08d474a8
[1.6.x] Fixed #20961 -- Fixed HttpResponse default empty content
...
Thanks epandurski at gmail.com for the report.
Backport of f4e980456
2013-08-24 18:10:50 +02:00
5f061986b9
[1.6.x] Fixed #20922 -- Allowed customizing the serializer used by contrib.sessions
...
Added settings.SESSION_SERIALIZER which is the import path of a serializer
to use for sessions.
Thanks apollo13, carljm, shaib, akaariai, charettes, and dstufft for reviews.
Backport of b0ce6fe656
2013-08-22 17:55:01 -04:00
161e26c2ec
[1.6.x] Fixed #20955 -- select_related regression
...
In cases where the same connection (from model A to model B along the
same field) was needed multiple times in a select_related query, the
join setup code mistakenly reused an existing join.
Backpatch of 8d65b6082c
2013-08-22 10:59:59 +03:00
12d364a9b0
[1.6.x] Fixed #20933 -- Allowed loaddata to load fixtures from relative paths.
...
Backport of 6e846f7627
2013-08-20 21:28:14 +02:00
b189169ed0
[1.6.x] Fixed invalid testing fixture
...
Backport of 86f4459f9e
2013-08-20 17:49:00 +03:00
2b1101a4a6
[1.6.x] Fixed #20820 -- Model inheritance + m2m fixture loading regression
...
Tests by Tim Graham, report from jeroen.pulles@redslider.net .
Backport of 1ed77e7782
2013-08-20 17:15:52 +03:00
3ae585b449
[1.6.x] Fixed a test failure introduced in f0bc2865ff.
...
`classobj` objects cannot be weakly referenced on Python 2.6
2013-08-20 04:08:41 -04:00
f0bc2865ff
Fixed #20943 -- Weakly reference senders when caching their associated receivers
...
Backport of e55ca60903
2013-08-20 02:12:50 -04:00
c769c26601
[1.6.x] Revert "Fixed #18491 -- deleting a proxy doesn't show warning about cascade deletes"
...
This reverts commit 2b48fcc607#20777 ) which we can't easily fix in 1.6.
2013-08-16 07:59:16 -04:00
919934602f
[1.6.x] Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value
...
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
Backport of 22c6497f99
2013-08-15 20:33:02 -04:00
ccff25b143
[1.6.x] Fixed #17778 -- Prevented class attributes on context from resolving as template variables.
...
Thanks KyleMac for the report, regebro for the patch, and Aymeric for the test.
Backport of 71b5617c24
2013-08-15 10:22:56 -04:00
b720ece065
[1.6.x] Removed unneeded conditional_escapes from the testsuite.
...
Backport of 4e50e40654
2013-08-13 22:24:14 +02:00
bfbae15c66
Apply autoescaping to AdminURLFieldWidget.
...
This is a security fix; disclosure to follow shortly.
2013-08-13 11:06:00 -05:00
e3e0cf8a0f
[1.6.x] Fixed #20865 -- Fixed raw_id_fields to work with callable limit_choices_to.
...
Backport of d53e574676
2013-08-06 13:44:31 -04:00
80b95a2b1f
[1.6.x] Fixed #19918 -- Modified select_for_update to run on the write database.
...
Backport of 1c64a0f29e
2013-08-06 10:58:32 -04:00
363b81c59c
[1.6.x] Fixed ordering related test failure
...
Also PEP8 + python_2_unicode_compatible cleanup done.
Backport of 263b873599
2013-08-06 10:34:42 +03:00
891cdf120a
[1.6.x] Fixed #20850 -- Added MultiWidget.needs_multipart_form
...
Backport of 75c87e2d38
2013-08-05 10:13:48 -04:00
2eac989985
[1.6.x] Fixed #20822 -- Set content type of default error pages to 'text/html'.
...
Thanks Jimmy Song for the patch.
Backport of 7843775
2013-08-04 11:04:58 +02:00
4e7745cc1c
[1.6.x] Fixed LogEntry.get_admin_url() for non-existent models.
...
Regression introduced by [369b6fa#18169 .
Backport of 1b47508ac8
2013-08-02 12:51:46 -04:00
4f8fb19994
[1.6.x] Fixed #18681 -- GenericInlineModelAdmin.get_formset() no longer bypasses get_fieldsets().
...
Refs 23e1b59a0ed2f9260
2013-08-02 10:45:58 -04:00
6e4fd816c4
[1.6.x] Fixed #18777 -- Localized form fields with as_text/as_hidden
...
Thanks croldan for the report.
Backport of 893d8de6f5
2013-08-02 08:43:19 -04:00
196cc875b2
[1.6.x] Fixed #17519 -- Fixed missing SQL constraints to proxy models.
...
Thanks thibaultj for the report, jenh for the patch,
and charettes for the tests.
Backport of aa830009de
2013-08-02 08:42:19 -04:00
badca4716f
[1.6.x] Fixed #10491 -- Allowed passing lazy objects to HttpResponseRedirect.
...
Thanks liangent for the report.
Backport of 3c45fb8589
2013-07-30 13:40:18 -04:00
081a27c358
[1.6.x] Simplified smart_urlquote and added some basic tests.
...
Backport of b70c371fc1
2013-07-28 10:07:01 +02:00
dbbd2b1272
[1.6.x] Fixed #20805 -- Removed an extra colon beside checkboxes in the admin.
...
Thanks CollinAnderson for the report.
Backport of 8676318d2d
2013-07-26 14:47:58 -04:00
5cc1ea4773
[1.6.x] Updated contrib.admin to use Email/URLInputs; refs #16630
...
Backport of 2a979d2a7b
2013-07-26 08:02:10 -04:00
7f892cedba
[1.6.x] Fixed related model lookup regression
...
It has been possible to use models of wrong type in related field
lookups. For example pigs__in=[a_duck] has worked. Changes to
ForeignObject broke that.
It might be a good idea to restrict the model types usable in lookups.
This should be done intentionally, not accidentally and without any
consideration for deprecation path.
Backpatch of 7cca8d56d2
2013-07-26 13:17:50 +03:00
d439f85bbf
[1.6.x] Fixed ._meta.pk_index() virtual field failure
...
Backport of 92476e880c
2013-07-25 16:35:04 +03:00
816bf0c6a7
[1.6.x] Fixed #20781 -- Fixed _has_changed regression with MultiValueField
...
Thanks Tim Graham for the report.
Backport of 02b0106d
2013-07-22 09:07:04 +02:00
48516d3b85
[1.6.x] Fixed an email validation regression
...
Thanks Vincent Wagelaar for the report.
Backport of 11b7b9ad
2013-07-21 21:12:50 +02:00
706e542eb5
[1.6.x] Fixed #13696 -- ensured inline pk field is rendered
...
Backport of 3aad955ea8
2013-07-21 13:13:20 -04:00
9d3f7a21a3
[1.6.x] Fixed #20765 -- Set small values of `step` using exponential notation.
...
Browsers parse small factors of 10 as 0 under decimal notation.
Thanks to Trac alias matklad for the report and Claude Paroz for the review.
Backport of 415a36947c
2013-07-19 23:45:29 -04:00
c660f0e985
[1.6.x] Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs.
...
Thanks Collin Anderson for the report.
Backport of 2fc6c9472c
2013-07-18 18:23:21 -04:00
e5241902f3
[1.6.x] Fixed #20681 -- Prevented teardown_databases from attempting to tear down aliases
...
Thanks simonpercivall.
Backport of d9c580306c
2013-07-13 17:46:37 -04:00
26b88e7658
[1.6.x] Fixed a deprecation warning in a selenium test.
...
Backport of 9b471a8fe3
2013-07-13 13:22:00 -04:00
45fab74561
[1.6.x] Fixed #20740 -- GenericIPAddressField should pass protocol to formfield()
...
Thanks Jeff250.
Backport of f2cb94f1c0
2013-07-12 16:06:43 -04:00
aecbaaed0c
[1.6.x] Fixed #19196 -- Added test/requirements
...
Backport of 4d92a0bd86
2013-07-10 09:37:15 -04:00
a2b4af3a1a
Fixed #20724 -- Test failure on SQLite.
...
This test failure happened if the connection's NAME was set to a file
system path, and its TEST_NAME wasn't.
Thanks Claude for the report.
Conflicts:
tests/transactions_regress/tests.py
Backport of 404870ee1f
2013-07-09 21:43:20 +02:00
d200405471
Avoided transaction.set_autocommit in tests.
...
It doesn't work as one might expect on a certain database backend where
autocommits_when_autocommit_is_off = True. That backend happens to be
popular for running tests.
Backport of 38bc581bc0
2013-07-09 21:42:11 +02:00
d14db25fee
[1.6.x] Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for default db.
...
Thanks simonpercivall.
Backport of 2cbd579efe
2013-07-04 20:15:27 -04:00
4c1029971e
[1.6.x] Fixed a couple form/formset deprecation warnings in tests.
...
Backport of a521d10322
2013-07-01 09:38:29 -04:00
3c51962cab
[1.6.x] Updated tests for deprecation of Option.get_(add|change|delete)_permission.
...
refs #20642 .
Backport of a6a905c619
2013-07-01 09:21:07 -04:00
d255004289
[1.6.x] Stopped calling loaddata with commit=False.
...
This was a stealth option only used by the tests, and it isn't useful
any more since `atomic` provides nested transactions.
Backport of 2c40681
2013-06-30 14:20:29 +02:00
59be2c6875
[1.6.x] Fixed #18592 -- Prevented crash when accessing MySQL _last_executed
...
Thanks reames at asymmetricventures.com for the report.
Backport of 59b0c48ce
2013-06-29 18:48:05 +02:00
a9b5a1e506
[1.6.x] Do not allow FileSystemStorage.delete to receive an empty name
...
Refs #20660 .
Backport of 7fbab3eba
2013-06-29 18:12:23 +02:00
b6aed803b2
[1.6.x] Fixed #20660 -- Do not try to delete an unset FieldFile
...
Thanks stanislas.guerra at gmail.com for the report and
Baptiste Mispelon for the review.
Backport of ea3fe78a9d
2013-06-29 18:11:51 +02:00
d097417025
Support 'pyformat' style parameters in raw queries, Refs #10070
...
Add support for Oracle, fix an issue with the repr of RawQuerySet,
add tests and documentations. Also added a 'supports_paramstyle_pyformat'
database feature, True by default, False for SQLite.
Thanks Donald Stufft for review of documentation.
2013-06-28 06:59:10 +03:00
7c0b72a826
Prevented running some admin_view tests twice.
2013-06-27 20:13:42 -04:00
534ced5aad
Fixed #20664 -- Fixed a bug with raw_id_fields on Python 3.
...
Thanks jefftriplett for the report.
2013-06-27 19:39:20 -04:00
c1284c3d3c
Fixed #20571 -- Added an API to control connection.needs_rollback.
...
This is useful:
- to force a rollback on the exit of an atomic block without having to
raise and catch an exception;
- to prevent a rollback after handling an exception manually.
2013-06-27 22:19:54 +02:00
99b467f272
Add related_query_name to ForeignKey/M2M. Refs #20244
2013-06-27 14:44:21 +01:00
a9ea7d8c70
Fixed #20462 - Replaced the str() cast introduced in 273dc55 by force_text()
2013-06-26 21:30:58 +07:00
273dc550a4
Fixed #20462 -- null/non-string regex lookups are now consistent
...
Thanks to noirbizarre for the report and initial patch.
2013-06-26 08:13:26 -04:00
ec371ace00
Fixed #20650 -- Fixed {% filter %} incorrectly accepting 'escape' as argument
...
Thanks to grzesiof for the report and to loic84 and Alex Gaynor
for the review.
2013-06-25 20:28:35 +02:00
f819bef3dc
Fixed #19773 - Added admin/popup_response.html template.
...
Thanks jimmylam@ for the suggestion.
2013-06-25 11:20:41 -04:00
0346563939
Fixed #20653 -- Renamed checksetup management command.
...
This is to allow future compatibility with work that is ongoing in the 2013 GSoC.
2013-06-25 09:37:54 +08:00
1559f84d8b
Fixed #20311 -- Make sure makemessages doesn't create duplicate Plural-Forms .po file headers.
...
Thanks naktinis for the report and initial patch.
2013-06-22 18:45:41 -03:00
680b512fc1
Fixed #20587 -- Made convert_values handle None values
2013-06-22 14:05:12 +01:00
ef37b23050
Fixed #18872 -- Added prefix to FormMixin
...
Thanks @ibustama for the initial patch and dragonsnaker for opening the
report.
2013-06-22 12:12:43 +01:00
ef79582e86
Fixed 17478 -- Allowed queryset overriding in BaseModelFormSet init
...
BaseModelFormSet.forms is now a cached property instead of being
populated in the __init__ method. This behaviour also matches an
example in the documentation.
Thanks Thomasz Swiderski for the report and Simon Charette for the
review.
2013-06-22 09:29:37 +02:00
552a90b444
Fixed #20290 -- Allow override_settings to be nested
...
Refactored override_settings to store the underlying settings._wrapped
value seen at runtime, not instantiation time.
2013-06-21 16:57:47 +02:00
04628e2016
Fixed #20630 -- Removed `maxlength` attribute from `NumberInput`.
...
This attribute is only allowed on inputs of type "text", "search", "url",
"tel", "email", or "password".
Thanks to yoyoma for the report and @bmispelon for the review.
2013-06-20 10:59:41 -04:00
18e79f1425
Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists.
...
Thanks to kux for the report, and Russ Webber for the patch.
2013-06-20 18:55:27 +08:00
d9a43545be
Merge pull request #1282 from loic/ticket6903
...
Fixed failing test on MySQL since c86a9b6
2013-06-19 03:04:04 -07:00
7d0c3b9b26
Fixed MySQL failing test introduced by c86a9b6
2013-06-19 16:13:43 +07:00
2f35c6f10f
Fixed #14930 -- values_list() failure on qs ordered by extra column
...
Thanks lsaffre for the report and simon29, vicould, and Florian Hahn
for the patch.
Some changes done by committer.
2013-06-18 23:56:51 +03:00
9da9b3eb04
Merge pull request #1281 from loic/ticket6903
...
Fixed #6903 - Preserved admin changelist filters.
2013-06-18 13:07:28 -07:00
c86a9b6398
Fixed #6903 - Preserve admin changelist filters after saving or deleting an object
2013-06-19 02:41:36 +07:00
aeb1389442
Fixed #20079 -- Improve security of password reset tokens
2013-06-18 20:02:00 +02:00
3128f3d38d
Fixed #20618 -- Fixed regression in `BoundField.label_tag`.
2013-06-18 17:49:53 +02:00
ee77d4b253
Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields
2013-06-18 08:01:17 -04:00
f34cfec0fa
Refactored ValidationError to allow persisting error params and error codes as the exception bubbles up
2013-06-18 08:01:17 -04:00
1b7634a0d0
Fixed #20464 -- Added a `total_error_count` method on formsets.
...
Thanks to frog32 for the report and to Tim Graham for the review.
2013-06-16 15:49:30 -04:00
c3df866619
Fixed #20603 -- Made the test suite faster.
...
By avoiding to run syncdb with the full set of test models.
Thanks Anssi for the idea.
2013-06-14 23:16:15 +02:00
46789e76c6
Fixed #20548 -- Removed all PendingDeprecationWarnings from django test suite
2013-06-14 15:37:39 +01:00
5459795ef2
Fixed #20289 -- pickling of dynamic models
2013-06-14 17:05:54 +03:00
855d1305c5
Added cache to available_apps in cache tests
2013-06-14 17:05:54 +03:00
89bf7a4525
Fixed #20528 -- regression in select_related join promotion
...
The join used by select_related was incorrectly INNER when the query
had an ORed filter for nullable join that was trimmed away. Fixed this
by forcing the join type to LOUTER even when a join was trimmed away
in ORed queries.
2013-06-14 16:29:06 +03:00
b7bd7087e6
Fixed #15273 -- Extend RedirectView to allow reversal by name.
...
Thanks to @DrMeers for the report and @ludwigkraatz for the initial patch.
2013-06-14 11:59:26 +01:00
8365ed08b8
Fixed #17076 -- When reversing a URL fails, inform the user which patterns were tried.
2013-06-14 10:26:30 +01:00
91f317c76d
Added a ``checksetup`` management command for verifying Django compatibility.
2013-06-13 18:39:02 -07:00
9e50833e22
Fixed #20000 -- Allowed ModelForm meta overrides for label, help_text and error_messages
2013-06-13 15:06:25 -04:00
dc9c359546
Fixed #20594 -- Add validation to models.SlugField.
...
Thanks carbonXT for the report.
2013-06-13 13:31:57 -04:00
92c49d6f01
Revert "Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields."
...
This reverts commit 64041f0e6e
2013-06-11 17:55:19 -04:00
64041f0e6e
Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields.
2013-06-11 14:13:40 -04:00
584bd14dcf
Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix
...
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.
This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
2013-06-10 14:23:15 -04:00
af70dfcf31
Reverted the introduction of shared_models.
...
The recent improvements should make shared_models obsolete.
This reverts commit 1059da8de64fa7f3cdd9
2013-06-10 12:34:47 +02:00
f5d4849cbe
Revert "Began implementing a shared set of test models to speed up tests."
...
This reverts commit 22b7870e40
2013-06-10 12:22:40 +02:00
Aymeric Augustin
Russell Keith-Magee
Eric Boersma
Tim Graham
Carl Meyer
Anssi Kääriäinen
Claude Paroz
Florian Apolloner
Simon Charette
Alasdair Nicol
Jacob Kaplan-Moss
Collin Anderson
Alex Cucu
Tim Heap
Petr Dlouhý
Loic Bistuer
Aleksandra Sendecka
Baptiste Mispelon
Karen Tracey
Shai Berger
Andrew Godwin
Andrew Clark
Javier Mansilla
Ramiro Morales
Gilberto Gonçalves
Oliver Beattie
Florian Hahn
Erik Romijn
Marc Tamlyn
Wilfred Hughes
Daniel Lindsley
Axel Haustant
Gabe Jackson