ceea86baa3
Fixed #35425 -- Avoided INSERT with force_update and explicit pk.
...
Affected models where the primary key field is defined with a
default or db_default, such as UUIDField.
2024-05-07 12:15:27 +02:00
9a27c76021
Fixed #35426 -- Updated querysets to be a required argument of GenericPrefetch.
2024-05-04 11:30:36 +02:00
91a4b9a8ec
Fixed #35422 -- Fixed migrations crash when altering GeneratedField referencing rename field.
...
Thanks Sarah Boyce for the report and Simon Charette for the
implementation idea.
2024-05-03 09:28:24 +02:00
9aeb38c296
Fixed #35359 -- Fixed migration operations ordering when adding fields referenced by GeneratedField.expression.
...
Thank you to Simon Charette for the review.
2024-05-02 21:43:13 -03:00
97d48cd3c6
Refs #34007 , Refs #35359 -- Added Q.referenced_based_fields property.
...
Thank you to Mariusz Felisiak and Natalia Bidart for the reviews.
2024-05-02 19:05:13 +02:00
39828fa778
Added a high contrast mode to screenshot cases.
...
Thank you to Sarah Abderemane and Nick Pope for the reviews.
2024-05-02 13:18:58 +02:00
c187f5f924
Refs #32819 -- Avoided adding 'aria-describedby' to hidden inputs.
...
Hidden elements are not visible for both accessibility tools and browsers presentation layer. This change therefore only reduces the size of the generated HTML.
2024-04-30 11:11:02 +02:00
85c154da2f
Fixed #35412 -- Dropped support for SQLite < 3.31.
2024-04-29 11:07:54 +02:00
c8df2f9941
Fixed #35339 -- Fixed PostgreSQL aggregate's filter and order_by params order.
...
Updated OrderableAggMixin.as_sql() to separate the order_by parameters
from the filter parameters. Previously, the parameters and SQL were
calculated by the Aggregate parent class, resulting in a mixture of
order_by and filter parameters.
Thanks Simon Charette for the review.
2024-04-25 17:40:03 -03:00
42b567ab4c
Refs #35339 -- Updated Aggregate class to return consistent source expressions.
...
Refactored the filter and order_by expressions in the Aggregate class to
return a list of Expression (or None) values, ensuring that the list
item is always available and represents the filter expression.
For the PostgreSQL OrderableAggMixin, the returned list will always
include the filter and the order_by value as the last two elements.
Lastly, emtpy Q objects passed directly into aggregate objects using
Aggregate.filter in admin facets are filtered out when resolving the
expression to avoid errors in get_refs().
Thanks Simon Charette for the review.
2024-04-25 17:40:03 -03:00
e64d42e753
Fixed #35395 -- slice filter crashes on an empty dict with Python 3.12.
...
Keep consistent behaviour of slice() filter between python 3.12 and prior
versions in the case of a dict passed to the filter (catch the new to python
3.12 KeyError exception).
2024-04-24 10:53:38 +02:00
83f5478225
Fixed #35356 -- Deferred self-referential foreign key fields adequately.
...
While refs #34612 surfaced issues with reverse one-to-one fields
deferrals, it missed that switching to storing remote fields would break
self-referential relationships.
This change switches to storing related objects in the select mask
instead of remote fields to prevent collisions when dealing with
self-referential relationships that might have a different directional
mask.
Despite fixing #21204 introduced a crash under some self-referential
deferral conditions, it was simply not working even before that as it
aggregated the sets of deferred fields by model.
Thanks Joshua van Besouw for the report and Mariusz Felisiak for the
review.
2024-04-23 13:17:17 -03:00
2be37b2533
Made SeleniumTests.test_inline_add_another_widgets less flaky by adding explicit wait.
2024-04-17 17:38:04 +02:00
d048f0d311
Fixed #35373 -- Fixed a crash when indexing a generated field on SQLite.
...
Generated fields have to be excluded from the INSERT query against the remade
table including the index.
Thanks Moshe Dicker for the report, David Sanders and Mariusz Felisiak for the
review.
2024-04-16 17:27:38 +02:00
50a702f3fd
Fixed #35364 -- Stopped AdminEmailHandler rendering email unnecessarily.
2024-04-12 10:37:28 +02:00
b0f2289426
Refs #35364 -- Tested AdminEmailHandler with empty ADMINS.
2024-04-12 10:37:28 +02:00
73b62a2126
Refs #35194 -- Adjusted a generated field test to work on Postgres 15.6+.
...
Postgres >= 12.18, 13.14, 14.11, 15.6, 16.2 changed the way the immutability
of generated and default expressions is detected in postgres/postgres@743ddaf .
The adjusted test semantic is presereved by switching from __icontains to
__contains as both make use of a `%` literal which requires proper escaping.
Refs #35336 .
Thanks bcail for the report.
2024-04-12 10:23:04 +02:00
f973a70bfc
Made postgresql.tests.Tests.test_connect_pool less flaky by increasing timeout value.
2024-04-10 14:09:52 -03:00
338ec052b4
Refs #35361 -- Added test for Email line length checks when dealing with surrogate pairs.
...
Refs #33173 , #34118 and #34900 .
2024-04-10 17:56:55 +02:00
8b53560eea
Fixed #35350 -- Fixed save() with pk set on models with GeneratedFields.
...
Thanks Matt Hegarty for the report and Simon Charette and Natalia Bidart for the reviews.
Regression in f333e35
2024-04-10 15:43:50 +02:00
bcd255cd5c
Fixed #35354 -- Simplified ASGIRequest path handling.
...
Following the ASGI HTTP Connection Scope docs[0], the provided `path`
is already the correct value that Django requires.
In combination with `root_path`, from which `script_name` is derived,
the `path_info` variable is set. It's then redundant to
re-calculate `path` from `script_name` and `path_info`.
See also, a clarifying discussion on the ASGIref repo[1].
[0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-scope
[1]: https://github.com/django/asgiref/issues/424
2024-04-05 11:35:38 +02:00
4d2ef9bb82
Refs #35169 -- Added test for ASGIRequest root_path handling.
2024-04-05 11:30:33 +02:00
89403dbedd
Fixed SeleniumTests.test_related_object_update_with_camel_casing() assert.
...
A selenium web element was compared to a string rather than its innerHTML.
2024-04-03 09:29:01 +02:00
8665cf03d7
Fixed #35330 -- Fixed the update of related widgets when the referenced model is camel case named.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-04-02 22:00:25 -03:00
888b9042b3
Fixed #35336 -- Addressed crash when adding a GeneratedField with % literals.
...
A longer term solution is likely to have a better separation of parametrized
DDL altogether to handle checks, constraints, defaults, and generated fields
but such a change would require a significant refactor that isn't suitable
for a backport.
Thanks Adrian Garcia for the report.
2024-04-02 17:33:31 -03:00
5f18021640
Fixed #35344 , Refs #34838 -- Corrected output_field of resolved columns for GeneratedFields in aliased tables.
...
Thanks Simon Charette for the review.
2024-04-01 18:54:38 +01:00
944745afe2
Fixed #34977 -- Improved accessibility in the UserChangeForm by replacing the reset password link with a button.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-03-27 16:40:41 -03:00
d658a3162f
Fixed #35233 -- Moved template engine system checks to backend methods.
...
Thanks Adam Johnson for reviews.
2024-03-27 08:14:54 +01:00
b98271a6e4
Fixed #35329 -- Fixed migrations crash when adding partial unique constraints with nulls_distinct.
...
Bug in 595a2abb58
2024-03-26 22:58:47 +01:00
a2dcc4ecbb
Increased test coverage for django.db.migrations.operations.special.
2024-03-25 08:31:32 +01:00
07c8d979ae
Fixed #35323 -- Prevented file_move_safe() from trying to overwrite existing file when allow_overwrite is False.
2024-03-24 16:05:36 +01:00
1c11dba835
Added ModelState.from_model() test for abstract model with unnamed indexes.
2024-03-22 13:31:33 +01:00
6a37e9bfae
Fixed #35257 -- Corrected resolving output_field for IntegerField/DecimalField with NULL.
2024-03-21 10:13:54 +01:00
6f7c0a4d66
Fixed ResourceWarning from unclosed SQLite connection in test_utils on Python 3.13+.
...
On SQLite, close() doesn't explicitly close in-memory connections.
Follow up to 921670c694dd45d5223b
2024-03-20 11:44:30 +01:00
f2388a4b73
Fixed #35309 -- Made prefetch clear ordering for single-valued relationships.
2024-03-20 05:26:18 +01:00
921670c694
Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.
...
On SQLite, close() doesn't explicitly close in-memory connections.
Follow up to dd45d5223b
2024-03-19 10:03:12 +01:00
10b31eea33
Refs #31014 -- Added srid argument to FromWKB/FromWKT() GIS functions.
2024-03-18 09:45:33 +01:00
7646b9023d
Fixed #35301 -- Fixed Options._property_names for overriden properties.
...
Regression in faeb92ea13
2024-03-17 09:43:04 +01:00
cbf1e87398
Fixed #35294 -- Fixed TEXT format of QuerySet.explain() for long plans.
...
co-authored-by: Gordon <gordon.wrigley@gmail.com>
co-authored-by: Simon Charette <charette.s@gmail.com>
2024-03-15 06:58:14 +01:00
593067a8ee
Fixed #28541 -- Fixed migrations crash when changing primary key on SQLite.
2024-03-14 20:56:43 +01:00
3d7235c67b
Refs #34488 -- Made ClearableFileInput preserve "Clear" checked attribute when form is invalid.
2024-03-14 14:03:14 +01:00
e69019555d
Fixed #35273 -- Fixed rendering AdminFileWidget's attributes.
...
Regression in 8a6c0203c4
2024-03-14 14:03:09 +01:00
f5c340684b
Fixed #34901 -- Added async-compatible interface to session engines.
...
Thanks Andrew-Chen-Wang for the initial implementation which was posted
to the Django forum thread about asyncifying contrib modules.
2024-03-13 17:55:15 +01:00
33c06ca0da
Refs #32673 , Refs #35295 -- Avoided wrapping rhs direct values in lookups.
2024-03-13 17:46:37 +01:00
894fa55da1
Applied BoundingCircle test to only one country.
...
Looks like testing the second Country is much more computing-intensive
and brings nothing to the test.
2024-03-10 20:59:36 +01:00
73df8b54a2
Fixed #35044 -- Avoided clearing reverse relations and private fields when accessing deferred fields.
...
Regression in a7b5ad8b19123b1d3fcf
2024-03-08 11:09:54 +01:00
0c690c6001
Refs #35044 -- Added Model.refresh_from_db(fields=...) test for clearing reverse relations.
2024-03-08 10:27:19 +01:00
1570ef02f3
Fixed #35223 -- Made Model.full_clean() ignore fields with db_default when validating empty values.
...
Thanks Brian Ibbotson for the report.
Regression in 7414704e88
2024-03-08 05:55:25 +01:00
549320946d
Fixed #35030 -- Made django.contrib.auth decorators to work with async functions.
2024-03-07 09:59:33 +01:00
20848bcf39
Fixed typos in docstrings and docs.
...
Signed-off-by: cuinix <915115094@qq.com>
2024-03-07 06:01:01 +01:00
c4df2a7776
Refs #35030 -- Added more tests for @user_passes_test decorator.
2024-03-06 13:28:32 +01:00
4426b1a72d
Fixed #35021 -- Fixed capturing queries when using client-side parameters binding with psycopg 3+.
2024-03-06 11:24:58 +01:00
eff21d8e7a
Fixed #35252 -- Optimized _route_to_regex().
...
co-authored-by: Nick Pope <nick@nickpope.me.uk>
2024-03-05 13:09:10 +01:00
241adf678f
Used sys_platform in tests requirements.
...
We already use implementation_name and python_version markers
so it's more consistent. Moreover, marker values can be specified
via pip's command line options.
2024-03-05 13:08:23 +01:00
3d4fe39bac
Refs #21286 -- Removed invalid commented out models and tests from serializer tests.
...
FileField/ImageField cannot be primary keys, so serialization support
for this case will not be implemented.
XMLField was removed in d1290b5b43
2024-03-04 11:38:18 +01:00
838659ea21
Updated fuzzy translations in tests.i18n.patterns.
...
Follow up to 9fd1b6f3f8
2024-03-04 11:24:21 +01:00
f6ad8c7676
Refs CVE-2024-27351 -- Forwardported release notes and tests.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2024-03-04 08:22:00 +01:00
f5ed4306bb
Fixed #35265 -- Added AdminSite tests for changing titles.
2024-03-04 05:34:42 +01:00
c187417611
Refs #9847 -- Added tests for handler403 resolution.
2024-03-04 05:24:36 +01:00
595738296f
Refs #26431 -- Added more test for translated path().
2024-03-02 19:54:21 +01:00
9fd1b6f3f8
Updated translation catalogs in tests.i18n.patterns.
2024-03-02 19:54:21 +01:00
fad334e1a9
Refs #33497 -- Added connection pool support for PostgreSQL.
...
Co-authored-by: Florian Apolloner <florian@apolloner.eu>
Co-authored-by: Ran Benita <ran@unusedvar.com>
2024-03-01 09:01:18 +01:00
daf7d482db
Refs #35234 -- Deprecated CheckConstraint.check in favor of .condition.
...
Once the deprecation period ends CheckConstraint.check() can become the
documented method that performs system checks for BaseConstraint
subclasses.
2024-03-01 07:15:32 +01:00
f82c67aa21
Fixed #35234 -- Added system checks for invalid model field names in ExclusionConstraint.expressions.
2024-02-29 12:22:17 +01:00
a738281265
Fixed #35198 -- Fixed facet filters crash on querysets with no primary key.
...
Thanks Simon Alef for the report.
Regression in 868e2fcdda
2024-02-29 10:01:18 +01:00
0e84e70bc8
Refs #35090 -- Fixed urlpatterns.tests.SimplifiedURLTests when run in reverse.
2024-02-29 08:22:03 +01:00
107aa76bcf
Fixed #29022 -- Fixed handling protocol-relative URLs in ManifestStaticFilesStorage when STATIC_URL is set to /.
2024-02-28 06:24:24 +01:00
ef2434f850
Refs #32114 -- Fixed test crash on non-picklable objects in subtests when PickleError is raised.
...
Related to the https://github.com/python/cpython/issues/73373 .
Follow up to c09e8f5fd8
2024-02-26 17:18:48 +01:00
73d5eb8084
Fixed #35241 -- Cached model's full parent list.
...
co-authored-by: Keryn Knight <keryn@kerynknight.com>
co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
co-authored-by: David Smith <smithdc@gmail.com>
co-authored-by: Paolo Melchiorre <paolo@melchiorre.org>
2024-02-26 05:38:31 +01:00
6e1ece7ed5
Fixed #35090 -- Deprecated registering URL converters with the same name.
2024-02-23 15:54:49 +01:00
50e95ad536
Simplified using DATABASES["OPTIONS"].
...
DATABASES["OPTIONS"] are always configured.
2024-02-23 07:49:43 +01:00
f835787f71
Refs #32114 -- Fixed RemoteTestResultTest.test_unpicklable_subtest test without tblib.
...
Follow up to c09e8f5fd8
2024-02-22 06:27:39 +01:00
eceb5e2eea
Fixed #34806 -- Made cached_db session backend resilient to cache write errors.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-02-21 21:51:58 -03:00
c09e8f5fd8
Fixed #32114 -- Fixed parallel test crash on non-picklable objects in subtests.
2024-02-21 12:04:03 +01:00
a269d8d1d8
Removed obsolete test_get_or_create_raises_IntegrityError_plus_traceback() test.
...
This test was added in 31b1cbc623746caf3ef8
2024-02-21 11:50:22 +01:00
abe6c1f93e
Refs #30913 -- Corrected IndexesTests.test_index_include_pointing_to_fk().
...
This adjusts a test assigning an Index to Meta.constraints.
2024-02-21 08:25:41 +01:00
a084c5d35a
Fixed #35238 -- Fixed database serialization crash when base managers use prefetch_related().
...
Regression in 1391356276
2024-02-20 22:14:17 +01:00
eb2d49b734
Fixed #23759 -- Preserved all file extensions in Storage.get_available_name().
2024-02-20 21:06:39 +01:00
3426a5c33c
Refs #34900 -- Fixed CommandTypes.test_help_default_options_with_custom_arguments test on Python 3.13+.
...
c4a2e8a2c5
2024-02-20 20:59:26 +01:00
e626716c28
Fixed #34429 -- Allowed setting unusable passwords for users in the auth forms.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-02-20 12:13:32 -03:00
8a757244f9
Refs #34429 -- Defined test user with unusable password for auth forms tests.
2024-02-20 12:12:37 -03:00
5f637a8a8d
Fixed #35226 -- Reallowed executing queries for dynamically created connections.
...
Regression in 8fb0be3500
2024-02-19 18:34:18 +01:00
9350308f37
Fixed closing connections in test_utils.tests.AllowedDatabaseQueriesTests.
2024-02-19 14:08:30 +01:00
f65f8ab84e
Refs #28011 -- Removed ForeignObjectRel.is_hidden().
2024-02-19 12:22:46 +01:00
f25d84f61a
Fixed #35232 -- Cached model's Options.verbose_name_raw.
2024-02-19 06:05:52 +01:00
28a3fbe004
Fixed #35229 -- Made URL custom error handler check run once.
2024-02-19 05:58:37 +01:00
5e80390add
Fixed #35230 -- Added cached ForeignObjectRel.accessor_name.
2024-02-19 05:47:12 +01:00
7a05b8a2fa
Fixed #24018 -- Allowed setting pragma options on SQLite.
2024-02-16 12:59:19 +01:00
66e47ac69a
Fixed #29725 -- Removed unnecessary join in QuerySet.count() and exists() on a many to many relation.
...
Co-Authored-By: Shiwei Chen <april.chen.0615@gmail.com>
2024-02-16 08:57:16 +01:00
0d8fbe2ade
Refs #34060 -- Fixed crash when filtering against literal JSON with psycopg2.
2024-02-16 07:40:33 +01:00
c991602ce5
Fixed #34060 -- Fixed migrations crash when adding check constraints with JSONField __exact lookup on Oracle.
2024-02-15 13:57:58 +01:00
22285d366c
Fixed #33037 -- Fixed Trunc() with offset timezones on MySQL, SQLite, Oracle.
2024-02-15 10:02:57 +01:00
2aa8388110
Improved test helpers in truncated date/time field tests.
...
Co-authored-by: Lily Foote <code@lilyf.org>
2024-02-15 10:02:53 +01:00
8db593de05
Fixed #35173 -- Fixed ModelAdmin.lookup_allowed() for lookups on foreign keys when not included in ModelAdmin.list_filter.
...
Regression in f80669d2f5
2024-02-14 22:29:49 -03:00
e6fa74f020
Fixed #35179 -- Made admindocs detect positional/keyword-only arguments.
2024-02-14 13:17:40 +01:00
cf107fe255
Fixed #35122 -- Made migrate --prune option respect --app_label.
2024-02-13 14:47:49 +01:00
222bf2932b
Refs #35058 -- Added support for measured geometries to GDAL GeometryCollection and subclasses.
2024-02-12 15:21:11 +01:00
bc8471f0aa
Refs #34900 , Refs #34118 -- Updated assertion in test_skip_class_unless_db_feature() test on Python 3.12.2+.
...
Python 3.12.2 bring back the skipped tests in the number of running
tests. Refs
0a737639dc
2024-02-10 16:14:51 +01:00
06264258dc
Fixed #35175 -- Made migraton writer preserve keyword-only arguments.
...
Thanks Gerald Goh for the report.
2024-02-09 09:37:13 +01:00
8b7ddd1b62
Refs #34534 -- Reduced constraint operations with Meta.constraints when optimizing migrations.
2024-02-09 07:02:52 +01:00
Jacob Walls
sobolevn
Mariusz Felisiak
DevilsAutumn
David Sanders
Sarah Boyce
David Smith
Chris Muthig
Tim Richardson
Simon Charette
Marijke Luttekes
Adam Johnson
Natalia
Carlton Gibson
devin13cox
Johannes Westphal
Fabian Braun
Giannis Terzopoulos
Ben Cail
sharonwoo
Laurent Lyaudet
Claude Paroz
Johannes Maron
Jon Janzen
Dingning
cuinix
Michail Chatzis
Adam Zapletal
Shai Berger
Kasun Herath
Shafiya Adzhani
David Wobrock
Salvo Polizzi
Florian Apolloner
Sulabh Katila
AlexCLeduc
Aaron Linville
ontowhee
Albert Defler
Hisham Mahmood
Moein Bbp
Daniel Garcia Moreno
David Sanders