589dc49e12
Fixed #21198 -- Prevented invalid use of @python_2_unicode_compatible.
...
Thanks jpic for the report and chmodas for working on a patch.
Reverts 2ea80b94#19362 .
2013-10-13 18:14:04 +02:00
570d9c2678
Fixed #19560 -- Identified field in warning for naive datetime.
...
Thanks gcc for the report and vajrasky for the patch.
2013-10-13 11:54:11 +02:00
00a73c1c69
Fixed #21173 -- Stopped fixing format for date-based widgets at init time
...
Thanks Marc Tamlyn for the review.
2013-10-12 18:31:19 +02:00
ad17d6a85f
Fixed errors in 848101bf17
2013-10-11 17:58:07 -04:00
848101bf17
Added tests for URLValidator schemes.
2013-10-11 13:41:38 -04:00
e527c0b6d8
Fixed #13252 -- Added ability to serialize with natural primary keys.
...
Added ``--natural-foreign`` and ``--natural-primary`` options and
deprecated the ``--natural`` option to the ``dumpdata`` management
command.
Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
arguments and deprecated the ``use_natural_keys`` argument to
``django.core.serializers.Serializer.serialize()``.
Thanks SmileyChris for the suggestion.
2013-10-11 12:52:57 -04:00
945e033a69
Fixed #8918 -- Made FileField.upload_to optional.
...
Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.
2013-10-11 08:07:25 -04:00
b67ab75e82
Fixed assorted flake8 errors.
2013-10-11 07:25:14 -04:00
1dae4ac177
Whitespace cleanup.
...
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
2013-10-10 16:49:20 -04:00
ca874b2fe6
Fixed an undefined variable and clarified the purpose of a test.
...
refs #4459 .
2013-10-10 13:01:12 -04:00
adedc31072
Fixed "redefinition of unused 'foo' from line X" pyflakes warnings.
2013-10-10 11:09:42 -04:00
cec11a3336
Used "is" for comparisons with None.
2013-10-10 09:35:56 -04:00
ff9e8eccf8
Removed unnecessary semicolons.
2013-10-10 08:50:32 -04:00
a971d19bab
Fixed #21243 -- Corrected exception message in multiple database tests.
...
Thanks to vajrasky for the report and patch.
2013-10-09 09:06:23 +08:00
40b95a24ae
Fixed #20568 -- truncatewords_html no longer splits words containing HTML entities.
...
Thanks yann0 at hotmail.com for the report.
2013-10-08 08:24:58 -04:00
58d555caf5
Fixed #16822 -- Added RawPostDataException
...
Thanks jaylett for the patch.
2013-10-08 08:05:39 -04:00
8ff4303946
Refs #21197 -- Clarified upgrade check message.
...
Thanks to Carl and Shai for the discussion.
2013-10-08 10:00:39 +08:00
a8df8e34f9
Revert "Fixed #21241 -- Avoid extraneous JOINs in admin changelist search."
...
This reverts commit 698dd82eee
2013-10-07 13:45:52 -04:00
698dd82eee
Fixed #21241 -- Avoid extraneous JOINs in admin changelist search.
2013-10-07 13:10:52 -04:00
617aceb1b4
Fixed #18263 -- Corrrected handling of hidden fields in tabular admin inlines.
...
Thanks hvdklauw for the report and patch.
2013-10-07 12:30:02 -04:00
4dbd95ad65
Fixed #21236 -- Allowed migrations to work with unique_together tuples.
...
Thanks hjwp for the report.
2013-10-07 09:39:14 -04:00
1df3c49a1a
Fixed #21174 -- transaction control in related manager methods
2013-10-05 23:07:52 +03:00
93cc6dcdac
Fixed #18414 -- qs.exists() for sliced distinct queries
2013-10-05 21:40:36 +03:00
068b1e045f
Simplified a test by using CapturedQueriesContext
2013-10-05 21:16:09 +03:00
671757b507
Fixed #21161 -- Timezone-related tests on Windows.
...
Thanks Xelnor for the patch.
2013-10-05 18:50:20 +02:00
ecaba36028
Improved Query join promotion logic
...
There were multiple cases where join promotion was a bit too aggressive.
This resulted in using outer joins where not necessary.
Refs #21150 .
2013-10-05 14:52:17 +03:00
ed0d720b78
Fixed #21150 -- select_related + annotate join promotion failure
...
Added tests for a .annotate().select_related() join promotion failure.
This happened to work on master but was currently untested.
2013-10-05 14:52:17 +03:00
948d209ada
Fixed #21217 -- Avoid connecting `(pre|post)_init` signals to abstract senders.
2013-10-04 16:23:06 -04:00
dc3d2ac98c
Fixed #11277 -- Hid labels of fields with HiddenInput widget in admin forms.
...
Thanks bartTC for the report.
2013-10-04 14:08:06 -04:00
bcd4c3f27d
Fixed #6681 -- Don't break docutils when rendering reStructuredText.
...
Don't set a global default interpreted role function for reStructuredText.
Instead, use the `default-role` directive to change the default only within
the `parse_rst()` function.
Thanks Malcolm Tredinnick for the report.
2013-10-04 13:27:08 -04:00
7a97df190c
Fixed #19277 -- Added LocaleMiddleware.response_redirect_class
...
Thanks ppetrid at yawd.eu for the suggestion.
2013-10-03 16:15:29 -04:00
fa2e1371cd
Fixed #21216 -- Allow `OneToOneField` reverse accessor to be hidden.
2013-10-03 13:20:05 -04:00
c4db7f075e
Fixed #19182 -- Fixed ModelAdmin.lookup_allowed to work with ('fieldname', SimpleListFilter) syntax.
...
Thanks gauss for the report.
2013-10-03 09:37:49 -04:00
62dfd79f8b
Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.
...
Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.
Refs #7936 .
2013-10-02 23:29:48 -03:00
a80d9ab0fe
Initial version of MigrationOptimizer and tests
2013-10-02 17:34:22 +01:00
978e1351a6
Fixed #21122 -- Improved clean up of test temp directory on Windows
...
- Fixed test that didn't close the files it opened
- Caught and handled exception when temp directory cannot be removed
2013-10-02 09:12:58 -04:00
5381317fe3
Fixed #21129 -- Prevented admin filter params modifications from throwing an exception.
...
Thanks Tuttle for the report.
2013-10-02 08:16:09 -04:00
651bed0918
Made test for issue 19552 compatible with Windows.
...
Take in account platform path separator. Refs #19552 .
2013-10-02 07:29:40 -03:00
0f46ec315e
Made skipping of symlink-related makemessages test smarter.
...
os.symlink() is available starting with Windows Vista but can fail at
runtime.
2013-10-02 07:17:08 -03:00
43959d1057
Fixed tests breakage from last commit.
2013-10-01 21:02:42 -03:00
4b715fc05a
Fixed #21209 -- .po file path comments on Windows.
...
Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.
Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.
Refs #16903 .
2013-10-01 20:37:43 -03:00
1d0fc61b1c
Fixed #15185 -- Allowed ModelAdmin.list_display_links=None to disable change list links.
...
Thanks rm_ for the suggestion.
2013-10-01 14:25:54 -04:00
8c27247397
Added default value for a BooleanField in test models
...
Test models introduced for #10733 didn't contain default value for
a BooleanField(). Check command didn't like that -> check tests failed.
2013-10-01 20:36:06 +03:00
bf13c75c0d
Fixed #21203 -- resolve_columns fields misalignment
...
In queries using .defer() together with .select_related() the values
and fields arguments didn't align properly for resolve_columns().
2013-10-01 20:29:23 +03:00
8d4b1629d4
Fixed #10733 -- select_related().only() failure
...
The bug was reported pre 1.1, and somewhere along the way it has been
fixed. So, this is tests only addition.
2013-10-01 19:29:48 +03:00
c1c44b2506
Factorized requires_tz_support decorator in test utils
...
Thanks Aymeric Augustin for the suggestion. Refs #21165 .
2013-10-01 13:20:41 +02:00
d847ddfe1d
Fixed #3871 -- Fixed regression introduced by 04a2a6b.
...
Added do_not_call_in_templates=True attribute to RelatedManagers
to prevent them from being called.
Thanks jbg@ for the report.
2013-09-30 15:43:44 -04:00
f93896344a
Fixed Python 3.2 syntax errors; refs #13724 .
2013-09-30 10:28:01 -04:00
728548e483
Fixed #21134 -- Prevented queries in broken transactions.
...
Squashed commit of the following:
commit 63ddb271a44df389b2c302e421fc17b7f0529755
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Sep 29 22:51:00 2013 +0200
Clarified interactions between atomic and exceptions.
commit 2899ec299228217c876ba3aa4024e523a41c8504
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Sep 22 22:45:32 2013 +0200
Fixed TransactionManagementError in tests.
Previous commit introduced an additional check to prevent running
queries in transactions that will be rolled back, which triggered a few
failures in the tests. In practice using transaction.atomic instead of
the low-level savepoint APIs was enough to fix the problems.
commit 4a639b059ea80aeb78f7f160a7d4b9f609b9c238
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Tue Sep 24 22:24:17 2013 +0200
Allowed nesting constraint_checks_disabled inside atomic.
Since MySQL handles transactions loosely, this isn't a problem.
commit 2a4ab1cb6e83391ff7e25d08479e230ca564bfef
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sat Sep 21 18:43:12 2013 +0200
Prevented running queries in transactions that will be rolled back.
This avoids a counter-intuitive behavior in an edge case on databases
with non-atomic transaction semantics.
It prevents using savepoint_rollback() inside an atomic block without
calling set_rollback(False) first, which is backwards-incompatible in
tests.
Refs #21134 .
commit 8e3db393853c7ac64a445b66e57f3620a3fde7b0
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Sep 22 22:14:17 2013 +0200
Replaced manual savepoints by atomic blocks.
This ensures the rollback flag is handled consistently in internal APIs.
2013-09-30 09:42:27 +02:00
9595183d03
Fixed #13724 : Corrected routing of write queries involving managers.
...
Previously, if a database request spanned a related object manager, the
first manager encountered would cause a request to the router, and this
would bind all subsequent queries to the same database returned by the
router. Unfortunately, the first router query would be performed using
a read request to the router, resulting in bad routing information being
used if the subsequent query was actually a write.
This change defers the call to the router until the final query is acutally
made.
It includes a small *BACKWARDS INCOMPATIBILITY* on an edge case - see the
release notes for details.
Thanks to Paul Collins (@paulcollinsiii) for the excellent debugging
work and patch.
2013-09-30 13:05:43 +08:00
12ca312e1b
Modified test added in 3afb5916b2 so it doesn't fail on Windows.
...
Refs #18091 .
2013-09-29 22:44:55 -03:00
c4fdd859ec
Fixed #15786 -- Added a regression test for o2o excludes using F().
...
The issue was reported against 1.3.x but has been fixed since.
2013-09-29 16:45:03 -04:00
b0e06c3662
Fixed #21167 - Improved queries.tests.SubqueryTests
...
Improve tests to cover slicing scenarios that could be handled in unique
ways by 3rd party database backends.
2013-09-29 17:35:42 +03:00
a834bc84d8
Fixed #20931 -- Fixed select widgets nested choice rendering
...
ChoiceFieldRenderer was not rendering nested choices. Added recursion
to ChoiceFieldRenderer to take nested choices and render them as
<ul>'s.
2013-09-28 17:25:32 -07:00
47e79bfcfb
Fixed #21187 -- Import CursorWrapper from django.db.backend.utils
...
The import was done from util instead of utils leading to
PendingDeprecationWarning.
2013-09-28 14:18:37 +03:00
1a63092981
Fixed #20439 -- Started deprecation of IPAddressField
2013-09-28 10:55:32 +02:00
8f51ba669a
Fixed #21186 : Fixed regression when using date fields in the admin's list_filter.
...
Thanks to onlygoldi2201 for the report and to ramiro and apollo13
for the reviews.
2013-09-28 00:40:43 +02:00
3754f4ad41
Fix #21185 : Added tests for unescape_entities.
...
Also fixed a py3 incompatibility.
Thanks to brutasse for the report.
2013-09-27 17:00:42 +02:00
209de62d22
Fix Python 3.2 compatiblity by removing unicode literals.
2013-09-26 00:03:57 -04:00
6c06adad1d
Fixed #20364 -- Changed urlize regexes to include quotation marks as punctation.
...
Thanks to EmilStenstrom for raising this, and to Chris Piwoński for all of the fixes and most of the tests.
2013-09-25 22:17:22 +02:00
99c87f1410
Fixed #17671 - Cursors are now context managers.
2013-09-25 21:47:26 +03:00
04a2a6b0f9
Fixed #3871 -- Custom managers when traversing reverse relations.
2013-09-25 21:15:59 +03:00
83554b018e
Fixed #21126 -- QuerySet value conversion failure
...
A .annotate().select_related() query resulted in misaligned rows vs
columns for compiler.resolve_columns() method.
Report & patch by Michael Manfre.
2013-09-25 20:47:57 +03:00
f671fb9d11
Remove most errors when running migration tests twice
2013-09-25 16:11:05 +01:00
fe9f342d8c
Allow callables as the argument to RunPython
2013-09-25 16:10:43 +01:00
3b810c5656
Add RunPython migration operation and tests
2013-09-25 13:58:07 +01:00
05656f2388
Add equality support for Project/ModelState
2013-09-25 13:47:46 +01:00
9a041807fc
Fixed #18333 - Quoted annotated column names
2013-09-24 10:10:08 -04:00
6ede1db331
Fixed #21151 -- Bad cleanup in schema M2M repoint test
2013-09-24 11:00:00 +01:00
16ceb05b47
Isolated select_for_update tests a bit more.
...
This change prevents including the multiple_database test models without
duplicating the router code (we probably should do this at one point).
Refs #21148
2013-09-24 10:29:21 +02:00
ab643cd634
Fixed test suite bisection on Python 3.
...
Thanks to @marfire for spotting this.
2013-09-23 17:05:36 -04:00
4ec6d281cd
Fixed #21001 -- Added a regression test for empty string exclusion on Oracle.
...
The issue was present in 1.4.x but has been reported to be fixed in master.
Thanks to @timgraham for the patch.
2013-09-23 14:18:03 -04:00
41167645b1
Fixed #14028 - Added validation for clashing db_columns.
...
Thanks akaariai for the suggestion.
2013-09-23 11:51:58 -04:00
4fcc1e4ad8
Stopped a test from executing queries at the module level.
...
Currently module level queries are executed against the real database
(specified in NAME) instead of the test database; since it is to late
to fix this for 1.6, we at least ensures stable builds. Refs #21443 .
2013-09-22 23:02:35 +02:00
e6c0020d19
Translated a test to English for consistency.
...
Also fixed a typo.
2013-09-22 22:48:22 +02:00
2ca00faa91
Fixed "Address already in use" from liveserver.
...
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".
Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
2013-09-22 22:02:59 +02:00
a5b062576b
Removed a few trailing backslashes.
...
We have always been at war with trailing backslashes.
2013-09-22 14:04:10 +02:00
ee0ef1b094
Partial revert of 165f44aa.
...
That commit didn't always improve readability.
See discussion on django-developers for details.
2013-09-22 14:04:10 +02:00
5444a9c683
Fixed #21074 -- Added tests for localized datetime fields.
...
Fields must render values in the current time zone.
This commit only contains tests because this ticket was just a symptom of
a regression from #18777 that was fixed separately.
2013-09-21 23:10:14 +02:00
68b10fa177
Ensured that explicit time zones are rejected by forms.
...
Refs #19371 .
2013-09-21 21:09:25 +02:00
0d1ba84d13
Fixed #20702 -- Deprecated get_formsets in favor of get_formsets_with_inlines.
...
Thanks stanislas.guerra at gmail.com for the report.
2013-09-20 07:47:24 -04:00
df27803a55
Fixed #9532 -- Added min_num and validate_min on formsets.
...
Thanks gsf for the suggestion.
2013-09-19 13:11:49 -04:00
4e9f800742
Fixed #21125 -- Removed support for cache URI syntax
2013-09-19 10:01:39 -04:00
7fec5a2240
Fixed #7557 -- Added type checking to Variable initialization.
...
Thanks tobias for the suggestion and boblefrag and saz for work on the
patch.
2013-09-19 09:27:19 -04:00
e23de9e350
Fixed typo in exception message; refs #19414
...
Thanks Alexey Boriskin for the report.
2013-09-19 06:24:12 -04:00
98514849dc
Fixed #19414 -- Added admin registration decorator
...
Thanks stavros for the suggestion.
2013-09-18 11:44:10 -04:00
2daada800f
Fixed #21098 -- Applied sensitive_post_parameters to MultiValueDict
...
Thanks simonpercivall for the report and bmispelon for the review.
2013-09-18 09:48:36 -04:00
4f40b97d97
Fixed #21118 -- Isolated a test that uses the database.
...
Thanks rmboggs for the report.
2013-09-18 09:42:47 -04:00
2f0566fa61
Fixed #4278 -- Added a dirs parameter to a few functions to override TEMPLATE_DIRS.
...
* django.template.loader.get_template()
* django.template.loader.select_template()
* django.shortcuts.render()
* django.shortcuts.render_to_response()
Thanks amcnabb for the suggestion.
2013-09-18 07:37:08 -04:00
893198509e
Fixed #15625 -- Made message in MultiValueDictKeyError less verbose.
...
Thanks margieroginski for the suggestion.
2013-09-18 06:44:38 -04:00
50633e7353
Fixed #12568 -- no error when accessing custom field's descriptor
...
The SubfieldBase's descriptor caused an AttributeError when accessed
from the class. Introspection didn't like that.
Patch by Trac alias supervacuo.
2013-09-18 10:03:52 +03:00
a772ea8117
Fixed #21115 -- Fixed NameError in migrate --list command
2013-09-17 12:53:59 -04:00
5a424c2393
Fixed #21114 -- Migrations must not have a dependency to themselves.
2013-09-17 11:47:19 -04:00
1234225068
Fixed test failures introduced in previous commit.
2013-09-16 13:12:50 -04:00
18ffdb1772
Fixed #17627 -- Renamed util.py files to utils.py
...
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
2013-09-16 12:52:05 -04:00
351a061497
Fixed a timing edge case in the RelatedFieldWidgetSeleniumFirefoxTests.
...
By settings an implicit wait timeout for the find_* methods we can wait
till the javascript code add the new option to the DOM.
See http://ci.djangoproject.com/job/Django/database=mysql_gis,python=python3.3/3174/testReport/junit/admin_widgets.tests/RelatedFieldWidgetSeleniumFirefoxTests/test_foreign_key_using_to_field/
Stacktrace:
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/Django/workspace/database/mysql_gis/python/python3.3/tests/admin_widgets/tests.py", line 1060, in test_foreign_key_using_to_field
self.assertEqual(username_value, new_option.get_attribute('value'))
AssertionError: 'newuser' != 'testser'
- newuser
+ testser
2013-09-15 01:11:07 +02:00
886bb9d878
Revert "Fixed #12288 -- Validated that app names in INSTALLED_APPS are unique"
...
This reverts commit c1ec08998d
2013-09-14 07:19:32 -04:00
74b91b3888
Added tests for double-pickling a QuerySet
...
Refs #21102 .
2013-09-14 10:33:15 +03:00
c89d80e2cc
Fixed #21097 - Added DatabaseFeature.can_introspect_autofield
2013-09-14 09:48:59 +03:00
6feb75129f
Fixed #21060 -- Refactored admin's autodiscover method to make it reusable.
...
We want to be able to use it for instance for discovering `tasks.py` modules
inside the INSTALLED_APPS.
This commit therefore moves the logic to `autodiscover_modules` method in
django.utils.module_loading.
2013-09-13 20:09:41 -04:00
Aymeric Augustin
Claude Paroz
Tim Graham
Sascha Peilicke
Tai Lee
Russell Keith-Magee
Jaap Roes
Simon Charette
Chris Adams
Javed Khan
Anssi Kääriäinen
Christopher Medrela
Emil Stenström
Anentropic
Ramiro Morales
Andrew Godwin
Kevin Christopher Henry
tschilling
Ramiro Morales
Loic Bistuer
Michael Manfre
Christopher Babiak
Erik Romijn
Baptiste Mispelon
Giles Richard Greenway
Florian Apolloner
Helen ST
yokomizor
Curtis Maloney
Brian Holdefehr
Berker Peksag
Markus Holtermann
Anssi Kääriäinen
Juan Catalano