53a5fb3cc0
Fixed #26676 -- Prevented prefetching to_attr from caching its result in through attr.
...
Thanks Ursidours for the report.
2016-05-31 14:32:58 -04:00
7ec330eeb9
Refs #26565 -- Errored nicely when using Prefetch with a values() queryset.
...
Thanks Maxime Lorant for the report and Anssi for the suggestion.
2016-05-03 09:28:31 -04:00
92053acbb9
Fixed E128 flake8 warnings in tests/.
2016-04-08 10:12:33 -04:00
c92123cc1d
Fixed #26226 -- Made related managers honor the queryset used for prefetching their results.
...
Thanks Loïc for the suggested improvements and Tim for the review.
2016-03-02 16:10:18 -05:00
5d240b070d
Refs #17001 -- Added a test for custom prefetch related queryset on generic relations.
2016-03-02 16:08:37 -05:00
5e2c4d7afb
Fixed #26264 -- Fixed prefetch_related() crashes with values_list(flat=True)
2016-02-26 19:26:15 -05:00
ef33bc2d4d
Fixed #25279 -- Made prefetch_related_objects() public.
2016-02-26 14:55:01 -05:00
c30086159d
Used setupTestData in prefetch_related tests.
2016-02-23 13:53:58 -05:00
bdbe50a491
Fixed #25546 -- Prevented duplicate queries with nested prefetch_related().
2016-01-26 07:20:13 -05:00
86eccdc8b6
Fixed #25544 -- Removed duplicate ids in prefetch_related() queries.
2015-12-17 19:08:30 -05:00
cc8c02fa0f
Refs #25693 -- Added a regression test for `to_attr` validation on forward m2m.
2015-11-11 12:25:10 -05:00
4608573788
Fixed #25693 -- Prevented data loss with Prefetch and ManyToManyField.
...
Thanks to Jamie Matthews for finding and explaining the bug.
2015-11-10 12:12:07 -05:00
e542e81b39
Renamed descriptor classes for related objects.
...
The old names were downright confusing. Some seemed to mean the opposite
of what the class actually did.
The new names follow a consistent nomenclature:
(Forward|Reverse)(ManyToOne|OneToOne|ManyToMany)Descriptor.
I mentioned combinations that do not exist in the docstring in order to
help people who would search for them in the code base.
2015-09-21 22:20:42 +02:00
b1e33ceced
Fixed #23395 -- Limited line lengths to 119 characters.
2015-09-12 11:40:50 -04:00
c2e70f0265
Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField
2015-07-27 18:28:13 -04:00
74261bc593
Fixed #24873 -- Prevented nested Prefetch objects from being overwritten.
2015-06-18 15:42:47 -04:00
bfb5b7150f
Fixed #24912 -- Fixed prefetch_related failure for UUIDField primary keys
...
This resolves a problem on databases besides PostgreSQL when using
prefetch_related with a source model that uses a UUID primary key.
2015-06-15 09:37:38 -04:00
db77915c9f
Fixed E265 comment style
2015-02-06 09:30:35 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
4468c08d70
Fixed #23968 -- Replaced list comprehension with generators and dict comprehension
2014-12-08 07:58:23 -05:00
f7969b0920
Fixed #23620 -- Used more specific assertions in the Django test suite.
2014-11-03 11:56:37 -05:00
4b257cf261
Fixed flake8 warnings.
2014-09-29 08:13:40 -04:00
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
9562ffea97
Avoid the word "stupid".
...
There's always a better word.
2014-09-09 20:55:57 +02:00
ae3fe6ccbb
Reordered setUp code in prefetch_related tests.
...
This allows these tests to run on databases that reject duplicate NULL
values in unique fields e.g. SQL Server.
Forward port of 4fb50a9a
2014-06-05 16:33:02 +02:00
870b0a1f86
Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups.
...
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650 .
2014-05-21 10:30:48 +07:00
bdf3473e64
Fixed #22650 -- Fixed regression on prefetch_related.
...
Regression from f51c1f59#17001 .
2014-05-21 10:26:04 +07:00
79f05616fb
Fixed flake8 warnings introduced in recent commits.
2014-04-16 16:49:37 -04:00
b82f30785f
Fixed stray comment introduced by d3b71b9.
...
Thanks Claude Paroz for the report.
2014-04-13 08:26:25 +07:00
d3b71b976d
Fixed #21760 -- prefetch_related used an inefficient query for reverse FK.
...
Regression introduced by commit 9777442#21410 .
2014-04-13 00:34:16 +07:00
b77f26313c
Fixed #22207 -- Added support for GenericRelation reverse lookups
...
GenericRelation now supports an optional related_query_name argument.
Setting related_query_name adds a relation from the related object back to
the content type for filtering, ordering and other query operations.
Thanks to Loic Bistuer for spotting a couple of important issues in
his review.
2014-03-05 22:37:53 +02:00
7bbb6958dc
Allowed custom querysets when prefetching single valued relations
...
The original patch for custom prefetches didn't allow usage of custom
queryset for single valued relations (along ForeignKey or OneToOneKey).
Allowing these enables calling performance oriented queryset methods like
select_related or defer/only.
Thanks @akaariai and @timgraham for the reviews. Refs #17001 .
2014-03-03 21:35:19 +02:00
10e3faf191
Fixed #19774 -- Deprecated the contenttypes.generic module.
...
It contained models, forms and admin objects causing undesirable
import side effects. Refs #16368 .
Thanks to Ramiro, Carl and Loïc for the review.
2014-01-26 14:42:30 -05:00
e32095616c
Imported override_settings from its new location.
2013-12-23 21:37:56 +01:00
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
cb83448891
Fixed #21410 -- prefetch_related() for ForeignKeys with related_name='+'
...
Regression introduced by commit 9777442
2013-11-13 07:35:34 +02:00
536c447820
Fixed a couple flake8 warnings.
2013-11-07 20:10:25 -05:00
f51c1f5900
Fixed #17001 -- Custom querysets for prefetch_related.
...
This patch introduces the Prefetch object which allows customizing prefetch
operations.
This enables things like filtering prefetched relations, calling select_related
from a prefetched relation, or prefetching the same relation multiple times
with different querysets.
When a Prefetch instance specifies a to_attr argument, the result is stored
in a list rather than a QuerySet. This has the fortunate consequence of being
significantly faster. The preformance improvement is due to the fact that we
save the costly creation of a QuerySet instance.
Thanks @akaariai for the original patch and @bmispelon and @timgraham
for the reviews.
2013-11-07 14:49:49 +02:00
c3791463a5
Fixing E302 Errors
...
Signed-off-by: Jason Myers <jason@jasonamyers.com>
2013-11-02 23:48:47 -05:00
9d740eb8b1
Fix all violators of E231
2013-10-26 12:15:03 -07:00
1597503a01
Fixed E221 pep8 warnings.
2013-10-22 09:51:39 -04:00
96d1d4e292
Removed unused local variables in tests.
2013-10-19 08:31:38 -04:00
a800036981
Fixed #21287 -- Fixed E123 pep8 warnings
2013-10-18 10:07:39 +01:00
bab9123daa
Fixed #21268 -- Fixed E303 pep8 warnings
2013-10-18 01:46:24 +01:00
dfb4cb9970
Fixed #21285 -- Fixed E121,E122 pep8 warnings
2013-10-17 20:20:11 -04:00
b67ab75e82
Fixed assorted flake8 errors.
2013-10-11 07:25:14 -04:00
5649c0af9d
Fixed "indentation is not a multiple of four" pep8 issues.
2013-09-03 14:22:21 -04:00
5c1143910e
Removed most of absolute_import imports
...
Should be unneeded with Python 2.7 and up.
Added some unicode_literals along the way.
2013-07-29 20:28:13 +02:00
a2967d5204
Fixed #20242 - Added a regression test for prefetch_related.
...
Issue was fixed by removal of chunked reads from
QuerySet iteration in 70679243d1
2013-05-28 13:37:44 -04:00
4fd94969d8
Fixed #19607 - prefetch_related crash
...
Thanks to av@rdf.ru and flarno11@yahoo.de for the report.
2013-05-24 11:10:48 +01:00
6983a1a540
Fixed #15363 -- Renamed and normalized to `get_queryset` the methods that return a QuerySet.
2013-03-08 10:11:45 -05:00
89f40e3624
Merged regressiontests and modeltests into the test root.
2013-02-26 14:36:57 +01:00
Simon Charette
Simon Charette
Tim Graham
Attila Tovt
Adam Chainz
François Freitag
Ian Foote
Aymeric Augustin
Dražen Odobašić
Flavio Curella
Gagaro
Brian King
Collin Anderson
Jon Dufresne
Berker Peksag
Thomas Chaumeny
Aymeric Augustin
Loic Bistuer
valtron
Gabe Jackson
Loic Bistuer
Jason Myers
Alex Gaynor
Alasdair Nicol
Claude Paroz
Luke Plant
Florian Apolloner